From a48d2ed6eb3b3162d5073ddfecf46d7c12a4ceb6 Mon Sep 17 00:00:00 2001
From: Matthew Baggett <matthew@baggett.me>
Date: Tue, 28 Jan 2020 10:56:39 +0100
Subject: [PATCH] Fix coverage of deleteByField

---
 .../templates/Services/tests.service.php.twig | 36 +++++++++++++++++--
 1 file changed, 34 insertions(+), 2 deletions(-)

diff --git a/src/Generator/templates/Services/tests.service.php.twig b/src/Generator/templates/Services/tests.service.php.twig
index 544f5b9..296a4bd 100755
--- a/src/Generator/templates/Services/tests.service.php.twig
+++ b/src/Generator/templates/Services/tests.service.php.twig
@@ -274,7 +274,36 @@ class {{ class_name }}Test extends BaseTestCase
 {% endfor %}
     }
 
+{% for column in columns %}
+{% if column.getFieldSanitised == 'id' %}
+    /**
+     * @covers \{{ namespace }}\Services\Base\Base{{ class_name }}Service::deleteById
+     */
     public function testDeleteById()
+    {
+        $deleteable = $this->{{ variable_name }}TableGateway
+            ->getNewMockModelInstance()
+            ->save();
+
+        $this->assertEquals(1, $this->{{ variable_name }}Service->deleteByField({{ class_name }}Model::FIELD_{{ column.getFieldSanitised|upper }}, $deleteable->get{{ column.getPropertyName }}()));
+        return $deleteable;
+    }
+
+    /**
+     * @covers \{{ namespace }}\Services\Base\Base{{ class_name }}Service::deleteById
+     * @depends testDeleteById
+     */
+    public function testDeleteByIdVerify({{ class_name }}Model $deleteable)
+    {
+        $this->assertEquals(null, $this->{{ variable_name }}Service->getByField({{ class_name }}Model::FIELD_{{ column.getFieldSanitised|upper }}, $deleteable->get{{ column.getPropertyName }}()));
+    }
+
+{% endif %}
+{% endfor %}
+    /**
+     * @covers \{{ namespace }}\Services\Base\Base{{ class_name }}Service::deleteByField
+     */
+    public function testDeleteByField()
     {
         /** @var {{ class_name }}Model[] $allDeleted */
         $allDeleted = [];
@@ -290,15 +319,18 @@ class {{ class_name }}Test extends BaseTestCase
     }
 
     /**
-     * @depends testDeleteById
+     * @depends testDeleteByField
+     * @covers \{{ namespace }}\Services\Base\Base{{ class_name }}Service::deleteByField
+     * @param {{ class_name }}Model[] $allDeleted
      */
-    public function testDeleteByIdVerify(array $allDeleted)
+    public function testDeleteByFieldVerify(array $allDeleted)
     {
         /** @var {{ class_name }}Model $deleteable */
 {% for primary,db in primary_keys %}
         // By {{ primary }}
         $deleteable = array_pop($allDeleted);
         $this->assertEquals(null, $this->{{ variable_name }}Service->getByField({{ class_name }}Model::FIELD_{{ primary|upper }}, $deleteable->get{{ primary }}()));
+
 {% endfor %}
     }