2014-09-23 20:52:39 +00:00
|
|
|
<?php
|
|
|
|
|
|
2022-07-21 22:18:27 +00:00
|
|
|
use MediaWiki\MainConfigNames;
|
2023-09-07 11:46:15 +00:00
|
|
|
use MediaWiki\Request\WebRequest;
|
2023-03-01 20:33:26 +00:00
|
|
|
use MediaWiki\Title\Title;
|
2022-07-21 22:18:27 +00:00
|
|
|
|
2014-09-23 20:52:39 +00:00
|
|
|
/**
|
2016-01-27 09:59:31 +00:00
|
|
|
* @author Addshore
|
2024-02-16 18:04:47 +00:00
|
|
|
* @covers \Job
|
2014-09-23 20:52:39 +00:00
|
|
|
*/
|
2020-06-30 15:09:24 +00:00
|
|
|
class JobTest extends MediaWikiIntegrationTestCase {
|
2014-09-23 20:52:39 +00:00
|
|
|
|
|
|
|
|
/**
|
|
|
|
|
* @dataProvider provideTestToString
|
|
|
|
|
*
|
|
|
|
|
* @param Job $job
|
|
|
|
|
* @param string $expected
|
|
|
|
|
*/
|
|
|
|
|
public function testToString( $job, $expected ) {
|
2022-07-21 22:18:27 +00:00
|
|
|
$this->overrideConfigValue( MainConfigNames::LanguageCode, 'en' );
|
2014-09-23 20:52:39 +00:00
|
|
|
$this->assertEquals( $expected, $job->toString() );
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
public function provideTestToString() {
|
2018-01-13 00:02:09 +00:00
|
|
|
$mockToStringObj = $this->getMockBuilder( stdClass::class )
|
2021-03-20 15:18:58 +00:00
|
|
|
->addMethods( [ '__toString' ] )->getMock();
|
2021-04-22 08:28:11 +00:00
|
|
|
$mockToStringObj->method( '__toString' )
|
|
|
|
|
->willReturn( '{STRING_OBJ_VAL}' );
|
2014-09-23 20:52:39 +00:00
|
|
|
|
2016-04-11 21:00:43 +00:00
|
|
|
$requestId = 'requestId=' . WebRequest::getRequestId();
|
|
|
|
|
|
2016-02-17 09:09:32 +00:00
|
|
|
return [
|
|
|
|
|
[
|
|
|
|
|
$this->getMockJob( [ 'key' => 'val' ] ),
|
2019-03-30 06:07:48 +00:00
|
|
|
'someCommand Special: key=val ' . $requestId
|
2016-02-17 09:09:32 +00:00
|
|
|
],
|
|
|
|
|
[
|
|
|
|
|
$this->getMockJob( [ 'key' => [ 'inkey' => 'inval' ] ] ),
|
2019-03-30 06:07:48 +00:00
|
|
|
'someCommand Special: key={"inkey":"inval"} ' . $requestId
|
2016-02-17 09:09:32 +00:00
|
|
|
],
|
|
|
|
|
[
|
|
|
|
|
$this->getMockJob( [ 'val1' ] ),
|
2019-03-30 06:07:48 +00:00
|
|
|
'someCommand Special: 0=val1 ' . $requestId
|
2016-02-17 09:09:32 +00:00
|
|
|
],
|
|
|
|
|
[
|
|
|
|
|
$this->getMockJob( [ 'val1', 'val2' ] ),
|
2019-03-30 06:07:48 +00:00
|
|
|
'someCommand Special: 0=val1 1=val2 ' . $requestId
|
2016-02-17 09:09:32 +00:00
|
|
|
],
|
|
|
|
|
[
|
2020-02-28 15:13:53 +00:00
|
|
|
$this->getMockJob( [ (object)[] ] ),
|
2019-03-30 06:07:48 +00:00
|
|
|
'someCommand Special: 0=object(stdClass) ' . $requestId
|
2016-02-17 09:09:32 +00:00
|
|
|
],
|
|
|
|
|
[
|
|
|
|
|
$this->getMockJob( [ $mockToStringObj ] ),
|
2019-03-30 06:07:48 +00:00
|
|
|
'someCommand Special: 0={STRING_OBJ_VAL} ' . $requestId
|
2016-02-17 09:09:32 +00:00
|
|
|
],
|
2016-03-16 10:24:10 +00:00
|
|
|
[
|
|
|
|
|
$this->getMockJob( [
|
|
|
|
|
"pages" => [
|
|
|
|
|
"932737" => [
|
|
|
|
|
0,
|
|
|
|
|
"Robert_James_Waller"
|
|
|
|
|
]
|
|
|
|
|
],
|
|
|
|
|
"rootJobSignature" => "45868e99bba89064e4483743ebb9b682ef95c1a7",
|
|
|
|
|
"rootJobTimestamp" => "20160309110158",
|
|
|
|
|
"masterPos" => [
|
|
|
|
|
"file" => "db1023-bin.001288",
|
|
|
|
|
"pos" => "308257743",
|
|
|
|
|
"asOfTime" => 1457521464.3814
|
|
|
|
|
],
|
|
|
|
|
"triggeredRecursive" => true
|
|
|
|
|
] ),
|
2019-03-30 06:07:48 +00:00
|
|
|
'someCommand Special: pages={"932737":[0,"Robert_James_Waller"]} ' .
|
2016-03-16 10:24:10 +00:00
|
|
|
'rootJobSignature=45868e99bba89064e4483743ebb9b682ef95c1a7 ' .
|
|
|
|
|
'rootJobTimestamp=20160309110158 masterPos=' .
|
2022-11-16 00:58:55 +00:00
|
|
|
'{"file":"db1023-bin.001288","pos":"308257743",' .
|
2022-11-28 16:59:37 +00:00
|
|
|
'"asOfTime":1457521464.3814} triggeredRecursive=1 ' .
|
2016-04-11 21:00:43 +00:00
|
|
|
$requestId
|
2016-03-16 10:24:10 +00:00
|
|
|
],
|
2016-02-17 09:09:32 +00:00
|
|
|
];
|
2014-09-23 20:52:39 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
|
|
public function getMockJob( $params ) {
|
|
|
|
|
$mock = $this->getMockForAbstractClass(
|
2018-01-13 00:02:09 +00:00
|
|
|
Job::class,
|
jobqueue: Follow-up for fc5d51f12936ed (added GenericParameterJob)
* Remove duplicate $params check from Job::factory done in Job::__construct.
* In Job::factory(), restore use of a valid title as default for passing as
constructor arg to old job classes. Their constructor may expect it to
be valid.
Keep the invalid dummy in Job::__construct, and document why.
* tests: Update test case for failure mode when using Job::factory
with a class that requires a title. It asserted getting an invalid
title. This now restores the behaviour prior to fc5d51f12936ed,
which is that job classes that require a title, get a valid one.
* tests: Remove test case for testToString that used
an explicitly passed but invalid params value. I've converted
that to expect the exception we now throw instead.
* tests: Update getMockJob(), also used by testToString, which was
relying on undocumented behaviour that 'new Title' is public
and gets namespace=0 and title=''. Before fc5d51f12936ed,
title params weren't in toString() and it asserted outputting
three spaces (delimiter, empty string from formatted title,
delimiter).
In fc5d51f12936ed, this changed to asserting "Special:" which
seems unintentional as we didn't pass it the internally reserved
NS_SPECIAL/'' value, and yet was caught by the dbkey=='' check.
Given this test case doesn't deal with titles, omit it for now.
A job can either have a $title and title/namespace in params,
or neither. This test was asserting an in-memory scenario
where $title can be an object, but title/namespace absent from
params.
Bug: T221368
Depends-On: I89f6ad6967d6f82d87a62c15c0dded901c51b714
Change-Id: I2ec99a12ecc627359a2aae5153d5d7c54156ff46
2019-04-18 15:29:41 +00:00
|
|
|
[ 'someCommand', $params ],
|
2014-09-23 20:52:39 +00:00
|
|
|
'SomeJob'
|
|
|
|
|
);
|
2019-03-30 06:07:48 +00:00
|
|
|
|
2014-09-23 20:52:39 +00:00
|
|
|
return $mock;
|
|
|
|
|
}
|
|
|
|
|
|
jobqueue: Follow-up for fc5d51f12936ed (added GenericParameterJob)
* Remove duplicate $params check from Job::factory done in Job::__construct.
* In Job::factory(), restore use of a valid title as default for passing as
constructor arg to old job classes. Their constructor may expect it to
be valid.
Keep the invalid dummy in Job::__construct, and document why.
* tests: Update test case for failure mode when using Job::factory
with a class that requires a title. It asserted getting an invalid
title. This now restores the behaviour prior to fc5d51f12936ed,
which is that job classes that require a title, get a valid one.
* tests: Remove test case for testToString that used
an explicitly passed but invalid params value. I've converted
that to expect the exception we now throw instead.
* tests: Update getMockJob(), also used by testToString, which was
relying on undocumented behaviour that 'new Title' is public
and gets namespace=0 and title=''. Before fc5d51f12936ed,
title params weren't in toString() and it asserted outputting
three spaces (delimiter, empty string from formatted title,
delimiter).
In fc5d51f12936ed, this changed to asserting "Special:" which
seems unintentional as we didn't pass it the internally reserved
NS_SPECIAL/'' value, and yet was caught by the dbkey=='' check.
Given this test case doesn't deal with titles, omit it for now.
A job can either have a $title and title/namespace in params,
or neither. This test was asserting an in-memory scenario
where $title can be an object, but title/namespace absent from
params.
Bug: T221368
Depends-On: I89f6ad6967d6f82d87a62c15c0dded901c51b714
Change-Id: I2ec99a12ecc627359a2aae5153d5d7c54156ff46
2019-04-18 15:29:41 +00:00
|
|
|
public function testInvalidParamsArgument() {
|
|
|
|
|
$params = false;
|
2019-10-05 15:42:53 +00:00
|
|
|
$this->expectException( InvalidArgumentException::class );
|
|
|
|
|
$this->expectExceptionMessage( '$params must be an array' );
|
jobqueue: Follow-up for fc5d51f12936ed (added GenericParameterJob)
* Remove duplicate $params check from Job::factory done in Job::__construct.
* In Job::factory(), restore use of a valid title as default for passing as
constructor arg to old job classes. Their constructor may expect it to
be valid.
Keep the invalid dummy in Job::__construct, and document why.
* tests: Update test case for failure mode when using Job::factory
with a class that requires a title. It asserted getting an invalid
title. This now restores the behaviour prior to fc5d51f12936ed,
which is that job classes that require a title, get a valid one.
* tests: Remove test case for testToString that used
an explicitly passed but invalid params value. I've converted
that to expect the exception we now throw instead.
* tests: Update getMockJob(), also used by testToString, which was
relying on undocumented behaviour that 'new Title' is public
and gets namespace=0 and title=''. Before fc5d51f12936ed,
title params weren't in toString() and it asserted outputting
three spaces (delimiter, empty string from formatted title,
delimiter).
In fc5d51f12936ed, this changed to asserting "Special:" which
seems unintentional as we didn't pass it the internally reserved
NS_SPECIAL/'' value, and yet was caught by the dbkey=='' check.
Given this test case doesn't deal with titles, omit it for now.
A job can either have a $title and title/namespace in params,
or neither. This test was asserting an in-memory scenario
where $title can be an object, but title/namespace absent from
params.
Bug: T221368
Depends-On: I89f6ad6967d6f82d87a62c15c0dded901c51b714
Change-Id: I2ec99a12ecc627359a2aae5153d5d7c54156ff46
2019-04-18 15:29:41 +00:00
|
|
|
$job = $this->getMockJob( $params );
|
|
|
|
|
}
|
|
|
|
|
|
2017-05-04 16:00:28 +00:00
|
|
|
/**
|
|
|
|
|
* @dataProvider provideTestJobFactory
|
|
|
|
|
*/
|
2023-01-12 13:17:43 +00:00
|
|
|
public function testJobFactory( $handler, $expectedClass ) {
|
|
|
|
|
$this->overrideConfigValue( 'JobClasses', [ 'testdummy' => $handler ] );
|
2017-05-04 16:00:28 +00:00
|
|
|
|
|
|
|
|
$job = Job::factory( 'testdummy', Title::newMainPage(), [] );
|
2023-01-12 13:17:43 +00:00
|
|
|
$this->assertInstanceOf( $expectedClass, $job );
|
2017-05-04 16:00:28 +00:00
|
|
|
|
2023-01-12 13:17:43 +00:00
|
|
|
$job2 = Job::factory( 'testdummy', [] );
|
|
|
|
|
$this->assertInstanceOf( $expectedClass, $job2 );
|
2017-05-04 16:00:28 +00:00
|
|
|
$this->assertNotSame( $job, $job2, 'should not reuse instance' );
|
2023-01-12 13:17:43 +00:00
|
|
|
|
|
|
|
|
$job3 = Job::factory( 'testdummy', [ 'namespace' => NS_MAIN, 'title' => 'JobTestTitle' ] );
|
|
|
|
|
$this->assertInstanceOf( $expectedClass, $job3 );
|
|
|
|
|
$this->assertNotSame( $job, $job3, 'should not reuse instance' );
|
2017-05-04 16:00:28 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
|
|
public function provideTestJobFactory() {
|
|
|
|
|
return [
|
2023-01-12 13:17:43 +00:00
|
|
|
'class name, no title' => [ 'NullJob', NullJob::class ],
|
|
|
|
|
'class name with title' => [ DeleteLinksJob::class, DeleteLinksJob::class ],
|
2021-02-07 13:10:36 +00:00
|
|
|
'closure' => [ static function ( Title $title, array $params ) {
|
2023-01-12 13:17:43 +00:00
|
|
|
return new NullJob( $params );
|
|
|
|
|
}, NullJob::class ],
|
|
|
|
|
'function' => [ [ $this, 'newNullJob' ], NullJob::class ],
|
|
|
|
|
'object spec, no title' => [ [ 'class' => 'NullJob' ], NullJob::class ],
|
|
|
|
|
'object spec with title' => [ [ 'class' => DeleteLinksJob::class ], DeleteLinksJob::class ],
|
|
|
|
|
'object spec with no title and not subclass of GenericParameterJob' => [
|
|
|
|
|
[
|
|
|
|
|
'class' => ParsoidCachePrewarmJob::class,
|
|
|
|
|
'services' => [
|
|
|
|
|
'ParsoidOutputAccess',
|
|
|
|
|
'PageStore',
|
|
|
|
|
'RevisionLookup'
|
|
|
|
|
],
|
|
|
|
|
'needsPage' => false
|
|
|
|
|
],
|
|
|
|
|
ParsoidCachePrewarmJob::class
|
|
|
|
|
]
|
2017-05-04 16:00:28 +00:00
|
|
|
];
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
public function newNullJob( Title $title, array $params ) {
|
2023-01-12 13:17:43 +00:00
|
|
|
return new NullJob( $params );
|
2019-03-30 06:07:48 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
|
|
public function testJobSignatureGeneric() {
|
|
|
|
|
$testPage = Title::makeTitle( NS_PROJECT, 'x' );
|
|
|
|
|
$blankTitle = Title::makeTitle( NS_SPECIAL, '' );
|
|
|
|
|
$params = [ 'z' => 1, 'lives' => 1, 'usleep' => 0 ];
|
|
|
|
|
$paramsWithTitle = $params + [ 'namespace' => NS_PROJECT, 'title' => 'x' ];
|
|
|
|
|
|
|
|
|
|
$job = new NullJob( [ 'namespace' => NS_PROJECT, 'title' => 'x' ] + $params );
|
|
|
|
|
$this->assertEquals( $testPage->getPrefixedText(), $job->getTitle()->getPrefixedText() );
|
|
|
|
|
$this->assertJobParamsMatch( $job, $paramsWithTitle );
|
|
|
|
|
|
|
|
|
|
$job = Job::factory( 'null', $testPage, $params );
|
|
|
|
|
$this->assertEquals( $blankTitle->getPrefixedText(), $job->getTitle()->getPrefixedText() );
|
|
|
|
|
$this->assertJobParamsMatch( $job, $params );
|
|
|
|
|
|
|
|
|
|
$job = Job::factory( 'null', $paramsWithTitle );
|
|
|
|
|
$this->assertEquals( $testPage->getPrefixedText(), $job->getTitle()->getPrefixedText() );
|
|
|
|
|
$this->assertJobParamsMatch( $job, $paramsWithTitle );
|
|
|
|
|
|
|
|
|
|
$job = Job::factory( 'null', $params );
|
|
|
|
|
$this->assertTrue( $blankTitle->equals( $job->getTitle() ) );
|
|
|
|
|
$this->assertJobParamsMatch( $job, $params );
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
public function testJobSignatureTitleBased() {
|
2022-02-09 09:14:34 +00:00
|
|
|
$testPage = Title::makeTitle( NS_PROJECT, 'X' );
|
jobqueue: Follow-up for fc5d51f12936ed (added GenericParameterJob)
* Remove duplicate $params check from Job::factory done in Job::__construct.
* In Job::factory(), restore use of a valid title as default for passing as
constructor arg to old job classes. Their constructor may expect it to
be valid.
Keep the invalid dummy in Job::__construct, and document why.
* tests: Update test case for failure mode when using Job::factory
with a class that requires a title. It asserted getting an invalid
title. This now restores the behaviour prior to fc5d51f12936ed,
which is that job classes that require a title, get a valid one.
* tests: Remove test case for testToString that used
an explicitly passed but invalid params value. I've converted
that to expect the exception we now throw instead.
* tests: Update getMockJob(), also used by testToString, which was
relying on undocumented behaviour that 'new Title' is public
and gets namespace=0 and title=''. Before fc5d51f12936ed,
title params weren't in toString() and it asserted outputting
three spaces (delimiter, empty string from formatted title,
delimiter).
In fc5d51f12936ed, this changed to asserting "Special:" which
seems unintentional as we didn't pass it the internally reserved
NS_SPECIAL/'' value, and yet was caught by the dbkey=='' check.
Given this test case doesn't deal with titles, omit it for now.
A job can either have a $title and title/namespace in params,
or neither. This test was asserting an in-memory scenario
where $title can be an object, but title/namespace absent from
params.
Bug: T221368
Depends-On: I89f6ad6967d6f82d87a62c15c0dded901c51b714
Change-Id: I2ec99a12ecc627359a2aae5153d5d7c54156ff46
2019-04-18 15:29:41 +00:00
|
|
|
$blankPage = Title::makeTitle( NS_SPECIAL, 'Blankpage' );
|
2019-03-30 06:07:48 +00:00
|
|
|
$params = [ 'z' => 1, 'causeAction' => 'unknown', 'causeAgent' => 'unknown' ];
|
2022-02-09 09:14:34 +00:00
|
|
|
$paramsWithTitle = $params + [ 'namespace' => NS_PROJECT, 'title' => 'X' ];
|
jobqueue: Follow-up for fc5d51f12936ed (added GenericParameterJob)
* Remove duplicate $params check from Job::factory done in Job::__construct.
* In Job::factory(), restore use of a valid title as default for passing as
constructor arg to old job classes. Their constructor may expect it to
be valid.
Keep the invalid dummy in Job::__construct, and document why.
* tests: Update test case for failure mode when using Job::factory
with a class that requires a title. It asserted getting an invalid
title. This now restores the behaviour prior to fc5d51f12936ed,
which is that job classes that require a title, get a valid one.
* tests: Remove test case for testToString that used
an explicitly passed but invalid params value. I've converted
that to expect the exception we now throw instead.
* tests: Update getMockJob(), also used by testToString, which was
relying on undocumented behaviour that 'new Title' is public
and gets namespace=0 and title=''. Before fc5d51f12936ed,
title params weren't in toString() and it asserted outputting
three spaces (delimiter, empty string from formatted title,
delimiter).
In fc5d51f12936ed, this changed to asserting "Special:" which
seems unintentional as we didn't pass it the internally reserved
NS_SPECIAL/'' value, and yet was caught by the dbkey=='' check.
Given this test case doesn't deal with titles, omit it for now.
A job can either have a $title and title/namespace in params,
or neither. This test was asserting an in-memory scenario
where $title can be an object, but title/namespace absent from
params.
Bug: T221368
Depends-On: I89f6ad6967d6f82d87a62c15c0dded901c51b714
Change-Id: I2ec99a12ecc627359a2aae5153d5d7c54156ff46
2019-04-18 15:29:41 +00:00
|
|
|
$paramsWithBlankpage = $params + [ 'namespace' => NS_SPECIAL, 'title' => 'Blankpage' ];
|
2019-03-30 06:07:48 +00:00
|
|
|
|
|
|
|
|
$job = new RefreshLinksJob( $testPage, $params );
|
|
|
|
|
$this->assertEquals( $testPage->getPrefixedText(), $job->getTitle()->getPrefixedText() );
|
jobqueue: Follow-up for fc5d51f12936ed (added GenericParameterJob)
* Remove duplicate $params check from Job::factory done in Job::__construct.
* In Job::factory(), restore use of a valid title as default for passing as
constructor arg to old job classes. Their constructor may expect it to
be valid.
Keep the invalid dummy in Job::__construct, and document why.
* tests: Update test case for failure mode when using Job::factory
with a class that requires a title. It asserted getting an invalid
title. This now restores the behaviour prior to fc5d51f12936ed,
which is that job classes that require a title, get a valid one.
* tests: Remove test case for testToString that used
an explicitly passed but invalid params value. I've converted
that to expect the exception we now throw instead.
* tests: Update getMockJob(), also used by testToString, which was
relying on undocumented behaviour that 'new Title' is public
and gets namespace=0 and title=''. Before fc5d51f12936ed,
title params weren't in toString() and it asserted outputting
three spaces (delimiter, empty string from formatted title,
delimiter).
In fc5d51f12936ed, this changed to asserting "Special:" which
seems unintentional as we didn't pass it the internally reserved
NS_SPECIAL/'' value, and yet was caught by the dbkey=='' check.
Given this test case doesn't deal with titles, omit it for now.
A job can either have a $title and title/namespace in params,
or neither. This test was asserting an in-memory scenario
where $title can be an object, but title/namespace absent from
params.
Bug: T221368
Depends-On: I89f6ad6967d6f82d87a62c15c0dded901c51b714
Change-Id: I2ec99a12ecc627359a2aae5153d5d7c54156ff46
2019-04-18 15:29:41 +00:00
|
|
|
$this->assertTrue( $testPage->equals( $job->getTitle() ) );
|
2019-03-30 06:07:48 +00:00
|
|
|
$this->assertJobParamsMatch( $job, $paramsWithTitle );
|
|
|
|
|
|
2022-02-09 09:14:34 +00:00
|
|
|
$job = Job::factory( 'htmlCacheUpdate', $testPage, $params );
|
2019-03-30 06:07:48 +00:00
|
|
|
$this->assertEquals( $testPage->getPrefixedText(), $job->getTitle()->getPrefixedText() );
|
|
|
|
|
$this->assertJobParamsMatch( $job, $paramsWithTitle );
|
|
|
|
|
|
2022-02-09 09:14:34 +00:00
|
|
|
$job = Job::factory( 'htmlCacheUpdate', $paramsWithTitle );
|
2019-03-30 06:07:48 +00:00
|
|
|
$this->assertEquals( $testPage->getPrefixedText(), $job->getTitle()->getPrefixedText() );
|
|
|
|
|
$this->assertJobParamsMatch( $job, $paramsWithTitle );
|
|
|
|
|
|
2022-02-09 09:14:34 +00:00
|
|
|
$job = Job::factory( 'htmlCacheUpdate', $params );
|
jobqueue: Follow-up for fc5d51f12936ed (added GenericParameterJob)
* Remove duplicate $params check from Job::factory done in Job::__construct.
* In Job::factory(), restore use of a valid title as default for passing as
constructor arg to old job classes. Their constructor may expect it to
be valid.
Keep the invalid dummy in Job::__construct, and document why.
* tests: Update test case for failure mode when using Job::factory
with a class that requires a title. It asserted getting an invalid
title. This now restores the behaviour prior to fc5d51f12936ed,
which is that job classes that require a title, get a valid one.
* tests: Remove test case for testToString that used
an explicitly passed but invalid params value. I've converted
that to expect the exception we now throw instead.
* tests: Update getMockJob(), also used by testToString, which was
relying on undocumented behaviour that 'new Title' is public
and gets namespace=0 and title=''. Before fc5d51f12936ed,
title params weren't in toString() and it asserted outputting
three spaces (delimiter, empty string from formatted title,
delimiter).
In fc5d51f12936ed, this changed to asserting "Special:" which
seems unintentional as we didn't pass it the internally reserved
NS_SPECIAL/'' value, and yet was caught by the dbkey=='' check.
Given this test case doesn't deal with titles, omit it for now.
A job can either have a $title and title/namespace in params,
or neither. This test was asserting an in-memory scenario
where $title can be an object, but title/namespace absent from
params.
Bug: T221368
Depends-On: I89f6ad6967d6f82d87a62c15c0dded901c51b714
Change-Id: I2ec99a12ecc627359a2aae5153d5d7c54156ff46
2019-04-18 15:29:41 +00:00
|
|
|
$this->assertTrue( $blankPage->equals( $job->getTitle() ) );
|
|
|
|
|
$this->assertJobParamsMatch( $job, $paramsWithBlankpage );
|
2019-03-30 06:07:48 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
|
|
public function testJobSignatureTitleBasedIncomplete() {
|
2022-02-09 09:14:34 +00:00
|
|
|
$testPage = Title::makeTitle( NS_PROJECT, 'X' );
|
2019-03-30 06:07:48 +00:00
|
|
|
$blankTitle = Title::makeTitle( NS_SPECIAL, '' );
|
|
|
|
|
$params = [ 'z' => 1, 'causeAction' => 'unknown', 'causeAgent' => 'unknown' ];
|
|
|
|
|
|
|
|
|
|
$job = new RefreshLinksJob( $testPage, $params + [ 'namespace' => 0 ] );
|
|
|
|
|
$this->assertEquals( $blankTitle->getPrefixedText(), $job->getTitle()->getPrefixedText() );
|
|
|
|
|
$this->assertJobParamsMatch( $job, $params + [ 'namespace' => 0 ] );
|
|
|
|
|
|
|
|
|
|
$job = new RefreshLinksJob( $testPage, $params + [ 'title' => 'x' ] );
|
|
|
|
|
$this->assertEquals( $blankTitle->getPrefixedText(), $job->getTitle()->getPrefixedText() );
|
|
|
|
|
$this->assertJobParamsMatch( $job, $params + [ 'title' => 'x' ] );
|
2017-05-04 16:00:28 +00:00
|
|
|
}
|
|
|
|
|
|
2019-03-30 06:07:48 +00:00
|
|
|
private function assertJobParamsMatch( IJobSpecification $job, array $params ) {
|
|
|
|
|
$actual = $job->getParams();
|
|
|
|
|
unset( $actual['requestId'] );
|
|
|
|
|
|
|
|
|
|
$this->assertEquals( $actual, $params );
|
|
|
|
|
}
|
2014-09-23 20:52:39 +00:00
|
|
|
}
|