wiki.techinc.nl/maintenance/cleanupPreferences.php

142 lines
4.5 KiB
PHP
Raw Normal View History

<?php
/**
* Clean up user preferences from the database.
*
* This program is free software; you can redistribute it and/or modify
* it under the terms of the GNU General Public License as published by
* the Free Software Foundation; either version 2 of the License, or
* (at your option) any later version.
*
* This program is distributed in the hope that it will be useful,
* but WITHOUT ANY WARRANTY; without even the implied warranty of
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
* GNU General Public License for more details.
*
* You should have received a copy of the GNU General Public License along
* with this program; if not, write to the Free Software Foundation, Inc.,
* 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
* http://www.gnu.org/copyleft/gpl.html
*
* @file
* @author TyA <tya.wiki@gmail.com>
* @author Chad <chad@wikimedia.org>
* @see https://phabricator.wikimedia.org/T32976
* @ingroup Maintenance
*/
require_once __DIR__ . '/Maintenance.php';
/**
* Maintenance script that removes unused preferences from the database.
*
* @ingroup Maintenance
*/
class CleanupPreferences extends Maintenance {
public function __construct() {
parent::__construct();
$this->addDescription( 'Clean up hidden preferences or removed preferences' );
$this->setBatchSize( 50 );
$this->addOption( 'dry-run', 'Print debug info instead of actually deleting' );
$this->addOption( 'hidden', 'Drop hidden preferences ($wgHiddenPrefs)' );
$this->addOption( 'unknown',
'Drop unknown preferences (not in $wgDefaultUserOptions or prefixed with "userjs-")' );
}
/**
* We will do this in three passes
* 1) The easiest is to drop the hidden preferences from the database. We
* don't actually want them
* 2) Drop preference keys that we don't know about. They could've been
* removed from core, provided by a now-disabled extension, or the result
* of a bug. We don't want them.
*/
public function execute() {
$dbw = $this->getDB( DB_PRIMARY );
$hidden = $this->hasOption( 'hidden' );
$unknown = $this->hasOption( 'unknown' );
if ( !$hidden && !$unknown ) {
$this->output( "Did not select one of --hidden, --unknown, exiting\n" );
return;
}
// Remove hidden prefs. Iterate over them to avoid the IN on a large table
if ( $hidden ) {
$hiddenPrefs = $this->getConfig()->get( 'HiddenPrefs' );
if ( !$hiddenPrefs ) {
$this->output( "No hidden preferences, skipping\n" );
}
foreach ( $hiddenPrefs as $hiddenPref ) {
$this->deleteByWhere(
$dbw,
'Dropping hidden preferences',
[ 'up_property' => $hiddenPref ]
);
}
}
// Remove unknown preferences. Special-case 'userjs-' as we can't control those names.
if ( $unknown ) {
$defaultUserOptions = $this->getConfig()->get( 'DefaultUserOptions' );
$where = [
'up_property NOT' . $dbw->buildLike( 'userjs-', $dbw->anyString() ),
'up_property NOT IN (' . $dbw->makeList( array_keys( $defaultUserOptions ) ) . ')',
];
// Allow extensions to add to the where clause to prevent deletion of their own prefs.
Hooks::run() call site migration Migrate all callers of Hooks::run() to use the new HookContainer/HookRunner system. General principles: * Use DI if it is already used. We're not changing the way state is managed in this patch. * HookContainer is always injected, not HookRunner. HookContainer is a service, it's a more generic interface, it is the only thing that provides isRegistered() which is needed in some cases, and a HookRunner can be efficiently constructed from it (confirmed by benchmark). Because HookContainer is needed for object construction, it is also needed by all factories. * "Ask your friendly local base class". Big hierarchies like SpecialPage and ApiBase have getHookContainer() and getHookRunner() methods in the base class, and classes that extend that base class are not expected to know or care where the base class gets its HookContainer from. * ProtectedHookAccessorTrait provides protected getHookContainer() and getHookRunner() methods, getting them from the global service container. The point of this is to ease migration to DI by ensuring that call sites ask their local friendly base class rather than getting a HookRunner from the service container directly. * Private $this->hookRunner. In some smaller classes where accessor methods did not seem warranted, there is a private HookRunner property which is accessed directly. Very rarely (two cases), there is a protected property, for consistency with code that conventionally assumes protected=private, but in cases where the class might actually be overridden, a protected accessor is preferred over a protected property. * The last resort: Hooks::runner(). Mostly for static, file-scope and global code. In a few cases it was used for objects with broken construction schemes, out of horror or laziness. Constructors with new required arguments: * AuthManager * BadFileLookup * BlockManager * ClassicInterwikiLookup * ContentHandlerFactory * ContentSecurityPolicy * DefaultOptionsManager * DerivedPageDataUpdater * FullSearchResultWidget * HtmlCacheUpdater * LanguageFactory * LanguageNameUtils * LinkRenderer * LinkRendererFactory * LocalisationCache * MagicWordFactory * MessageCache * NamespaceInfo * PageEditStash * PageHandlerFactory * PageUpdater * ParserFactory * PermissionManager * RevisionStore * RevisionStoreFactory * SearchEngineConfig * SearchEngineFactory * SearchFormWidget * SearchNearMatcher * SessionBackend * SpecialPageFactory * UserNameUtils * UserOptionsManager * WatchedItemQueryService * WatchedItemStore Constructors with new optional arguments: * DefaultPreferencesFactory * Language * LinkHolderArray * MovePage * Parser * ParserCache * PasswordReset * Router setHookContainer() now required after construction: * AuthenticationProvider * ResourceLoaderModule * SearchEngine Change-Id: Id442b0dbe43aba84bd5cf801d86dedc768b082c7
2020-03-19 02:42:09 +00:00
$this->getHookRunner()->onDeleteUnknownPreferences( $where, $dbw );
$this->deleteByWhere( $dbw, 'Dropping unknown preferences', $where );
}
}
private function deleteByWhere( $dbw, $startMessage, $where ) {
$this->output( $startMessage . "...\n" );
$total = 0;
while ( true ) {
$res = $dbw->select(
'user_properties',
'*', // The table lacks a primary key, so select the whole row
$where,
__METHOD__,
[ 'LIMIT' => $this->mBatchSize ]
);
$numRows = $res->numRows();
$total += $numRows;
if ( $res->numRows() <= 0 ) {
$this->output( "DONE! (handled $total entries)\n" );
break;
}
// Progress or something
$this->output( "..doing $numRows entries\n" );
// Delete our batch, then wait
foreach ( $res as $row ) {
if ( $this->hasOption( 'dry-run' ) ) {
$this->output(
" DRY RUN, would drop: " .
"[up_user] => '{$row->up_user}' " .
"[up_property] => '{$row->up_property}' " .
"[up_value] => '{$row->up_value}'\n"
);
continue;
}
$this->beginTransaction( $dbw, __METHOD__ );
$dbw->delete(
'user_properties',
[
'up_user' => $row->up_user,
'up_property' => $row->up_property,
'up_value' => $row->up_value,
],
__METHOD__
);
$this->commitTransaction( $dbw, __METHOD__ );
}
}
}
}
$maintClass = CleanupPreferences::class; // Tells it to run the class
require_once RUN_MAINTENANCE_IF_MAIN;