2012-11-12 14:23:51 +00:00
|
|
|
<?php
|
|
|
|
|
/**
|
2017-07-25 20:32:31 +00:00
|
|
|
* Clean up user preferences from the database.
|
2012-11-12 14:23:51 +00:00
|
|
|
*
|
|
|
|
|
* This program is free software; you can redistribute it and/or modify
|
|
|
|
|
* it under the terms of the GNU General Public License as published by
|
|
|
|
|
* the Free Software Foundation; either version 2 of the License, or
|
|
|
|
|
* (at your option) any later version.
|
|
|
|
|
*
|
|
|
|
|
* This program is distributed in the hope that it will be useful,
|
|
|
|
|
* but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
|
|
|
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
|
|
|
* GNU General Public License for more details.
|
|
|
|
|
*
|
|
|
|
|
* You should have received a copy of the GNU General Public License along
|
|
|
|
|
* with this program; if not, write to the Free Software Foundation, Inc.,
|
|
|
|
|
* 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
|
|
|
|
|
* http://www.gnu.org/copyleft/gpl.html
|
|
|
|
|
*
|
|
|
|
|
* @file
|
|
|
|
|
* @author TyA <tya.wiki@gmail.com>
|
2017-07-25 20:32:31 +00:00
|
|
|
* @author Chad <chad@wikimedia.org>
|
2015-09-12 13:54:13 +00:00
|
|
|
* @see https://phabricator.wikimedia.org/T32976
|
2012-11-12 14:23:51 +00:00
|
|
|
* @ingroup Maintenance
|
|
|
|
|
*/
|
|
|
|
|
|
2013-05-17 00:16:59 +00:00
|
|
|
require_once __DIR__ . '/Maintenance.php';
|
2012-11-12 14:23:51 +00:00
|
|
|
|
|
|
|
|
/**
|
2021-09-29 16:46:45 +00:00
|
|
|
* Maintenance script that removes unused preferences from the database.
|
2012-11-12 14:23:51 +00:00
|
|
|
*
|
|
|
|
|
* @ingroup Maintenance
|
|
|
|
|
*/
|
|
|
|
|
class CleanupPreferences extends Maintenance {
|
2017-07-25 20:32:31 +00:00
|
|
|
public function __construct() {
|
|
|
|
|
parent::__construct();
|
2021-09-29 16:46:45 +00:00
|
|
|
$this->addDescription( 'Clean up hidden preferences or removed preferences' );
|
2017-07-25 20:32:31 +00:00
|
|
|
$this->setBatchSize( 50 );
|
|
|
|
|
$this->addOption( 'dry-run', 'Print debug info instead of actually deleting' );
|
|
|
|
|
$this->addOption( 'hidden', 'Drop hidden preferences ($wgHiddenPrefs)' );
|
|
|
|
|
$this->addOption( 'unknown',
|
2018-04-06 01:44:50 +00:00
|
|
|
'Drop unknown preferences (not in $wgDefaultUserOptions or prefixed with "userjs-")' );
|
2017-07-25 20:32:31 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
|
|
/**
|
|
|
|
|
* We will do this in three passes
|
|
|
|
|
* 1) The easiest is to drop the hidden preferences from the database. We
|
|
|
|
|
* don't actually want them
|
|
|
|
|
* 2) Drop preference keys that we don't know about. They could've been
|
|
|
|
|
* removed from core, provided by a now-disabled extension, or the result
|
|
|
|
|
* of a bug. We don't want them.
|
|
|
|
|
*/
|
2012-11-12 14:23:51 +00:00
|
|
|
public function execute() {
|
2021-04-29 02:37:11 +00:00
|
|
|
$dbw = $this->getDB( DB_PRIMARY );
|
2017-07-25 20:32:31 +00:00
|
|
|
$hidden = $this->hasOption( 'hidden' );
|
|
|
|
|
$unknown = $this->hasOption( 'unknown' );
|
|
|
|
|
|
2021-09-29 16:46:45 +00:00
|
|
|
if ( !$hidden && !$unknown ) {
|
|
|
|
|
$this->output( "Did not select one of --hidden, --unknown, exiting\n" );
|
2017-07-25 20:32:31 +00:00
|
|
|
return;
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
// Remove hidden prefs. Iterate over them to avoid the IN on a large table
|
|
|
|
|
if ( $hidden ) {
|
2019-08-19 15:44:14 +00:00
|
|
|
$hiddenPrefs = $this->getConfig()->get( 'HiddenPrefs' );
|
|
|
|
|
if ( !$hiddenPrefs ) {
|
2017-07-25 20:32:31 +00:00
|
|
|
$this->output( "No hidden preferences, skipping\n" );
|
|
|
|
|
}
|
2019-08-19 15:44:14 +00:00
|
|
|
foreach ( $hiddenPrefs as $hiddenPref ) {
|
2017-07-25 20:32:31 +00:00
|
|
|
$this->deleteByWhere(
|
|
|
|
|
$dbw,
|
|
|
|
|
'Dropping hidden preferences',
|
|
|
|
|
[ 'up_property' => $hiddenPref ]
|
|
|
|
|
);
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
|
2018-04-06 01:44:50 +00:00
|
|
|
// Remove unknown preferences. Special-case 'userjs-' as we can't control those names.
|
2017-07-25 20:32:31 +00:00
|
|
|
if ( $unknown ) {
|
2019-08-19 15:44:14 +00:00
|
|
|
$defaultUserOptions = $this->getConfig()->get( 'DefaultUserOptions' );
|
2018-04-03 03:56:18 +00:00
|
|
|
$where = [
|
|
|
|
|
'up_property NOT' . $dbw->buildLike( 'userjs-', $dbw->anyString() ),
|
2019-08-19 15:44:14 +00:00
|
|
|
'up_property NOT IN (' . $dbw->makeList( array_keys( $defaultUserOptions ) ) . ')',
|
2018-04-03 03:56:18 +00:00
|
|
|
];
|
|
|
|
|
// Allow extensions to add to the where clause to prevent deletion of their own prefs.
|
Hooks::run() call site migration
Migrate all callers of Hooks::run() to use the new
HookContainer/HookRunner system.
General principles:
* Use DI if it is already used. We're not changing the way state is
managed in this patch.
* HookContainer is always injected, not HookRunner. HookContainer
is a service, it's a more generic interface, it is the only
thing that provides isRegistered() which is needed in some cases,
and a HookRunner can be efficiently constructed from it
(confirmed by benchmark). Because HookContainer is needed
for object construction, it is also needed by all factories.
* "Ask your friendly local base class". Big hierarchies like
SpecialPage and ApiBase have getHookContainer() and getHookRunner()
methods in the base class, and classes that extend that base class
are not expected to know or care where the base class gets its
HookContainer from.
* ProtectedHookAccessorTrait provides protected getHookContainer() and
getHookRunner() methods, getting them from the global service
container. The point of this is to ease migration to DI by ensuring
that call sites ask their local friendly base class rather than
getting a HookRunner from the service container directly.
* Private $this->hookRunner. In some smaller classes where accessor
methods did not seem warranted, there is a private HookRunner property
which is accessed directly. Very rarely (two cases), there is a
protected property, for consistency with code that conventionally
assumes protected=private, but in cases where the class might actually
be overridden, a protected accessor is preferred over a protected
property.
* The last resort: Hooks::runner(). Mostly for static, file-scope and
global code. In a few cases it was used for objects with broken
construction schemes, out of horror or laziness.
Constructors with new required arguments:
* AuthManager
* BadFileLookup
* BlockManager
* ClassicInterwikiLookup
* ContentHandlerFactory
* ContentSecurityPolicy
* DefaultOptionsManager
* DerivedPageDataUpdater
* FullSearchResultWidget
* HtmlCacheUpdater
* LanguageFactory
* LanguageNameUtils
* LinkRenderer
* LinkRendererFactory
* LocalisationCache
* MagicWordFactory
* MessageCache
* NamespaceInfo
* PageEditStash
* PageHandlerFactory
* PageUpdater
* ParserFactory
* PermissionManager
* RevisionStore
* RevisionStoreFactory
* SearchEngineConfig
* SearchEngineFactory
* SearchFormWidget
* SearchNearMatcher
* SessionBackend
* SpecialPageFactory
* UserNameUtils
* UserOptionsManager
* WatchedItemQueryService
* WatchedItemStore
Constructors with new optional arguments:
* DefaultPreferencesFactory
* Language
* LinkHolderArray
* MovePage
* Parser
* ParserCache
* PasswordReset
* Router
setHookContainer() now required after construction:
* AuthenticationProvider
* ResourceLoaderModule
* SearchEngine
Change-Id: Id442b0dbe43aba84bd5cf801d86dedc768b082c7
2020-03-19 02:42:09 +00:00
|
|
|
$this->getHookRunner()->onDeleteUnknownPreferences( $where, $dbw );
|
2018-04-03 03:56:18 +00:00
|
|
|
$this->deleteByWhere( $dbw, 'Dropping unknown preferences', $where );
|
2017-07-25 20:32:31 +00:00
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
private function deleteByWhere( $dbw, $startMessage, $where ) {
|
|
|
|
|
$this->output( $startMessage . "...\n" );
|
|
|
|
|
$total = 0;
|
|
|
|
|
while ( true ) {
|
|
|
|
|
$res = $dbw->select(
|
2012-11-12 14:23:51 +00:00
|
|
|
'user_properties',
|
2017-07-25 20:32:31 +00:00
|
|
|
'*', // The table lacks a primary key, so select the whole row
|
|
|
|
|
$where,
|
|
|
|
|
__METHOD__,
|
|
|
|
|
[ 'LIMIT' => $this->mBatchSize ]
|
2012-11-12 14:23:51 +00:00
|
|
|
);
|
2017-07-25 20:32:31 +00:00
|
|
|
|
|
|
|
|
$numRows = $res->numRows();
|
|
|
|
|
$total += $numRows;
|
|
|
|
|
if ( $res->numRows() <= 0 ) {
|
|
|
|
|
$this->output( "DONE! (handled $total entries)\n" );
|
|
|
|
|
break;
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
// Progress or something
|
|
|
|
|
$this->output( "..doing $numRows entries\n" );
|
|
|
|
|
|
|
|
|
|
// Delete our batch, then wait
|
|
|
|
|
foreach ( $res as $row ) {
|
|
|
|
|
if ( $this->hasOption( 'dry-run' ) ) {
|
|
|
|
|
$this->output(
|
|
|
|
|
" DRY RUN, would drop: " .
|
|
|
|
|
"[up_user] => '{$row->up_user}' " .
|
|
|
|
|
"[up_property] => '{$row->up_property}' " .
|
|
|
|
|
"[up_value] => '{$row->up_value}'\n"
|
|
|
|
|
);
|
|
|
|
|
continue;
|
|
|
|
|
}
|
|
|
|
|
$this->beginTransaction( $dbw, __METHOD__ );
|
|
|
|
|
$dbw->delete(
|
|
|
|
|
'user_properties',
|
|
|
|
|
[
|
|
|
|
|
'up_user' => $row->up_user,
|
|
|
|
|
'up_property' => $row->up_property,
|
|
|
|
|
'up_value' => $row->up_value,
|
|
|
|
|
],
|
|
|
|
|
__METHOD__
|
|
|
|
|
);
|
|
|
|
|
$this->commitTransaction( $dbw, __METHOD__ );
|
|
|
|
|
}
|
|
|
|
|
}
|
2012-11-12 14:23:51 +00:00
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
|
2018-01-13 00:02:09 +00:00
|
|
|
$maintClass = CleanupPreferences::class; // Tells it to run the class
|
2013-05-07 23:00:15 +00:00
|
|
|
require_once RUN_MAINTENANCE_IF_MAIN;
|