Thijs/wiki.techinc.nl
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions
wiki.techinc.nl/tests/phpunit/unit/includes/password/BcryptPasswordTest.php

44 lines
3 KiB
PHP
Raw Normal View History

Added password hashing API Deprecated the old User::crypt, et. al password hashing system and implemented an extensible password hashing API. The new Password class allows registering of child classes and provides factory functions for creating new Password objects. The built-in hash types are the old MediaWiki MD5 types, which are for backwards-compatibility only, and bcrypt. Also included is support for wrapping existing hashes as well as encrypting passwords with a configured encryption key. Bug: 54948 Bug: 28419 Change-Id: I0a9c972931a0eff0cfb2619cef3ddffd03710285
2013-07-31 05:11:18 +00:00
<?php
/**
* @group large
Improve test coverage in includes/password From 21% to 82%. * Added missing @covers, broadened @covers where appropriate. * Added tests for some code that lacked them. * Added a parameter to control the use of hash_pbkdf2() so that the pure PHP fallback could be tested. In the non-fallback test, force the use of the extension, and mark it skipped if it is not installed. Bug: T167003 Change-Id: I987e1a89ec343907f4ead7f6192b2d4deb58ac16
2017-06-06 05:05:22 +00:00
* @covers BcryptPassword
* @covers ParameterizedPassword
* @covers Password
* @covers PasswordFactory
Added password hashing API Deprecated the old User::crypt, et. al password hashing system and implemented an extensible password hashing API. The new Password class allows registering of child classes and provides factory functions for creating new Password objects. The built-in hash types are the old MediaWiki MD5 types, which are for backwards-compatibility only, and bcrypt. Also included is support for wrapping existing hashes as well as encrypting passwords with a configured encryption key. Bug: 54948 Bug: 28419 Change-Id: I0a9c972931a0eff0cfb2619cef3ddffd03710285
2013-07-31 05:11:18 +00:00
*/
Fix class name of BcryptPasswordTest Tests are named Test, not TestCase Change-Id: I3725f8bebde5896fde24e36bd6b6e25dd8492a91
2016-02-22 17:46:57 +00:00
class BcryptPasswordTest extends PasswordTestCase {
Added password hashing API Deprecated the old User::crypt, et. al password hashing system and implemented an extensible password hashing API. The new Password class allows registering of child classes and provides factory functions for creating new Password objects. The built-in hash types are the old MediaWiki MD5 types, which are for backwards-compatibility only, and bcrypt. Also included is support for wrapping existing hashes as well as encrypting passwords with a configured encryption key. Bug: 54948 Bug: 28419 Change-Id: I0a9c972931a0eff0cfb2619cef3ddffd03710285
2013-07-31 05:11:18 +00:00
protected function getTypeConfigs() {
Convert all array() syntax to [] Per wikitech-l consensus: https://lists.wikimedia.org/pipermail/wikitech-l/2016-February/084821.html Notes: * Disabled CallTimePassByReference due to false positives (T127163) Change-Id: I2c8ce713ce6600a0bb7bf67537c87044c7a45c4b
2016-02-17 09:09:32 +00:00
return [ 'bcrypt' => [
Use ::class to resolve class names in tests This helps to find renamed or misspelled classes earlier. Phan will check the class names Change-Id: Ie541a7baae10ab6f5c13f95ac2ff6598b8f8950c
2018-01-13 00:02:09 +00:00
'class' => BcryptPassword::class,
password: Reduce time cost of password unit tests Remove Argon2PasswordTest::testPartialConfig(). It's irreparably slow and doesn't seem to test anything useful, just that the defaults are the defaults. It was added in PS5 of Ifdf648f5d8a734a663e6 as part of a change which removed explicit cost defaults from DefaultSettings.php. Reduce time costs of some other tests. The time to execute tests in this directory is reduced from ~1.3s to ~0.5s. Bug: T225730 Change-Id: I30b846b5364ad2030e2547da6c58db13eaf401f2
2022-11-21 22:51:12 +00:00
'cost' => 4,
Convert all array() syntax to [] Per wikitech-l consensus: https://lists.wikimedia.org/pipermail/wikitech-l/2016-February/084821.html Notes: * Disabled CallTimePassByReference due to false positives (T127163) Change-Id: I2c8ce713ce6600a0bb7bf67537c87044c7a45c4b
2016-02-17 09:09:32 +00:00
] ];
Added password hashing API Deprecated the old User::crypt, et. al password hashing system and implemented an extensible password hashing API. The new Password class allows registering of child classes and provides factory functions for creating new Password objects. The built-in hash types are the old MediaWiki MD5 types, which are for backwards-compatibility only, and bcrypt. Also included is support for wrapping existing hashes as well as encrypting passwords with a configured encryption key. Bug: 54948 Bug: 28419 Change-Id: I0a9c972931a0eff0cfb2619cef3ddffd03710285
2013-07-31 05:11:18 +00:00
}
test: Clean up data providers that should be static Follows-up b36d883. By far most data providers are static (and PHPUnit expects them to be static and calls them that way). Most of these classes already had their data providers static but additional commits sloppily introduced non-static ones. * ResourceLoaderWikiModuleTest, 8968d8787f. * TitleTest, 545f1d3a73. Odd unused method 'dataTestIsValidMoveOperation' was introduced in 550b878e63. * GlobalVarConfigTest, a3e18c3670. Change-Id: I5da99f7cd3da68c550ae507ffe1f725d31e7666f
2014-09-18 01:28:26 +00:00
public static function providePasswordTests() {
Swap the rest of array() -> [] Change-Id: I76a7259ed952a0673a1941f08b39b545211fba07
2016-03-19 01:05:19 +00:00
return [
Added password hashing API Deprecated the old User::crypt, et. al password hashing system and implemented an extensible password hashing API. The new Password class allows registering of child classes and provides factory functions for creating new Password objects. The built-in hash types are the old MediaWiki MD5 types, which are for backwards-compatibility only, and bcrypt. Also included is support for wrapping existing hashes as well as encrypting passwords with a configured encryption key. Bug: 54948 Bug: 28419 Change-Id: I0a9c972931a0eff0cfb2619cef3ddffd03710285
2013-07-31 05:11:18 +00:00
// Tests from glibc bcrypt implementation
Swap the rest of array() -> [] Change-Id: I76a7259ed952a0673a1941f08b39b545211fba07
2016-03-19 01:05:19 +00:00
[ true, ':bcrypt:5$CCCCCCCCCCCCCCCCCCCCC.$E5YPO9kmyuRGyh0XouQYb4YMJKvyOeW', "U*U" ],
[ true, ':bcrypt:5$CCCCCCCCCCCCCCCCCCCCC.$VGOzA784oUp/Z0DY336zx7pLYAy0lwK', "U*U*" ],
[ true, ':bcrypt:5$XXXXXXXXXXXXXXXXXXXXXO$AcXxm9kjPGEMsLznoKqmqw7tc8WCx4a', "U*U*U" ],
[ true, ':bcrypt:5$abcdefghijklmnopqrstuu$5s2v8.iXieOjg/.AySBTTZIIVFJeBui', "0123456789abcdefghijklmnopqrstuvwxyzABCDEFGHIJKLMNOPQRSTUVWXYZ0123456789chars after 72 are ignored" ],
[ true, ':bcrypt:5$/OK.fbVrR/bpIqNJ5ianF.$CE5elHaaO4EbggVDjb8P19RukzXSM3e', "\xff\xff\xa3" ],
[ true, ':bcrypt:5$/OK.fbVrR/bpIqNJ5ianF.$Sa7shbm4.OzKpvFnX1pQLmQW96oUlCq', "\xa3" ],
[ true, ':bcrypt:5$/OK.fbVrR/bpIqNJ5ianF.$Sa7shbm4.OzKpvFnX1pQLmQW96oUlCq', "\xa3" ],
[ true, ':bcrypt:5$/OK.fbVrR/bpIqNJ5ianF.$o./n25XVfn6oAPaUvHe.Csk4zRfsYPi', "\xff\xa334\xff\xff\xff\xa3345" ],
[ true, ':bcrypt:5$/OK.fbVrR/bpIqNJ5ianF.$nRht2l/HRhr6zmCp9vYUvvsqynflf9e', "\xff\xa3345" ],
[ true, ':bcrypt:5$/OK.fbVrR/bpIqNJ5ianF.$nRht2l/HRhr6zmCp9vYUvvsqynflf9e', "\xff\xa3345" ],
[ true, ':bcrypt:5$/OK.fbVrR/bpIqNJ5ianF.$6IflQkJytoRVc1yuaNtHfiuq.FRlSIS', "\xa3ab" ],
[ true, ':bcrypt:5$/OK.fbVrR/bpIqNJ5ianF.$6IflQkJytoRVc1yuaNtHfiuq.FRlSIS', "\xa3ab" ],
[ true, ':bcrypt:5$/OK.fbVrR/bpIqNJ5ianF.$swQOIzjOiJ9GHEPuhEkvqrUyvWhEMx6', "\xaa\xaa\xaa\xaa\xaa\xaa\xaa\xaa\xaa\xaa\xaa\xaa\xaa\xaa\xaa\xaa\xaa\xaa\xaa\xaa\xaa\xaa\xaa\xaa\xaa\xaa\xaa\xaa\xaa\xaa\xaa\xaa\xaa\xaa\xaa\xaa\xaa\xaa\xaa\xaa\xaa\xaa\xaa\xaa\xaa\xaa\xaa\xaa\xaa\xaa\xaa\xaa\xaa\xaa\xaa\xaa\xaa\xaa\xaa\xaa\xaa\xaa\xaa\xaa\xaa\xaa\xaa\xaa\xaa\xaa\xaa\xaachars after 72 are ignored as usual" ],
[ true, ':bcrypt:5$/OK.fbVrR/bpIqNJ5ianF.$R9xrDjiycxMbQE2bp.vgqlYpW5wx2yy', "\xaa\x55\xaa\x55\xaa\x55\xaa\x55\xaa\x55\xaa\x55\xaa\x55\xaa\x55\xaa\x55\xaa\x55\xaa\x55\xaa\x55\xaa\x55\xaa\x55\xaa\x55\xaa\x55\xaa\x55\xaa\x55\xaa\x55\xaa\x55\xaa\x55\xaa\x55\xaa\x55\xaa\x55\xaa\x55\xaa\x55\xaa\x55\xaa\x55\xaa\x55\xaa\x55\xaa\x55\xaa\x55\xaa\x55\xaa\x55\xaa\x55\xaa\x55" ],
[ true, ':bcrypt:5$/OK.fbVrR/bpIqNJ5ianF.$9tQZzcJfm3uj2NvJ/n5xkhpqLrMpWCe', "\x55\xaa\xff\x55\xaa\xff\x55\xaa\xff\x55\xaa\xff\x55\xaa\xff\x55\xaa\xff\x55\xaa\xff\x55\xaa\xff\x55\xaa\xff\x55\xaa\xff\x55\xaa\xff\x55\xaa\xff\x55\xaa\xff\x55\xaa\xff\x55\xaa\xff\x55\xaa\xff\x55\xaa\xff\x55\xaa\xff\x55\xaa\xff\x55\xaa\xff\x55\xaa\xff\x55\xaa\xff\x55\xaa\xff\x55\xaa\xff" ],
[ true, ':bcrypt:5$CCCCCCCCCCCCCCCCCCCCC.$7uG0VCzI2bS7j6ymqJi9CdcdxiRTWNy', "" ],
Remove or replace usages of "sanity" Still some more to go... Bug: T254646 Change-Id: Ia117f01e443c35b4765f3275cab4f2707e1be96f
2021-11-21 16:23:11 +00:00
// False positive tests
Swap the rest of array() -> [] Change-Id: I76a7259ed952a0673a1941f08b39b545211fba07
2016-03-19 01:05:19 +00:00
[ false, ':bcrypt:5$CCCCCCCCCCCCCCCCCCCCC.$E5YPO9kmyuRGyh0XouQYb4YMJKvyOeW', "UXU" ],
[ false, ':bcrypt:5$CCCCCCCCCCCCCCCCCCCCC.$E5YPO9kmyuRGyh0XouQYb4YMJKvyOeW', "" ],
];
build: Updating mediawiki/mediawiki-codesniffer to 15.0.0 Clean up use of @codingStandardsIgnore - @codingStandardsIgnoreFile -> phpcs:ignoreFile - @codingStandardsIgnoreLine -> phpcs:ignore - @codingStandardsIgnoreStart -> phpcs:disable - @codingStandardsIgnoreEnd -> phpcs:enable For phpcs:disable always the necessary sniffs are provided. Some start/end pairs are changed to line ignore Change-Id: I92ef235849bcc349c69e53504e664a155dd162c8
2018-01-01 13:10:16 +00:00
// phpcs:enable
Added password hashing API Deprecated the old User::crypt, et. al password hashing system and implemented an extensible password hashing API. The new Password class allows registering of child classes and provides factory functions for creating new Password objects. The built-in hash types are the old MediaWiki MD5 types, which are for backwards-compatibility only, and bcrypt. Also included is support for wrapping existing hashes as well as encrypting passwords with a configured encryption key. Bug: 54948 Bug: 28419 Change-Id: I0a9c972931a0eff0cfb2619cef3ddffd03710285
2013-07-31 05:11:18 +00:00
}
}
Reference in a new issue Copy permalink