2010-12-29 15:52:07 +00:00
|
|
|
<?php
|
2016-02-07 08:12:10 +00:00
|
|
|
use MediaWiki\Logger\LegacySpi;
|
|
|
|
|
use MediaWiki\Logger\LoggerFactory;
|
|
|
|
|
use MediaWiki\Logger\MonologSpi;
|
2016-05-01 19:29:11 +00:00
|
|
|
use MediaWiki\MediaWikiServices;
|
2016-02-07 08:12:10 +00:00
|
|
|
use Psr\Log\LoggerInterface;
|
2010-12-29 15:52:07 +00:00
|
|
|
|
2014-03-05 14:41:41 +00:00
|
|
|
/**
|
|
|
|
|
* @since 1.18
|
|
|
|
|
*/
|
2010-12-29 15:52:07 +00:00
|
|
|
abstract class MediaWikiTestCase extends PHPUnit_Framework_TestCase {
|
2016-05-01 19:29:11 +00:00
|
|
|
|
|
|
|
|
/**
|
|
|
|
|
* The service locator created by prepareServices(). This service locator will
|
|
|
|
|
* be restored after each test. Tests that pollute the global service locator
|
|
|
|
|
* instance should use overrideMwServices() to isolate the test.
|
|
|
|
|
*
|
|
|
|
|
* @var MediaWikiServices|null
|
|
|
|
|
*/
|
|
|
|
|
private static $serviceLocator = null;
|
|
|
|
|
|
2012-10-22 23:53:51 +00:00
|
|
|
/**
|
|
|
|
|
* $called tracks whether the setUp and tearDown method has been called.
|
|
|
|
|
* class extending MediaWikiTestCase usually override setUp and tearDown
|
|
|
|
|
* but forget to call the parent.
|
|
|
|
|
*
|
|
|
|
|
* The array format takes a method name as key and anything as a value.
|
|
|
|
|
* By asserting the key exist, we know the child class has called the
|
|
|
|
|
* parent.
|
|
|
|
|
*
|
|
|
|
|
* This property must be private, we do not want child to override it,
|
|
|
|
|
* they should call the appropriate parent method instead.
|
|
|
|
|
*/
|
2016-02-17 09:09:32 +00:00
|
|
|
private $called = [];
|
2012-10-22 23:53:51 +00:00
|
|
|
|
2012-09-11 00:07:18 +00:00
|
|
|
/**
|
2014-03-05 14:41:41 +00:00
|
|
|
* @var TestUser[]
|
|
|
|
|
* @since 1.20
|
2012-09-11 00:07:18 +00:00
|
|
|
*/
|
|
|
|
|
public static $users;
|
|
|
|
|
|
2011-05-24 21:22:36 +00:00
|
|
|
/**
|
2016-03-03 07:30:24 +00:00
|
|
|
* Primary database
|
|
|
|
|
*
|
2011-05-24 21:22:36 +00:00
|
|
|
* @var DatabaseBase
|
2014-03-05 14:41:41 +00:00
|
|
|
* @since 1.18
|
2011-05-24 21:22:36 +00:00
|
|
|
*/
|
2010-12-29 15:52:07 +00:00
|
|
|
protected $db;
|
2014-03-05 14:41:41 +00:00
|
|
|
|
|
|
|
|
/**
|
|
|
|
|
* @var array
|
|
|
|
|
* @since 1.19
|
|
|
|
|
*/
|
2016-02-17 09:09:32 +00:00
|
|
|
protected $tablesUsed = []; // tables with data
|
2011-12-10 05:47:46 +00:00
|
|
|
|
2012-11-13 16:48:15 +00:00
|
|
|
private static $useTemporaryTables = true;
|
|
|
|
|
private static $reuseDB = false;
|
2011-05-24 21:22:36 +00:00
|
|
|
private static $dbSetup = false;
|
2016-09-19 01:39:59 +00:00
|
|
|
private static $oldTablePrefix = '';
|
2011-01-10 18:34:59 +00:00
|
|
|
|
2013-07-17 16:42:24 +00:00
|
|
|
/**
|
|
|
|
|
* Original value of PHP's error_reporting setting.
|
|
|
|
|
*
|
|
|
|
|
* @var int
|
|
|
|
|
*/
|
|
|
|
|
private $phpErrorLevel;
|
|
|
|
|
|
2012-04-10 14:28:42 +00:00
|
|
|
/**
|
|
|
|
|
* Holds the paths of temporary files/directories created through getNewTempFile,
|
|
|
|
|
* and getNewTempDirectory
|
|
|
|
|
*
|
|
|
|
|
* @var array
|
|
|
|
|
*/
|
2016-02-17 09:09:32 +00:00
|
|
|
private $tmpFiles = [];
|
2012-04-10 14:28:42 +00:00
|
|
|
|
2012-10-08 10:59:55 +00:00
|
|
|
/**
|
|
|
|
|
* Holds original values of MediaWiki configuration settings
|
|
|
|
|
* to be restored in tearDown().
|
2013-12-27 11:50:27 +00:00
|
|
|
* See also setMwGlobals().
|
2012-10-08 10:59:55 +00:00
|
|
|
* @var array
|
|
|
|
|
*/
|
2016-02-17 09:09:32 +00:00
|
|
|
private $mwGlobals = [];
|
2012-04-10 14:28:42 +00:00
|
|
|
|
2016-02-07 08:12:10 +00:00
|
|
|
/**
|
|
|
|
|
* Holds original loggers which have been replaced by setLogger()
|
|
|
|
|
* @var LoggerInterface[]
|
|
|
|
|
*/
|
2016-02-17 09:09:32 +00:00
|
|
|
private $loggers = [];
|
2016-02-07 08:12:10 +00:00
|
|
|
|
2011-01-10 18:34:59 +00:00
|
|
|
/**
|
|
|
|
|
* Table name prefixes. Oracle likes it shorter.
|
|
|
|
|
*/
|
|
|
|
|
const DB_PREFIX = 'unittest_';
|
|
|
|
|
const ORA_DB_PREFIX = 'ut_';
|
2011-06-02 19:32:45 +00:00
|
|
|
|
2014-03-05 14:41:41 +00:00
|
|
|
/**
|
|
|
|
|
* @var array
|
|
|
|
|
* @since 1.18
|
|
|
|
|
*/
|
2016-02-17 09:09:32 +00:00
|
|
|
protected $supportedDBs = [
|
2010-12-31 21:10:36 +00:00
|
|
|
'mysql',
|
2011-01-10 19:22:27 +00:00
|
|
|
'sqlite',
|
2011-10-24 19:28:31 +00:00
|
|
|
'postgres',
|
2011-01-10 19:22:27 +00:00
|
|
|
'oracle'
|
2016-02-17 09:09:32 +00:00
|
|
|
];
|
2010-12-29 15:52:07 +00:00
|
|
|
|
2016-02-17 09:09:32 +00:00
|
|
|
public function __construct( $name = null, array $data = [], $dataName = '' ) {
|
2011-02-05 16:25:18 +00:00
|
|
|
parent::__construct( $name, $data, $dataName );
|
2010-12-29 15:52:07 +00:00
|
|
|
|
2010-12-31 20:47:48 +00:00
|
|
|
$this->backupGlobals = false;
|
2011-02-20 17:52:09 +00:00
|
|
|
$this->backupStaticAttributes = false;
|
2010-12-29 15:52:07 +00:00
|
|
|
}
|
2011-06-02 19:32:45 +00:00
|
|
|
|
2014-09-14 19:07:14 +00:00
|
|
|
public function __destruct() {
|
|
|
|
|
// Complain if self::setUp() was called, but not self::tearDown()
|
|
|
|
|
// $this->called['setUp'] will be checked by self::testMediaWikiTestCaseParentSetupCalled()
|
|
|
|
|
if ( isset( $this->called['setUp'] ) && !isset( $this->called['tearDown'] ) ) {
|
2016-02-25 20:00:22 +00:00
|
|
|
throw new MWException( static::class . "::tearDown() must call parent::tearDown()" );
|
2014-09-14 19:07:14 +00:00
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
|
2016-05-01 19:29:11 +00:00
|
|
|
public static function setUpBeforeClass() {
|
|
|
|
|
parent::setUpBeforeClass();
|
|
|
|
|
|
Refactor parser tests
Merge the PHPUnit parser test runner with the old parserTests.inc,
taking the good bits of both. Reviewed, pared down and documented the
setup code. parserTests.php is now a frontend to a fully featured
parser test system, with lots of developer options, whereas PHPUnit
provides a simpler interface with increased isolation between test
cases.
Performance of both frontends is much improved, perhaps 2x faster for
parserTests.php and 10x faster for PHPUnit.
General:
* Split out the pre-Setup.php global variable configuration from
phpunit.php into a new class called TestSetup, also called it from
parserTests.php.
* Factored out the setup of TestsAutoLoader into a static method in
Maintenance.
* In Setup.php improved "caches" debug output.
PHPUnit frontend:
* Delete the entire contents of NewParserTest and replace it with a
small wrapper around ParserTestRunner. It doesn't inherit from
MediaWikiTestCase anymore since integrating the setup code was an
unnecessary complication.
* Rename MediaWikiParserTest to ParserTestTopLevelSuite and made it an
instantiable TestSuite class instead of just a static method. Got rid
of the eval(), just construct TestCase objects directly with a
specified name, it works just as well.
* Introduce ParserTestFileSuite for per-file setup.
* Remove parser-related options from phpunit.php, since we don't
support them anymore. Note that --filter now works just as well as
--regex used to.
* Add CoreParserTestSuite, equivalent to ExtensionsParserTestSuite,
for clarity.
* Make it possible to call MediaWikiTestCase::setupTestDB() more than
once, as is implied by the documentation.
parserTests.php frontend:
* Made parserTests.php into a Maintenance subclass, moved CLI-specific
code to it.
* Renamed ParserTest to ParserTestRunner, this is now the generic
backend.
* Add --upload-dir option which sets up an FSFileBackend, similar
to the old default behaviour
Test file reading and interpretation:
* Rename TestFileIterator to TestFileReader, and make it read and buffer
an entire file, instead of iterating.
* The previous code had an associative array representation of test
specifications. Used this form more widely to pass around test data.
* Remove the idea of !!hooks copying hooks from $wgParser, this is
unnecessary now that all extensions use ParserFirstCallInit. Resurrect
an old interpretation of the feature which was accidentally broken: if
a named hook does not exist, skip all tests in the file.
* Got rid of the "subtest" idea for tidy variants, instead use a
human-readable description that appears in the output.
* When all tests in a file are filtered or skipped, don't create the
articles in them. This greatly speeds up execution time when --regex
matches a small number of tests. It may possibly break extensions, but
they would have been randomly broken anyway since there is no
guarantee of test file execution order.
* Remove integrated testing of OutputPage::addCategoryLinks() category
link formatting, life is complicated enough already. It can go in
OutputPageTest if that's a thing we really need.
Result recording and display:
* Make TestRecorder into a generic plugin interface for progress output
etc., which needs to be abstracted for PHPUnit integration.
* Introduce MultiTestRecorder for recorder chaining, instead of using
a long inheritance chain. All test recorders now directly inherit from
TestRecorder.
* Move all console-related code to the new ParserTestPrinter.
* Introduce PhpunitTestRecorder, which is the recorder for the PHPUnit
frontend. Most events are ignored since they are never emitted in the
PHPUnit frontend, which does not call runTests().
* Put more information into ParserTestResult and use it more often.
Setup and teardown:
* Introduce a new API for setup/teardown where setup functions return a
ScopedCallback object which automatically performs the corresponding
teardown when it goes out of scope.
* Rename setUp() to staticSetup(), rewrite. There was a lot of cruft in
here which was simply copied from Setup.php without review, and had
nothing to do with parser tests.
* Rename setupGlobals() to perTestSetup(), mostly rewrite. For
performance, give staticSetup() precedence in cases where they were
both setting up the same thing.
* In support of merged setup code, allow Hooks::clear() to be called
from parserTests.php.
* Remove wgFileExtensions -- it is only used by UploadBase which we
don't call.
* Remove wgUseImageResize -- superseded by MockMediaHandlerFactory which
I imported from NewParserTest.
* Import MockFileBackend from NewParserTest. But instead of
customising the configuration globals, I injected services.
* Remove thumbnail deletion from upload teardown. This makes glob
handling as in the old parserTests.php unnecessary.
* Remove math file from upload teardown, math is actually an extension
now! Also, the relevant parser tests were removed from the Math
extension two years ago in favour of unit tests.
* Make addArticle() private, and introduce addArticles() instead, which
allows setup/teardown to be done once for each batch of articles
instead of every time.
* Remove $wgNamespaceAliases and $wgNamespaceProtection setup. These were
copied in from Setup.php in 2010, and are redundant since we do
actually run Setup.php.
* Use NullLockManager, don't set up a temporary directory just for
this alone.
Fuzz tests:
* Use the new TestSetup class.
* Updated for ParserTestRunner interface change.
* Remove some obsolete references to fuzz tests from the two frontends
where they used to reside.
Bug: T41473
Change-Id: Ia8e17008cb9d9b62ce5645e15a41a3b402f4026a
2016-09-08 01:25:22 +00:00
|
|
|
// Get the service locator, and reset services if it's not done already
|
|
|
|
|
self::$serviceLocator = self::prepareServices( new GlobalVarConfig() );
|
2016-05-01 19:29:11 +00:00
|
|
|
}
|
|
|
|
|
|
2016-05-18 09:19:20 +00:00
|
|
|
/**
|
|
|
|
|
* Convenience method for getting an immutable test user
|
|
|
|
|
*
|
|
|
|
|
* @since 1.28
|
|
|
|
|
*
|
|
|
|
|
* @param string[] $groups Groups the test user should be in.
|
|
|
|
|
* @return TestUser
|
|
|
|
|
*/
|
|
|
|
|
public static function getTestUser( $groups = [] ) {
|
|
|
|
|
return TestUserRegistry::getImmutableTestUser( $groups );
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
/**
|
|
|
|
|
* Convenience method for getting a mutable test user
|
|
|
|
|
*
|
|
|
|
|
* @since 1.28
|
|
|
|
|
*
|
|
|
|
|
* @param string[] $groups Groups the test user should be added in.
|
|
|
|
|
* @return TestUser
|
|
|
|
|
*/
|
|
|
|
|
public static function getMutableTestUser( $groups = [] ) {
|
|
|
|
|
return TestUserRegistry::getMutableTestUser( __CLASS__, $groups );
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
/**
|
|
|
|
|
* Convenience method for getting an immutable admin test user
|
|
|
|
|
*
|
|
|
|
|
* @since 1.28
|
|
|
|
|
*
|
|
|
|
|
* @param string[] $groups Groups the test user should be added to.
|
|
|
|
|
* @return TestUser
|
|
|
|
|
*/
|
|
|
|
|
public static function getTestSysop() {
|
|
|
|
|
return self::getTestUser( [ 'sysop', 'bureaucrat' ] );
|
|
|
|
|
}
|
|
|
|
|
|
2016-05-01 19:29:11 +00:00
|
|
|
/**
|
|
|
|
|
* Prepare service configuration for unit testing.
|
|
|
|
|
*
|
|
|
|
|
* This calls MediaWikiServices::resetGlobalInstance() to allow some critical services
|
|
|
|
|
* to be overridden for testing.
|
|
|
|
|
*
|
|
|
|
|
* prepareServices() only needs to be called once, but should be called as early as possible,
|
|
|
|
|
* before any class has a chance to grab a reference to any of the global services
|
|
|
|
|
* instances that get discarded by prepareServices(). Only the first call has any effect,
|
|
|
|
|
* later calls are ignored.
|
|
|
|
|
*
|
|
|
|
|
* @note This is called by PHPUnitMaintClass::finalSetup.
|
|
|
|
|
*
|
|
|
|
|
* @see MediaWikiServices::resetGlobalInstance()
|
|
|
|
|
*
|
|
|
|
|
* @param Config $bootstrapConfig The bootstrap config to use with the new
|
|
|
|
|
* MediaWikiServices. Only used for the first call to this method.
|
Refactor parser tests
Merge the PHPUnit parser test runner with the old parserTests.inc,
taking the good bits of both. Reviewed, pared down and documented the
setup code. parserTests.php is now a frontend to a fully featured
parser test system, with lots of developer options, whereas PHPUnit
provides a simpler interface with increased isolation between test
cases.
Performance of both frontends is much improved, perhaps 2x faster for
parserTests.php and 10x faster for PHPUnit.
General:
* Split out the pre-Setup.php global variable configuration from
phpunit.php into a new class called TestSetup, also called it from
parserTests.php.
* Factored out the setup of TestsAutoLoader into a static method in
Maintenance.
* In Setup.php improved "caches" debug output.
PHPUnit frontend:
* Delete the entire contents of NewParserTest and replace it with a
small wrapper around ParserTestRunner. It doesn't inherit from
MediaWikiTestCase anymore since integrating the setup code was an
unnecessary complication.
* Rename MediaWikiParserTest to ParserTestTopLevelSuite and made it an
instantiable TestSuite class instead of just a static method. Got rid
of the eval(), just construct TestCase objects directly with a
specified name, it works just as well.
* Introduce ParserTestFileSuite for per-file setup.
* Remove parser-related options from phpunit.php, since we don't
support them anymore. Note that --filter now works just as well as
--regex used to.
* Add CoreParserTestSuite, equivalent to ExtensionsParserTestSuite,
for clarity.
* Make it possible to call MediaWikiTestCase::setupTestDB() more than
once, as is implied by the documentation.
parserTests.php frontend:
* Made parserTests.php into a Maintenance subclass, moved CLI-specific
code to it.
* Renamed ParserTest to ParserTestRunner, this is now the generic
backend.
* Add --upload-dir option which sets up an FSFileBackend, similar
to the old default behaviour
Test file reading and interpretation:
* Rename TestFileIterator to TestFileReader, and make it read and buffer
an entire file, instead of iterating.
* The previous code had an associative array representation of test
specifications. Used this form more widely to pass around test data.
* Remove the idea of !!hooks copying hooks from $wgParser, this is
unnecessary now that all extensions use ParserFirstCallInit. Resurrect
an old interpretation of the feature which was accidentally broken: if
a named hook does not exist, skip all tests in the file.
* Got rid of the "subtest" idea for tidy variants, instead use a
human-readable description that appears in the output.
* When all tests in a file are filtered or skipped, don't create the
articles in them. This greatly speeds up execution time when --regex
matches a small number of tests. It may possibly break extensions, but
they would have been randomly broken anyway since there is no
guarantee of test file execution order.
* Remove integrated testing of OutputPage::addCategoryLinks() category
link formatting, life is complicated enough already. It can go in
OutputPageTest if that's a thing we really need.
Result recording and display:
* Make TestRecorder into a generic plugin interface for progress output
etc., which needs to be abstracted for PHPUnit integration.
* Introduce MultiTestRecorder for recorder chaining, instead of using
a long inheritance chain. All test recorders now directly inherit from
TestRecorder.
* Move all console-related code to the new ParserTestPrinter.
* Introduce PhpunitTestRecorder, which is the recorder for the PHPUnit
frontend. Most events are ignored since they are never emitted in the
PHPUnit frontend, which does not call runTests().
* Put more information into ParserTestResult and use it more often.
Setup and teardown:
* Introduce a new API for setup/teardown where setup functions return a
ScopedCallback object which automatically performs the corresponding
teardown when it goes out of scope.
* Rename setUp() to staticSetup(), rewrite. There was a lot of cruft in
here which was simply copied from Setup.php without review, and had
nothing to do with parser tests.
* Rename setupGlobals() to perTestSetup(), mostly rewrite. For
performance, give staticSetup() precedence in cases where they were
both setting up the same thing.
* In support of merged setup code, allow Hooks::clear() to be called
from parserTests.php.
* Remove wgFileExtensions -- it is only used by UploadBase which we
don't call.
* Remove wgUseImageResize -- superseded by MockMediaHandlerFactory which
I imported from NewParserTest.
* Import MockFileBackend from NewParserTest. But instead of
customising the configuration globals, I injected services.
* Remove thumbnail deletion from upload teardown. This makes glob
handling as in the old parserTests.php unnecessary.
* Remove math file from upload teardown, math is actually an extension
now! Also, the relevant parser tests were removed from the Math
extension two years ago in favour of unit tests.
* Make addArticle() private, and introduce addArticles() instead, which
allows setup/teardown to be done once for each batch of articles
instead of every time.
* Remove $wgNamespaceAliases and $wgNamespaceProtection setup. These were
copied in from Setup.php in 2010, and are redundant since we do
actually run Setup.php.
* Use NullLockManager, don't set up a temporary directory just for
this alone.
Fuzz tests:
* Use the new TestSetup class.
* Updated for ParserTestRunner interface change.
* Remove some obsolete references to fuzz tests from the two frontends
where they used to reside.
Bug: T41473
Change-Id: Ia8e17008cb9d9b62ce5645e15a41a3b402f4026a
2016-09-08 01:25:22 +00:00
|
|
|
* @return MediaWikiServices
|
2016-05-01 19:29:11 +00:00
|
|
|
*/
|
|
|
|
|
public static function prepareServices( Config $bootstrapConfig ) {
|
Refactor parser tests
Merge the PHPUnit parser test runner with the old parserTests.inc,
taking the good bits of both. Reviewed, pared down and documented the
setup code. parserTests.php is now a frontend to a fully featured
parser test system, with lots of developer options, whereas PHPUnit
provides a simpler interface with increased isolation between test
cases.
Performance of both frontends is much improved, perhaps 2x faster for
parserTests.php and 10x faster for PHPUnit.
General:
* Split out the pre-Setup.php global variable configuration from
phpunit.php into a new class called TestSetup, also called it from
parserTests.php.
* Factored out the setup of TestsAutoLoader into a static method in
Maintenance.
* In Setup.php improved "caches" debug output.
PHPUnit frontend:
* Delete the entire contents of NewParserTest and replace it with a
small wrapper around ParserTestRunner. It doesn't inherit from
MediaWikiTestCase anymore since integrating the setup code was an
unnecessary complication.
* Rename MediaWikiParserTest to ParserTestTopLevelSuite and made it an
instantiable TestSuite class instead of just a static method. Got rid
of the eval(), just construct TestCase objects directly with a
specified name, it works just as well.
* Introduce ParserTestFileSuite for per-file setup.
* Remove parser-related options from phpunit.php, since we don't
support them anymore. Note that --filter now works just as well as
--regex used to.
* Add CoreParserTestSuite, equivalent to ExtensionsParserTestSuite,
for clarity.
* Make it possible to call MediaWikiTestCase::setupTestDB() more than
once, as is implied by the documentation.
parserTests.php frontend:
* Made parserTests.php into a Maintenance subclass, moved CLI-specific
code to it.
* Renamed ParserTest to ParserTestRunner, this is now the generic
backend.
* Add --upload-dir option which sets up an FSFileBackend, similar
to the old default behaviour
Test file reading and interpretation:
* Rename TestFileIterator to TestFileReader, and make it read and buffer
an entire file, instead of iterating.
* The previous code had an associative array representation of test
specifications. Used this form more widely to pass around test data.
* Remove the idea of !!hooks copying hooks from $wgParser, this is
unnecessary now that all extensions use ParserFirstCallInit. Resurrect
an old interpretation of the feature which was accidentally broken: if
a named hook does not exist, skip all tests in the file.
* Got rid of the "subtest" idea for tidy variants, instead use a
human-readable description that appears in the output.
* When all tests in a file are filtered or skipped, don't create the
articles in them. This greatly speeds up execution time when --regex
matches a small number of tests. It may possibly break extensions, but
they would have been randomly broken anyway since there is no
guarantee of test file execution order.
* Remove integrated testing of OutputPage::addCategoryLinks() category
link formatting, life is complicated enough already. It can go in
OutputPageTest if that's a thing we really need.
Result recording and display:
* Make TestRecorder into a generic plugin interface for progress output
etc., which needs to be abstracted for PHPUnit integration.
* Introduce MultiTestRecorder for recorder chaining, instead of using
a long inheritance chain. All test recorders now directly inherit from
TestRecorder.
* Move all console-related code to the new ParserTestPrinter.
* Introduce PhpunitTestRecorder, which is the recorder for the PHPUnit
frontend. Most events are ignored since they are never emitted in the
PHPUnit frontend, which does not call runTests().
* Put more information into ParserTestResult and use it more often.
Setup and teardown:
* Introduce a new API for setup/teardown where setup functions return a
ScopedCallback object which automatically performs the corresponding
teardown when it goes out of scope.
* Rename setUp() to staticSetup(), rewrite. There was a lot of cruft in
here which was simply copied from Setup.php without review, and had
nothing to do with parser tests.
* Rename setupGlobals() to perTestSetup(), mostly rewrite. For
performance, give staticSetup() precedence in cases where they were
both setting up the same thing.
* In support of merged setup code, allow Hooks::clear() to be called
from parserTests.php.
* Remove wgFileExtensions -- it is only used by UploadBase which we
don't call.
* Remove wgUseImageResize -- superseded by MockMediaHandlerFactory which
I imported from NewParserTest.
* Import MockFileBackend from NewParserTest. But instead of
customising the configuration globals, I injected services.
* Remove thumbnail deletion from upload teardown. This makes glob
handling as in the old parserTests.php unnecessary.
* Remove math file from upload teardown, math is actually an extension
now! Also, the relevant parser tests were removed from the Math
extension two years ago in favour of unit tests.
* Make addArticle() private, and introduce addArticles() instead, which
allows setup/teardown to be done once for each batch of articles
instead of every time.
* Remove $wgNamespaceAliases and $wgNamespaceProtection setup. These were
copied in from Setup.php in 2010, and are redundant since we do
actually run Setup.php.
* Use NullLockManager, don't set up a temporary directory just for
this alone.
Fuzz tests:
* Use the new TestSetup class.
* Updated for ParserTestRunner interface change.
* Remove some obsolete references to fuzz tests from the two frontends
where they used to reside.
Bug: T41473
Change-Id: Ia8e17008cb9d9b62ce5645e15a41a3b402f4026a
2016-09-08 01:25:22 +00:00
|
|
|
static $services = null;
|
2016-05-01 19:29:11 +00:00
|
|
|
|
Refactor parser tests
Merge the PHPUnit parser test runner with the old parserTests.inc,
taking the good bits of both. Reviewed, pared down and documented the
setup code. parserTests.php is now a frontend to a fully featured
parser test system, with lots of developer options, whereas PHPUnit
provides a simpler interface with increased isolation between test
cases.
Performance of both frontends is much improved, perhaps 2x faster for
parserTests.php and 10x faster for PHPUnit.
General:
* Split out the pre-Setup.php global variable configuration from
phpunit.php into a new class called TestSetup, also called it from
parserTests.php.
* Factored out the setup of TestsAutoLoader into a static method in
Maintenance.
* In Setup.php improved "caches" debug output.
PHPUnit frontend:
* Delete the entire contents of NewParserTest and replace it with a
small wrapper around ParserTestRunner. It doesn't inherit from
MediaWikiTestCase anymore since integrating the setup code was an
unnecessary complication.
* Rename MediaWikiParserTest to ParserTestTopLevelSuite and made it an
instantiable TestSuite class instead of just a static method. Got rid
of the eval(), just construct TestCase objects directly with a
specified name, it works just as well.
* Introduce ParserTestFileSuite for per-file setup.
* Remove parser-related options from phpunit.php, since we don't
support them anymore. Note that --filter now works just as well as
--regex used to.
* Add CoreParserTestSuite, equivalent to ExtensionsParserTestSuite,
for clarity.
* Make it possible to call MediaWikiTestCase::setupTestDB() more than
once, as is implied by the documentation.
parserTests.php frontend:
* Made parserTests.php into a Maintenance subclass, moved CLI-specific
code to it.
* Renamed ParserTest to ParserTestRunner, this is now the generic
backend.
* Add --upload-dir option which sets up an FSFileBackend, similar
to the old default behaviour
Test file reading and interpretation:
* Rename TestFileIterator to TestFileReader, and make it read and buffer
an entire file, instead of iterating.
* The previous code had an associative array representation of test
specifications. Used this form more widely to pass around test data.
* Remove the idea of !!hooks copying hooks from $wgParser, this is
unnecessary now that all extensions use ParserFirstCallInit. Resurrect
an old interpretation of the feature which was accidentally broken: if
a named hook does not exist, skip all tests in the file.
* Got rid of the "subtest" idea for tidy variants, instead use a
human-readable description that appears in the output.
* When all tests in a file are filtered or skipped, don't create the
articles in them. This greatly speeds up execution time when --regex
matches a small number of tests. It may possibly break extensions, but
they would have been randomly broken anyway since there is no
guarantee of test file execution order.
* Remove integrated testing of OutputPage::addCategoryLinks() category
link formatting, life is complicated enough already. It can go in
OutputPageTest if that's a thing we really need.
Result recording and display:
* Make TestRecorder into a generic plugin interface for progress output
etc., which needs to be abstracted for PHPUnit integration.
* Introduce MultiTestRecorder for recorder chaining, instead of using
a long inheritance chain. All test recorders now directly inherit from
TestRecorder.
* Move all console-related code to the new ParserTestPrinter.
* Introduce PhpunitTestRecorder, which is the recorder for the PHPUnit
frontend. Most events are ignored since they are never emitted in the
PHPUnit frontend, which does not call runTests().
* Put more information into ParserTestResult and use it more often.
Setup and teardown:
* Introduce a new API for setup/teardown where setup functions return a
ScopedCallback object which automatically performs the corresponding
teardown when it goes out of scope.
* Rename setUp() to staticSetup(), rewrite. There was a lot of cruft in
here which was simply copied from Setup.php without review, and had
nothing to do with parser tests.
* Rename setupGlobals() to perTestSetup(), mostly rewrite. For
performance, give staticSetup() precedence in cases where they were
both setting up the same thing.
* In support of merged setup code, allow Hooks::clear() to be called
from parserTests.php.
* Remove wgFileExtensions -- it is only used by UploadBase which we
don't call.
* Remove wgUseImageResize -- superseded by MockMediaHandlerFactory which
I imported from NewParserTest.
* Import MockFileBackend from NewParserTest. But instead of
customising the configuration globals, I injected services.
* Remove thumbnail deletion from upload teardown. This makes glob
handling as in the old parserTests.php unnecessary.
* Remove math file from upload teardown, math is actually an extension
now! Also, the relevant parser tests were removed from the Math
extension two years ago in favour of unit tests.
* Make addArticle() private, and introduce addArticles() instead, which
allows setup/teardown to be done once for each batch of articles
instead of every time.
* Remove $wgNamespaceAliases and $wgNamespaceProtection setup. These were
copied in from Setup.php in 2010, and are redundant since we do
actually run Setup.php.
* Use NullLockManager, don't set up a temporary directory just for
this alone.
Fuzz tests:
* Use the new TestSetup class.
* Updated for ParserTestRunner interface change.
* Remove some obsolete references to fuzz tests from the two frontends
where they used to reside.
Bug: T41473
Change-Id: Ia8e17008cb9d9b62ce5645e15a41a3b402f4026a
2016-09-08 01:25:22 +00:00
|
|
|
if ( !$services ) {
|
|
|
|
|
$services = self::resetGlobalServices( $bootstrapConfig );
|
2016-05-01 19:29:11 +00:00
|
|
|
}
|
Refactor parser tests
Merge the PHPUnit parser test runner with the old parserTests.inc,
taking the good bits of both. Reviewed, pared down and documented the
setup code. parserTests.php is now a frontend to a fully featured
parser test system, with lots of developer options, whereas PHPUnit
provides a simpler interface with increased isolation between test
cases.
Performance of both frontends is much improved, perhaps 2x faster for
parserTests.php and 10x faster for PHPUnit.
General:
* Split out the pre-Setup.php global variable configuration from
phpunit.php into a new class called TestSetup, also called it from
parserTests.php.
* Factored out the setup of TestsAutoLoader into a static method in
Maintenance.
* In Setup.php improved "caches" debug output.
PHPUnit frontend:
* Delete the entire contents of NewParserTest and replace it with a
small wrapper around ParserTestRunner. It doesn't inherit from
MediaWikiTestCase anymore since integrating the setup code was an
unnecessary complication.
* Rename MediaWikiParserTest to ParserTestTopLevelSuite and made it an
instantiable TestSuite class instead of just a static method. Got rid
of the eval(), just construct TestCase objects directly with a
specified name, it works just as well.
* Introduce ParserTestFileSuite for per-file setup.
* Remove parser-related options from phpunit.php, since we don't
support them anymore. Note that --filter now works just as well as
--regex used to.
* Add CoreParserTestSuite, equivalent to ExtensionsParserTestSuite,
for clarity.
* Make it possible to call MediaWikiTestCase::setupTestDB() more than
once, as is implied by the documentation.
parserTests.php frontend:
* Made parserTests.php into a Maintenance subclass, moved CLI-specific
code to it.
* Renamed ParserTest to ParserTestRunner, this is now the generic
backend.
* Add --upload-dir option which sets up an FSFileBackend, similar
to the old default behaviour
Test file reading and interpretation:
* Rename TestFileIterator to TestFileReader, and make it read and buffer
an entire file, instead of iterating.
* The previous code had an associative array representation of test
specifications. Used this form more widely to pass around test data.
* Remove the idea of !!hooks copying hooks from $wgParser, this is
unnecessary now that all extensions use ParserFirstCallInit. Resurrect
an old interpretation of the feature which was accidentally broken: if
a named hook does not exist, skip all tests in the file.
* Got rid of the "subtest" idea for tidy variants, instead use a
human-readable description that appears in the output.
* When all tests in a file are filtered or skipped, don't create the
articles in them. This greatly speeds up execution time when --regex
matches a small number of tests. It may possibly break extensions, but
they would have been randomly broken anyway since there is no
guarantee of test file execution order.
* Remove integrated testing of OutputPage::addCategoryLinks() category
link formatting, life is complicated enough already. It can go in
OutputPageTest if that's a thing we really need.
Result recording and display:
* Make TestRecorder into a generic plugin interface for progress output
etc., which needs to be abstracted for PHPUnit integration.
* Introduce MultiTestRecorder for recorder chaining, instead of using
a long inheritance chain. All test recorders now directly inherit from
TestRecorder.
* Move all console-related code to the new ParserTestPrinter.
* Introduce PhpunitTestRecorder, which is the recorder for the PHPUnit
frontend. Most events are ignored since they are never emitted in the
PHPUnit frontend, which does not call runTests().
* Put more information into ParserTestResult and use it more often.
Setup and teardown:
* Introduce a new API for setup/teardown where setup functions return a
ScopedCallback object which automatically performs the corresponding
teardown when it goes out of scope.
* Rename setUp() to staticSetup(), rewrite. There was a lot of cruft in
here which was simply copied from Setup.php without review, and had
nothing to do with parser tests.
* Rename setupGlobals() to perTestSetup(), mostly rewrite. For
performance, give staticSetup() precedence in cases where they were
both setting up the same thing.
* In support of merged setup code, allow Hooks::clear() to be called
from parserTests.php.
* Remove wgFileExtensions -- it is only used by UploadBase which we
don't call.
* Remove wgUseImageResize -- superseded by MockMediaHandlerFactory which
I imported from NewParserTest.
* Import MockFileBackend from NewParserTest. But instead of
customising the configuration globals, I injected services.
* Remove thumbnail deletion from upload teardown. This makes glob
handling as in the old parserTests.php unnecessary.
* Remove math file from upload teardown, math is actually an extension
now! Also, the relevant parser tests were removed from the Math
extension two years ago in favour of unit tests.
* Make addArticle() private, and introduce addArticles() instead, which
allows setup/teardown to be done once for each batch of articles
instead of every time.
* Remove $wgNamespaceAliases and $wgNamespaceProtection setup. These were
copied in from Setup.php in 2010, and are redundant since we do
actually run Setup.php.
* Use NullLockManager, don't set up a temporary directory just for
this alone.
Fuzz tests:
* Use the new TestSetup class.
* Updated for ParserTestRunner interface change.
* Remove some obsolete references to fuzz tests from the two frontends
where they used to reside.
Bug: T41473
Change-Id: Ia8e17008cb9d9b62ce5645e15a41a3b402f4026a
2016-09-08 01:25:22 +00:00
|
|
|
return $services;
|
2016-05-01 19:29:11 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
|
|
/**
|
|
|
|
|
* Reset global services, and install testing environment.
|
|
|
|
|
* This is the testing equivalent of MediaWikiServices::resetGlobalInstance().
|
|
|
|
|
* This should only be used to set up the testing environment, not when
|
Refactor parser tests
Merge the PHPUnit parser test runner with the old parserTests.inc,
taking the good bits of both. Reviewed, pared down and documented the
setup code. parserTests.php is now a frontend to a fully featured
parser test system, with lots of developer options, whereas PHPUnit
provides a simpler interface with increased isolation between test
cases.
Performance of both frontends is much improved, perhaps 2x faster for
parserTests.php and 10x faster for PHPUnit.
General:
* Split out the pre-Setup.php global variable configuration from
phpunit.php into a new class called TestSetup, also called it from
parserTests.php.
* Factored out the setup of TestsAutoLoader into a static method in
Maintenance.
* In Setup.php improved "caches" debug output.
PHPUnit frontend:
* Delete the entire contents of NewParserTest and replace it with a
small wrapper around ParserTestRunner. It doesn't inherit from
MediaWikiTestCase anymore since integrating the setup code was an
unnecessary complication.
* Rename MediaWikiParserTest to ParserTestTopLevelSuite and made it an
instantiable TestSuite class instead of just a static method. Got rid
of the eval(), just construct TestCase objects directly with a
specified name, it works just as well.
* Introduce ParserTestFileSuite for per-file setup.
* Remove parser-related options from phpunit.php, since we don't
support them anymore. Note that --filter now works just as well as
--regex used to.
* Add CoreParserTestSuite, equivalent to ExtensionsParserTestSuite,
for clarity.
* Make it possible to call MediaWikiTestCase::setupTestDB() more than
once, as is implied by the documentation.
parserTests.php frontend:
* Made parserTests.php into a Maintenance subclass, moved CLI-specific
code to it.
* Renamed ParserTest to ParserTestRunner, this is now the generic
backend.
* Add --upload-dir option which sets up an FSFileBackend, similar
to the old default behaviour
Test file reading and interpretation:
* Rename TestFileIterator to TestFileReader, and make it read and buffer
an entire file, instead of iterating.
* The previous code had an associative array representation of test
specifications. Used this form more widely to pass around test data.
* Remove the idea of !!hooks copying hooks from $wgParser, this is
unnecessary now that all extensions use ParserFirstCallInit. Resurrect
an old interpretation of the feature which was accidentally broken: if
a named hook does not exist, skip all tests in the file.
* Got rid of the "subtest" idea for tidy variants, instead use a
human-readable description that appears in the output.
* When all tests in a file are filtered or skipped, don't create the
articles in them. This greatly speeds up execution time when --regex
matches a small number of tests. It may possibly break extensions, but
they would have been randomly broken anyway since there is no
guarantee of test file execution order.
* Remove integrated testing of OutputPage::addCategoryLinks() category
link formatting, life is complicated enough already. It can go in
OutputPageTest if that's a thing we really need.
Result recording and display:
* Make TestRecorder into a generic plugin interface for progress output
etc., which needs to be abstracted for PHPUnit integration.
* Introduce MultiTestRecorder for recorder chaining, instead of using
a long inheritance chain. All test recorders now directly inherit from
TestRecorder.
* Move all console-related code to the new ParserTestPrinter.
* Introduce PhpunitTestRecorder, which is the recorder for the PHPUnit
frontend. Most events are ignored since they are never emitted in the
PHPUnit frontend, which does not call runTests().
* Put more information into ParserTestResult and use it more often.
Setup and teardown:
* Introduce a new API for setup/teardown where setup functions return a
ScopedCallback object which automatically performs the corresponding
teardown when it goes out of scope.
* Rename setUp() to staticSetup(), rewrite. There was a lot of cruft in
here which was simply copied from Setup.php without review, and had
nothing to do with parser tests.
* Rename setupGlobals() to perTestSetup(), mostly rewrite. For
performance, give staticSetup() precedence in cases where they were
both setting up the same thing.
* In support of merged setup code, allow Hooks::clear() to be called
from parserTests.php.
* Remove wgFileExtensions -- it is only used by UploadBase which we
don't call.
* Remove wgUseImageResize -- superseded by MockMediaHandlerFactory which
I imported from NewParserTest.
* Import MockFileBackend from NewParserTest. But instead of
customising the configuration globals, I injected services.
* Remove thumbnail deletion from upload teardown. This makes glob
handling as in the old parserTests.php unnecessary.
* Remove math file from upload teardown, math is actually an extension
now! Also, the relevant parser tests were removed from the Math
extension two years ago in favour of unit tests.
* Make addArticle() private, and introduce addArticles() instead, which
allows setup/teardown to be done once for each batch of articles
instead of every time.
* Remove $wgNamespaceAliases and $wgNamespaceProtection setup. These were
copied in from Setup.php in 2010, and are redundant since we do
actually run Setup.php.
* Use NullLockManager, don't set up a temporary directory just for
this alone.
Fuzz tests:
* Use the new TestSetup class.
* Updated for ParserTestRunner interface change.
* Remove some obsolete references to fuzz tests from the two frontends
where they used to reside.
Bug: T41473
Change-Id: Ia8e17008cb9d9b62ce5645e15a41a3b402f4026a
2016-09-08 01:25:22 +00:00
|
|
|
* running unit tests. Use MediaWikiTestCase::overrideMwServices() for that.
|
2016-05-01 19:29:11 +00:00
|
|
|
*
|
|
|
|
|
* @see MediaWikiServices::resetGlobalInstance()
|
|
|
|
|
* @see prepareServices()
|
Refactor parser tests
Merge the PHPUnit parser test runner with the old parserTests.inc,
taking the good bits of both. Reviewed, pared down and documented the
setup code. parserTests.php is now a frontend to a fully featured
parser test system, with lots of developer options, whereas PHPUnit
provides a simpler interface with increased isolation between test
cases.
Performance of both frontends is much improved, perhaps 2x faster for
parserTests.php and 10x faster for PHPUnit.
General:
* Split out the pre-Setup.php global variable configuration from
phpunit.php into a new class called TestSetup, also called it from
parserTests.php.
* Factored out the setup of TestsAutoLoader into a static method in
Maintenance.
* In Setup.php improved "caches" debug output.
PHPUnit frontend:
* Delete the entire contents of NewParserTest and replace it with a
small wrapper around ParserTestRunner. It doesn't inherit from
MediaWikiTestCase anymore since integrating the setup code was an
unnecessary complication.
* Rename MediaWikiParserTest to ParserTestTopLevelSuite and made it an
instantiable TestSuite class instead of just a static method. Got rid
of the eval(), just construct TestCase objects directly with a
specified name, it works just as well.
* Introduce ParserTestFileSuite for per-file setup.
* Remove parser-related options from phpunit.php, since we don't
support them anymore. Note that --filter now works just as well as
--regex used to.
* Add CoreParserTestSuite, equivalent to ExtensionsParserTestSuite,
for clarity.
* Make it possible to call MediaWikiTestCase::setupTestDB() more than
once, as is implied by the documentation.
parserTests.php frontend:
* Made parserTests.php into a Maintenance subclass, moved CLI-specific
code to it.
* Renamed ParserTest to ParserTestRunner, this is now the generic
backend.
* Add --upload-dir option which sets up an FSFileBackend, similar
to the old default behaviour
Test file reading and interpretation:
* Rename TestFileIterator to TestFileReader, and make it read and buffer
an entire file, instead of iterating.
* The previous code had an associative array representation of test
specifications. Used this form more widely to pass around test data.
* Remove the idea of !!hooks copying hooks from $wgParser, this is
unnecessary now that all extensions use ParserFirstCallInit. Resurrect
an old interpretation of the feature which was accidentally broken: if
a named hook does not exist, skip all tests in the file.
* Got rid of the "subtest" idea for tidy variants, instead use a
human-readable description that appears in the output.
* When all tests in a file are filtered or skipped, don't create the
articles in them. This greatly speeds up execution time when --regex
matches a small number of tests. It may possibly break extensions, but
they would have been randomly broken anyway since there is no
guarantee of test file execution order.
* Remove integrated testing of OutputPage::addCategoryLinks() category
link formatting, life is complicated enough already. It can go in
OutputPageTest if that's a thing we really need.
Result recording and display:
* Make TestRecorder into a generic plugin interface for progress output
etc., which needs to be abstracted for PHPUnit integration.
* Introduce MultiTestRecorder for recorder chaining, instead of using
a long inheritance chain. All test recorders now directly inherit from
TestRecorder.
* Move all console-related code to the new ParserTestPrinter.
* Introduce PhpunitTestRecorder, which is the recorder for the PHPUnit
frontend. Most events are ignored since they are never emitted in the
PHPUnit frontend, which does not call runTests().
* Put more information into ParserTestResult and use it more often.
Setup and teardown:
* Introduce a new API for setup/teardown where setup functions return a
ScopedCallback object which automatically performs the corresponding
teardown when it goes out of scope.
* Rename setUp() to staticSetup(), rewrite. There was a lot of cruft in
here which was simply copied from Setup.php without review, and had
nothing to do with parser tests.
* Rename setupGlobals() to perTestSetup(), mostly rewrite. For
performance, give staticSetup() precedence in cases where they were
both setting up the same thing.
* In support of merged setup code, allow Hooks::clear() to be called
from parserTests.php.
* Remove wgFileExtensions -- it is only used by UploadBase which we
don't call.
* Remove wgUseImageResize -- superseded by MockMediaHandlerFactory which
I imported from NewParserTest.
* Import MockFileBackend from NewParserTest. But instead of
customising the configuration globals, I injected services.
* Remove thumbnail deletion from upload teardown. This makes glob
handling as in the old parserTests.php unnecessary.
* Remove math file from upload teardown, math is actually an extension
now! Also, the relevant parser tests were removed from the Math
extension two years ago in favour of unit tests.
* Make addArticle() private, and introduce addArticles() instead, which
allows setup/teardown to be done once for each batch of articles
instead of every time.
* Remove $wgNamespaceAliases and $wgNamespaceProtection setup. These were
copied in from Setup.php in 2010, and are redundant since we do
actually run Setup.php.
* Use NullLockManager, don't set up a temporary directory just for
this alone.
Fuzz tests:
* Use the new TestSetup class.
* Updated for ParserTestRunner interface change.
* Remove some obsolete references to fuzz tests from the two frontends
where they used to reside.
Bug: T41473
Change-Id: Ia8e17008cb9d9b62ce5645e15a41a3b402f4026a
2016-09-08 01:25:22 +00:00
|
|
|
* @see MediaWikiTestCase::overrideMwServices()
|
2016-05-01 19:29:11 +00:00
|
|
|
*
|
|
|
|
|
* @param Config|null $bootstrapConfig The bootstrap config to use with the new
|
|
|
|
|
* MediaWikiServices.
|
|
|
|
|
*/
|
|
|
|
|
protected static function resetGlobalServices( Config $bootstrapConfig = null ) {
|
|
|
|
|
$oldServices = MediaWikiServices::getInstance();
|
|
|
|
|
$oldConfigFactory = $oldServices->getConfigFactory();
|
|
|
|
|
|
|
|
|
|
$testConfig = self::makeTestConfig( $bootstrapConfig );
|
|
|
|
|
|
|
|
|
|
MediaWikiServices::resetGlobalInstance( $testConfig );
|
|
|
|
|
|
Refactor parser tests
Merge the PHPUnit parser test runner with the old parserTests.inc,
taking the good bits of both. Reviewed, pared down and documented the
setup code. parserTests.php is now a frontend to a fully featured
parser test system, with lots of developer options, whereas PHPUnit
provides a simpler interface with increased isolation between test
cases.
Performance of both frontends is much improved, perhaps 2x faster for
parserTests.php and 10x faster for PHPUnit.
General:
* Split out the pre-Setup.php global variable configuration from
phpunit.php into a new class called TestSetup, also called it from
parserTests.php.
* Factored out the setup of TestsAutoLoader into a static method in
Maintenance.
* In Setup.php improved "caches" debug output.
PHPUnit frontend:
* Delete the entire contents of NewParserTest and replace it with a
small wrapper around ParserTestRunner. It doesn't inherit from
MediaWikiTestCase anymore since integrating the setup code was an
unnecessary complication.
* Rename MediaWikiParserTest to ParserTestTopLevelSuite and made it an
instantiable TestSuite class instead of just a static method. Got rid
of the eval(), just construct TestCase objects directly with a
specified name, it works just as well.
* Introduce ParserTestFileSuite for per-file setup.
* Remove parser-related options from phpunit.php, since we don't
support them anymore. Note that --filter now works just as well as
--regex used to.
* Add CoreParserTestSuite, equivalent to ExtensionsParserTestSuite,
for clarity.
* Make it possible to call MediaWikiTestCase::setupTestDB() more than
once, as is implied by the documentation.
parserTests.php frontend:
* Made parserTests.php into a Maintenance subclass, moved CLI-specific
code to it.
* Renamed ParserTest to ParserTestRunner, this is now the generic
backend.
* Add --upload-dir option which sets up an FSFileBackend, similar
to the old default behaviour
Test file reading and interpretation:
* Rename TestFileIterator to TestFileReader, and make it read and buffer
an entire file, instead of iterating.
* The previous code had an associative array representation of test
specifications. Used this form more widely to pass around test data.
* Remove the idea of !!hooks copying hooks from $wgParser, this is
unnecessary now that all extensions use ParserFirstCallInit. Resurrect
an old interpretation of the feature which was accidentally broken: if
a named hook does not exist, skip all tests in the file.
* Got rid of the "subtest" idea for tidy variants, instead use a
human-readable description that appears in the output.
* When all tests in a file are filtered or skipped, don't create the
articles in them. This greatly speeds up execution time when --regex
matches a small number of tests. It may possibly break extensions, but
they would have been randomly broken anyway since there is no
guarantee of test file execution order.
* Remove integrated testing of OutputPage::addCategoryLinks() category
link formatting, life is complicated enough already. It can go in
OutputPageTest if that's a thing we really need.
Result recording and display:
* Make TestRecorder into a generic plugin interface for progress output
etc., which needs to be abstracted for PHPUnit integration.
* Introduce MultiTestRecorder for recorder chaining, instead of using
a long inheritance chain. All test recorders now directly inherit from
TestRecorder.
* Move all console-related code to the new ParserTestPrinter.
* Introduce PhpunitTestRecorder, which is the recorder for the PHPUnit
frontend. Most events are ignored since they are never emitted in the
PHPUnit frontend, which does not call runTests().
* Put more information into ParserTestResult and use it more often.
Setup and teardown:
* Introduce a new API for setup/teardown where setup functions return a
ScopedCallback object which automatically performs the corresponding
teardown when it goes out of scope.
* Rename setUp() to staticSetup(), rewrite. There was a lot of cruft in
here which was simply copied from Setup.php without review, and had
nothing to do with parser tests.
* Rename setupGlobals() to perTestSetup(), mostly rewrite. For
performance, give staticSetup() precedence in cases where they were
both setting up the same thing.
* In support of merged setup code, allow Hooks::clear() to be called
from parserTests.php.
* Remove wgFileExtensions -- it is only used by UploadBase which we
don't call.
* Remove wgUseImageResize -- superseded by MockMediaHandlerFactory which
I imported from NewParserTest.
* Import MockFileBackend from NewParserTest. But instead of
customising the configuration globals, I injected services.
* Remove thumbnail deletion from upload teardown. This makes glob
handling as in the old parserTests.php unnecessary.
* Remove math file from upload teardown, math is actually an extension
now! Also, the relevant parser tests were removed from the Math
extension two years ago in favour of unit tests.
* Make addArticle() private, and introduce addArticles() instead, which
allows setup/teardown to be done once for each batch of articles
instead of every time.
* Remove $wgNamespaceAliases and $wgNamespaceProtection setup. These were
copied in from Setup.php in 2010, and are redundant since we do
actually run Setup.php.
* Use NullLockManager, don't set up a temporary directory just for
this alone.
Fuzz tests:
* Use the new TestSetup class.
* Updated for ParserTestRunner interface change.
* Remove some obsolete references to fuzz tests from the two frontends
where they used to reside.
Bug: T41473
Change-Id: Ia8e17008cb9d9b62ce5645e15a41a3b402f4026a
2016-09-08 01:25:22 +00:00
|
|
|
$serviceLocator = MediaWikiServices::getInstance();
|
2016-05-01 19:29:11 +00:00
|
|
|
self::installTestServices(
|
|
|
|
|
$oldConfigFactory,
|
Refactor parser tests
Merge the PHPUnit parser test runner with the old parserTests.inc,
taking the good bits of both. Reviewed, pared down and documented the
setup code. parserTests.php is now a frontend to a fully featured
parser test system, with lots of developer options, whereas PHPUnit
provides a simpler interface with increased isolation between test
cases.
Performance of both frontends is much improved, perhaps 2x faster for
parserTests.php and 10x faster for PHPUnit.
General:
* Split out the pre-Setup.php global variable configuration from
phpunit.php into a new class called TestSetup, also called it from
parserTests.php.
* Factored out the setup of TestsAutoLoader into a static method in
Maintenance.
* In Setup.php improved "caches" debug output.
PHPUnit frontend:
* Delete the entire contents of NewParserTest and replace it with a
small wrapper around ParserTestRunner. It doesn't inherit from
MediaWikiTestCase anymore since integrating the setup code was an
unnecessary complication.
* Rename MediaWikiParserTest to ParserTestTopLevelSuite and made it an
instantiable TestSuite class instead of just a static method. Got rid
of the eval(), just construct TestCase objects directly with a
specified name, it works just as well.
* Introduce ParserTestFileSuite for per-file setup.
* Remove parser-related options from phpunit.php, since we don't
support them anymore. Note that --filter now works just as well as
--regex used to.
* Add CoreParserTestSuite, equivalent to ExtensionsParserTestSuite,
for clarity.
* Make it possible to call MediaWikiTestCase::setupTestDB() more than
once, as is implied by the documentation.
parserTests.php frontend:
* Made parserTests.php into a Maintenance subclass, moved CLI-specific
code to it.
* Renamed ParserTest to ParserTestRunner, this is now the generic
backend.
* Add --upload-dir option which sets up an FSFileBackend, similar
to the old default behaviour
Test file reading and interpretation:
* Rename TestFileIterator to TestFileReader, and make it read and buffer
an entire file, instead of iterating.
* The previous code had an associative array representation of test
specifications. Used this form more widely to pass around test data.
* Remove the idea of !!hooks copying hooks from $wgParser, this is
unnecessary now that all extensions use ParserFirstCallInit. Resurrect
an old interpretation of the feature which was accidentally broken: if
a named hook does not exist, skip all tests in the file.
* Got rid of the "subtest" idea for tidy variants, instead use a
human-readable description that appears in the output.
* When all tests in a file are filtered or skipped, don't create the
articles in them. This greatly speeds up execution time when --regex
matches a small number of tests. It may possibly break extensions, but
they would have been randomly broken anyway since there is no
guarantee of test file execution order.
* Remove integrated testing of OutputPage::addCategoryLinks() category
link formatting, life is complicated enough already. It can go in
OutputPageTest if that's a thing we really need.
Result recording and display:
* Make TestRecorder into a generic plugin interface for progress output
etc., which needs to be abstracted for PHPUnit integration.
* Introduce MultiTestRecorder for recorder chaining, instead of using
a long inheritance chain. All test recorders now directly inherit from
TestRecorder.
* Move all console-related code to the new ParserTestPrinter.
* Introduce PhpunitTestRecorder, which is the recorder for the PHPUnit
frontend. Most events are ignored since they are never emitted in the
PHPUnit frontend, which does not call runTests().
* Put more information into ParserTestResult and use it more often.
Setup and teardown:
* Introduce a new API for setup/teardown where setup functions return a
ScopedCallback object which automatically performs the corresponding
teardown when it goes out of scope.
* Rename setUp() to staticSetup(), rewrite. There was a lot of cruft in
here which was simply copied from Setup.php without review, and had
nothing to do with parser tests.
* Rename setupGlobals() to perTestSetup(), mostly rewrite. For
performance, give staticSetup() precedence in cases where they were
both setting up the same thing.
* In support of merged setup code, allow Hooks::clear() to be called
from parserTests.php.
* Remove wgFileExtensions -- it is only used by UploadBase which we
don't call.
* Remove wgUseImageResize -- superseded by MockMediaHandlerFactory which
I imported from NewParserTest.
* Import MockFileBackend from NewParserTest. But instead of
customising the configuration globals, I injected services.
* Remove thumbnail deletion from upload teardown. This makes glob
handling as in the old parserTests.php unnecessary.
* Remove math file from upload teardown, math is actually an extension
now! Also, the relevant parser tests were removed from the Math
extension two years ago in favour of unit tests.
* Make addArticle() private, and introduce addArticles() instead, which
allows setup/teardown to be done once for each batch of articles
instead of every time.
* Remove $wgNamespaceAliases and $wgNamespaceProtection setup. These were
copied in from Setup.php in 2010, and are redundant since we do
actually run Setup.php.
* Use NullLockManager, don't set up a temporary directory just for
this alone.
Fuzz tests:
* Use the new TestSetup class.
* Updated for ParserTestRunner interface change.
* Remove some obsolete references to fuzz tests from the two frontends
where they used to reside.
Bug: T41473
Change-Id: Ia8e17008cb9d9b62ce5645e15a41a3b402f4026a
2016-09-08 01:25:22 +00:00
|
|
|
$serviceLocator
|
2016-05-01 19:29:11 +00:00
|
|
|
);
|
Refactor parser tests
Merge the PHPUnit parser test runner with the old parserTests.inc,
taking the good bits of both. Reviewed, pared down and documented the
setup code. parserTests.php is now a frontend to a fully featured
parser test system, with lots of developer options, whereas PHPUnit
provides a simpler interface with increased isolation between test
cases.
Performance of both frontends is much improved, perhaps 2x faster for
parserTests.php and 10x faster for PHPUnit.
General:
* Split out the pre-Setup.php global variable configuration from
phpunit.php into a new class called TestSetup, also called it from
parserTests.php.
* Factored out the setup of TestsAutoLoader into a static method in
Maintenance.
* In Setup.php improved "caches" debug output.
PHPUnit frontend:
* Delete the entire contents of NewParserTest and replace it with a
small wrapper around ParserTestRunner. It doesn't inherit from
MediaWikiTestCase anymore since integrating the setup code was an
unnecessary complication.
* Rename MediaWikiParserTest to ParserTestTopLevelSuite and made it an
instantiable TestSuite class instead of just a static method. Got rid
of the eval(), just construct TestCase objects directly with a
specified name, it works just as well.
* Introduce ParserTestFileSuite for per-file setup.
* Remove parser-related options from phpunit.php, since we don't
support them anymore. Note that --filter now works just as well as
--regex used to.
* Add CoreParserTestSuite, equivalent to ExtensionsParserTestSuite,
for clarity.
* Make it possible to call MediaWikiTestCase::setupTestDB() more than
once, as is implied by the documentation.
parserTests.php frontend:
* Made parserTests.php into a Maintenance subclass, moved CLI-specific
code to it.
* Renamed ParserTest to ParserTestRunner, this is now the generic
backend.
* Add --upload-dir option which sets up an FSFileBackend, similar
to the old default behaviour
Test file reading and interpretation:
* Rename TestFileIterator to TestFileReader, and make it read and buffer
an entire file, instead of iterating.
* The previous code had an associative array representation of test
specifications. Used this form more widely to pass around test data.
* Remove the idea of !!hooks copying hooks from $wgParser, this is
unnecessary now that all extensions use ParserFirstCallInit. Resurrect
an old interpretation of the feature which was accidentally broken: if
a named hook does not exist, skip all tests in the file.
* Got rid of the "subtest" idea for tidy variants, instead use a
human-readable description that appears in the output.
* When all tests in a file are filtered or skipped, don't create the
articles in them. This greatly speeds up execution time when --regex
matches a small number of tests. It may possibly break extensions, but
they would have been randomly broken anyway since there is no
guarantee of test file execution order.
* Remove integrated testing of OutputPage::addCategoryLinks() category
link formatting, life is complicated enough already. It can go in
OutputPageTest if that's a thing we really need.
Result recording and display:
* Make TestRecorder into a generic plugin interface for progress output
etc., which needs to be abstracted for PHPUnit integration.
* Introduce MultiTestRecorder for recorder chaining, instead of using
a long inheritance chain. All test recorders now directly inherit from
TestRecorder.
* Move all console-related code to the new ParserTestPrinter.
* Introduce PhpunitTestRecorder, which is the recorder for the PHPUnit
frontend. Most events are ignored since they are never emitted in the
PHPUnit frontend, which does not call runTests().
* Put more information into ParserTestResult and use it more often.
Setup and teardown:
* Introduce a new API for setup/teardown where setup functions return a
ScopedCallback object which automatically performs the corresponding
teardown when it goes out of scope.
* Rename setUp() to staticSetup(), rewrite. There was a lot of cruft in
here which was simply copied from Setup.php without review, and had
nothing to do with parser tests.
* Rename setupGlobals() to perTestSetup(), mostly rewrite. For
performance, give staticSetup() precedence in cases where they were
both setting up the same thing.
* In support of merged setup code, allow Hooks::clear() to be called
from parserTests.php.
* Remove wgFileExtensions -- it is only used by UploadBase which we
don't call.
* Remove wgUseImageResize -- superseded by MockMediaHandlerFactory which
I imported from NewParserTest.
* Import MockFileBackend from NewParserTest. But instead of
customising the configuration globals, I injected services.
* Remove thumbnail deletion from upload teardown. This makes glob
handling as in the old parserTests.php unnecessary.
* Remove math file from upload teardown, math is actually an extension
now! Also, the relevant parser tests were removed from the Math
extension two years ago in favour of unit tests.
* Make addArticle() private, and introduce addArticles() instead, which
allows setup/teardown to be done once for each batch of articles
instead of every time.
* Remove $wgNamespaceAliases and $wgNamespaceProtection setup. These were
copied in from Setup.php in 2010, and are redundant since we do
actually run Setup.php.
* Use NullLockManager, don't set up a temporary directory just for
this alone.
Fuzz tests:
* Use the new TestSetup class.
* Updated for ParserTestRunner interface change.
* Remove some obsolete references to fuzz tests from the two frontends
where they used to reside.
Bug: T41473
Change-Id: Ia8e17008cb9d9b62ce5645e15a41a3b402f4026a
2016-09-08 01:25:22 +00:00
|
|
|
return $serviceLocator;
|
2016-05-01 19:29:11 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
|
|
/**
|
|
|
|
|
* Create a config suitable for testing, based on a base config, default overrides,
|
|
|
|
|
* and custom overrides.
|
|
|
|
|
*
|
|
|
|
|
* @param Config|null $baseConfig
|
|
|
|
|
* @param Config|null $customOverrides
|
|
|
|
|
*
|
|
|
|
|
* @return Config
|
|
|
|
|
*/
|
|
|
|
|
private static function makeTestConfig(
|
|
|
|
|
Config $baseConfig = null,
|
|
|
|
|
Config $customOverrides = null
|
|
|
|
|
) {
|
|
|
|
|
$defaultOverrides = new HashConfig();
|
|
|
|
|
|
|
|
|
|
if ( !$baseConfig ) {
|
|
|
|
|
$baseConfig = MediaWikiServices::getInstance()->getBootstrapConfig();
|
|
|
|
|
}
|
|
|
|
|
|
2011-02-26 21:49:42 +00:00
|
|
|
/* Some functions require some kind of caching, and will end up using the db,
|
|
|
|
|
* which we can't allow, as that would open a new connection for mysql.
|
|
|
|
|
* Replace with a HashBag. They would not be going to persist anyway.
|
|
|
|
|
*/
|
2016-05-01 19:29:11 +00:00
|
|
|
$hashCache = [ 'class' => 'HashBagOStuff' ];
|
|
|
|
|
$objectCaches = [
|
|
|
|
|
CACHE_DB => $hashCache,
|
|
|
|
|
CACHE_ACCEL => $hashCache,
|
|
|
|
|
CACHE_MEMCACHED => $hashCache,
|
|
|
|
|
'apc' => $hashCache,
|
|
|
|
|
'xcache' => $hashCache,
|
|
|
|
|
'wincache' => $hashCache,
|
|
|
|
|
] + $baseConfig->get( 'ObjectCaches' );
|
|
|
|
|
|
|
|
|
|
$defaultOverrides->set( 'ObjectCaches', $objectCaches );
|
|
|
|
|
$defaultOverrides->set( 'MainCacheType', CACHE_NONE );
|
2016-09-12 00:23:54 +00:00
|
|
|
$defaultOverrides->set( 'JobTypeConf', [ 'default' => [ 'class' => 'JobQueueMemory' ] ] );
|
2016-05-01 19:29:11 +00:00
|
|
|
|
2016-05-12 10:40:41 +00:00
|
|
|
// Use a fast hash algorithm to hash passwords.
|
|
|
|
|
$defaultOverrides->set( 'PasswordDefault', 'A' );
|
|
|
|
|
|
2016-05-01 19:29:11 +00:00
|
|
|
$testConfig = $customOverrides
|
|
|
|
|
? new MultiConfig( [ $customOverrides, $defaultOverrides, $baseConfig ] )
|
|
|
|
|
: new MultiConfig( [ $defaultOverrides, $baseConfig ] );
|
|
|
|
|
|
|
|
|
|
return $testConfig;
|
|
|
|
|
}
|
2011-04-29 16:26:20 +00:00
|
|
|
|
2016-05-01 19:29:11 +00:00
|
|
|
/**
|
|
|
|
|
* @param ConfigFactory $oldConfigFactory
|
|
|
|
|
* @param MediaWikiServices $newServices
|
|
|
|
|
*
|
|
|
|
|
* @throws MWException
|
|
|
|
|
*/
|
|
|
|
|
private static function installTestServices(
|
|
|
|
|
ConfigFactory $oldConfigFactory,
|
|
|
|
|
MediaWikiServices $newServices
|
|
|
|
|
) {
|
|
|
|
|
// Use bootstrap config for all configuration.
|
|
|
|
|
// This allows config overrides via global variables to take effect.
|
|
|
|
|
$bootstrapConfig = $newServices->getBootstrapConfig();
|
|
|
|
|
$newServices->resetServiceForTesting( 'ConfigFactory' );
|
|
|
|
|
$newServices->redefineService(
|
|
|
|
|
'ConfigFactory',
|
|
|
|
|
self::makeTestConfigFactoryInstantiator(
|
|
|
|
|
$oldConfigFactory,
|
|
|
|
|
[ 'main' => $bootstrapConfig ]
|
|
|
|
|
)
|
|
|
|
|
);
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
/**
|
|
|
|
|
* @param ConfigFactory $oldFactory
|
|
|
|
|
* @param Config[] $configurations
|
|
|
|
|
*
|
|
|
|
|
* @return Closure
|
|
|
|
|
*/
|
|
|
|
|
private static function makeTestConfigFactoryInstantiator(
|
|
|
|
|
ConfigFactory $oldFactory,
|
|
|
|
|
array $configurations
|
|
|
|
|
) {
|
|
|
|
|
return function( MediaWikiServices $services ) use ( $oldFactory, $configurations ) {
|
|
|
|
|
$factory = new ConfigFactory();
|
|
|
|
|
|
|
|
|
|
// clone configurations from $oldFactory that are not overwritten by $configurations
|
|
|
|
|
$namesToClone = array_diff(
|
|
|
|
|
$oldFactory->getConfigNames(),
|
|
|
|
|
array_keys( $configurations )
|
|
|
|
|
);
|
|
|
|
|
|
|
|
|
|
foreach ( $namesToClone as $name ) {
|
|
|
|
|
$factory->register( $name, $oldFactory->makeConfig( $name ) );
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
foreach ( $configurations as $name => $config ) {
|
|
|
|
|
$factory->register( $name, $config );
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
return $factory;
|
|
|
|
|
};
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
/**
|
|
|
|
|
* Resets some well known services that typically have state that may interfere with unit tests.
|
|
|
|
|
* This is a lightweight alternative to resetGlobalServices().
|
|
|
|
|
*
|
|
|
|
|
* @note There is no guarantee that no references remain to stale service instances destroyed
|
|
|
|
|
* by a call to doLightweightServiceReset().
|
|
|
|
|
*
|
|
|
|
|
* @throws MWException if called outside of PHPUnit tests.
|
|
|
|
|
*
|
|
|
|
|
* @see resetGlobalServices()
|
|
|
|
|
*/
|
|
|
|
|
private function doLightweightServiceReset() {
|
|
|
|
|
global $wgRequest;
|
|
|
|
|
|
|
|
|
|
JobQueueGroup::destroySingletons();
|
|
|
|
|
ObjectCache::clear();
|
|
|
|
|
FileBackendGroup::destroySingleton();
|
|
|
|
|
|
|
|
|
|
// TODO: move global state into MediaWikiServices
|
|
|
|
|
RequestContext::resetMain();
|
|
|
|
|
if ( session_id() !== '' ) {
|
|
|
|
|
session_write_close();
|
|
|
|
|
session_id( '' );
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
$wgRequest = new FauxRequest();
|
|
|
|
|
MediaWiki\Session\SessionManager::resetCache();
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
public function run( PHPUnit_Framework_TestResult $result = null ) {
|
|
|
|
|
// Reset all caches between tests.
|
|
|
|
|
$this->doLightweightServiceReset();
|
2015-09-24 12:23:15 +00:00
|
|
|
|
2012-11-22 18:34:32 +00:00
|
|
|
$needsResetDB = false;
|
|
|
|
|
|
2016-05-18 09:19:20 +00:00
|
|
|
if ( !self::$dbSetup || $this->needsDB() ) {
|
2012-11-13 16:48:15 +00:00
|
|
|
// set up a DB connection for this test to use
|
|
|
|
|
|
|
|
|
|
self::$useTemporaryTables = !$this->getCliArg( 'use-normal-tables' );
|
2013-02-14 11:22:13 +00:00
|
|
|
self::$reuseDB = $this->getCliArg( 'reuse-db' );
|
2011-06-02 19:32:45 +00:00
|
|
|
|
2010-12-31 20:42:39 +00:00
|
|
|
$this->db = wfGetDB( DB_MASTER );
|
2011-06-02 19:32:45 +00:00
|
|
|
|
2010-12-31 21:10:36 +00:00
|
|
|
$this->checkDbIsSupported();
|
2011-06-01 22:43:19 +00:00
|
|
|
|
2013-02-14 11:22:13 +00:00
|
|
|
if ( !self::$dbSetup ) {
|
2016-03-03 07:30:24 +00:00
|
|
|
$this->setupAllTestDBs();
|
2016-03-07 17:26:25 +00:00
|
|
|
$this->addCoreDBData();
|
2012-11-13 16:48:15 +00:00
|
|
|
|
|
|
|
|
if ( ( $this->db->getType() == 'oracle' || !self::$useTemporaryTables ) && self::$reuseDB ) {
|
2016-03-03 07:30:24 +00:00
|
|
|
$this->resetDB( $this->db, $this->tablesUsed );
|
2012-11-13 16:48:15 +00:00
|
|
|
}
|
2011-05-24 21:22:36 +00:00
|
|
|
}
|
2016-03-07 17:26:25 +00:00
|
|
|
|
|
|
|
|
// TODO: the DB setup should be done in setUpBeforeClass(), so the test DB
|
2016-03-03 07:30:24 +00:00
|
|
|
// is available in subclass's setUpBeforeClass() and setUp() methods.
|
2016-03-07 17:26:25 +00:00
|
|
|
// This would also remove the need for the HACK that is oncePerClass().
|
|
|
|
|
if ( $this->oncePerClass() ) {
|
|
|
|
|
$this->addDBDataOnce();
|
|
|
|
|
}
|
|
|
|
|
|
2010-12-29 15:52:07 +00:00
|
|
|
$this->addDBData();
|
2012-11-22 18:34:32 +00:00
|
|
|
$needsResetDB = true;
|
|
|
|
|
}
|
2011-05-28 21:19:24 +00:00
|
|
|
|
2012-11-22 18:34:32 +00:00
|
|
|
parent::run( $result );
|
|
|
|
|
|
2013-02-14 11:22:13 +00:00
|
|
|
if ( $needsResetDB ) {
|
2016-03-03 07:30:24 +00:00
|
|
|
$this->resetDB( $this->db, $this->tablesUsed );
|
2010-12-29 15:52:07 +00:00
|
|
|
}
|
|
|
|
|
}
|
2011-03-05 15:44:28 +00:00
|
|
|
|
2016-03-07 17:26:25 +00:00
|
|
|
/**
|
2016-03-24 08:44:09 +00:00
|
|
|
* @return bool
|
2016-03-07 17:26:25 +00:00
|
|
|
*/
|
|
|
|
|
private function oncePerClass() {
|
|
|
|
|
// Remember current test class in the database connection,
|
|
|
|
|
// so we know when we need to run addData.
|
|
|
|
|
|
|
|
|
|
$class = static::class;
|
|
|
|
|
|
|
|
|
|
$first = !isset( $this->db->_hasDataForTestClass )
|
|
|
|
|
|| $this->db->_hasDataForTestClass !== $class;
|
|
|
|
|
|
|
|
|
|
$this->db->_hasDataForTestClass = $class;
|
|
|
|
|
return $first;
|
|
|
|
|
}
|
|
|
|
|
|
2014-03-05 14:41:41 +00:00
|
|
|
/**
|
|
|
|
|
* @since 1.21
|
|
|
|
|
*
|
|
|
|
|
* @return bool
|
|
|
|
|
*/
|
|
|
|
|
public function usesTemporaryTables() {
|
2013-03-18 15:09:18 +00:00
|
|
|
return self::$useTemporaryTables;
|
|
|
|
|
}
|
|
|
|
|
|
2012-04-10 14:28:42 +00:00
|
|
|
/**
|
2014-03-05 14:41:41 +00:00
|
|
|
* Obtains a new temporary file name
|
2012-04-10 14:28:42 +00:00
|
|
|
*
|
|
|
|
|
* The obtained filename is enlisted to be removed upon tearDown
|
|
|
|
|
*
|
2014-03-05 14:41:41 +00:00
|
|
|
* @since 1.20
|
|
|
|
|
*
|
2014-04-17 18:43:42 +00:00
|
|
|
* @return string Absolute name of the temporary file
|
2012-04-10 14:28:42 +00:00
|
|
|
*/
|
|
|
|
|
protected function getNewTempFile() {
|
2014-03-05 14:41:41 +00:00
|
|
|
$fileName = tempnam( wfTempDir(), 'MW_PHPUnit_' . get_class( $this ) . '_' );
|
|
|
|
|
$this->tmpFiles[] = $fileName;
|
2013-04-26 12:00:22 +00:00
|
|
|
|
2014-03-05 14:41:41 +00:00
|
|
|
return $fileName;
|
2012-04-10 14:28:42 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
|
|
/**
|
|
|
|
|
* obtains a new temporary directory
|
|
|
|
|
*
|
|
|
|
|
* The obtained directory is enlisted to be removed (recursively with all its contained
|
|
|
|
|
* files) upon tearDown.
|
|
|
|
|
*
|
2014-03-05 14:41:41 +00:00
|
|
|
* @since 1.20
|
|
|
|
|
*
|
|
|
|
|
* @return string Absolute name of the temporary directory
|
2012-04-10 14:28:42 +00:00
|
|
|
*/
|
|
|
|
|
protected function getNewTempDirectory() {
|
|
|
|
|
// Starting of with a temporary /file/.
|
2014-03-05 14:41:41 +00:00
|
|
|
$fileName = $this->getNewTempFile();
|
2012-04-10 14:28:42 +00:00
|
|
|
|
|
|
|
|
// Converting the temporary /file/ to a /directory/
|
|
|
|
|
// The following is not atomic, but at least we now have a single place,
|
|
|
|
|
// where temporary directory creation is bundled and can be improved
|
2014-03-05 14:41:41 +00:00
|
|
|
unlink( $fileName );
|
|
|
|
|
$this->assertTrue( wfMkdirParents( $fileName ) );
|
2013-04-26 12:00:22 +00:00
|
|
|
|
2014-03-05 14:41:41 +00:00
|
|
|
return $fileName;
|
2012-04-10 14:28:42 +00:00
|
|
|
}
|
|
|
|
|
|
2012-10-08 10:59:55 +00:00
|
|
|
protected function setUp() {
|
|
|
|
|
parent::setUp();
|
2014-09-14 19:07:14 +00:00
|
|
|
$this->called['setUp'] = true;
|
2012-10-08 10:59:55 +00:00
|
|
|
|
2013-07-17 16:42:24 +00:00
|
|
|
$this->phpErrorLevel = intval( ini_get( 'error_reporting' ) );
|
|
|
|
|
|
2012-10-08 10:59:55 +00:00
|
|
|
// Cleaning up temporary files
|
2014-03-05 14:41:41 +00:00
|
|
|
foreach ( $this->tmpFiles as $fileName ) {
|
|
|
|
|
if ( is_file( $fileName ) || ( is_link( $fileName ) ) ) {
|
|
|
|
|
unlink( $fileName );
|
|
|
|
|
} elseif ( is_dir( $fileName ) ) {
|
|
|
|
|
wfRecursiveRemoveDir( $fileName );
|
2012-10-08 10:59:55 +00:00
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
if ( $this->needsDB() && $this->db ) {
|
2012-12-05 16:13:21 +00:00
|
|
|
// Clean up open transactions
|
2013-02-14 11:22:13 +00:00
|
|
|
while ( $this->db->trxLevel() > 0 ) {
|
2015-10-21 19:13:22 +00:00
|
|
|
$this->db->rollback( __METHOD__, 'flush' );
|
2012-10-08 10:59:55 +00:00
|
|
|
}
|
2016-09-02 16:57:40 +00:00
|
|
|
// Check for unsafe queries
|
|
|
|
|
if ( $this->db->getType() === 'mysql' ) {
|
|
|
|
|
$this->db->query( "SET sql_mode = 'STRICT_ALL_TABLES'" );
|
|
|
|
|
}
|
2012-10-08 10:59:55 +00:00
|
|
|
}
|
2012-11-22 18:34:32 +00:00
|
|
|
|
2014-11-03 21:40:49 +00:00
|
|
|
DeferredUpdates::clearPendingUpdates();
|
2016-03-24 22:50:44 +00:00
|
|
|
ObjectCache::getMainWANInstance()->clearProcessCache();
|
2014-11-03 21:40:49 +00:00
|
|
|
|
2016-09-01 16:43:01 +00:00
|
|
|
// XXX: reset maintenance triggers
|
|
|
|
|
// Hook into period lag checks which often happen in long-running scripts
|
|
|
|
|
$lbFactory = MediaWikiServices::getInstance()->getDBLoadBalancerFactory();
|
|
|
|
|
Maintenance::setLBFactoryTriggers( $lbFactory );
|
|
|
|
|
|
2015-08-21 16:01:10 +00:00
|
|
|
ob_start( 'MediaWikiTestCase::wfResetOutputBuffersBarrier' );
|
2012-10-08 10:59:55 +00:00
|
|
|
}
|
|
|
|
|
|
2015-02-11 01:42:33 +00:00
|
|
|
protected function addTmpFiles( $files ) {
|
|
|
|
|
$this->tmpFiles = array_merge( $this->tmpFiles, (array)$files );
|
|
|
|
|
}
|
2012-11-22 18:34:32 +00:00
|
|
|
|
2015-02-11 01:42:33 +00:00
|
|
|
protected function tearDown() {
|
2016-09-02 16:57:40 +00:00
|
|
|
global $wgRequest, $wgSQLMode;
|
2016-02-01 20:44:03 +00:00
|
|
|
|
2015-08-21 16:01:10 +00:00
|
|
|
$status = ob_get_status();
|
2015-09-26 11:26:35 +00:00
|
|
|
if ( isset( $status['name'] ) &&
|
|
|
|
|
$status['name'] === 'MediaWikiTestCase::wfResetOutputBuffersBarrier'
|
|
|
|
|
) {
|
2015-08-21 16:01:10 +00:00
|
|
|
ob_end_flush();
|
|
|
|
|
}
|
|
|
|
|
|
2014-09-14 19:07:14 +00:00
|
|
|
$this->called['tearDown'] = true;
|
2012-08-27 12:38:25 +00:00
|
|
|
// Cleaning up temporary files
|
2014-03-05 14:41:41 +00:00
|
|
|
foreach ( $this->tmpFiles as $fileName ) {
|
|
|
|
|
if ( is_file( $fileName ) || ( is_link( $fileName ) ) ) {
|
|
|
|
|
unlink( $fileName );
|
|
|
|
|
} elseif ( is_dir( $fileName ) ) {
|
|
|
|
|
wfRecursiveRemoveDir( $fileName );
|
2012-04-10 14:28:42 +00:00
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
|
2012-10-08 10:59:55 +00:00
|
|
|
if ( $this->needsDB() && $this->db ) {
|
2012-12-05 16:13:21 +00:00
|
|
|
// Clean up open transactions
|
2013-02-14 11:22:13 +00:00
|
|
|
while ( $this->db->trxLevel() > 0 ) {
|
2015-10-21 19:13:22 +00:00
|
|
|
$this->db->rollback( __METHOD__, 'flush' );
|
2012-08-27 12:38:25 +00:00
|
|
|
}
|
2016-09-02 16:57:40 +00:00
|
|
|
if ( $this->db->getType() === 'mysql' ) {
|
|
|
|
|
$this->db->query( "SET sql_mode = " . $this->db->addQuotes( $wgSQLMode ) );
|
|
|
|
|
}
|
2012-08-27 12:38:25 +00:00
|
|
|
}
|
|
|
|
|
|
2012-10-08 10:59:55 +00:00
|
|
|
// Restore mw globals
|
|
|
|
|
foreach ( $this->mwGlobals as $key => $value ) {
|
|
|
|
|
$GLOBALS[$key] = $value;
|
|
|
|
|
}
|
2016-02-17 09:09:32 +00:00
|
|
|
$this->mwGlobals = [];
|
2016-02-07 08:12:10 +00:00
|
|
|
$this->restoreLoggers();
|
2016-05-01 19:29:11 +00:00
|
|
|
|
|
|
|
|
if ( self::$serviceLocator && MediaWikiServices::getInstance() !== self::$serviceLocator ) {
|
|
|
|
|
MediaWikiServices::forceGlobalInstance( self::$serviceLocator );
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
// TODO: move global state into MediaWikiServices
|
2014-06-27 17:59:47 +00:00
|
|
|
RequestContext::resetMain();
|
2016-02-01 20:44:03 +00:00
|
|
|
if ( session_id() !== '' ) {
|
|
|
|
|
session_write_close();
|
|
|
|
|
session_id( '' );
|
|
|
|
|
}
|
|
|
|
|
$wgRequest = new FauxRequest();
|
|
|
|
|
MediaWiki\Session\SessionManager::resetCache();
|
2015-11-22 20:17:00 +00:00
|
|
|
MediaWiki\Auth\AuthManager::resetCache();
|
2012-10-08 10:59:55 +00:00
|
|
|
|
2013-07-17 16:42:24 +00:00
|
|
|
$phpErrorLevel = intval( ini_get( 'error_reporting' ) );
|
|
|
|
|
|
|
|
|
|
if ( $phpErrorLevel !== $this->phpErrorLevel ) {
|
|
|
|
|
ini_set( 'error_reporting', $this->phpErrorLevel );
|
|
|
|
|
|
|
|
|
|
$oldHex = strtoupper( dechex( $this->phpErrorLevel ) );
|
|
|
|
|
$newHex = strtoupper( dechex( $phpErrorLevel ) );
|
2014-04-24 09:57:41 +00:00
|
|
|
$message = "PHP error_reporting setting was left dirty: "
|
|
|
|
|
. "was 0x$oldHex before test, 0x$newHex after test!";
|
2013-07-17 16:42:24 +00:00
|
|
|
|
|
|
|
|
$this->fail( $message );
|
|
|
|
|
}
|
|
|
|
|
|
2012-04-10 14:28:42 +00:00
|
|
|
parent::tearDown();
|
|
|
|
|
}
|
|
|
|
|
|
2012-10-22 23:53:51 +00:00
|
|
|
/**
|
|
|
|
|
* Make sure MediaWikiTestCase extending classes have called their
|
|
|
|
|
* parent setUp method
|
|
|
|
|
*/
|
|
|
|
|
final public function testMediaWikiTestCaseParentSetupCalled() {
|
|
|
|
|
$this->assertArrayHasKey( 'setUp', $this->called,
|
2016-02-25 20:00:22 +00:00
|
|
|
static::class . '::setUp() must call parent::setUp()'
|
2012-10-22 23:53:51 +00:00
|
|
|
);
|
|
|
|
|
}
|
|
|
|
|
|
2016-05-01 19:29:11 +00:00
|
|
|
/**
|
|
|
|
|
* Sets a service, maintaining a stashed version of the previous service to be
|
|
|
|
|
* restored in tearDown
|
|
|
|
|
*
|
|
|
|
|
* @since 1.27
|
|
|
|
|
*
|
|
|
|
|
* @param string $name
|
|
|
|
|
* @param object $object
|
|
|
|
|
*/
|
|
|
|
|
protected function setService( $name, $object ) {
|
|
|
|
|
// If we did not yet override the service locator, so so now.
|
|
|
|
|
if ( MediaWikiServices::getInstance() === self::$serviceLocator ) {
|
|
|
|
|
$this->overrideMwServices();
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
MediaWikiServices::getInstance()->disableService( $name );
|
|
|
|
|
MediaWikiServices::getInstance()->redefineService(
|
|
|
|
|
$name,
|
|
|
|
|
function () use ( $object ) {
|
|
|
|
|
return $object;
|
|
|
|
|
}
|
|
|
|
|
);
|
|
|
|
|
}
|
|
|
|
|
|
2012-10-08 10:59:55 +00:00
|
|
|
/**
|
2014-03-05 20:19:16 +00:00
|
|
|
* Sets a global, maintaining a stashed version of the previous global to be
|
|
|
|
|
* restored in tearDown
|
|
|
|
|
*
|
|
|
|
|
* The key is added to the array of globals that will be reset afterwards
|
|
|
|
|
* in the tearDown().
|
2012-10-08 10:59:55 +00:00
|
|
|
*
|
|
|
|
|
* @example
|
|
|
|
|
* <code>
|
|
|
|
|
* protected function setUp() {
|
|
|
|
|
* $this->setMwGlobals( 'wgRestrictStuff', true );
|
|
|
|
|
* }
|
|
|
|
|
*
|
|
|
|
|
* function testFoo() {}
|
|
|
|
|
*
|
|
|
|
|
* function testBar() {}
|
|
|
|
|
* $this->assertTrue( self::getX()->doStuff() );
|
|
|
|
|
*
|
|
|
|
|
* $this->setMwGlobals( 'wgRestrictStuff', false );
|
|
|
|
|
* $this->assertTrue( self::getX()->doStuff() );
|
|
|
|
|
* }
|
|
|
|
|
*
|
|
|
|
|
* function testQuux() {}
|
|
|
|
|
* </code>
|
|
|
|
|
*
|
|
|
|
|
* @param array|string $pairs Key to the global variable, or an array
|
|
|
|
|
* of key/value pairs.
|
|
|
|
|
* @param mixed $value Value to set the global to (ignored
|
|
|
|
|
* if an array is given as first argument).
|
2014-03-05 20:19:16 +00:00
|
|
|
*
|
2016-05-01 19:29:11 +00:00
|
|
|
* @note To allow changes to global variables to take effect on global service instances,
|
|
|
|
|
* call overrideMwServices().
|
|
|
|
|
*
|
2014-03-05 20:19:16 +00:00
|
|
|
* @since 1.21
|
2012-10-08 10:59:55 +00:00
|
|
|
*/
|
|
|
|
|
protected function setMwGlobals( $pairs, $value = null ) {
|
2013-02-14 11:22:13 +00:00
|
|
|
if ( is_string( $pairs ) ) {
|
2016-02-17 09:09:32 +00:00
|
|
|
$pairs = [ $pairs => $value ];
|
2012-10-25 15:29:10 +00:00
|
|
|
}
|
|
|
|
|
|
2014-03-05 20:19:16 +00:00
|
|
|
$this->stashMwGlobals( array_keys( $pairs ) );
|
|
|
|
|
|
2012-10-25 15:29:10 +00:00
|
|
|
foreach ( $pairs as $key => $value ) {
|
2014-03-05 20:19:16 +00:00
|
|
|
$GLOBALS[$key] = $value;
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
|
2016-05-11 11:12:46 +00:00
|
|
|
/**
|
|
|
|
|
* Check if we can back up a value by performing a shallow copy.
|
|
|
|
|
* Values which fail this test are copied recursively.
|
|
|
|
|
*
|
|
|
|
|
* @param mixed $value
|
|
|
|
|
* @return bool True if a shallow copy will do; false if a deep copy
|
|
|
|
|
* is required.
|
|
|
|
|
*/
|
|
|
|
|
private static function canShallowCopy( $value ) {
|
|
|
|
|
if ( is_scalar( $value ) || $value === null ) {
|
|
|
|
|
return true;
|
|
|
|
|
}
|
|
|
|
|
if ( is_array( $value ) ) {
|
|
|
|
|
foreach ( $value as $subValue ) {
|
|
|
|
|
if ( !is_scalar( $subValue ) && $subValue !== null ) {
|
|
|
|
|
return false;
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
return true;
|
|
|
|
|
}
|
|
|
|
|
return false;
|
|
|
|
|
}
|
|
|
|
|
|
2014-03-05 20:19:16 +00:00
|
|
|
/**
|
|
|
|
|
* Stashes the global, will be restored in tearDown()
|
|
|
|
|
*
|
|
|
|
|
* Individual test functions may override globals through the setMwGlobals() function
|
|
|
|
|
* or directly. When directly overriding globals their keys should first be passed to this
|
|
|
|
|
* method in setUp to avoid breaking global state for other tests
|
|
|
|
|
*
|
|
|
|
|
* That way all other tests are executed with the same settings (instead of using the
|
|
|
|
|
* unreliable local settings for most tests and fix it only for some tests).
|
|
|
|
|
*
|
|
|
|
|
* @param array|string $globalKeys Key to the global variable, or an array of keys.
|
|
|
|
|
*
|
2014-07-24 12:55:43 +00:00
|
|
|
* @throws Exception When trying to stash an unset global
|
2016-05-01 19:29:11 +00:00
|
|
|
*
|
|
|
|
|
* @note To allow changes to global variables to take effect on global service instances,
|
|
|
|
|
* call overrideMwServices().
|
|
|
|
|
*
|
2014-03-05 20:19:16 +00:00
|
|
|
* @since 1.23
|
|
|
|
|
*/
|
|
|
|
|
protected function stashMwGlobals( $globalKeys ) {
|
|
|
|
|
if ( is_string( $globalKeys ) ) {
|
2016-02-17 09:09:32 +00:00
|
|
|
$globalKeys = [ $globalKeys ];
|
2014-03-05 20:19:16 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
|
|
foreach ( $globalKeys as $globalKey ) {
|
2012-10-25 15:29:10 +00:00
|
|
|
// NOTE: make sure we only save the global once or a second call to
|
|
|
|
|
// setMwGlobals() on the same global would override the original
|
|
|
|
|
// value.
|
2014-03-05 20:19:16 +00:00
|
|
|
if ( !array_key_exists( $globalKey, $this->mwGlobals ) ) {
|
2014-03-05 20:25:49 +00:00
|
|
|
if ( !array_key_exists( $globalKey, $GLOBALS ) ) {
|
|
|
|
|
throw new Exception( "Global with key {$globalKey} doesn't exist and cant be stashed" );
|
|
|
|
|
}
|
2014-03-05 13:25:07 +00:00
|
|
|
// NOTE: we serialize then unserialize the value in case it is an object
|
|
|
|
|
// this stops any objects being passed by reference. We could use clone
|
|
|
|
|
// and if is_object but this does account for objects within objects!
|
2016-05-11 11:12:46 +00:00
|
|
|
if ( self::canShallowCopy( $GLOBALS[$globalKey] ) ) {
|
2014-03-05 20:19:16 +00:00
|
|
|
$this->mwGlobals[$globalKey] = $GLOBALS[$globalKey];
|
2016-05-11 11:12:46 +00:00
|
|
|
} elseif (
|
|
|
|
|
// Many MediaWiki types are safe to clone. These are the
|
|
|
|
|
// ones that are most commonly stashed.
|
|
|
|
|
$GLOBALS[$globalKey] instanceof Language ||
|
|
|
|
|
$GLOBALS[$globalKey] instanceof User ||
|
|
|
|
|
$GLOBALS[$globalKey] instanceof FauxRequest
|
|
|
|
|
) {
|
|
|
|
|
$this->mwGlobals[$globalKey] = clone $GLOBALS[$globalKey];
|
|
|
|
|
} else {
|
|
|
|
|
try {
|
|
|
|
|
$this->mwGlobals[$globalKey] = unserialize( serialize( $GLOBALS[$globalKey] ) );
|
|
|
|
|
} catch ( Exception $e ) {
|
|
|
|
|
$this->mwGlobals[$globalKey] = $GLOBALS[$globalKey];
|
|
|
|
|
}
|
2014-03-05 19:50:20 +00:00
|
|
|
}
|
2012-10-08 10:59:55 +00:00
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
|
2012-10-09 09:34:24 +00:00
|
|
|
/**
|
|
|
|
|
* Merges the given values into a MW global array variable.
|
|
|
|
|
* Useful for setting some entries in a configuration array, instead of
|
|
|
|
|
* setting the entire array.
|
|
|
|
|
*
|
2014-03-05 14:41:41 +00:00
|
|
|
* @param string $name The name of the global, as in wgFooBar
|
|
|
|
|
* @param array $values The array containing the entries to set in that global
|
2012-10-09 09:34:24 +00:00
|
|
|
*
|
2014-07-24 12:55:43 +00:00
|
|
|
* @throws MWException If the designated global is not an array.
|
2014-03-05 20:19:16 +00:00
|
|
|
*
|
2016-05-01 19:29:11 +00:00
|
|
|
* @note To allow changes to global variables to take effect on global service instances,
|
|
|
|
|
* call overrideMwServices().
|
|
|
|
|
*
|
2014-03-05 20:19:16 +00:00
|
|
|
* @since 1.21
|
2012-10-09 09:34:24 +00:00
|
|
|
*/
|
|
|
|
|
protected function mergeMwGlobalArrayValue( $name, $values ) {
|
|
|
|
|
if ( !isset( $GLOBALS[$name] ) ) {
|
|
|
|
|
$merged = $values;
|
|
|
|
|
} else {
|
|
|
|
|
if ( !is_array( $GLOBALS[$name] ) ) {
|
|
|
|
|
throw new MWException( "MW global $name is not an array." );
|
|
|
|
|
}
|
|
|
|
|
|
2012-10-20 01:51:15 +00:00
|
|
|
// NOTE: do not use array_merge, it screws up for numeric keys.
|
2012-10-09 09:34:24 +00:00
|
|
|
$merged = $GLOBALS[$name];
|
|
|
|
|
foreach ( $values as $k => $v ) {
|
|
|
|
|
$merged[$k] = $v;
|
|
|
|
|
}
|
2012-09-05 13:04:07 +00:00
|
|
|
}
|
|
|
|
|
|
2012-10-09 09:34:24 +00:00
|
|
|
$this->setMwGlobals( $name, $merged );
|
2012-04-10 14:28:42 +00:00
|
|
|
}
|
|
|
|
|
|
2016-05-01 19:29:11 +00:00
|
|
|
/**
|
|
|
|
|
* Stashes the global instance of MediaWikiServices, and installs a new one,
|
|
|
|
|
* allowing test cases to override settings and services.
|
|
|
|
|
* The previous instance of MediaWikiServices will be restored on tearDown.
|
|
|
|
|
*
|
|
|
|
|
* @since 1.27
|
|
|
|
|
*
|
|
|
|
|
* @param Config $configOverrides Configuration overrides for the new MediaWikiServices instance.
|
|
|
|
|
* @param callable[] $services An associative array of services to re-define. Keys are service
|
|
|
|
|
* names, values are callables.
|
|
|
|
|
*
|
|
|
|
|
* @return MediaWikiServices
|
|
|
|
|
* @throws MWException
|
|
|
|
|
*/
|
|
|
|
|
protected function overrideMwServices( Config $configOverrides = null, array $services = [] ) {
|
|
|
|
|
if ( !$configOverrides ) {
|
|
|
|
|
$configOverrides = new HashConfig();
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
$oldInstance = MediaWikiServices::getInstance();
|
|
|
|
|
$oldConfigFactory = $oldInstance->getConfigFactory();
|
|
|
|
|
|
|
|
|
|
$testConfig = self::makeTestConfig( null, $configOverrides );
|
|
|
|
|
$newInstance = new MediaWikiServices( $testConfig );
|
|
|
|
|
|
|
|
|
|
// Load the default wiring from the specified files.
|
|
|
|
|
// NOTE: this logic mirrors the logic in MediaWikiServices::newInstance.
|
|
|
|
|
$wiringFiles = $testConfig->get( 'ServiceWiringFiles' );
|
|
|
|
|
$newInstance->loadWiringFiles( $wiringFiles );
|
|
|
|
|
|
|
|
|
|
// Provide a traditional hook point to allow extensions to configure services.
|
|
|
|
|
Hooks::run( 'MediaWikiServices', [ $newInstance ] );
|
|
|
|
|
|
|
|
|
|
foreach ( $services as $name => $callback ) {
|
|
|
|
|
$newInstance->redefineService( $name, $callback );
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
self::installTestServices(
|
|
|
|
|
$oldConfigFactory,
|
|
|
|
|
$newInstance
|
|
|
|
|
);
|
|
|
|
|
MediaWikiServices::forceGlobalInstance( $newInstance );
|
|
|
|
|
|
|
|
|
|
return $newInstance;
|
|
|
|
|
}
|
|
|
|
|
|
2016-03-09 16:47:58 +00:00
|
|
|
/**
|
|
|
|
|
* @since 1.27
|
|
|
|
|
* @param string|Language $lang
|
|
|
|
|
*/
|
|
|
|
|
public function setUserLang( $lang ) {
|
|
|
|
|
RequestContext::getMain()->setLanguage( $lang );
|
|
|
|
|
$this->setMwGlobals( 'wgLang', RequestContext::getMain()->getLanguage() );
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
/**
|
|
|
|
|
* @since 1.27
|
|
|
|
|
* @param string|Language $lang
|
|
|
|
|
*/
|
|
|
|
|
public function setContentLang( $lang ) {
|
|
|
|
|
if ( $lang instanceof Language ) {
|
|
|
|
|
$langCode = $lang->getCode();
|
|
|
|
|
$langObj = $lang;
|
|
|
|
|
} else {
|
|
|
|
|
$langCode = $lang;
|
|
|
|
|
$langObj = Language::factory( $langCode );
|
|
|
|
|
}
|
|
|
|
|
$this->setMwGlobals( [
|
|
|
|
|
'wgLanguageCode' => $langCode,
|
|
|
|
|
'wgContLang' => $langObj,
|
|
|
|
|
] );
|
|
|
|
|
}
|
|
|
|
|
|
2016-02-07 08:12:10 +00:00
|
|
|
/**
|
|
|
|
|
* Sets the logger for a specified channel, for the duration of the test.
|
|
|
|
|
* @since 1.27
|
|
|
|
|
* @param string $channel
|
|
|
|
|
* @param LoggerInterface $logger
|
|
|
|
|
*/
|
|
|
|
|
protected function setLogger( $channel, LoggerInterface $logger ) {
|
2016-05-01 19:29:11 +00:00
|
|
|
// TODO: Once loggers are managed by MediaWikiServices, use
|
|
|
|
|
// overrideMwServices() to set loggers.
|
|
|
|
|
|
2016-02-07 08:12:10 +00:00
|
|
|
$provider = LoggerFactory::getProvider();
|
|
|
|
|
$wrappedProvider = TestingAccessWrapper::newFromObject( $provider );
|
|
|
|
|
$singletons = $wrappedProvider->singletons;
|
|
|
|
|
if ( $provider instanceof MonologSpi ) {
|
|
|
|
|
if ( !isset( $this->loggers[$channel] ) ) {
|
|
|
|
|
$this->loggers[$channel] = isset( $singletons['loggers'][$channel] )
|
|
|
|
|
? $singletons['loggers'][$channel] : null;
|
|
|
|
|
}
|
|
|
|
|
$singletons['loggers'][$channel] = $logger;
|
|
|
|
|
} elseif ( $provider instanceof LegacySpi ) {
|
|
|
|
|
if ( !isset( $this->loggers[$channel] ) ) {
|
|
|
|
|
$this->loggers[$channel] = isset( $singletons[$channel] ) ? $singletons[$channel] : null;
|
|
|
|
|
}
|
|
|
|
|
$singletons[$channel] = $logger;
|
|
|
|
|
} else {
|
|
|
|
|
throw new LogicException( __METHOD__ . ': setting a logger for ' . get_class( $provider )
|
|
|
|
|
. ' is not implemented' );
|
|
|
|
|
}
|
|
|
|
|
$wrappedProvider->singletons = $singletons;
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
/**
|
|
|
|
|
* Restores loggers replaced by setLogger().
|
|
|
|
|
* @since 1.27
|
|
|
|
|
*/
|
|
|
|
|
private function restoreLoggers() {
|
|
|
|
|
$provider = LoggerFactory::getProvider();
|
|
|
|
|
$wrappedProvider = TestingAccessWrapper::newFromObject( $provider );
|
|
|
|
|
$singletons = $wrappedProvider->singletons;
|
|
|
|
|
foreach ( $this->loggers as $channel => $logger ) {
|
|
|
|
|
if ( $provider instanceof MonologSpi ) {
|
|
|
|
|
if ( $logger === null ) {
|
|
|
|
|
unset( $singletons['loggers'][$channel] );
|
|
|
|
|
} else {
|
|
|
|
|
$singletons['loggers'][$channel] = $logger;
|
|
|
|
|
}
|
|
|
|
|
} elseif ( $provider instanceof LegacySpi ) {
|
|
|
|
|
if ( $logger === null ) {
|
|
|
|
|
unset( $singletons[$channel] );
|
|
|
|
|
} else {
|
|
|
|
|
$singletons[$channel] = $logger;
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
$wrappedProvider->singletons = $singletons;
|
2016-02-17 09:09:32 +00:00
|
|
|
$this->loggers = [];
|
2016-02-07 08:12:10 +00:00
|
|
|
}
|
|
|
|
|
|
2014-03-05 14:41:41 +00:00
|
|
|
/**
|
|
|
|
|
* @return string
|
|
|
|
|
* @since 1.18
|
|
|
|
|
*/
|
|
|
|
|
public function dbPrefix() {
|
2011-03-05 15:44:28 +00:00
|
|
|
return $this->db->getType() == 'oracle' ? self::ORA_DB_PREFIX : self::DB_PREFIX;
|
|
|
|
|
}
|
2011-06-02 19:32:45 +00:00
|
|
|
|
2014-03-05 14:41:41 +00:00
|
|
|
/**
|
|
|
|
|
* @return bool
|
|
|
|
|
* @since 1.18
|
|
|
|
|
*/
|
|
|
|
|
public function needsDB() {
|
2012-05-04 14:02:09 +00:00
|
|
|
# if the test says it uses database tables, it needs the database
|
|
|
|
|
if ( $this->tablesUsed ) {
|
|
|
|
|
return true;
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
# if the test says it belongs to the Database group, it needs the database
|
2010-12-29 15:52:07 +00:00
|
|
|
$rc = new ReflectionClass( $this );
|
2012-05-04 14:02:09 +00:00
|
|
|
if ( preg_match( '/@group +Database/im', $rc->getDocComment() ) ) {
|
|
|
|
|
return true;
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
return false;
|
2010-12-29 15:52:07 +00:00
|
|
|
}
|
2011-01-10 18:34:59 +00:00
|
|
|
|
2014-09-18 00:02:24 +00:00
|
|
|
/**
|
|
|
|
|
* Insert a new page.
|
|
|
|
|
*
|
|
|
|
|
* Should be called from addDBData().
|
|
|
|
|
*
|
2014-06-02 18:34:52 +00:00
|
|
|
* @since 1.25 ($namespace in 1.28)
|
|
|
|
|
* @param string|title $pageName Page name or title
|
2014-09-18 00:02:24 +00:00
|
|
|
* @param string $text Page's content
|
2014-06-02 18:34:52 +00:00
|
|
|
* @param int $namespace Namespace id (name cannot already contain namespace)
|
2014-09-18 00:02:24 +00:00
|
|
|
* @return array Title object and page id
|
|
|
|
|
*/
|
2014-06-02 18:34:52 +00:00
|
|
|
protected function insertPage(
|
|
|
|
|
$pageName,
|
|
|
|
|
$text = 'Sample page for unit test.',
|
|
|
|
|
$namespace = null
|
|
|
|
|
) {
|
|
|
|
|
if ( is_string( $pageName ) ) {
|
|
|
|
|
$title = Title::newFromText( $pageName, $namespace );
|
|
|
|
|
} else {
|
|
|
|
|
$title = $pageName;
|
|
|
|
|
}
|
2014-09-18 00:02:24 +00:00
|
|
|
|
2016-05-18 09:19:20 +00:00
|
|
|
$user = static::getTestSysop()->getUser();
|
2014-09-18 00:02:24 +00:00
|
|
|
$comment = __METHOD__ . ': Sample page for unit test.';
|
|
|
|
|
|
2016-05-01 19:29:11 +00:00
|
|
|
// Avoid memory leak...?
|
|
|
|
|
// LinkCache::singleton()->clear();
|
|
|
|
|
// Maybe. But doing this absolutely breaks $title->isRedirect() when called during unit tests....
|
|
|
|
|
|
2014-09-18 00:02:24 +00:00
|
|
|
$page = WikiPage::factory( $title );
|
|
|
|
|
$page->doEditContent( ContentHandler::makeContent( $text, $title ), $comment, 0, false, $user );
|
|
|
|
|
|
2016-02-17 09:09:32 +00:00
|
|
|
return [
|
2014-09-18 00:02:24 +00:00
|
|
|
'title' => $title,
|
|
|
|
|
'id' => $page->getId(),
|
2016-02-17 09:09:32 +00:00
|
|
|
];
|
2014-09-18 00:02:24 +00:00
|
|
|
}
|
|
|
|
|
|
2011-01-10 18:34:59 +00:00
|
|
|
/**
|
2016-03-07 17:26:25 +00:00
|
|
|
* Stub. If a test suite needs to add additional data to the database, it should
|
|
|
|
|
* implement this method and do so. This method is called once per test suite
|
|
|
|
|
* (i.e. once per class).
|
|
|
|
|
*
|
|
|
|
|
* Note data added by this method may be removed by resetDB() depending on
|
|
|
|
|
* the contents of $tablesUsed.
|
|
|
|
|
*
|
|
|
|
|
* To add additional data between test function runs, override prepareDB().
|
|
|
|
|
*
|
|
|
|
|
* @see addDBData()
|
|
|
|
|
* @see resetDB()
|
|
|
|
|
*
|
|
|
|
|
* @since 1.27
|
|
|
|
|
*/
|
|
|
|
|
public function addDBDataOnce() {
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
/**
|
|
|
|
|
* Stub. Subclasses may override this to prepare the database.
|
|
|
|
|
* Called before every test run (test function or data set).
|
|
|
|
|
*
|
|
|
|
|
* @see addDBDataOnce()
|
|
|
|
|
* @see resetDB()
|
2014-03-05 14:41:41 +00:00
|
|
|
*
|
|
|
|
|
* @since 1.18
|
2011-01-10 18:34:59 +00:00
|
|
|
*/
|
2014-03-05 14:41:41 +00:00
|
|
|
public function addDBData() {
|
2013-04-26 12:00:22 +00:00
|
|
|
}
|
2011-06-02 19:32:45 +00:00
|
|
|
|
2010-12-29 15:52:07 +00:00
|
|
|
private function addCoreDBData() {
|
2011-11-10 13:29:32 +00:00
|
|
|
if ( $this->db->getType() == 'oracle' ) {
|
|
|
|
|
|
|
|
|
|
# Insert 0 user to prevent FK violations
|
|
|
|
|
# Anonymous user
|
2016-05-18 09:19:20 +00:00
|
|
|
if ( !$this->db->selectField( 'user', '1', [ 'user_id' => 0 ] ) ) {
|
|
|
|
|
$this->db->insert( 'user', [
|
|
|
|
|
'user_id' => 0,
|
|
|
|
|
'user_name' => 'Anonymous' ], __METHOD__, [ 'IGNORE' ] );
|
|
|
|
|
}
|
2011-11-10 13:29:32 +00:00
|
|
|
|
|
|
|
|
# Insert 0 page to prevent FK violations
|
|
|
|
|
# Blank page
|
2016-05-18 09:19:20 +00:00
|
|
|
if ( !$this->db->selectField( 'page', '1', [ 'page_id' => 0 ] ) ) {
|
|
|
|
|
$this->db->insert( 'page', [
|
|
|
|
|
'page_id' => 0,
|
|
|
|
|
'page_namespace' => 0,
|
|
|
|
|
'page_title' => ' ',
|
|
|
|
|
'page_restrictions' => null,
|
|
|
|
|
'page_is_redirect' => 0,
|
|
|
|
|
'page_is_new' => 0,
|
|
|
|
|
'page_random' => 0,
|
|
|
|
|
'page_touched' => $this->db->timestamp(),
|
|
|
|
|
'page_latest' => 0,
|
|
|
|
|
'page_len' => 0 ], __METHOD__, [ 'IGNORE' ] );
|
|
|
|
|
}
|
2011-11-10 13:29:32 +00:00
|
|
|
}
|
2011-01-25 16:32:43 +00:00
|
|
|
|
|
|
|
|
User::resetIdByNameCache();
|
|
|
|
|
|
2014-09-18 00:02:24 +00:00
|
|
|
// Make sysop user
|
2016-05-18 09:19:20 +00:00
|
|
|
$user = static::getTestSysop()->getUser();
|
2010-12-29 15:52:07 +00:00
|
|
|
|
2014-09-18 00:02:24 +00:00
|
|
|
// Make 1 page with 1 revision
|
2011-12-16 18:55:20 +00:00
|
|
|
$page = WikiPage::factory( Title::newFromText( 'UTPage' ) );
|
2014-03-10 02:04:53 +00:00
|
|
|
if ( $page->getId() == 0 ) {
|
2012-08-28 13:58:36 +00:00
|
|
|
$page->doEditContent(
|
|
|
|
|
new WikitextContent( 'UTContent' ),
|
|
|
|
|
'UTPageSummary',
|
|
|
|
|
EDIT_NEW,
|
|
|
|
|
false,
|
2015-03-23 05:36:20 +00:00
|
|
|
$user
|
2014-09-18 00:02:24 +00:00
|
|
|
);
|
2016-02-01 20:44:03 +00:00
|
|
|
|
|
|
|
|
// doEditContent() probably started the session via
|
|
|
|
|
// User::loadFromSession(). Close it now.
|
|
|
|
|
if ( session_id() !== '' ) {
|
|
|
|
|
session_write_close();
|
|
|
|
|
session_id( '' );
|
|
|
|
|
}
|
2012-01-25 23:11:53 +00:00
|
|
|
}
|
2010-12-29 15:52:07 +00:00
|
|
|
}
|
2011-06-02 19:32:45 +00:00
|
|
|
|
2012-11-13 16:48:15 +00:00
|
|
|
/**
|
|
|
|
|
* Restores MediaWiki to using the table set (table prefix) it was using before
|
|
|
|
|
* setupTestDB() was called. Useful if we need to perform database operations
|
|
|
|
|
* after the test run has finished (such as saving logs or profiling info).
|
2014-03-05 14:41:41 +00:00
|
|
|
*
|
|
|
|
|
* @since 1.21
|
2012-11-13 16:48:15 +00:00
|
|
|
*/
|
|
|
|
|
public static function teardownTestDB() {
|
2015-12-11 23:45:05 +00:00
|
|
|
global $wgJobClasses;
|
|
|
|
|
|
2012-11-13 16:48:15 +00:00
|
|
|
if ( !self::$dbSetup ) {
|
|
|
|
|
return;
|
|
|
|
|
}
|
|
|
|
|
|
2015-12-11 23:45:05 +00:00
|
|
|
foreach ( $wgJobClasses as $type => $class ) {
|
|
|
|
|
// Delete any jobs under the clone DB (or old prefix in other stores)
|
|
|
|
|
JobQueueGroup::singleton()->get( $type )->delete();
|
|
|
|
|
}
|
|
|
|
|
|
2012-11-13 16:48:15 +00:00
|
|
|
CloneDatabase::changePrefix( self::$oldTablePrefix );
|
|
|
|
|
|
|
|
|
|
self::$oldTablePrefix = false;
|
|
|
|
|
self::$dbSetup = false;
|
|
|
|
|
}
|
|
|
|
|
|
2016-03-03 07:30:24 +00:00
|
|
|
/**
|
|
|
|
|
* Setups a database with the given prefix.
|
|
|
|
|
*
|
|
|
|
|
* If reuseDB is true and certain conditions apply, it will just change the prefix.
|
|
|
|
|
* Otherwise, it will clone the tables and change the prefix.
|
|
|
|
|
*
|
|
|
|
|
* Clones all tables in the given database (whatever database that connection has
|
|
|
|
|
* open), to versions with the test prefix.
|
|
|
|
|
*
|
|
|
|
|
* @param DatabaseBase $db Database to use
|
|
|
|
|
* @param string $prefix Prefix to use for test tables
|
|
|
|
|
* @return bool True if tables were cloned, false if only the prefix was changed
|
|
|
|
|
*/
|
|
|
|
|
protected static function setupDatabaseWithTestPrefix( DatabaseBase $db, $prefix ) {
|
|
|
|
|
$tablesCloned = self::listTables( $db );
|
|
|
|
|
$dbClone = new CloneDatabase( $db, $tablesCloned, $prefix );
|
|
|
|
|
$dbClone->useTemporaryTables( self::$useTemporaryTables );
|
|
|
|
|
|
|
|
|
|
if ( ( $db->getType() == 'oracle' || !self::$useTemporaryTables ) && self::$reuseDB ) {
|
|
|
|
|
CloneDatabase::changePrefix( $prefix );
|
|
|
|
|
|
|
|
|
|
return false;
|
|
|
|
|
} else {
|
|
|
|
|
$dbClone->cloneTableStructure();
|
|
|
|
|
return true;
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
/**
|
|
|
|
|
* Set up all test DBs
|
|
|
|
|
*/
|
|
|
|
|
public function setupAllTestDBs() {
|
|
|
|
|
global $wgDBprefix;
|
|
|
|
|
|
|
|
|
|
self::$oldTablePrefix = $wgDBprefix;
|
|
|
|
|
|
|
|
|
|
$testPrefix = $this->dbPrefix();
|
|
|
|
|
|
|
|
|
|
// switch to a temporary clone of the database
|
|
|
|
|
self::setupTestDB( $this->db, $testPrefix );
|
|
|
|
|
|
|
|
|
|
if ( self::isUsingExternalStoreDB() ) {
|
|
|
|
|
self::setupExternalStoreTestDBs( $testPrefix );
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
|
2012-11-13 16:48:15 +00:00
|
|
|
/**
|
|
|
|
|
* Creates an empty skeleton of the wiki database by cloning its structure
|
|
|
|
|
* to equivalent tables using the given $prefix. Then sets MediaWiki to
|
|
|
|
|
* use the new set of tables (aka schema) instead of the original set.
|
|
|
|
|
*
|
|
|
|
|
* This is used to generate a dummy table set, typically consisting of temporary
|
|
|
|
|
* tables, that will be used by tests instead of the original wiki database tables.
|
|
|
|
|
*
|
2014-03-05 14:41:41 +00:00
|
|
|
* @since 1.21
|
|
|
|
|
*
|
2014-07-24 09:30:25 +00:00
|
|
|
* @note the original table prefix is stored in self::$oldTablePrefix. This is used
|
2012-11-13 16:48:15 +00:00
|
|
|
* by teardownTestDB() to return the wiki to using the original table set.
|
|
|
|
|
*
|
2014-07-24 09:30:25 +00:00
|
|
|
* @note this method only works when first called. Subsequent calls have no effect,
|
2012-11-13 16:48:15 +00:00
|
|
|
* even if using different parameters.
|
|
|
|
|
*
|
|
|
|
|
* @param DatabaseBase $db The database connection
|
2014-04-17 18:43:42 +00:00
|
|
|
* @param string $prefix The prefix to use for the new table set (aka schema).
|
2012-11-13 16:48:15 +00:00
|
|
|
*
|
2014-07-24 12:55:43 +00:00
|
|
|
* @throws MWException If the database table prefix is already $prefix
|
2012-11-13 16:48:15 +00:00
|
|
|
*/
|
|
|
|
|
public static function setupTestDB( DatabaseBase $db, $prefix ) {
|
Refactor parser tests
Merge the PHPUnit parser test runner with the old parserTests.inc,
taking the good bits of both. Reviewed, pared down and documented the
setup code. parserTests.php is now a frontend to a fully featured
parser test system, with lots of developer options, whereas PHPUnit
provides a simpler interface with increased isolation between test
cases.
Performance of both frontends is much improved, perhaps 2x faster for
parserTests.php and 10x faster for PHPUnit.
General:
* Split out the pre-Setup.php global variable configuration from
phpunit.php into a new class called TestSetup, also called it from
parserTests.php.
* Factored out the setup of TestsAutoLoader into a static method in
Maintenance.
* In Setup.php improved "caches" debug output.
PHPUnit frontend:
* Delete the entire contents of NewParserTest and replace it with a
small wrapper around ParserTestRunner. It doesn't inherit from
MediaWikiTestCase anymore since integrating the setup code was an
unnecessary complication.
* Rename MediaWikiParserTest to ParserTestTopLevelSuite and made it an
instantiable TestSuite class instead of just a static method. Got rid
of the eval(), just construct TestCase objects directly with a
specified name, it works just as well.
* Introduce ParserTestFileSuite for per-file setup.
* Remove parser-related options from phpunit.php, since we don't
support them anymore. Note that --filter now works just as well as
--regex used to.
* Add CoreParserTestSuite, equivalent to ExtensionsParserTestSuite,
for clarity.
* Make it possible to call MediaWikiTestCase::setupTestDB() more than
once, as is implied by the documentation.
parserTests.php frontend:
* Made parserTests.php into a Maintenance subclass, moved CLI-specific
code to it.
* Renamed ParserTest to ParserTestRunner, this is now the generic
backend.
* Add --upload-dir option which sets up an FSFileBackend, similar
to the old default behaviour
Test file reading and interpretation:
* Rename TestFileIterator to TestFileReader, and make it read and buffer
an entire file, instead of iterating.
* The previous code had an associative array representation of test
specifications. Used this form more widely to pass around test data.
* Remove the idea of !!hooks copying hooks from $wgParser, this is
unnecessary now that all extensions use ParserFirstCallInit. Resurrect
an old interpretation of the feature which was accidentally broken: if
a named hook does not exist, skip all tests in the file.
* Got rid of the "subtest" idea for tidy variants, instead use a
human-readable description that appears in the output.
* When all tests in a file are filtered or skipped, don't create the
articles in them. This greatly speeds up execution time when --regex
matches a small number of tests. It may possibly break extensions, but
they would have been randomly broken anyway since there is no
guarantee of test file execution order.
* Remove integrated testing of OutputPage::addCategoryLinks() category
link formatting, life is complicated enough already. It can go in
OutputPageTest if that's a thing we really need.
Result recording and display:
* Make TestRecorder into a generic plugin interface for progress output
etc., which needs to be abstracted for PHPUnit integration.
* Introduce MultiTestRecorder for recorder chaining, instead of using
a long inheritance chain. All test recorders now directly inherit from
TestRecorder.
* Move all console-related code to the new ParserTestPrinter.
* Introduce PhpunitTestRecorder, which is the recorder for the PHPUnit
frontend. Most events are ignored since they are never emitted in the
PHPUnit frontend, which does not call runTests().
* Put more information into ParserTestResult and use it more often.
Setup and teardown:
* Introduce a new API for setup/teardown where setup functions return a
ScopedCallback object which automatically performs the corresponding
teardown when it goes out of scope.
* Rename setUp() to staticSetup(), rewrite. There was a lot of cruft in
here which was simply copied from Setup.php without review, and had
nothing to do with parser tests.
* Rename setupGlobals() to perTestSetup(), mostly rewrite. For
performance, give staticSetup() precedence in cases where they were
both setting up the same thing.
* In support of merged setup code, allow Hooks::clear() to be called
from parserTests.php.
* Remove wgFileExtensions -- it is only used by UploadBase which we
don't call.
* Remove wgUseImageResize -- superseded by MockMediaHandlerFactory which
I imported from NewParserTest.
* Import MockFileBackend from NewParserTest. But instead of
customising the configuration globals, I injected services.
* Remove thumbnail deletion from upload teardown. This makes glob
handling as in the old parserTests.php unnecessary.
* Remove math file from upload teardown, math is actually an extension
now! Also, the relevant parser tests were removed from the Math
extension two years ago in favour of unit tests.
* Make addArticle() private, and introduce addArticles() instead, which
allows setup/teardown to be done once for each batch of articles
instead of every time.
* Remove $wgNamespaceAliases and $wgNamespaceProtection setup. These were
copied in from Setup.php in 2010, and are redundant since we do
actually run Setup.php.
* Use NullLockManager, don't set up a temporary directory just for
this alone.
Fuzz tests:
* Use the new TestSetup class.
* Updated for ParserTestRunner interface change.
* Remove some obsolete references to fuzz tests from the two frontends
where they used to reside.
Bug: T41473
Change-Id: Ia8e17008cb9d9b62ce5645e15a41a3b402f4026a
2016-09-08 01:25:22 +00:00
|
|
|
if ( self::$dbSetup ) {
|
|
|
|
|
return;
|
|
|
|
|
}
|
|
|
|
|
|
2016-03-03 07:30:24 +00:00
|
|
|
if ( $db->tablePrefix() === $prefix ) {
|
2014-03-05 14:41:41 +00:00
|
|
|
throw new MWException(
|
|
|
|
|
'Cannot run unit tests, the database prefix is already "' . $prefix . '"' );
|
2010-12-29 15:52:07 +00:00
|
|
|
}
|
|
|
|
|
|
2016-05-01 19:29:11 +00:00
|
|
|
// TODO: the below should be re-written as soon as LBFactory, LoadBalancer,
|
|
|
|
|
// and DatabaseBase no longer use global state.
|
|
|
|
|
|
2016-03-15 02:49:13 +00:00
|
|
|
self::$dbSetup = true;
|
|
|
|
|
|
2016-03-03 07:30:24 +00:00
|
|
|
if ( !self::setupDatabaseWithTestPrefix( $db, $prefix ) ) {
|
|
|
|
|
return;
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
// Assuming this isn't needed for External Store database, and not sure if the procedure
|
|
|
|
|
// would be available there.
|
|
|
|
|
if ( $db->getType() == 'oracle' ) {
|
|
|
|
|
$db->query( 'BEGIN FILL_WIKI_INFO; END;' );
|
|
|
|
|
}
|
|
|
|
|
}
|
2012-11-13 16:48:15 +00:00
|
|
|
|
2016-03-03 07:30:24 +00:00
|
|
|
/**
|
|
|
|
|
* Clones the External Store database(s) for testing
|
|
|
|
|
*
|
|
|
|
|
* @param string $testPrefix Prefix for test tables
|
|
|
|
|
*/
|
|
|
|
|
protected static function setupExternalStoreTestDBs( $testPrefix ) {
|
|
|
|
|
$connections = self::getExternalStoreDatabaseConnections();
|
|
|
|
|
foreach ( $connections as $dbw ) {
|
|
|
|
|
// Hack: cloneTableStructure sets $wgDBprefix to the unit test
|
|
|
|
|
// prefix,. Even though listTables now uses tablePrefix, that
|
|
|
|
|
// itself is populated from $wgDBprefix by default.
|
2013-04-26 12:00:22 +00:00
|
|
|
|
2016-03-03 07:30:24 +00:00
|
|
|
// We have to set it back, or we won't find the original 'blobs'
|
|
|
|
|
// table to copy.
|
|
|
|
|
|
|
|
|
|
$dbw->tablePrefix( self::$oldTablePrefix );
|
|
|
|
|
self::setupDatabaseWithTestPrefix( $dbw, $testPrefix );
|
2011-11-10 13:29:32 +00:00
|
|
|
}
|
2016-03-03 07:30:24 +00:00
|
|
|
}
|
2011-06-01 22:43:19 +00:00
|
|
|
|
2016-03-03 07:30:24 +00:00
|
|
|
/**
|
|
|
|
|
* Gets master database connections for all of the ExternalStoreDB
|
|
|
|
|
* stores configured in $wgDefaultExternalStore.
|
|
|
|
|
*
|
2016-09-23 22:59:22 +00:00
|
|
|
* @return DatabaseBase[] Array of DatabaseBase master connections
|
2016-03-03 07:30:24 +00:00
|
|
|
*/
|
|
|
|
|
|
|
|
|
|
protected static function getExternalStoreDatabaseConnections() {
|
|
|
|
|
global $wgDefaultExternalStore;
|
|
|
|
|
|
2016-09-23 22:59:22 +00:00
|
|
|
/** @var ExternalStoreDB $externalStoreDB */
|
2016-03-03 07:30:24 +00:00
|
|
|
$externalStoreDB = ExternalStore::getStoreObject( 'DB' );
|
|
|
|
|
$defaultArray = (array) $wgDefaultExternalStore;
|
|
|
|
|
$dbws = [];
|
|
|
|
|
foreach ( $defaultArray as $url ) {
|
|
|
|
|
if ( strpos( $url, 'DB://' ) === 0 ) {
|
|
|
|
|
list( $proto, $cluster ) = explode( '://', $url, 2 );
|
2016-09-23 22:59:22 +00:00
|
|
|
// Avoid getMaster() because setupDatabaseWithTestPrefix()
|
|
|
|
|
// requires DatabaseBase instead of plain DBConnRef/IDatabase
|
|
|
|
|
$lb = $externalStoreDB->getLoadBalancer( $cluster );
|
|
|
|
|
$dbw = $lb->getConnection( DB_MASTER );
|
2016-03-03 07:30:24 +00:00
|
|
|
$dbws[] = $dbw;
|
|
|
|
|
}
|
2011-06-01 22:43:19 +00:00
|
|
|
}
|
2016-03-03 07:30:24 +00:00
|
|
|
|
|
|
|
|
return $dbws;
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
/**
|
|
|
|
|
* Check whether ExternalStoreDB is being used
|
|
|
|
|
*
|
|
|
|
|
* @return bool True if it's being used
|
|
|
|
|
*/
|
|
|
|
|
protected static function isUsingExternalStoreDB() {
|
|
|
|
|
global $wgDefaultExternalStore;
|
|
|
|
|
if ( !$wgDefaultExternalStore ) {
|
|
|
|
|
return false;
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
$defaultArray = (array) $wgDefaultExternalStore;
|
|
|
|
|
foreach ( $defaultArray as $url ) {
|
|
|
|
|
if ( strpos( $url, 'DB://' ) === 0 ) {
|
|
|
|
|
return true;
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
return false;
|
2011-05-24 21:22:36 +00:00
|
|
|
}
|
2010-12-29 15:52:07 +00:00
|
|
|
|
2011-05-24 21:22:36 +00:00
|
|
|
/**
|
|
|
|
|
* Empty all tables so they can be repopulated for tests
|
2016-03-03 07:30:24 +00:00
|
|
|
*
|
|
|
|
|
* @param DatabaseBase $db|null Database to reset
|
|
|
|
|
* @param array $tablesUsed Tables to reset
|
2011-05-24 21:22:36 +00:00
|
|
|
*/
|
2016-03-03 07:30:24 +00:00
|
|
|
private function resetDB( $db, $tablesUsed ) {
|
|
|
|
|
if ( $db ) {
|
2016-04-11 17:36:38 +00:00
|
|
|
$userTables = [ 'user', 'user_groups', 'user_properties' ];
|
|
|
|
|
$coreDBDataTables = array_merge( $userTables, [ 'page', 'revision' ] );
|
|
|
|
|
|
|
|
|
|
// If any of the user tables were marked as used, we should clear all of them.
|
|
|
|
|
if ( array_intersect( $tablesUsed, $userTables ) ) {
|
|
|
|
|
$tablesUsed = array_unique( array_merge( $tablesUsed, $userTables ) );
|
2016-05-18 09:19:20 +00:00
|
|
|
TestUserRegistry::clear();
|
2016-04-11 17:36:38 +00:00
|
|
|
}
|
|
|
|
|
|
2016-03-03 07:30:24 +00:00
|
|
|
$truncate = in_array( $db->getType(), [ 'oracle', 'mysql' ] );
|
|
|
|
|
foreach ( $tablesUsed as $tbl ) {
|
2016-04-11 17:36:38 +00:00
|
|
|
// TODO: reset interwiki table to its original content.
|
|
|
|
|
if ( $tbl == 'interwiki' ) {
|
2016-03-07 17:26:25 +00:00
|
|
|
continue;
|
2011-11-10 13:29:32 +00:00
|
|
|
}
|
2016-03-07 17:26:25 +00:00
|
|
|
|
|
|
|
|
if ( $truncate ) {
|
2016-03-03 07:30:24 +00:00
|
|
|
$db->query( 'TRUNCATE TABLE ' . $db->tableName( $tbl ), __METHOD__ );
|
2016-03-07 17:26:25 +00:00
|
|
|
} else {
|
2016-03-03 07:30:24 +00:00
|
|
|
$db->delete( $tbl, '*', __METHOD__ );
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
if ( $tbl === 'page' ) {
|
|
|
|
|
// Forget about the pages since they don't
|
|
|
|
|
// exist in the DB.
|
|
|
|
|
LinkCache::singleton()->clear();
|
2011-11-10 13:29:32 +00:00
|
|
|
}
|
2011-05-24 21:22:36 +00:00
|
|
|
}
|
2016-04-11 17:36:38 +00:00
|
|
|
|
|
|
|
|
if ( array_intersect( $tablesUsed, $coreDBDataTables ) ) {
|
|
|
|
|
// Re-add core DB data that was deleted
|
|
|
|
|
$this->addCoreDBData();
|
|
|
|
|
}
|
2010-12-29 15:52:07 +00:00
|
|
|
}
|
|
|
|
|
}
|
2011-06-01 22:43:19 +00:00
|
|
|
|
2014-03-05 14:41:41 +00:00
|
|
|
/**
|
|
|
|
|
* @since 1.18
|
|
|
|
|
*
|
|
|
|
|
* @param string $func
|
|
|
|
|
* @param array $args
|
|
|
|
|
*
|
|
|
|
|
* @return mixed
|
|
|
|
|
* @throws MWException
|
|
|
|
|
*/
|
|
|
|
|
public function __call( $func, $args ) {
|
2016-02-17 09:09:32 +00:00
|
|
|
static $compatibility = [
|
2014-03-05 14:41:41 +00:00
|
|
|
'assertEmpty' => 'assertEmpty2', // assertEmpty was added in phpunit 3.7.32
|
2016-02-17 09:09:32 +00:00
|
|
|
];
|
2010-12-29 15:52:07 +00:00
|
|
|
|
2014-03-05 14:41:41 +00:00
|
|
|
if ( isset( $compatibility[$func] ) ) {
|
2016-02-17 09:09:32 +00:00
|
|
|
return call_user_func_array( [ $this, $compatibility[$func] ], $args );
|
2010-12-29 15:52:07 +00:00
|
|
|
} else {
|
2014-12-12 08:41:27 +00:00
|
|
|
throw new MWException( "Called non-existent $func method on "
|
2010-12-29 15:52:07 +00:00
|
|
|
. get_class( $this ) );
|
|
|
|
|
}
|
|
|
|
|
}
|
2011-02-10 09:51:31 +00:00
|
|
|
|
2014-03-05 14:41:41 +00:00
|
|
|
/**
|
|
|
|
|
* Used as a compatibility method for phpunit < 3.7.32
|
2014-04-17 18:43:42 +00:00
|
|
|
* @param string $value
|
|
|
|
|
* @param string $msg
|
2014-03-05 14:41:41 +00:00
|
|
|
*/
|
2011-02-10 10:03:38 +00:00
|
|
|
private function assertEmpty2( $value, $msg ) {
|
2015-04-01 00:13:47 +00:00
|
|
|
$this->assertTrue( $value == '', $msg );
|
2011-02-10 09:51:31 +00:00
|
|
|
}
|
2011-06-02 19:32:45 +00:00
|
|
|
|
2016-03-03 07:30:24 +00:00
|
|
|
private static function unprefixTable( &$tableName, $ind, $prefix ) {
|
|
|
|
|
$tableName = substr( $tableName, strlen( $prefix ) );
|
2010-12-30 16:24:29 +00:00
|
|
|
}
|
|
|
|
|
|
2013-01-28 10:27:15 +00:00
|
|
|
private static function isNotUnittest( $table ) {
|
2011-06-02 17:58:34 +00:00
|
|
|
return strpos( $table, 'unittest_' ) !== 0;
|
|
|
|
|
}
|
|
|
|
|
|
2014-03-05 14:41:41 +00:00
|
|
|
/**
|
|
|
|
|
* @since 1.18
|
|
|
|
|
*
|
2015-04-01 00:13:47 +00:00
|
|
|
* @param DatabaseBase $db
|
2014-03-05 14:41:41 +00:00
|
|
|
*
|
|
|
|
|
* @return array
|
|
|
|
|
*/
|
2016-09-23 03:11:18 +00:00
|
|
|
public static function listTables( DatabaseBase $db ) {
|
2016-03-03 07:30:24 +00:00
|
|
|
$prefix = $db->tablePrefix();
|
|
|
|
|
$tables = $db->listTables( $prefix, __METHOD__ );
|
2013-05-24 15:14:40 +00:00
|
|
|
|
|
|
|
|
if ( $db->getType() === 'mysql' ) {
|
2016-09-23 03:11:18 +00:00
|
|
|
static $viewListCache = null;
|
|
|
|
|
if ( $viewListCache === null ) {
|
|
|
|
|
$viewListCache = $db->listViews( null, __METHOD__ );
|
|
|
|
|
}
|
|
|
|
|
// T45571: cannot clone VIEWs under MySQL
|
|
|
|
|
$tables = array_diff( $tables, $viewListCache );
|
2013-05-24 15:14:40 +00:00
|
|
|
}
|
2016-03-03 07:30:24 +00:00
|
|
|
array_walk( $tables, [ __CLASS__, 'unprefixTable' ], $prefix );
|
2011-06-01 23:17:29 +00:00
|
|
|
|
2011-06-02 17:58:34 +00:00
|
|
|
// Don't duplicate test tables from the previous fataled run
|
2016-02-17 09:09:32 +00:00
|
|
|
$tables = array_filter( $tables, [ __CLASS__, 'isNotUnittest' ] );
|
2011-06-02 17:58:34 +00:00
|
|
|
|
2012-11-13 16:48:15 +00:00
|
|
|
if ( $db->getType() == 'sqlite' ) {
|
2011-06-01 23:17:29 +00:00
|
|
|
$tables = array_flip( $tables );
|
|
|
|
|
// these are subtables of searchindex and don't need to be duped/dropped separately
|
|
|
|
|
unset( $tables['searchindex_content'] );
|
|
|
|
|
unset( $tables['searchindex_segdir'] );
|
|
|
|
|
unset( $tables['searchindex_segments'] );
|
|
|
|
|
$tables = array_flip( $tables );
|
2011-03-05 16:09:10 +00:00
|
|
|
}
|
2013-04-26 12:00:22 +00:00
|
|
|
|
2011-06-01 23:17:29 +00:00
|
|
|
return $tables;
|
2010-12-29 15:52:07 +00:00
|
|
|
}
|
2011-06-02 19:32:45 +00:00
|
|
|
|
2014-03-05 14:41:41 +00:00
|
|
|
/**
|
|
|
|
|
* @throws MWException
|
|
|
|
|
* @since 1.18
|
|
|
|
|
*/
|
2010-12-31 21:10:36 +00:00
|
|
|
protected function checkDbIsSupported() {
|
2013-02-14 11:22:13 +00:00
|
|
|
if ( !in_array( $this->db->getType(), $this->supportedDBs ) ) {
|
2010-12-31 21:10:36 +00:00
|
|
|
throw new MWException( $this->db->getType() . " is not currently supported for unit testing." );
|
|
|
|
|
}
|
|
|
|
|
}
|
2011-06-02 19:32:45 +00:00
|
|
|
|
2014-03-05 14:41:41 +00:00
|
|
|
/**
|
|
|
|
|
* @since 1.18
|
2014-04-17 18:43:42 +00:00
|
|
|
* @param string $offset
|
|
|
|
|
* @return mixed
|
2014-03-05 14:41:41 +00:00
|
|
|
*/
|
2011-01-01 05:53:04 +00:00
|
|
|
public function getCliArg( $offset ) {
|
2014-05-05 16:10:07 +00:00
|
|
|
if ( isset( PHPUnitMaintClass::$additionalOptions[$offset] ) ) {
|
|
|
|
|
return PHPUnitMaintClass::$additionalOptions[$offset];
|
2011-01-01 05:53:04 +00:00
|
|
|
}
|
|
|
|
|
}
|
2011-06-02 19:32:45 +00:00
|
|
|
|
2014-03-05 14:41:41 +00:00
|
|
|
/**
|
|
|
|
|
* @since 1.18
|
2014-04-17 18:43:42 +00:00
|
|
|
* @param string $offset
|
|
|
|
|
* @param mixed $value
|
2014-03-05 14:41:41 +00:00
|
|
|
*/
|
2011-01-01 05:53:04 +00:00
|
|
|
public function setCliArg( $offset, $value ) {
|
2014-05-05 16:10:07 +00:00
|
|
|
PHPUnitMaintClass::$additionalOptions[$offset] = $value;
|
2011-01-01 05:53:04 +00:00
|
|
|
}
|
2011-06-22 21:02:07 +00:00
|
|
|
|
2011-07-25 16:27:33 +00:00
|
|
|
/**
|
|
|
|
|
* Don't throw a warning if $function is deprecated and called later
|
|
|
|
|
*
|
2014-03-05 14:41:41 +00:00
|
|
|
* @since 1.19
|
|
|
|
|
*
|
|
|
|
|
* @param string $function
|
2011-07-25 16:27:33 +00:00
|
|
|
*/
|
2014-03-05 14:41:41 +00:00
|
|
|
public function hideDeprecated( $function ) {
|
2015-06-10 18:29:05 +00:00
|
|
|
MediaWiki\suppressWarnings();
|
2011-07-25 16:27:33 +00:00
|
|
|
wfDeprecated( $function );
|
2015-06-10 18:29:05 +00:00
|
|
|
MediaWiki\restoreWarnings();
|
2011-07-25 16:27:33 +00:00
|
|
|
}
|
2012-05-10 20:56:34 +00:00
|
|
|
|
|
|
|
|
/**
|
|
|
|
|
* Asserts that the given database query yields the rows given by $expectedRows.
|
|
|
|
|
* The expected rows should be given as indexed (not associative) arrays, with
|
|
|
|
|
* the values given in the order of the columns in the $fields parameter.
|
|
|
|
|
* Note that the rows are sorted by the columns given in $fields.
|
|
|
|
|
*
|
2012-08-12 19:35:37 +00:00
|
|
|
* @since 1.20
|
|
|
|
|
*
|
2014-03-05 14:41:41 +00:00
|
|
|
* @param string|array $table The table(s) to query
|
|
|
|
|
* @param string|array $fields The columns to include in the result (and to sort by)
|
|
|
|
|
* @param string|array $condition "where" condition(s)
|
|
|
|
|
* @param array $expectedRows An array of arrays giving the expected rows.
|
2012-05-10 20:56:34 +00:00
|
|
|
*
|
2014-03-05 14:41:41 +00:00
|
|
|
* @throws MWException If this test cases's needsDB() method doesn't return true.
|
2012-05-10 20:56:34 +00:00
|
|
|
* Test cases can use "@group Database" to enable database test support,
|
|
|
|
|
* or list the tables under testing in $this->tablesUsed, or override the
|
|
|
|
|
* needsDB() method.
|
|
|
|
|
*/
|
2012-10-05 14:11:18 +00:00
|
|
|
protected function assertSelect( $table, $fields, $condition, array $expectedRows ) {
|
2012-05-10 20:56:34 +00:00
|
|
|
if ( !$this->needsDB() ) {
|
|
|
|
|
throw new MWException( 'When testing database state, the test cases\'s needDB()' .
|
2013-02-14 11:22:13 +00:00
|
|
|
' method should return true. Use @group Database or $this->tablesUsed.' );
|
2012-05-10 20:56:34 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
|
|
$db = wfGetDB( DB_SLAVE );
|
|
|
|
|
|
2016-02-17 09:09:32 +00:00
|
|
|
$res = $db->select( $table, $fields, $condition, wfGetCaller(), [ 'ORDER BY' => $fields ] );
|
2012-05-10 20:56:34 +00:00
|
|
|
$this->assertNotEmpty( $res, "query failed: " . $db->lastError() );
|
|
|
|
|
|
|
|
|
|
$i = 0;
|
|
|
|
|
|
|
|
|
|
foreach ( $expectedRows as $expected ) {
|
|
|
|
|
$r = $res->fetchRow();
|
|
|
|
|
self::stripStringKeys( $r );
|
|
|
|
|
|
|
|
|
|
$i += 1;
|
|
|
|
|
$this->assertNotEmpty( $r, "row #$i missing" );
|
|
|
|
|
|
|
|
|
|
$this->assertEquals( $expected, $r, "row #$i mismatches" );
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
$r = $res->fetchRow();
|
|
|
|
|
self::stripStringKeys( $r );
|
|
|
|
|
|
|
|
|
|
$this->assertFalse( $r, "found extra row (after #$i)" );
|
|
|
|
|
}
|
|
|
|
|
|
2012-08-12 19:37:54 +00:00
|
|
|
/**
|
|
|
|
|
* Utility method taking an array of elements and wrapping
|
2014-11-08 19:07:19 +00:00
|
|
|
* each element in its own array. Useful for data providers
|
2012-08-12 19:37:54 +00:00
|
|
|
* that only return a single argument.
|
|
|
|
|
*
|
|
|
|
|
* @since 1.20
|
|
|
|
|
*
|
|
|
|
|
* @param array $elements
|
|
|
|
|
*
|
|
|
|
|
* @return array
|
|
|
|
|
*/
|
|
|
|
|
protected function arrayWrap( array $elements ) {
|
|
|
|
|
return array_map(
|
2013-02-14 11:22:13 +00:00
|
|
|
function ( $element ) {
|
2016-02-17 09:09:32 +00:00
|
|
|
return [ $element ];
|
2012-08-12 19:37:54 +00:00
|
|
|
},
|
|
|
|
|
$elements
|
|
|
|
|
);
|
|
|
|
|
}
|
|
|
|
|
|
2012-07-02 14:24:10 +00:00
|
|
|
/**
|
|
|
|
|
* Assert that two arrays are equal. By default this means that both arrays need to hold
|
|
|
|
|
* the same set of values. Using additional arguments, order and associated key can also
|
|
|
|
|
* be set as relevant.
|
|
|
|
|
*
|
|
|
|
|
* @since 1.20
|
|
|
|
|
*
|
|
|
|
|
* @param array $expected
|
|
|
|
|
* @param array $actual
|
2014-03-05 14:41:41 +00:00
|
|
|
* @param bool $ordered If the order of the values should match
|
|
|
|
|
* @param bool $named If the keys should match
|
2012-07-02 14:24:10 +00:00
|
|
|
*/
|
2014-04-24 09:57:41 +00:00
|
|
|
protected function assertArrayEquals( array $expected, array $actual,
|
|
|
|
|
$ordered = false, $named = false
|
|
|
|
|
) {
|
2012-07-02 14:24:10 +00:00
|
|
|
if ( !$ordered ) {
|
2012-08-12 20:55:55 +00:00
|
|
|
$this->objectAssociativeSort( $expected );
|
|
|
|
|
$this->objectAssociativeSort( $actual );
|
2012-07-02 14:24:10 +00:00
|
|
|
}
|
|
|
|
|
|
2012-07-26 18:08:54 +00:00
|
|
|
if ( !$named ) {
|
|
|
|
|
$expected = array_values( $expected );
|
|
|
|
|
$actual = array_values( $actual );
|
|
|
|
|
}
|
|
|
|
|
|
2012-07-02 14:24:10 +00:00
|
|
|
call_user_func_array(
|
2016-02-17 09:09:32 +00:00
|
|
|
[ $this, 'assertEquals' ],
|
|
|
|
|
array_merge( [ $expected, $actual ], array_slice( func_get_args(), 4 ) )
|
2012-07-02 14:24:10 +00:00
|
|
|
);
|
|
|
|
|
}
|
|
|
|
|
|
2012-09-03 08:46:07 +00:00
|
|
|
/**
|
|
|
|
|
* Put each HTML element on its own line and then equals() the results
|
|
|
|
|
*
|
|
|
|
|
* Use for nicely formatting of PHPUnit diff output when comparing very
|
|
|
|
|
* simple HTML
|
|
|
|
|
*
|
|
|
|
|
* @since 1.20
|
|
|
|
|
*
|
2014-03-05 14:41:41 +00:00
|
|
|
* @param string $expected HTML on oneline
|
|
|
|
|
* @param string $actual HTML on oneline
|
|
|
|
|
* @param string $msg Optional message
|
2012-09-03 08:46:07 +00:00
|
|
|
*/
|
2013-02-14 11:22:13 +00:00
|
|
|
protected function assertHTMLEquals( $expected, $actual, $msg = '' ) {
|
2012-09-03 08:46:07 +00:00
|
|
|
$expected = str_replace( '>', ">\n", $expected );
|
2013-02-14 11:22:13 +00:00
|
|
|
$actual = str_replace( '>', ">\n", $actual );
|
2012-09-03 08:46:07 +00:00
|
|
|
|
|
|
|
|
$this->assertEquals( $expected, $actual, $msg );
|
|
|
|
|
}
|
|
|
|
|
|
2012-08-12 20:55:55 +00:00
|
|
|
/**
|
|
|
|
|
* Does an associative sort that works for objects.
|
|
|
|
|
*
|
|
|
|
|
* @since 1.20
|
|
|
|
|
*
|
|
|
|
|
* @param array $array
|
|
|
|
|
*/
|
|
|
|
|
protected function objectAssociativeSort( array &$array ) {
|
|
|
|
|
uasort(
|
|
|
|
|
$array,
|
2013-02-14 11:22:13 +00:00
|
|
|
function ( $a, $b ) {
|
2012-08-12 20:55:55 +00:00
|
|
|
return serialize( $a ) > serialize( $b ) ? 1 : -1;
|
|
|
|
|
}
|
|
|
|
|
);
|
|
|
|
|
}
|
|
|
|
|
|
2012-05-10 20:56:34 +00:00
|
|
|
/**
|
|
|
|
|
* Utility function for eliminating all string keys from an array.
|
|
|
|
|
* Useful to turn a database result row as returned by fetchRow() into
|
|
|
|
|
* a pure indexed array.
|
|
|
|
|
*
|
2012-08-12 19:35:37 +00:00
|
|
|
* @since 1.20
|
|
|
|
|
*
|
2014-03-05 14:41:41 +00:00
|
|
|
* @param mixed $r The array to remove string keys from.
|
2012-05-10 20:56:34 +00:00
|
|
|
*/
|
|
|
|
|
protected static function stripStringKeys( &$r ) {
|
2012-08-12 19:35:37 +00:00
|
|
|
if ( !is_array( $r ) ) {
|
|
|
|
|
return;
|
|
|
|
|
}
|
2012-05-10 20:56:34 +00:00
|
|
|
|
|
|
|
|
foreach ( $r as $k => $v ) {
|
2012-08-12 19:35:37 +00:00
|
|
|
if ( is_string( $k ) ) {
|
|
|
|
|
unset( $r[$k] );
|
|
|
|
|
}
|
2012-05-10 20:56:34 +00:00
|
|
|
}
|
|
|
|
|
}
|
2012-08-12 19:35:37 +00:00
|
|
|
|
2012-09-04 13:53:05 +00:00
|
|
|
/**
|
|
|
|
|
* Asserts that the provided variable is of the specified
|
|
|
|
|
* internal type or equals the $value argument. This is useful
|
|
|
|
|
* for testing return types of functions that return a certain
|
|
|
|
|
* type or *value* when not set or on error.
|
|
|
|
|
*
|
|
|
|
|
* @since 1.20
|
|
|
|
|
*
|
|
|
|
|
* @param string $type
|
|
|
|
|
* @param mixed $actual
|
|
|
|
|
* @param mixed $value
|
|
|
|
|
* @param string $message
|
|
|
|
|
*/
|
|
|
|
|
protected function assertTypeOrValue( $type, $actual, $value = false, $message = '' ) {
|
|
|
|
|
if ( $actual === $value ) {
|
|
|
|
|
$this->assertTrue( true, $message );
|
2013-02-14 11:22:13 +00:00
|
|
|
} else {
|
2012-09-04 13:53:05 +00:00
|
|
|
$this->assertType( $type, $actual, $message );
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
/**
|
|
|
|
|
* Asserts the type of the provided value. This can be either
|
|
|
|
|
* in internal type such as boolean or integer, or a class or
|
|
|
|
|
* interface the value extends or implements.
|
|
|
|
|
*
|
|
|
|
|
* @since 1.20
|
|
|
|
|
*
|
|
|
|
|
* @param string $type
|
|
|
|
|
* @param mixed $actual
|
|
|
|
|
* @param string $message
|
|
|
|
|
*/
|
|
|
|
|
protected function assertType( $type, $actual, $message = '' ) {
|
2012-09-24 13:14:28 +00:00
|
|
|
if ( class_exists( $type ) || interface_exists( $type ) ) {
|
2012-09-04 13:53:05 +00:00
|
|
|
$this->assertInstanceOf( $type, $actual, $message );
|
2013-02-14 11:22:13 +00:00
|
|
|
} else {
|
2012-09-04 13:53:05 +00:00
|
|
|
$this->assertInternalType( $type, $actual, $message );
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
|
2012-10-12 11:09:08 +00:00
|
|
|
/**
|
2013-06-11 23:01:52 +00:00
|
|
|
* Returns true if the given namespace defaults to Wikitext
|
2012-10-12 11:09:08 +00:00
|
|
|
* according to $wgNamespaceContentModels
|
|
|
|
|
*
|
|
|
|
|
* @param int $ns The namespace ID to check
|
|
|
|
|
*
|
|
|
|
|
* @return bool
|
|
|
|
|
* @since 1.21
|
|
|
|
|
*/
|
|
|
|
|
protected function isWikitextNS( $ns ) {
|
|
|
|
|
global $wgNamespaceContentModels;
|
|
|
|
|
|
|
|
|
|
if ( isset( $wgNamespaceContentModels[$ns] ) ) {
|
|
|
|
|
return $wgNamespaceContentModels[$ns] === CONTENT_MODEL_WIKITEXT;
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
return true;
|
|
|
|
|
}
|
2012-10-12 15:34:29 +00:00
|
|
|
|
|
|
|
|
/**
|
|
|
|
|
* Returns the ID of a namespace that defaults to Wikitext.
|
|
|
|
|
*
|
2014-03-05 14:41:41 +00:00
|
|
|
* @throws MWException If there is none.
|
|
|
|
|
* @return int The ID of the wikitext Namespace
|
2012-10-12 15:34:29 +00:00
|
|
|
* @since 1.21
|
|
|
|
|
*/
|
|
|
|
|
protected function getDefaultWikitextNS() {
|
|
|
|
|
global $wgNamespaceContentModels;
|
|
|
|
|
|
|
|
|
|
static $wikitextNS = null; // this is not going to change
|
|
|
|
|
if ( $wikitextNS !== null ) {
|
|
|
|
|
return $wikitextNS;
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
// quickly short out on most common case:
|
|
|
|
|
if ( !isset( $wgNamespaceContentModels[NS_MAIN] ) ) {
|
|
|
|
|
return NS_MAIN;
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
// NOTE: prefer content namespaces
|
|
|
|
|
$namespaces = array_unique( array_merge(
|
|
|
|
|
MWNamespace::getContentNamespaces(),
|
2016-02-17 09:09:32 +00:00
|
|
|
[ NS_MAIN, NS_HELP, NS_PROJECT ], // prefer these
|
2012-10-12 15:34:29 +00:00
|
|
|
MWNamespace::getValidNamespaces()
|
|
|
|
|
) );
|
|
|
|
|
|
2016-02-17 09:09:32 +00:00
|
|
|
$namespaces = array_diff( $namespaces, [
|
2012-10-12 15:34:29 +00:00
|
|
|
NS_FILE, NS_CATEGORY, NS_MEDIAWIKI, NS_USER // don't mess with magic namespaces
|
2016-02-17 09:09:32 +00:00
|
|
|
] );
|
2012-10-12 15:34:29 +00:00
|
|
|
|
|
|
|
|
$talk = array_filter( $namespaces, function ( $ns ) {
|
|
|
|
|
return MWNamespace::isTalk( $ns );
|
|
|
|
|
} );
|
|
|
|
|
|
|
|
|
|
// prefer non-talk pages
|
|
|
|
|
$namespaces = array_diff( $namespaces, $talk );
|
|
|
|
|
$namespaces = array_merge( $namespaces, $talk );
|
|
|
|
|
|
|
|
|
|
// check default content model of each namespace
|
|
|
|
|
foreach ( $namespaces as $ns ) {
|
|
|
|
|
if ( !isset( $wgNamespaceContentModels[$ns] ) ||
|
2013-02-14 11:22:13 +00:00
|
|
|
$wgNamespaceContentModels[$ns] === CONTENT_MODEL_WIKITEXT
|
|
|
|
|
) {
|
2012-10-12 15:34:29 +00:00
|
|
|
|
|
|
|
|
$wikitextNS = $ns;
|
2013-04-26 12:00:22 +00:00
|
|
|
|
2012-10-12 15:34:29 +00:00
|
|
|
return $wikitextNS;
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
// give up
|
2013-05-15 01:12:35 +00:00
|
|
|
// @todo Inside a test, we could skip the test as incomplete.
|
2012-10-12 15:34:29 +00:00
|
|
|
// But frequently, this is used in fixture setup.
|
|
|
|
|
throw new MWException( "No namespace defaults to wikitext!" );
|
|
|
|
|
}
|
2012-11-22 16:45:50 +00:00
|
|
|
|
|
|
|
|
/**
|
|
|
|
|
* Check, if $wgDiff3 is set and ready to merge
|
|
|
|
|
* Will mark the calling test as skipped, if not ready
|
|
|
|
|
*
|
|
|
|
|
* @since 1.21
|
|
|
|
|
*/
|
2016-01-27 18:56:09 +00:00
|
|
|
protected function markTestSkippedIfNoDiff3() {
|
2012-11-22 16:45:50 +00:00
|
|
|
global $wgDiff3;
|
|
|
|
|
|
|
|
|
|
# This check may also protect against code injection in
|
|
|
|
|
# case of broken installations.
|
2015-06-10 18:29:05 +00:00
|
|
|
MediaWiki\suppressWarnings();
|
2012-11-22 16:45:50 +00:00
|
|
|
$haveDiff3 = $wgDiff3 && file_exists( $wgDiff3 );
|
2015-06-10 18:29:05 +00:00
|
|
|
MediaWiki\restoreWarnings();
|
2012-11-22 16:45:50 +00:00
|
|
|
|
2013-02-14 11:22:13 +00:00
|
|
|
if ( !$haveDiff3 ) {
|
2012-11-22 16:45:50 +00:00
|
|
|
$this->markTestSkipped( "Skip test, since diff3 is not configured" );
|
|
|
|
|
}
|
|
|
|
|
}
|
2012-11-29 17:03:03 +00:00
|
|
|
|
2013-01-28 09:27:31 +00:00
|
|
|
/**
|
|
|
|
|
* Check if $extName is a loaded PHP extension, will skip the
|
|
|
|
|
* test whenever it is not loaded.
|
|
|
|
|
*
|
|
|
|
|
* @since 1.21
|
2014-04-17 18:43:42 +00:00
|
|
|
* @param string $extName
|
|
|
|
|
* @return bool
|
2013-01-28 09:27:31 +00:00
|
|
|
*/
|
|
|
|
|
protected function checkPHPExtension( $extName ) {
|
|
|
|
|
$loaded = extension_loaded( $extName );
|
2013-02-14 11:22:13 +00:00
|
|
|
if ( !$loaded ) {
|
2013-01-28 09:27:31 +00:00
|
|
|
$this->markTestSkipped( "PHP extension '$extName' is not loaded, skipping." );
|
|
|
|
|
}
|
2013-04-26 12:00:22 +00:00
|
|
|
|
2013-01-28 09:27:31 +00:00
|
|
|
return $loaded;
|
|
|
|
|
}
|
|
|
|
|
|
2013-12-03 17:42:48 +00:00
|
|
|
/**
|
|
|
|
|
* Asserts that the given string is a valid HTML snippet.
|
|
|
|
|
* Wraps the given string in the required top level tags and
|
|
|
|
|
* then calls assertValidHtmlDocument().
|
|
|
|
|
* The snippet is expected to be HTML 5.
|
|
|
|
|
*
|
2014-03-05 14:41:41 +00:00
|
|
|
* @since 1.23
|
|
|
|
|
*
|
|
|
|
|
* @note Will mark the test as skipped if the "tidy" module is not installed.
|
|
|
|
|
* @note This ignores $wgUseTidy, so we can check for valid HTML even (and especially)
|
2013-12-03 17:42:48 +00:00
|
|
|
* when automatic tidying is disabled.
|
|
|
|
|
*
|
|
|
|
|
* @param string $html An HTML snippet (treated as the contents of the body tag).
|
|
|
|
|
*/
|
|
|
|
|
protected function assertValidHtmlSnippet( $html ) {
|
|
|
|
|
$html = '<!DOCTYPE html><html><head><title>test</title></head><body>' . $html . '</body></html>';
|
|
|
|
|
$this->assertValidHtmlDocument( $html );
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
/**
|
|
|
|
|
* Asserts that the given string is valid HTML document.
|
|
|
|
|
*
|
2014-03-05 14:41:41 +00:00
|
|
|
* @since 1.23
|
|
|
|
|
*
|
|
|
|
|
* @note Will mark the test as skipped if the "tidy" module is not installed.
|
|
|
|
|
* @note This ignores $wgUseTidy, so we can check for valid HTML even (and especially)
|
2013-12-03 17:42:48 +00:00
|
|
|
* when automatic tidying is disabled.
|
|
|
|
|
*
|
|
|
|
|
* @param string $html A complete HTML document
|
|
|
|
|
*/
|
|
|
|
|
protected function assertValidHtmlDocument( $html ) {
|
|
|
|
|
// Note: we only validate if the tidy PHP extension is available.
|
|
|
|
|
// In case wgTidyInternal is false, MWTidy would fall back to the command line version
|
|
|
|
|
// of tidy. In that case however, we can not reliably detect whether a failing validation
|
|
|
|
|
// is due to malformed HTML, or caused by tidy not being installed as a command line tool.
|
|
|
|
|
// That would cause all HTML assertions to fail on a system that has no tidy installed.
|
2015-08-31 04:42:55 +00:00
|
|
|
if ( !$GLOBALS['wgTidyInternal'] || !MWTidy::isEnabled() ) {
|
2013-12-03 17:42:48 +00:00
|
|
|
$this->markTestSkipped( 'Tidy extension not installed' );
|
|
|
|
|
}
|
|
|
|
|
|
2014-01-23 20:02:34 +00:00
|
|
|
$errorBuffer = '';
|
|
|
|
|
MWTidy::checkErrors( $html, $errorBuffer );
|
|
|
|
|
$allErrors = preg_split( '/[\r\n]+/', $errorBuffer );
|
|
|
|
|
|
|
|
|
|
// Filter Tidy warnings which aren't useful for us.
|
|
|
|
|
// Tidy eg. often cries about parameters missing which have actually
|
|
|
|
|
// been deprecated since HTML4, thus we should not care about them.
|
|
|
|
|
$errors = preg_grep(
|
|
|
|
|
'/^(.*Warning: (trimming empty|.* lacks ".*?" attribute).*|\s*)$/m',
|
|
|
|
|
$allErrors, PREG_GREP_INVERT
|
|
|
|
|
);
|
|
|
|
|
|
|
|
|
|
$this->assertEmpty( $errors, implode( "\n", $errors ) );
|
2013-12-03 17:42:48 +00:00
|
|
|
}
|
2014-08-17 21:38:07 +00:00
|
|
|
|
2014-10-17 18:14:35 +00:00
|
|
|
/**
|
|
|
|
|
* @param array $matcher
|
|
|
|
|
* @param string $actual
|
|
|
|
|
* @param bool $isHtml
|
|
|
|
|
*
|
|
|
|
|
* @return bool
|
|
|
|
|
*/
|
|
|
|
|
private static function tagMatch( $matcher, $actual, $isHtml = true ) {
|
|
|
|
|
$dom = PHPUnit_Util_XML::load( $actual, $isHtml );
|
|
|
|
|
$tags = PHPUnit_Util_XML::findNodes( $dom, $matcher, $isHtml );
|
|
|
|
|
return count( $tags ) > 0 && $tags[0] instanceof DOMNode;
|
|
|
|
|
}
|
|
|
|
|
|
2014-08-17 21:38:07 +00:00
|
|
|
/**
|
|
|
|
|
* Note: we are overriding this method to remove the deprecated error
|
2015-09-12 13:54:13 +00:00
|
|
|
* @see https://phabricator.wikimedia.org/T71505
|
2014-08-17 21:38:07 +00:00
|
|
|
* @see https://github.com/sebastianbergmann/phpunit/issues/1292
|
2014-10-17 18:14:35 +00:00
|
|
|
* @deprecated
|
2014-08-17 21:38:07 +00:00
|
|
|
*
|
|
|
|
|
* @param array $matcher
|
|
|
|
|
* @param string $actual
|
|
|
|
|
* @param string $message
|
|
|
|
|
* @param bool $isHtml
|
|
|
|
|
*/
|
2014-08-25 17:16:36 +00:00
|
|
|
public static function assertTag( $matcher, $actual, $message = '', $isHtml = true ) {
|
2015-09-11 13:44:59 +00:00
|
|
|
// trigger_error(__METHOD__ . ' is deprecated', E_USER_DEPRECATED);
|
2014-08-17 21:38:07 +00:00
|
|
|
|
2014-10-17 18:14:35 +00:00
|
|
|
self::assertTrue( self::tagMatch( $matcher, $actual, $isHtml ), $message );
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
/**
|
|
|
|
|
* @see MediaWikiTestCase::assertTag
|
|
|
|
|
* @deprecated
|
|
|
|
|
*
|
|
|
|
|
* @param array $matcher
|
|
|
|
|
* @param string $actual
|
|
|
|
|
* @param string $message
|
|
|
|
|
* @param bool $isHtml
|
|
|
|
|
*/
|
|
|
|
|
public static function assertNotTag( $matcher, $actual, $message = '', $isHtml = true ) {
|
2015-09-11 13:44:59 +00:00
|
|
|
// trigger_error(__METHOD__ . ' is deprecated', E_USER_DEPRECATED);
|
2014-08-17 21:38:07 +00:00
|
|
|
|
2014-10-17 18:14:35 +00:00
|
|
|
self::assertFalse( self::tagMatch( $matcher, $actual, $isHtml ), $message );
|
2014-08-17 21:38:07 +00:00
|
|
|
}
|
2015-08-21 16:01:10 +00:00
|
|
|
|
|
|
|
|
/**
|
|
|
|
|
* Used as a marker to prevent wfResetOutputBuffers from breaking PHPUnit.
|
|
|
|
|
* @return string
|
|
|
|
|
*/
|
|
|
|
|
public static function wfResetOutputBuffersBarrier( $buffer ) {
|
|
|
|
|
return $buffer;
|
|
|
|
|
}
|
2016-03-07 17:26:25 +00:00
|
|
|
|
2016-05-16 20:24:10 +00:00
|
|
|
/**
|
|
|
|
|
* Create a temporary hook handler which will be reset by tearDown.
|
|
|
|
|
* This replaces other handlers for the same hook.
|
|
|
|
|
* @param string $hookName Hook name
|
|
|
|
|
* @param mixed $handler Value suitable for a hook handler
|
|
|
|
|
* @since 1.28
|
|
|
|
|
*/
|
|
|
|
|
protected function setTemporaryHook( $hookName, $handler ) {
|
|
|
|
|
$this->mergeMwGlobalArrayValue( 'wgHooks', [ $hookName => [ $handler ] ] );
|
|
|
|
|
}
|
|
|
|
|
|
2011-07-25 16:27:33 +00:00
|
|
|
}
|