wiki.techinc.nl/tests/phpunit/includes/db/DatabaseTest.php

414 lines
12 KiB
PHP
Raw Normal View History

<?php
/**
* @group Database
* @group DatabaseBase
*/
class DatabaseTest extends MediaWikiTestCase {
/**
* @var DatabaseBase
*/
protected $db;
private $functionTest = false;
Clean and repair many phpunit tests (+ fix implied configuration) This commit depends on the introduction of MediaWikiTestCase::setMwGlobals in change Iccf6ea81f4. Various tests already set their globals, but forgot to restore them afterwards, or forgot to call the parent setUp, tearDown... Either way they won't have to anymore with setMwGlobals. Consistent use of function characteristics: * protected function setUp * protected function tearDown * public static function (provide..) (Matching the function signature with PHPUnit/Framework/TestCase.php) Replaces: * public function (setUp|tearDown)\( * protected function $1( * \tfunction (setUp|tearDown)\( * \tprotected function $1( * \tfunction (data|provide)\( * \tpublic static function $1\( Also renamed a few "data#", "provider#" and "provides#" functions to "provide#" for consistency. This also removes confusion where the /media tests had a few private methods called dataFile(), which were sometimes expected to be data providers. Fixes: TimestampTest often failed due to a previous test setting a different language (it tests "1 hour ago" so need to make sure it is set to English). MWNamespaceTest became a lot cleaner now that it executes with a known context. Though the now-redundant code that was removed didn't work anyway because wgContentNamespaces isn't keyed by namespace id, it had them was values... FileBackendTest: * Fixed: "PHP Fatal: Using $this when not in object context" HttpTest * Added comment about: "PHP Fatal: Call to protected MWHttpRequest::__construct()" (too much unrelated code to fix in this commit) ExternalStoreTest * Add an assertTrue as well, without it the test is useless because regardless of whether wgExternalStores is true or false it only uses it if it is an array. Change-Id: I9d2b148e57bada64afeb7d5a99bec0e58f8e1561
2012-10-08 10:56:20 +00:00
protected function setUp() {
parent::setUp();
$this->db = wfGetDB( DB_MASTER );
}
Clean and repair many phpunit tests (+ fix implied configuration) This commit depends on the introduction of MediaWikiTestCase::setMwGlobals in change Iccf6ea81f4. Various tests already set their globals, but forgot to restore them afterwards, or forgot to call the parent setUp, tearDown... Either way they won't have to anymore with setMwGlobals. Consistent use of function characteristics: * protected function setUp * protected function tearDown * public static function (provide..) (Matching the function signature with PHPUnit/Framework/TestCase.php) Replaces: * public function (setUp|tearDown)\( * protected function $1( * \tfunction (setUp|tearDown)\( * \tprotected function $1( * \tfunction (data|provide)\( * \tpublic static function $1\( Also renamed a few "data#", "provider#" and "provides#" functions to "provide#" for consistency. This also removes confusion where the /media tests had a few private methods called dataFile(), which were sometimes expected to be data providers. Fixes: TimestampTest often failed due to a previous test setting a different language (it tests "1 hour ago" so need to make sure it is set to English). MWNamespaceTest became a lot cleaner now that it executes with a known context. Though the now-redundant code that was removed didn't work anyway because wgContentNamespaces isn't keyed by namespace id, it had them was values... FileBackendTest: * Fixed: "PHP Fatal: Using $this when not in object context" HttpTest * Added comment about: "PHP Fatal: Call to protected MWHttpRequest::__construct()" (too much unrelated code to fix in this commit) ExternalStoreTest * Add an assertTrue as well, without it the test is useless because regardless of whether wgExternalStores is true or false it only uses it if it is an array. Change-Id: I9d2b148e57bada64afeb7d5a99bec0e58f8e1561
2012-10-08 10:56:20 +00:00
protected function tearDown() {
parent::tearDown();
if ( $this->functionTest ) {
$this->dropFunctions();
$this->functionTest = false;
}
$this->db->restoreFlags( IDatabase::RESTORE_INITIAL );
}
/**
* @covers DatabaseBase::dropTable
*/
public function testAddQuotesNull() {
$check = "NULL";
if ( $this->db->getType() === 'sqlite' || $this->db->getType() === 'oracle' ) {
$check = "''";
}
$this->assertEquals( $check, $this->db->addQuotes( null ) );
}
public function testAddQuotesInt() {
# returning just "1234" should be ok too, though...
# maybe
$this->assertEquals(
"'1234'",
$this->db->addQuotes( 1234 ) );
}
public function testAddQuotesFloat() {
# returning just "1234.5678" would be ok too, though
$this->assertEquals(
"'1234.5678'",
$this->db->addQuotes( 1234.5678 ) );
}
public function testAddQuotesString() {
$this->assertEquals(
"'string'",
$this->db->addQuotes( 'string' ) );
}
public function testAddQuotesStringQuote() {
$check = "'string''s cause trouble'";
if ( $this->db->getType() === 'mysql' ) {
$check = "'string\'s cause trouble'";
}
$this->assertEquals(
$check,
$this->db->addQuotes( "string's cause trouble" ) );
}
private function getSharedTableName( $table, $database, $prefix, $format = 'quoted' ) {
global $wgSharedDB, $wgSharedTables, $wgSharedPrefix, $wgSharedSchema;
$this->db->setTableAliases( [
$table => [
'dbname' => $database,
'schema' => null,
'prefix' => $prefix
]
] );
$ret = $this->db->tableName( $table, $format );
$this->db->setTableAliases( array_fill_keys(
$wgSharedDB ? $wgSharedTables : [],
[
'dbname' => $wgSharedDB,
'schema' => $wgSharedSchema,
'prefix' => $wgSharedPrefix
]
) );
return $ret;
}
private function prefixAndQuote( $table, $database = null, $prefix = null, $format = 'quoted' ) {
if ( $this->db->getType() === 'sqlite' || $format !== 'quoted' ) {
$quote = '';
} elseif ( $this->db->getType() === 'mysql' ) {
$quote = '`';
} elseif ( $this->db->getType() === 'oracle' ) {
$quote = '/*Q*/';
} else {
$quote = '"';
}
if ( $database !== null ) {
if ( $this->db->getType() === 'oracle' ) {
$database = $quote . $database . '.';
} else {
$database = $quote . $database . $quote . '.';
}
}
if ( $prefix === null ) {
$prefix = $this->dbPrefix();
}
if ( $this->db->getType() === 'oracle' ) {
return strtoupper( $database . $quote . $prefix . $table );
} else {
return $database . $quote . $prefix . $table . $quote;
}
}
public function testTableNameLocal() {
$this->assertEquals(
$this->prefixAndQuote( 'tablename' ),
$this->db->tableName( 'tablename' )
);
}
public function testTableNameRawLocal() {
$this->assertEquals(
$this->prefixAndQuote( 'tablename', null, null, 'raw' ),
$this->db->tableName( 'tablename', 'raw' )
);
}
public function testTableNameShared() {
$this->assertEquals(
$this->prefixAndQuote( 'tablename', 'sharedatabase', 'sh_' ),
$this->getSharedTableName( 'tablename', 'sharedatabase', 'sh_' )
);
$this->assertEquals(
$this->prefixAndQuote( 'tablename', 'sharedatabase', null ),
$this->getSharedTableName( 'tablename', 'sharedatabase', null )
);
}
public function testTableNameRawShared() {
$this->assertEquals(
$this->prefixAndQuote( 'tablename', 'sharedatabase', 'sh_', 'raw' ),
$this->getSharedTableName( 'tablename', 'sharedatabase', 'sh_', 'raw' )
);
$this->assertEquals(
$this->prefixAndQuote( 'tablename', 'sharedatabase', null, 'raw' ),
$this->getSharedTableName( 'tablename', 'sharedatabase', null, 'raw' )
);
}
public function testTableNameForeign() {
$this->assertEquals(
$this->prefixAndQuote( 'tablename', 'databasename', '' ),
$this->db->tableName( 'databasename.tablename' )
);
}
public function testTableNameRawForeign() {
$this->assertEquals(
$this->prefixAndQuote( 'tablename', 'databasename', '', 'raw' ),
$this->db->tableName( 'databasename.tablename', 'raw' )
);
}
public function testStoredFunctions() {
if ( !in_array( wfGetDB( DB_MASTER )->getType(), [ 'mysql', 'postgres' ] ) ) {
$this->markTestSkipped( 'MySQL or Postgres required' );
}
global $IP;
$this->dropFunctions();
$this->functionTest = true;
$this->assertTrue(
$this->db->sourceFile( "$IP/tests/phpunit/data/db/{$this->db->getType()}/functions.sql" )
);
$res = $this->db->query( 'SELECT mw_test_function() AS test', __METHOD__ );
$this->assertEquals( 42, $res->fetchObject()->test );
}
private function dropFunctions() {
$this->db->query( 'DROP FUNCTION IF EXISTS mw_test_function'
. ( $this->db->getType() == 'postgres' ? '()' : '' )
);
}
public function testUnknownTableCorruptsResults() {
$res = $this->db->select( 'page', '*', [ 'page_id' => 1 ] );
$this->assertFalse( $this->db->tableExists( 'foobarbaz' ) );
$this->assertInternalType( 'int', $res->numRows() );
}
public function testTransactionIdle() {
$db = $this->db;
$db->setFlag( DBO_TRX );
$called = false;
$flagSet = null;
$db->onTransactionIdle(
function () use ( $db, &$flagSet, &$called ) {
$called = true;
$flagSet = $db->getFlag( DBO_TRX );
},
__METHOD__
);
$this->assertFalse( $flagSet, 'DBO_TRX off in callback' );
$this->assertTrue( $db->getFlag( DBO_TRX ), 'DBO_TRX restored to default' );
$this->assertTrue( $called, 'Callback reached' );
$db->clearFlag( DBO_TRX );
$flagSet = null;
$db->onTransactionIdle(
function () use ( $db, &$flagSet ) {
$flagSet = $db->getFlag( DBO_TRX );
},
__METHOD__
);
$this->assertFalse( $flagSet, 'DBO_TRX off in callback' );
$this->assertFalse( $db->getFlag( DBO_TRX ), 'DBO_TRX restored to default' );
$db->clearFlag( DBO_TRX );
$db->onTransactionIdle(
function () use ( $db ) {
$db->setFlag( DBO_TRX );
},
__METHOD__
);
$this->assertFalse( $db->getFlag( DBO_TRX ), 'DBO_TRX restored to default' );
}
public function testTransactionResolution() {
$db = $this->db;
$db->clearFlag( DBO_TRX );
$db->begin( __METHOD__ );
$called = false;
$db->onTransactionResolution( function () use ( $db, &$called ) {
$called = true;
$db->setFlag( DBO_TRX );
} );
$db->commit( __METHOD__ );
$this->assertFalse( $db->getFlag( DBO_TRX ), 'DBO_TRX restored to default' );
$this->assertTrue( $called, 'Callback reached' );
$db->clearFlag( DBO_TRX );
$db->begin( __METHOD__ );
$called = false;
$db->onTransactionResolution( function () use ( $db, &$called ) {
$called = true;
$db->setFlag( DBO_TRX );
} );
$db->rollback( __METHOD__, IDatabase::FLUSHING_ALL_PEERS );
$this->assertFalse( $db->getFlag( DBO_TRX ), 'DBO_TRX restored to default' );
$this->assertTrue( $called, 'Callback reached' );
}
/**
* @covers DatabaseBase::setTransactionListener()
*/
public function testTransactionListener() {
$db = $this->db;
$db->setTransactionListener( 'ping', function () use ( $db, &$called ) {
$called = true;
} );
$called = false;
$db->begin( __METHOD__ );
$db->commit( __METHOD__ );
$this->assertTrue( $called, 'Callback reached' );
$called = false;
$db->begin( __METHOD__ );
$db->commit( __METHOD__ );
$this->assertTrue( $called, 'Callback still reached' );
$called = false;
$db->begin( __METHOD__ );
$db->rollback( __METHOD__ );
$this->assertTrue( $called, 'Callback reached' );
$db->setTransactionListener( 'ping', null );
$called = false;
$db->begin( __METHOD__ );
$db->commit( __METHOD__ );
$this->assertFalse( $called, 'Callback not reached' );
}
/**
* @covers DatabaseBase::flushSnapshot()
*/
public function testFlushSnapshot() {
$db = $this->db;
$db->flushSnapshot( __METHOD__ ); // ok
$db->flushSnapshot( __METHOD__ ); // ok
$db->setFlag( DBO_TRX, $db::REMEMBER_PRIOR );
$db->query( 'SELECT 1', __METHOD__ );
$this->assertTrue( (bool)$db->trxLevel(), "Transaction started." );
$db->flushSnapshot( __METHOD__ ); // ok
$db->restoreFlags( $db::RESTORE_PRIOR );
$this->assertFalse( (bool)$db->trxLevel(), "Transaction cleared." );
}
public function testGetScopedLock() {
$db = $this->db;
$db->setFlag( DBO_TRX );
try {
$this->badLockingMethodImplicit( $db );
} catch ( RunTimeException $e ) {
$this->assertTrue( $db->trxLevel() > 0, "Transaction not committed." );
}
$db->clearFlag( DBO_TRX );
$db->rollback( __METHOD__, IDatabase::FLUSHING_ALL_PEERS );
$this->assertTrue( $db->lockIsFree( 'meow', __METHOD__ ) );
try {
$this->badLockingMethodExplicit( $db );
} catch ( RunTimeException $e ) {
$this->assertTrue( $db->trxLevel() > 0, "Transaction not committed." );
}
$db->rollback( __METHOD__, IDatabase::FLUSHING_ALL_PEERS );
$this->assertTrue( $db->lockIsFree( 'meow', __METHOD__ ) );
}
private function badLockingMethodImplicit( IDatabase $db ) {
$lock = $db->getScopedLockAndFlush( 'meow', __METHOD__, 1 );
$db->query( "SELECT 1" ); // trigger DBO_TRX
throw new RunTimeException( "Uh oh!" );
}
private function badLockingMethodExplicit( IDatabase $db ) {
$lock = $db->getScopedLockAndFlush( 'meow', __METHOD__, 1 );
$db->begin( __METHOD__ );
throw new RunTimeException( "Uh oh!" );
}
/**
* @covers DatabaseBase::getFlag(
* @covers DatabaseBase::setFlag()
* @covers DatabaseBase::restoreFlags()
*/
public function testFlagSetting() {
$db = $this->db;
$origTrx = $db->getFlag( DBO_TRX );
$origSsl = $db->getFlag( DBO_SSL );
$origTrx
? $db->clearFlag( DBO_TRX, $db::REMEMBER_PRIOR )
: $db->setFlag( DBO_TRX, $db::REMEMBER_PRIOR );
$this->assertEquals( !$origTrx, $db->getFlag( DBO_TRX ) );
$origSsl
? $db->clearFlag( DBO_SSL, $db::REMEMBER_PRIOR )
: $db->setFlag( DBO_SSL, $db::REMEMBER_PRIOR );
$this->assertEquals( !$origSsl, $db->getFlag( DBO_SSL ) );
$db->restoreFlags( $db::RESTORE_INITIAL );
$this->assertEquals( $origTrx, $db->getFlag( DBO_TRX ) );
$this->assertEquals( $origSsl, $db->getFlag( DBO_SSL ) );
$origTrx
? $db->clearFlag( DBO_TRX, $db::REMEMBER_PRIOR )
: $db->setFlag( DBO_TRX, $db::REMEMBER_PRIOR );
$origSsl
? $db->clearFlag( DBO_SSL, $db::REMEMBER_PRIOR )
: $db->setFlag( DBO_SSL, $db::REMEMBER_PRIOR );
$db->restoreFlags();
$this->assertEquals( $origSsl, $db->getFlag( DBO_SSL ) );
$this->assertEquals( !$origTrx, $db->getFlag( DBO_TRX ) );
$db->restoreFlags();
$this->assertEquals( $origSsl, $db->getFlag( DBO_SSL ) );
$this->assertEquals( $origTrx, $db->getFlag( DBO_TRX ) );
}
/**
* @covers DatabaseBase::tablePrefix()
* @covers DatabaseBase::dbSchema()
*/
public function testMutators() {
$old = $this->db->tablePrefix();
$this->assertType( 'string', $old, 'Prefix is string' );
$this->assertEquals( $old, $this->db->tablePrefix(), "Prefix unchanged" );
$this->assertEquals( $old, $this->db->tablePrefix( 'xxx' ) );
$this->assertEquals( 'xxx', $this->db->tablePrefix(), "Prefix set" );
$this->db->tablePrefix( $old );
$this->assertNotEquals( 'xxx', $this->db->tablePrefix() );
$old = $this->db->dbSchema();
$this->assertType( 'string', $old, 'Schema is string' );
$this->assertEquals( $old, $this->db->dbSchema(), "Schema unchanged" );
$this->assertEquals( $old, $this->db->dbSchema( 'xxx' ) );
$this->assertEquals( 'xxx', $this->db->dbSchema(), "Schema set" );
$this->db->dbSchema( $old );
$this->assertNotEquals( 'xxx', $this->db->dbSchema() );
}
}