2019-06-26 02:33:35 +00:00
|
|
|
<?php
|
|
|
|
|
|
|
|
|
|
namespace MediaWiki\Tests\Rest;
|
|
|
|
|
|
|
|
|
|
use GuzzleHttp\Psr7\Uri;
|
2019-09-13 21:07:59 +00:00
|
|
|
use MediaWiki\Permissions\PermissionManager;
|
2019-06-26 02:33:35 +00:00
|
|
|
use MediaWiki\Rest\BasicAccess\StaticBasicAuthorizer;
|
|
|
|
|
use MediaWiki\Rest\Handler;
|
|
|
|
|
use MediaWiki\Rest\HttpException;
|
|
|
|
|
use MediaWiki\Rest\RequestData;
|
2019-06-12 19:51:59 +00:00
|
|
|
use MediaWiki\Rest\RequestInterface;
|
2019-06-26 02:33:35 +00:00
|
|
|
use MediaWiki\Rest\ResponseFactory;
|
|
|
|
|
use MediaWiki\Rest\Router;
|
2019-06-12 19:51:59 +00:00
|
|
|
use MediaWiki\Rest\Validator\Validator;
|
|
|
|
|
use Psr\Container\ContainerInterface;
|
|
|
|
|
use User;
|
2020-01-10 00:00:51 +00:00
|
|
|
use Wikimedia\ObjectFactory;
|
2019-06-26 02:33:35 +00:00
|
|
|
|
|
|
|
|
/**
|
|
|
|
|
* @covers \MediaWiki\Rest\Router
|
|
|
|
|
*/
|
2019-07-10 16:47:39 +00:00
|
|
|
class RouterTest extends \MediaWikiUnitTestCase {
|
2019-06-26 02:33:35 +00:00
|
|
|
/** @return Router */
|
2020-03-20 04:23:51 +00:00
|
|
|
private function createRouter(
|
|
|
|
|
RequestInterface $request,
|
|
|
|
|
$authError = null,
|
|
|
|
|
$additionalRouteFiles = []
|
|
|
|
|
) {
|
2019-06-12 19:51:59 +00:00
|
|
|
$objectFactory = new ObjectFactory(
|
|
|
|
|
$this->getMockForAbstractClass( ContainerInterface::class )
|
|
|
|
|
);
|
2019-09-13 21:07:59 +00:00
|
|
|
$permissionManager = $this->createMock( PermissionManager::class );
|
2020-03-20 04:23:51 +00:00
|
|
|
$routeFiles = array_merge( [ __DIR__ . '/testRoutes.json' ], $additionalRouteFiles );
|
2019-06-26 02:33:35 +00:00
|
|
|
return new Router(
|
2020-03-20 04:23:51 +00:00
|
|
|
$routeFiles,
|
2019-06-26 02:33:35 +00:00
|
|
|
[],
|
2020-03-06 15:53:01 +00:00
|
|
|
'http://wiki.example.com',
|
2019-06-26 02:33:35 +00:00
|
|
|
'/rest',
|
|
|
|
|
new \EmptyBagOStuff(),
|
2019-07-16 22:43:43 +00:00
|
|
|
new ResponseFactory( [] ),
|
2019-06-12 19:51:59 +00:00
|
|
|
new StaticBasicAuthorizer( $authError ),
|
|
|
|
|
$objectFactory,
|
2019-09-13 21:07:59 +00:00
|
|
|
new Validator( $objectFactory, $permissionManager, $request, new User )
|
2019-06-12 19:51:59 +00:00
|
|
|
);
|
2019-06-26 02:33:35 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
|
|
public function testPrefixMismatch() {
|
|
|
|
|
$request = new RequestData( [ 'uri' => new Uri( '/bogus' ) ] );
|
2019-06-12 19:51:59 +00:00
|
|
|
$router = $this->createRouter( $request );
|
2019-06-26 02:33:35 +00:00
|
|
|
$response = $router->execute( $request );
|
|
|
|
|
$this->assertSame( 404, $response->getStatusCode() );
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
public function testWrongMethod() {
|
|
|
|
|
$request = new RequestData( [
|
2020-03-18 16:05:05 +00:00
|
|
|
'uri' => new Uri( '/rest/mock/RouterTest/hello' ),
|
2019-06-26 02:33:35 +00:00
|
|
|
'method' => 'OPTIONS'
|
|
|
|
|
] );
|
2019-06-12 19:51:59 +00:00
|
|
|
$router = $this->createRouter( $request );
|
2019-06-26 02:33:35 +00:00
|
|
|
$response = $router->execute( $request );
|
|
|
|
|
$this->assertSame( 405, $response->getStatusCode() );
|
|
|
|
|
$this->assertSame( 'Method Not Allowed', $response->getReasonPhrase() );
|
|
|
|
|
$this->assertSame( 'GET', $response->getHeaderLine( 'Allow' ) );
|
|
|
|
|
}
|
|
|
|
|
|
2019-09-10 06:26:53 +00:00
|
|
|
public function testHeadToGet() {
|
|
|
|
|
$request = new RequestData( [
|
2020-03-18 16:05:05 +00:00
|
|
|
'uri' => new Uri( '/rest/mock/RouterTest/hello' ),
|
2019-09-10 06:26:53 +00:00
|
|
|
'method' => 'HEAD'
|
|
|
|
|
] );
|
|
|
|
|
$router = $this->createRouter( $request );
|
|
|
|
|
$response = $router->execute( $request );
|
|
|
|
|
$this->assertSame( 200, $response->getStatusCode() );
|
|
|
|
|
}
|
|
|
|
|
|
2019-06-26 02:33:35 +00:00
|
|
|
public function testNoMatch() {
|
|
|
|
|
$request = new RequestData( [ 'uri' => new Uri( '/rest/bogus' ) ] );
|
2019-06-12 19:51:59 +00:00
|
|
|
$router = $this->createRouter( $request );
|
2019-06-26 02:33:35 +00:00
|
|
|
$response = $router->execute( $request );
|
|
|
|
|
$this->assertSame( 404, $response->getStatusCode() );
|
|
|
|
|
// TODO: add more information to the response body and test for its presence here
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
public static function throwHandlerFactory() {
|
|
|
|
|
return new class extends Handler {
|
|
|
|
|
public function execute() {
|
|
|
|
|
throw new HttpException( 'Mock error', 555 );
|
|
|
|
|
}
|
|
|
|
|
};
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
public function testException() {
|
|
|
|
|
$request = new RequestData( [ 'uri' => new Uri( '/rest/mock/RouterTest/throw' ) ] );
|
2019-06-12 19:51:59 +00:00
|
|
|
$router = $this->createRouter( $request );
|
2019-06-26 02:33:35 +00:00
|
|
|
$response = $router->execute( $request );
|
|
|
|
|
$this->assertSame( 555, $response->getStatusCode() );
|
|
|
|
|
$body = $response->getBody();
|
|
|
|
|
$body->rewind();
|
|
|
|
|
$data = json_decode( $body->getContents(), true );
|
|
|
|
|
$this->assertSame( 'Mock error', $data['message'] );
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
public function testBasicAccess() {
|
|
|
|
|
// Using the throwing handler is a way to assert that the handler is not executed
|
|
|
|
|
$request = new RequestData( [ 'uri' => new Uri( '/rest/mock/RouterTest/throw' ) ] );
|
2020-03-20 04:23:51 +00:00
|
|
|
$router = $this->createRouter( $request, 'test-error', [] );
|
2019-06-26 02:33:35 +00:00
|
|
|
$response = $router->execute( $request );
|
|
|
|
|
$this->assertSame( 403, $response->getStatusCode() );
|
|
|
|
|
$body = $response->getBody();
|
|
|
|
|
$body->rewind();
|
|
|
|
|
$data = json_decode( $body->getContents(), true );
|
|
|
|
|
$this->assertSame( 'test-error', $data['error'] );
|
|
|
|
|
}
|
2020-03-20 04:23:51 +00:00
|
|
|
|
|
|
|
|
/**
|
|
|
|
|
* @dataProvider providePaths
|
|
|
|
|
*/
|
|
|
|
|
public function testAdditionalEndpoints( $path ) {
|
|
|
|
|
$request = new RequestData( [
|
|
|
|
|
'uri' => new Uri( $path )
|
|
|
|
|
] );
|
|
|
|
|
$router = $this->createRouter(
|
|
|
|
|
$request,
|
|
|
|
|
null,
|
|
|
|
|
[ __DIR__ . '/testAdditionalRoutes.json' ]
|
|
|
|
|
);
|
|
|
|
|
$response = $router->execute( $request );
|
|
|
|
|
$this->assertSame( 200, $response->getStatusCode() );
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
public static function providePaths() {
|
|
|
|
|
return [
|
|
|
|
|
[ '/rest/mock/RouterTest/hello' ],
|
|
|
|
|
[ '/rest/mock/RouterTest/hello/two' ],
|
|
|
|
|
];
|
|
|
|
|
}
|
2020-03-06 15:53:01 +00:00
|
|
|
|
|
|
|
|
public function provideGetRouteUrl() {
|
|
|
|
|
yield 'empty' => [ '' ];
|
|
|
|
|
yield 'simple route' => [ '/foo/bar' ];
|
|
|
|
|
yield 'simple route with query' => [ '/foo/bar', [ 'x' => '1', 'y' => '2' ] ];
|
|
|
|
|
yield 'strange chars' => [ '/foo+bar', [ 'x' => '#', 'y' => '%' ] ];
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
/**
|
|
|
|
|
* @dataProvider provideGetRouteUrl
|
|
|
|
|
*/
|
|
|
|
|
public function testGetRouteUrl( $route, $query = [] ) {
|
|
|
|
|
$request = new RequestData( [ 'uri' => new Uri( '/rest/mock/route' ) ] );
|
|
|
|
|
$router = $this->createRouter( $request );
|
|
|
|
|
|
|
|
|
|
$url = $router->getRouteUrl( $route, $query );
|
|
|
|
|
$this->assertRegExp( '!^https?://[\w.]+/!', $url );
|
|
|
|
|
|
|
|
|
|
$uri = new Uri( $url );
|
|
|
|
|
|
|
|
|
|
$this->assertSame( wfArrayToCgi( $query ), $uri->getQuery() );
|
|
|
|
|
$this->assertStringContainsString( $route, $uri->getPath() );
|
|
|
|
|
}
|
|
|
|
|
|
2019-06-26 02:33:35 +00:00
|
|
|
}
|