Thijs/wiki.techinc.nl
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions
wiki.techinc.nl/maintenance/runScript.php

12 lines
368 B
PHP
Raw Normal View History

Add convenience maintenance script wrapper Useful for scripts or extensions installed in non-standard locations. Example usage: php maintenance/runScript.php extensions/Wikibase/lib/maintenance/dispatchChanges.php Change-Id: I6ffc72f41f3f96dd535a427d90c7166372459bd2
2013-11-05 15:54:16 +00:00
<?php
Safer autoloading with respect to file-scope code Many files were in the autoloader despite having potentially harmful file-scope code. * Exclude all CommandLineInc maintenance scripts from the autoloader. * Introduce "NO_AUTOLOAD" tag which excludes the file containing it from the autoloader. Use it on CommandLineInc.php and a few suspicious-looking files without classes in case they are refactored to add classes in the future. * Add a test which parses all non-PSR4 class files and confirms that they do not contain dangerous file-scope code. It's slow (15s) but its results were enlightening. * Several maintenance scripts define constants in the file scope, intending to modify the behaviour of MediaWiki. Either move the define() to a later setup function, or protect with NO_AUTOLOAD. * Use require_once consistently with Maintenance.php and doMaintenance.php, per the original convention which is supposed to allow one maintenance script to use the class of another maintenance script. Using require breaks autoloading of these maintenance class files. * When Maintenance.php is included, check if MediaWiki has already started, and if so, return early. Revert the fix for T250003 which is incompatible with this safety measure. Hopefully it was superseded by splitting out the class file. * In runScript.php add a redundant PHP_SAPI check since it does some things in file-scope code before any other check will be run. * Change the if(false) class_alias(...) to something more hackish and more compatible with the new test. * Some site-related scripts found Maintenance.php in a non-standard way. Use the standard way. * fileOpPerfTest.php called error_reporting(). Probably debugging code left in; removed. * Moved mediawiki.compress.7z registration from the class file to the caller. Change-Id: I1b1be90343a5ab678df6f1b1bdd03319dcf6537f
2021-01-08 02:16:02 +00:00
Make runScript.php an alias for run.php runScript.php was designed to run maintenance scripts from arbitrary locations, provided these scripts used getenv( 'MW_INSTALL_PATH' ) to locate Maintenance.php. This functionality is covered by run.php now. Bug: T326589 Change-Id: I25bf6375a1bf078dd240e1eeda4d41af77b06e3a
2023-01-09 21:44:05 +00:00
if ( stream_isatty( STDOUT ) ) {
echo "\n";
echo "*******************************************************************************\n";
echo "NOTE: The maintenance/runScript.php entry point has been replaced by run.php!\n";
echo "*******************************************************************************\n";
echo "\n";
Safer autoloading with respect to file-scope code Many files were in the autoloader despite having potentially harmful file-scope code. * Exclude all CommandLineInc maintenance scripts from the autoloader. * Introduce "NO_AUTOLOAD" tag which excludes the file containing it from the autoloader. Use it on CommandLineInc.php and a few suspicious-looking files without classes in case they are refactored to add classes in the future. * Add a test which parses all non-PSR4 class files and confirms that they do not contain dangerous file-scope code. It's slow (15s) but its results were enlightening. * Several maintenance scripts define constants in the file scope, intending to modify the behaviour of MediaWiki. Either move the define() to a later setup function, or protect with NO_AUTOLOAD. * Use require_once consistently with Maintenance.php and doMaintenance.php, per the original convention which is supposed to allow one maintenance script to use the class of another maintenance script. Using require breaks autoloading of these maintenance class files. * When Maintenance.php is included, check if MediaWiki has already started, and if so, return early. Revert the fix for T250003 which is incompatible with this safety measure. Hopefully it was superseded by splitting out the class file. * In runScript.php add a redundant PHP_SAPI check since it does some things in file-scope code before any other check will be run. * Change the if(false) class_alias(...) to something more hackish and more compatible with the new test. * Some site-related scripts found Maintenance.php in a non-standard way. Use the standard way. * fileOpPerfTest.php called error_reporting(). Probably debugging code left in; removed. * Moved mediawiki.compress.7z registration from the class file to the caller. Change-Id: I1b1be90343a5ab678df6f1b1bdd03319dcf6537f
2021-01-08 02:16:02 +00:00
}
Make runScript.php an alias for run.php runScript.php was designed to run maintenance scripts from arbitrary locations, provided these scripts used getenv( 'MW_INSTALL_PATH' ) to locate Maintenance.php. This functionality is covered by run.php now. Bug: T326589 Change-Id: I25bf6375a1bf078dd240e1eeda4d41af77b06e3a
2023-01-09 21:44:05 +00:00
require __DIR__ . "/run.php";
Reference in a new issue Copy permalink