2004-11-27 21:43:06 +00:00
|
|
|
<?php
|
2013-04-22 14:38:47 +00:00
|
|
|
|
2004-11-27 21:43:06 +00:00
|
|
|
/**
|
2010-08-08 14:23:14 +00:00
|
|
|
* A tool for running hook functions.
|
|
|
|
|
*
|
Changed the calling protocol for function wfRunHooks() in Hooks.php.
Previously, this function used variable arguments to allow
different hooks to pass different parameters. However, var args
silently convert reference-calling to value-calling. So a call
that used to work like this:
# old
wfRunHooks('SomeEvent', $param1, &$param2, $param3);
...now works like this:
# new
wfRunHooks('SomeEvent', array($param1, &$param2, $param3));
Hook functions can now change pass-by-reference parameters correctly
(e.g. $param2 in the above example).
All calls to wfRunHooks() were changed and tested, and the change
was documented in docs/hooks.doc. This change was originally checked
in on REL1_4 branch as a bugfix, but per vibber reverted and checked
in to HEAD instead.
2005-03-13 15:29:43 +00:00
|
|
|
* Copyright 2004, 2005 Evan Prodromou <evan@wikitravel.org>.
|
2004-11-27 21:43:06 +00:00
|
|
|
*
|
2011-01-26 16:50:31 +00:00
|
|
|
* This program is free software; you can redistribute it and/or modify
|
|
|
|
|
* it under the terms of the GNU General Public License as published by
|
|
|
|
|
* the Free Software Foundation; either version 2 of the License, or
|
|
|
|
|
* (at your option) any later version.
|
2004-11-27 21:43:06 +00:00
|
|
|
*
|
2011-01-26 16:50:31 +00:00
|
|
|
* This program is distributed in the hope that it will be useful,
|
|
|
|
|
* but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
|
|
|
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
|
|
|
* GNU General Public License for more details.
|
2004-11-27 21:43:06 +00:00
|
|
|
*
|
2011-01-26 16:50:31 +00:00
|
|
|
* You should have received a copy of the GNU General Public License
|
|
|
|
|
* along with this program; if not, write to the Free Software
|
|
|
|
|
* Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA
|
2004-11-27 21:43:06 +00:00
|
|
|
*
|
2005-05-23 14:17:29 +00:00
|
|
|
* @author Evan Prodromou <evan@wikitravel.org>
|
2005-04-12 02:07:16 +00:00
|
|
|
* @see hooks.txt
|
WARNING: HUGE COMMIT
Doxygen documentation update:
* Changed alls @addtogroup to @ingroup. @addtogroup adds the comment to the group description, but doesn't add the file, class, function, ... to the group like @ingroup does. See for example http://svn.wikimedia.org/doc/group__SpecialPage.html where it's impossible to see related files, classes, ... that should belong to that group.
* Added @file to file description, it seems that it should be explicitely decalred for file descriptions, otherwise doxygen will think that the comment document the first class, variabled, function, ... that is in that file.
* Removed some empty comments
* Removed some ?>
Added following groups:
* ExternalStorage
* JobQueue
* MaintenanceLanguage
One more thing: there are still a lot of warnings when generating the doc.
2008-05-20 17:13:28 +00:00
|
|
|
* @file
|
2004-11-27 21:43:06 +00:00
|
|
|
*/
|
|
|
|
|
|
2011-01-17 03:35:42 +00:00
|
|
|
/**
|
|
|
|
|
* Hooks class.
|
|
|
|
|
*
|
2011-01-26 16:50:31 +00:00
|
|
|
* Used to supersede $wgHooks, because globals are EVIL.
|
2012-10-05 18:29:26 +00:00
|
|
|
*
|
|
|
|
|
* @since 1.18
|
2011-01-17 03:35:42 +00:00
|
|
|
*/
|
|
|
|
|
class Hooks {
|
2013-04-22 14:38:47 +00:00
|
|
|
/**
|
|
|
|
|
* Array of events mapped to an array of callbacks to be run
|
|
|
|
|
* when that event is triggered.
|
|
|
|
|
*/
|
2016-02-17 09:09:32 +00:00
|
|
|
protected static $handlers = [];
|
2011-01-26 16:50:31 +00:00
|
|
|
|
2012-10-05 16:28:21 +00:00
|
|
|
/**
|
2013-04-22 14:38:47 +00:00
|
|
|
* Attach an event handler to a given hook.
|
2012-10-05 16:28:21 +00:00
|
|
|
*
|
2013-04-22 14:38:47 +00:00
|
|
|
* @param string $name Name of hook
|
2014-07-03 19:20:35 +00:00
|
|
|
* @param callable $callback Callback function to attach
|
2012-10-05 16:28:21 +00:00
|
|
|
*
|
2013-04-22 14:38:47 +00:00
|
|
|
* @since 1.18
|
2012-10-05 16:28:21 +00:00
|
|
|
*/
|
2013-04-22 14:38:47 +00:00
|
|
|
public static function register( $name, $callback ) {
|
2013-04-27 12:02:08 +00:00
|
|
|
if ( !isset( self::$handlers[$name] ) ) {
|
2016-02-17 09:09:32 +00:00
|
|
|
self::$handlers[$name] = [];
|
2012-10-05 16:28:21 +00:00
|
|
|
}
|
|
|
|
|
|
2013-04-22 14:38:47 +00:00
|
|
|
self::$handlers[$name][] = $callback;
|
2012-10-05 16:28:21 +00:00
|
|
|
}
|
|
|
|
|
|
2011-01-17 03:35:42 +00:00
|
|
|
/**
|
2013-04-22 14:38:47 +00:00
|
|
|
* Clears hooks registered via Hooks::register(). Does not touch $wgHooks.
|
|
|
|
|
* This is intended for use while testing and will fail if MW_PHPUNIT_TEST is not defined.
|
2011-01-26 16:50:31 +00:00
|
|
|
*
|
2014-07-24 17:42:24 +00:00
|
|
|
* @param string $name The name of the hook to clear.
|
2012-10-05 18:29:26 +00:00
|
|
|
*
|
2013-04-22 14:38:47 +00:00
|
|
|
* @since 1.21
|
2014-07-24 17:42:24 +00:00
|
|
|
* @throws MWException If not in testing mode.
|
2011-01-17 03:35:42 +00:00
|
|
|
*/
|
2013-04-22 14:38:47 +00:00
|
|
|
public static function clear( $name ) {
|
Refactor parser tests
Merge the PHPUnit parser test runner with the old parserTests.inc,
taking the good bits of both. Reviewed, pared down and documented the
setup code. parserTests.php is now a frontend to a fully featured
parser test system, with lots of developer options, whereas PHPUnit
provides a simpler interface with increased isolation between test
cases.
Performance of both frontends is much improved, perhaps 2x faster for
parserTests.php and 10x faster for PHPUnit.
General:
* Split out the pre-Setup.php global variable configuration from
phpunit.php into a new class called TestSetup, also called it from
parserTests.php.
* Factored out the setup of TestsAutoLoader into a static method in
Maintenance.
* In Setup.php improved "caches" debug output.
PHPUnit frontend:
* Delete the entire contents of NewParserTest and replace it with a
small wrapper around ParserTestRunner. It doesn't inherit from
MediaWikiTestCase anymore since integrating the setup code was an
unnecessary complication.
* Rename MediaWikiParserTest to ParserTestTopLevelSuite and made it an
instantiable TestSuite class instead of just a static method. Got rid
of the eval(), just construct TestCase objects directly with a
specified name, it works just as well.
* Introduce ParserTestFileSuite for per-file setup.
* Remove parser-related options from phpunit.php, since we don't
support them anymore. Note that --filter now works just as well as
--regex used to.
* Add CoreParserTestSuite, equivalent to ExtensionsParserTestSuite,
for clarity.
* Make it possible to call MediaWikiTestCase::setupTestDB() more than
once, as is implied by the documentation.
parserTests.php frontend:
* Made parserTests.php into a Maintenance subclass, moved CLI-specific
code to it.
* Renamed ParserTest to ParserTestRunner, this is now the generic
backend.
* Add --upload-dir option which sets up an FSFileBackend, similar
to the old default behaviour
Test file reading and interpretation:
* Rename TestFileIterator to TestFileReader, and make it read and buffer
an entire file, instead of iterating.
* The previous code had an associative array representation of test
specifications. Used this form more widely to pass around test data.
* Remove the idea of !!hooks copying hooks from $wgParser, this is
unnecessary now that all extensions use ParserFirstCallInit. Resurrect
an old interpretation of the feature which was accidentally broken: if
a named hook does not exist, skip all tests in the file.
* Got rid of the "subtest" idea for tidy variants, instead use a
human-readable description that appears in the output.
* When all tests in a file are filtered or skipped, don't create the
articles in them. This greatly speeds up execution time when --regex
matches a small number of tests. It may possibly break extensions, but
they would have been randomly broken anyway since there is no
guarantee of test file execution order.
* Remove integrated testing of OutputPage::addCategoryLinks() category
link formatting, life is complicated enough already. It can go in
OutputPageTest if that's a thing we really need.
Result recording and display:
* Make TestRecorder into a generic plugin interface for progress output
etc., which needs to be abstracted for PHPUnit integration.
* Introduce MultiTestRecorder for recorder chaining, instead of using
a long inheritance chain. All test recorders now directly inherit from
TestRecorder.
* Move all console-related code to the new ParserTestPrinter.
* Introduce PhpunitTestRecorder, which is the recorder for the PHPUnit
frontend. Most events are ignored since they are never emitted in the
PHPUnit frontend, which does not call runTests().
* Put more information into ParserTestResult and use it more often.
Setup and teardown:
* Introduce a new API for setup/teardown where setup functions return a
ScopedCallback object which automatically performs the corresponding
teardown when it goes out of scope.
* Rename setUp() to staticSetup(), rewrite. There was a lot of cruft in
here which was simply copied from Setup.php without review, and had
nothing to do with parser tests.
* Rename setupGlobals() to perTestSetup(), mostly rewrite. For
performance, give staticSetup() precedence in cases where they were
both setting up the same thing.
* In support of merged setup code, allow Hooks::clear() to be called
from parserTests.php.
* Remove wgFileExtensions -- it is only used by UploadBase which we
don't call.
* Remove wgUseImageResize -- superseded by MockMediaHandlerFactory which
I imported from NewParserTest.
* Import MockFileBackend from NewParserTest. But instead of
customising the configuration globals, I injected services.
* Remove thumbnail deletion from upload teardown. This makes glob
handling as in the old parserTests.php unnecessary.
* Remove math file from upload teardown, math is actually an extension
now! Also, the relevant parser tests were removed from the Math
extension two years ago in favour of unit tests.
* Make addArticle() private, and introduce addArticles() instead, which
allows setup/teardown to be done once for each batch of articles
instead of every time.
* Remove $wgNamespaceAliases and $wgNamespaceProtection setup. These were
copied in from Setup.php in 2010, and are redundant since we do
actually run Setup.php.
* Use NullLockManager, don't set up a temporary directory just for
this alone.
Fuzz tests:
* Use the new TestSetup class.
* Updated for ParserTestRunner interface change.
* Remove some obsolete references to fuzz tests from the two frontends
where they used to reside.
Bug: T41473
Change-Id: Ia8e17008cb9d9b62ce5645e15a41a3b402f4026a
2016-09-08 01:25:22 +00:00
|
|
|
if ( !defined( 'MW_PHPUNIT_TEST' ) && !defined( 'MW_PARSER_TEST' ) ) {
|
2013-04-22 14:38:47 +00:00
|
|
|
throw new MWException( 'Cannot reset hooks in operation.' );
|
2011-01-17 03:35:42 +00:00
|
|
|
}
|
2011-01-26 16:50:31 +00:00
|
|
|
|
2013-04-22 14:38:47 +00:00
|
|
|
unset( self::$handlers[$name] );
|
2006-01-07 12:17:42 +00:00
|
|
|
}
|
2011-01-26 16:50:31 +00:00
|
|
|
|
2011-01-17 03:35:42 +00:00
|
|
|
/**
|
|
|
|
|
* Returns true if a hook has a function registered to it.
|
2012-10-05 16:28:21 +00:00
|
|
|
* The function may have been registered either via Hooks::register or in $wgHooks.
|
2011-01-26 16:50:31 +00:00
|
|
|
*
|
2012-10-05 18:29:26 +00:00
|
|
|
* @since 1.18
|
|
|
|
|
*
|
2013-04-22 14:38:47 +00:00
|
|
|
* @param string $name Name of hook
|
|
|
|
|
* @return bool True if the hook has a function registered to it
|
2011-01-17 03:35:42 +00:00
|
|
|
*/
|
|
|
|
|
public static function isRegistered( $name ) {
|
2012-10-05 16:28:21 +00:00
|
|
|
global $wgHooks;
|
|
|
|
|
return !empty( $wgHooks[$name] ) || !empty( self::$handlers[$name] );
|
2011-01-17 03:35:42 +00:00
|
|
|
}
|
2011-01-26 16:50:31 +00:00
|
|
|
|
2011-01-17 03:35:42 +00:00
|
|
|
/**
|
|
|
|
|
* Returns an array of all the event functions attached to a hook
|
2012-10-05 16:28:21 +00:00
|
|
|
* This combines functions registered via Hooks::register and with $wgHooks.
|
2012-10-05 18:29:26 +00:00
|
|
|
*
|
2013-04-22 14:38:47 +00:00
|
|
|
* @since 1.18
|
2012-10-05 16:28:21 +00:00
|
|
|
*
|
2013-04-22 14:38:47 +00:00
|
|
|
* @param string $name Name of the hook
|
2011-01-17 03:35:42 +00:00
|
|
|
* @return array
|
|
|
|
|
*/
|
|
|
|
|
public static function getHandlers( $name ) {
|
2012-10-05 16:28:21 +00:00
|
|
|
global $wgHooks;
|
|
|
|
|
|
2013-04-22 14:38:47 +00:00
|
|
|
if ( !self::isRegistered( $name ) ) {
|
2016-02-17 09:09:32 +00:00
|
|
|
return [];
|
2013-04-22 14:38:47 +00:00
|
|
|
} elseif ( !isset( self::$handlers[$name] ) ) {
|
|
|
|
|
return $wgHooks[$name];
|
|
|
|
|
} elseif ( !isset( $wgHooks[$name] ) ) {
|
|
|
|
|
return self::$handlers[$name];
|
2012-10-05 16:28:21 +00:00
|
|
|
} else {
|
2013-04-22 14:38:47 +00:00
|
|
|
return array_merge( self::$handlers[$name], $wgHooks[$name] );
|
2012-10-05 16:28:21 +00:00
|
|
|
}
|
2011-01-17 03:35:42 +00:00
|
|
|
}
|
2011-01-26 16:50:31 +00:00
|
|
|
|
2017-08-19 00:33:25 +00:00
|
|
|
/**
|
|
|
|
|
* @param string $event Event name
|
|
|
|
|
* @param array|callable $hook
|
|
|
|
|
* @param array $args Array of parameters passed to hook functions
|
|
|
|
|
* @param string|null $deprecatedVersion [optional]
|
|
|
|
|
* @param string &$fname [optional] Readable name of hook [returned]
|
|
|
|
|
* @return null|string|bool
|
|
|
|
|
*/
|
|
|
|
|
private static function callHook( $event, $hook, array $args, $deprecatedVersion = null,
|
|
|
|
|
&$fname = null
|
|
|
|
|
) {
|
|
|
|
|
// Turn non-array values into an array. (Can't use casting because of objects.)
|
|
|
|
|
if ( !is_array( $hook ) ) {
|
|
|
|
|
$hook = [ $hook ];
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
if ( !array_filter( $hook ) ) {
|
|
|
|
|
// Either array is empty or it's an array filled with null/false/empty.
|
|
|
|
|
return null;
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
if ( is_array( $hook[0] ) ) {
|
|
|
|
|
// First element is an array, meaning the developer intended
|
|
|
|
|
// the first element to be a callback. Merge it in so that
|
|
|
|
|
// processing can be uniform.
|
|
|
|
|
$hook = array_merge( $hook[0], array_slice( $hook, 1 ) );
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
/**
|
|
|
|
|
* $hook can be: a function, an object, an array of $function and
|
|
|
|
|
* $data, an array of just a function, an array of object and
|
|
|
|
|
* method, or an array of object, method, and data.
|
|
|
|
|
*/
|
|
|
|
|
if ( $hook[0] instanceof Closure ) {
|
|
|
|
|
$fname = "hook-$event-closure";
|
|
|
|
|
$callback = array_shift( $hook );
|
|
|
|
|
} elseif ( is_object( $hook[0] ) ) {
|
|
|
|
|
$object = array_shift( $hook );
|
|
|
|
|
$method = array_shift( $hook );
|
|
|
|
|
|
|
|
|
|
// If no method was specified, default to on$event.
|
|
|
|
|
if ( $method === null ) {
|
|
|
|
|
$method = "on$event";
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
$fname = get_class( $object ) . '::' . $method;
|
|
|
|
|
$callback = [ $object, $method ];
|
|
|
|
|
} elseif ( is_string( $hook[0] ) ) {
|
|
|
|
|
$fname = $callback = array_shift( $hook );
|
|
|
|
|
} else {
|
|
|
|
|
throw new MWException( 'Unknown datatype in hooks for ' . $event . "\n" );
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
// Run autoloader (workaround for call_user_func_array bug)
|
|
|
|
|
// and throw error if not callable.
|
|
|
|
|
if ( !is_callable( $callback ) ) {
|
|
|
|
|
throw new MWException( 'Invalid callback ' . $fname . ' in hooks for ' . $event . "\n" );
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
// mark hook as deprecated, if deprecation version is specified
|
|
|
|
|
if ( $deprecatedVersion !== null ) {
|
|
|
|
|
wfDeprecated( "$event hook (used in $fname)", $deprecatedVersion );
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
// Call the hook.
|
|
|
|
|
$hook_args = array_merge( $hook, $args );
|
|
|
|
|
return call_user_func_array( $callback, $hook_args );
|
|
|
|
|
}
|
|
|
|
|
|
2011-01-17 03:35:42 +00:00
|
|
|
/**
|
2013-04-22 14:38:47 +00:00
|
|
|
* Call hook functions defined in Hooks::register and $wgHooks.
|
2011-01-17 03:35:42 +00:00
|
|
|
*
|
2017-08-19 00:33:25 +00:00
|
|
|
* For the given hook event, fetch the array of hook events and
|
2013-04-22 14:38:47 +00:00
|
|
|
* process them. Determine the proper callback for each hook and
|
|
|
|
|
* then call the actual hook using the appropriate arguments.
|
|
|
|
|
* Finally, process the return value and return/throw accordingly.
|
|
|
|
|
*
|
2017-08-19 00:33:25 +00:00
|
|
|
* For hook event that are not abortable through a handler's return value,
|
|
|
|
|
* use runWithoutAbort() instead.
|
|
|
|
|
*
|
2013-04-22 14:38:47 +00:00
|
|
|
* @param string $event Event name
|
2014-07-24 17:42:24 +00:00
|
|
|
* @param array $args Array of parameters passed to hook functions
|
2017-08-19 00:33:25 +00:00
|
|
|
* @param string|null $deprecatedVersion [optional] Mark hook as deprecated with version number
|
2013-04-22 14:38:47 +00:00
|
|
|
* @return bool True if no handler aborted the hook
|
2012-10-05 16:28:21 +00:00
|
|
|
*
|
2014-12-24 13:49:20 +00:00
|
|
|
* @throws Exception
|
|
|
|
|
* @throws FatalError
|
|
|
|
|
* @throws MWException
|
2013-06-24 21:42:20 +00:00
|
|
|
* @since 1.22 A hook function is not required to return a value for
|
|
|
|
|
* processing to continue. Not returning a value (or explicitly
|
|
|
|
|
* returning null) is equivalent to returning true.
|
2011-01-17 03:35:42 +00:00
|
|
|
*/
|
2016-02-17 09:09:32 +00:00
|
|
|
public static function run( $event, array $args = [], $deprecatedVersion = null ) {
|
2013-04-22 14:38:47 +00:00
|
|
|
foreach ( self::getHandlers( $event ) as $hook ) {
|
2017-08-19 00:33:25 +00:00
|
|
|
$retval = self::callHook( $event, $hook, $args, $deprecatedVersion );
|
|
|
|
|
if ( $retval === null ) {
|
2013-04-22 14:38:47 +00:00
|
|
|
continue;
|
|
|
|
|
}
|
2011-01-26 16:50:31 +00:00
|
|
|
|
2013-04-22 14:38:47 +00:00
|
|
|
// Process the return value.
|
2011-01-17 03:35:42 +00:00
|
|
|
if ( is_string( $retval ) ) {
|
2013-04-22 14:38:47 +00:00
|
|
|
// String returned means error.
|
2011-11-09 10:59:17 +00:00
|
|
|
throw new FatalError( $retval );
|
2013-06-24 21:42:20 +00:00
|
|
|
} elseif ( $retval === false ) {
|
2013-04-22 14:38:47 +00:00
|
|
|
// False was returned. Stop processing, but no error.
|
2011-01-17 03:35:42 +00:00
|
|
|
return false;
|
2010-07-28 21:05:15 +00:00
|
|
|
}
|
2006-01-07 12:17:42 +00:00
|
|
|
}
|
2011-01-26 16:50:31 +00:00
|
|
|
|
2011-01-17 03:35:42 +00:00
|
|
|
return true;
|
2004-11-27 21:43:06 +00:00
|
|
|
}
|
2017-08-19 00:33:25 +00:00
|
|
|
|
|
|
|
|
/**
|
|
|
|
|
* Call hook functions defined in Hooks::register and $wgHooks.
|
|
|
|
|
*
|
|
|
|
|
* @param string $event Event name
|
|
|
|
|
* @param array $args Array of parameters passed to hook functions
|
|
|
|
|
* @param string|null $deprecatedVersion [optional] Mark hook as deprecated with version number
|
|
|
|
|
* @return bool Always true
|
|
|
|
|
* @throws MWException If a callback is invalid, unknown
|
|
|
|
|
* @throws UnexpectedValueException If a callback returns an abort value.
|
|
|
|
|
* @since 1.30
|
|
|
|
|
*/
|
|
|
|
|
public static function runWithoutAbort( $event, array $args = [], $deprecatedVersion = null ) {
|
|
|
|
|
foreach ( self::getHandlers( $event ) as $hook ) {
|
|
|
|
|
$fname = null;
|
|
|
|
|
$retval = self::callHook( $event, $hook, $args, $deprecatedVersion, $fname );
|
|
|
|
|
if ( $retval !== null && $retval !== true ) {
|
|
|
|
|
throw new UnexpectedValueException( "Invalid return from $fname for unabortable $event." );
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
return true;
|
|
|
|
|
}
|
2010-07-28 21:05:15 +00:00
|
|
|
}
|