wiki.techinc.nl/tests/phpunit/includes/http/HttpTest.php

<?php

/**
 * @covers Http
 * @group Http
 * @group small
 */
class HttpTest extends MediaWikiTestCase {

	/**
	 * @covers Http::getProxy
	 */
	public function testGetProxy() {
		$this->hideDeprecated( 'Http::getProxy' );

		$this->setMwGlobals( 'wgHTTPProxy', false );
		$this->assertSame(
			'',
			Http::getProxy(),
			'default setting'
		);

		$this->setMwGlobals( 'wgHTTPProxy', 'proxy.domain.tld' );
		$this->assertEquals(
			'proxy.domain.tld',
			Http::getProxy()
		);
	}

}
Per wikitech-l discussion: Move tests from maintenance/tests/ to tests/. They're not strictly maintenance scripts, and some people want to do a selective checkout that doesn't include the tests. There's still debate on whether we should include these in the release downloads, but we had a pretty firm consensus to move this. 2010-12-14 16:26:35 +00:00			`<?php`
Add cURL constants test Bug: 70570 Change-Id: I217470638adc1973ebe1227cc9fb65e1c3fab1b7 2014-09-08 19:45:46 +00:00
Per wikitech-l discussion: Move tests from maintenance/tests/ to tests/. They're not strictly maintenance scripts, and some people want to do a selective checkout that doesn't include the tests. There's still debate on whether we should include these in the release downloads, but we had a pretty firm consensus to move this. 2010-12-14 16:26:35 +00:00			`/**`
Add tests for HttpRequestFactoryTest. This also moves several tests out of HttpTest, so they are not lost when the deprecated Http class is removed. Bug: T222935 Change-Id: Ib4aac96ba1a978e8b6738ed446663afc3cc8c792 2019-05-13 10:38:00 +00:00			`* @covers Http`
Add cURL constants test Bug: 70570 Change-Id: I217470638adc1973ebe1227cc9fb65e1c3fab1b7 2014-09-08 19:45:46 +00:00			`* @group Http`
phpunit: Add some @covers and @large/@medium to integration tests - @small: single class, no I/O (unit test). - @medium: multi-class (partial or no mocks), no I/O (unit/integration test). - @large: multi-class, I/O allowed (integration test). Change-Id: I09317e6dd9b0ee34b7467fbffdd07957ef55dc04 2018-03-20 16:14:34 +00:00			`* @group small`
Per wikitech-l discussion: Move tests from maintenance/tests/ to tests/. They're not strictly maintenance scripts, and some people want to do a selective checkout that doesn't include the tests. There's still debate on whether we should include these in the release downloads, but we had a pretty firm consensus to move this. 2010-12-14 16:26:35 +00:00			`*/`
* verbose and color default output from phpunit * Make a bunch of tests subclass MediaWikiTestCase * Parser tests and ResourceLoaderTest can't subclass it yet due to various issues 2010-12-28 18:17:16 +00:00			`class HttpTest extends MediaWikiTestCase {`
Per wikitech-l discussion: Move tests from maintenance/tests/ to tests/. They're not strictly maintenance scripts, and some people want to do a selective checkout that doesn't include the tests. There's still debate on whether we should include these in the release downloads, but we had a pretty firm consensus to move this. 2010-12-14 16:26:35 +00:00
Http::getProxy() method to get proxy configuration MediaWiki currently uses two sources for proxy configuration: * the $wgHTTPProxy global configuration variable * the http_proxy environment variable The HTTP proxy adress to use is a valuable information for extensions handling directly HTTP requests instead of use helper classes provided by the core to construct them. This change offers an Http::getProxy() utility method to get the configuration, regardless of the source. Bug: T117954 Change-Id: I5df31845df71f05ac581f532cc9bd7a1fea25583 2016-03-25 15:10:19 +00:00			`/**`
			`* @covers Http::getProxy`
			`*/`
			`public function testGetProxy() {`
Deprecate the Http class All methods got moved to HttpRequestFactory or MWHttpRequest or dropped. I made the return value of the new HttpRequestFactory::request/get/post methods null on error instead of false, so that when we drop PHP 7 support, we can use a "?string" return value. This could theoretically change behavior of code that was switched from the old Http methods, but probably won't. I kept the old behavior for the deprecated methods. I changed the default value of $wgHTTPProxy from false to ''. This way it should be usable directly without a trivial wrapper method. For the benefit of anyone who might have set it to false in LocalSettings.php, I also recommend casting to string just in case. Http::$httpEngine is deprecated. Eventually it will be removed along with the curl and PHP engines, leaving only the Guzlle engine. I also added deprecation of MWHttpRequest::factory, which occurred in 1.31, to the release notes for 1.34. Now hopefully we can hard-deprecate it in another couple of versions. Bug: T214390 Change-Id: I2a316a758d793857f248bd251b90f5e9a6440e3a 2019-04-15 13:23:02 +00:00			`$this->hideDeprecated( 'Http::getProxy' );`

HttpFunctions: Increase code coverage * Complete coverage for Http::getProxy(). * Remove bogus @covers tag on data provider, and add the relevant MWHttpRequest::getFinalUrl to the test instead. * Convert test to use dataProvider and add missing test cases to increase getFinalUrl() test coverage to 100%. * Minor clean up in getFinalUrl to consistently use early-return for all cases, not just for relative 'domain' and 'isset-host' cases. Without this coverage actually couldn't reach 100% due to the remainder of the empty else branch never being reached (CRAP: "Redundant 'else' after 'return'") Change-Id: I775d95965dc23a1e6c4c62ed84f9da64b6c72135 2017-03-29 00:21:15 +00:00			`$this->setMwGlobals( 'wgHTTPProxy', false );`
tests: Prefer PHPUnit's assertSame() when comparing empty strings assertSame() is guaranteed to never do any magic type conversion. This can be critical when accidentially comparing empty strings (a value PHP considers to be "falsy") to false, 0, 0.0, null, and such. Change-Id: I2e2685c5992cae252f629a68ffe1a049f2e5ed1b 2019-09-17 14:28:35 +00:00			`$this->assertSame(`
HttpFunctions: Increase code coverage * Complete coverage for Http::getProxy(). * Remove bogus @covers tag on data provider, and add the relevant MWHttpRequest::getFinalUrl to the test instead. * Convert test to use dataProvider and add missing test cases to increase getFinalUrl() test coverage to 100%. * Minor clean up in getFinalUrl to consistently use early-return for all cases, not just for relative 'domain' and 'isset-host' cases. Without this coverage actually couldn't reach 100% due to the remainder of the empty else branch never being reached (CRAP: "Redundant 'else' after 'return'") Change-Id: I775d95965dc23a1e6c4c62ed84f9da64b6c72135 2017-03-29 00:21:15 +00:00			`'',`
			`Http::getProxy(),`
			`'default setting'`
			`);`

Http::getProxy() method to get proxy configuration MediaWiki currently uses two sources for proxy configuration: * the $wgHTTPProxy global configuration variable * the http_proxy environment variable The HTTP proxy adress to use is a valuable information for extensions handling directly HTTP requests instead of use helper classes provided by the core to construct them. This change offers an Http::getProxy() utility method to get the configuration, regardless of the source. Bug: T117954 Change-Id: I5df31845df71f05ac581f532cc9bd7a1fea25583 2016-03-25 15:10:19 +00:00			`$this->setMwGlobals( 'wgHTTPProxy', 'proxy.domain.tld' );`
			`$this->assertEquals(`
			`'proxy.domain.tld',`
			`Http::getProxy()`
			`);`
			`}`

Per wikitech-l discussion: Move tests from maintenance/tests/ to tests/. They're not strictly maintenance scripts, and some people want to do a selective checkout that doesn't include the tests. There's still debate on whether we should include these in the release downloads, but we had a pretty firm consensus to move this. 2010-12-14 16:26:35 +00:00			`}`