wiki.techinc.nl/tests/selenium/selenium.sh

#!/usr/bin/env bash
set -euo pipefail
# Check the command before running in background so
# that it can actually fail and have a descriptive error
hash chromedriver
chromedriver --url-base=wd/hub --port=4444 &
CHROME_DRIVER_PID=$!
echo chromedriver running with PID $CHROME_DRIVER_PID
# Make sure it is killed to prevent file descriptors leak
function kill_chromedriver() {
    # Use kill instead of killall to increase chances of this working on Windows
    kill $CHROME_DRIVER_PID > /dev/null
}
trap kill_chromedriver EXIT
npm run selenium-test
Selenium: move logic for running tests from package.json to selenium.sh Just running `npm run selenium` in CI does not work. If WebdriverIO fails, the job still passes since the last command to run is `killall chromedriver`. Reusing the script from CI that starts and stops Chromedriver should fix the problem. Bug: T179190 Change-Id: If29227263d23a3e4f26e2329dfa13c49f976cf8e 2018-04-07 14:35:26 +00:00			`#!/usr/bin/env bash`
			`set -euo pipefail`
selenium: Run wdio directly without grunt Doesn't seem to add anything, except complexity. This has the benefit of matching more closely the way the README recommends running individual tests. Also add a check for 'chromedriver' before running it. Normally the -e and pipefail would suffice, but because it runs in the background, the error can be buried, hard to find, or even not cause exit code to be set properly. Thus, do a simple 'hash' check that will print a useful command and exit cleanly. Before: > $ something & > [1] 57922 > -bash: something: command not found > [1]+ Exit 127 something > $ echo $? > 0 After: > $ hash something > -bash: hash: something: not found > (exit: 1) $ echo $? > 1 Change-Id: Id95f18927b5443defe679a77a82c5cbdd127c716 2018-04-21 01:10:56 +00:00			`# Check the command before running in background so`
			`# that it can actually fail and have a descriptive error`
			`hash chromedriver`
Use wd/hub not /wd/hub in selenium.sh I have run into this before and we fixed it in the README but not in this script (I wasn't using this script at the time) This was changed in the README in change: I85a9e7dbd9a66418c85585969adb5ac1548f5ef6 Bug: T182421 Change-Id: I6ab92c6a61a57dc313b05321d0789dcbeb776c94 2018-06-07 16:27:06 +00:00			`chromedriver --url-base=wd/hub --port=4444 &`
Don't use killall in selenium.sh git bash for windows apparently doesn't have killall by default, so instead get the PID of the chrome driver we start and kill that specifically. Change-Id: I8a9a773a7d3dc23807dc3ec12f5b3ef03661c9e3 2018-06-07 16:20:59 +00:00			`CHROME_DRIVER_PID=$!`
			`echo chromedriver running with PID $CHROME_DRIVER_PID`
Selenium: move logic for running tests from package.json to selenium.sh Just running `npm run selenium` in CI does not work. If WebdriverIO fails, the job still passes since the last command to run is `killall chromedriver`. Reusing the script from CI that starts and stops Chromedriver should fix the problem. Bug: T179190 Change-Id: If29227263d23a3e4f26e2329dfa13c49f976cf8e 2018-04-07 14:35:26 +00:00			`# Make sure it is killed to prevent file descriptors leak`
			`function kill_chromedriver() {`
Don't use killall in selenium.sh git bash for windows apparently doesn't have killall by default, so instead get the PID of the chrome driver we start and kill that specifically. Change-Id: I8a9a773a7d3dc23807dc3ec12f5b3ef03661c9e3 2018-06-07 16:20:59 +00:00			`# Use kill instead of killall to increase chances of this working on Windows`
			`kill $CHROME_DRIVER_PID > /dev/null`
Selenium: move logic for running tests from package.json to selenium.sh Just running `npm run selenium` in CI does not work. If WebdriverIO fails, the job still passes since the last command to run is `killall chromedriver`. Reusing the script from CI that starts and stops Chromedriver should fix the problem. Bug: T179190 Change-Id: If29227263d23a3e4f26e2329dfa13c49f976cf8e 2018-04-07 14:35:26 +00:00			`}`
			`trap kill_chromedriver EXIT`
selenium: Abstract test command behind 'npm run' This makes it possible to use in Quibble. Right now, Quibble cannot use 'npm run selenium' yet because it sets up its own chromedriver, which would conflict with selenium.sh. But, in preparation for Id95f18927b5, we can at least abstract the test command so that it can easily be changed without having to update Quibble and without having to worry about it being the same in all MediaWiki branches. Bug: T179190 Change-Id: I622ec3bf36746502cae891cc6bec23982b21f876 2018-04-23 14:56:54 +00:00			`npm run selenium-test`