Thijs/wiki.techinc.nl
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions
wiki.techinc.nl/resources/mediawiki.special/mediawiki.special.block.js

47 lines
1.3 KiB
JavaScript
Raw Normal View History

Convert Special:BlockIP JS to jQuery/ResourceLoader. Change the order of the checkboxes on the block form so that options which appear/disappear when the type of user is changed are grouped together.
2011-03-03 23:54:39 +00:00
/* JavaScript for Special:Block */
Moving IP-check to mw.util & some enhancements to and applying code conventions to mw.special.block.js * This commit addresses the @TODOs that were in mediawiki.legacy.block before it was migrated to /resources in r83183 ("@TODO: find some better JS file for [is IP functions]") * JSHint warning fixed: Using ==== when comparing to '' (safer and faster than ==) * Instead of checking the initial onload state by faking a onkeyup/onchange event, seperate the two functions and use those ** --> This fixes issue where it falsely triggers other bindings on-load that are globally bound to input elements via $('input').live() or $('[type="text"]').delegate() because of the .keyup()/.change() call ) * Caching selectors (var $wpBlockExpiry = $(..) etc.) instead of re-creating a dozen jQuery objects again and getting the document element by id – on *every* onkeyup/onchange ** --> Notable speed improvement in Safari 3 and IE6 with the caching, these had a little bit of a lag when typing fast, mw.legacy.block.js had the lag as well. Fixed now. * Adding instantToggle-argument to switch between fade or hiding/showing right away. When setting the initial state they're called with instant=true so that there's no fading, the page loads and stuff hides that shouldn't be visible. Any later interaction will still have the fade. ** Calling a function like foo(true) sucks, adding a local DO_INSTANT = true. * Making behaviour the same as the legacy.block was (if isEmpty, do bring the element back to view ( show() / fadeIn) instead of doing nothing)
2011-03-04 01:48:24 +00:00
Convert Special:BlockIP JS to jQuery/ResourceLoader. Change the order of the checkboxes on the block form so that options which appear/disappear when the type of user is changed are grouped together.
2011-03-03 23:54:39 +00:00
jQuery( function( $ ) {
Moving IP-check to mw.util & some enhancements to and applying code conventions to mw.special.block.js * This commit addresses the @TODOs that were in mediawiki.legacy.block before it was migrated to /resources in r83183 ("@TODO: find some better JS file for [is IP functions]") * JSHint warning fixed: Using ==== when comparing to '' (safer and faster than ==) * Instead of checking the initial onload state by faking a onkeyup/onchange event, seperate the two functions and use those ** --> This fixes issue where it falsely triggers other bindings on-load that are globally bound to input elements via $('input').live() or $('[type="text"]').delegate() because of the .keyup()/.change() call ) * Caching selectors (var $wpBlockExpiry = $(..) etc.) instead of re-creating a dozen jQuery objects again and getting the document element by id – on *every* onkeyup/onchange ** --> Notable speed improvement in Safari 3 and IE6 with the caching, these had a little bit of a lag when typing fast, mw.legacy.block.js had the lag as well. Fixed now. * Adding instantToggle-argument to switch between fade or hiding/showing right away. When setting the initial state they're called with instant=true so that there's no fading, the page loads and stuff hides that shouldn't be visible. Any later interaction will still have the fade. ** Calling a function like foo(true) sucks, adding a local DO_INSTANT = true. * Making behaviour the same as the legacy.block was (if isEmpty, do bring the element back to view ( show() / fadeIn) instead of doing nothing)
2011-03-04 01:48:24 +00:00
var DO_INSTANT = true,
Divert a river through the Augean Stables that is SpecialBlockip.php. * Move to SpecialBlock.php, and rename class appropriately * Complete refactor * Use HTMLForm in block form. This changes most of the ids and field names on the form, but allows proper validation, nicer formatting, clears up several fixmes, and is generally Better(TM). * Spin various parts out into static functions, several of which properly belong in the backend (but Block.php is a worse mess still) * Invert some of the block options so that every checkbox makes the block more severe (so "check to disable email" is fine, but "check to allow usertalk edit" (default true) is inverted to "check to disable usertalk edit" (default false). * revert r40359 (move doMassUserBlock() to core). No one seems to be using this function, which has nothing to do with the frontend UI in SpecialBlock (it might perhaps belong in Block.php); it is pretty bespoke for CheckUser, doesn't seem to have very much utility elsewhere.
2011-03-12 21:54:35 +00:00
$blockTarget = $( '#mw-bi-target' ),
Fixed case of ID in selector
2011-10-01 06:16:08 +00:00
$anonOnlyRow = $( '#mw-input-wpHardBlock' ).closest( 'tr' ),
Divert a river through the Augean Stables that is SpecialBlockip.php. * Move to SpecialBlock.php, and rename class appropriately * Complete refactor * Use HTMLForm in block form. This changes most of the ids and field names on the form, but allows proper validation, nicer formatting, clears up several fixmes, and is generally Better(TM). * Spin various parts out into static functions, several of which properly belong in the backend (but Block.php is a worse mess still) * Invert some of the block options so that every checkbox makes the block more severe (so "check to disable email" is fine, but "check to allow usertalk edit" (default true) is inverted to "check to disable usertalk edit" (default false). * revert r40359 (move doMassUserBlock() to core). No one seems to be using this function, which has nothing to do with the frontend UI in SpecialBlock (it might perhaps belong in Block.php); it is pretty bespoke for CheckUser, doesn't seem to have very much utility elsewhere.
2011-03-12 21:54:35 +00:00
$enableAutoblockRow = $( '#mw-input-wpAutoBlock' ).closest( 'tr' ),
$hideUser = $( '#mw-input-wpHideUser' ).closest( 'tr' ),
$watchUser = $( '#mw-input-wpWatch' ).closest( 'tr' );
Moving IP-check to mw.util & some enhancements to and applying code conventions to mw.special.block.js * This commit addresses the @TODOs that were in mediawiki.legacy.block before it was migrated to /resources in r83183 ("@TODO: find some better JS file for [is IP functions]") * JSHint warning fixed: Using ==== when comparing to '' (safer and faster than ==) * Instead of checking the initial onload state by faking a onkeyup/onchange event, seperate the two functions and use those ** --> This fixes issue where it falsely triggers other bindings on-load that are globally bound to input elements via $('input').live() or $('[type="text"]').delegate() because of the .keyup()/.change() call ) * Caching selectors (var $wpBlockExpiry = $(..) etc.) instead of re-creating a dozen jQuery objects again and getting the document element by id – on *every* onkeyup/onchange ** --> Notable speed improvement in Safari 3 and IE6 with the caching, these had a little bit of a lag when typing fast, mw.legacy.block.js had the lag as well. Fixed now. * Adding instantToggle-argument to switch between fade or hiding/showing right away. When setting the initial state they're called with instant=true so that there's no fading, the page loads and stuff hides that shouldn't be visible. Any later interaction will still have the fade. ** Calling a function like foo(true) sucks, adding a local DO_INSTANT = true. * Making behaviour the same as the legacy.block was (if isEmpty, do bring the element back to view ( show() / fadeIn) instead of doing nothing)
2011-03-04 01:48:24 +00:00
var updateBlockOptions = function( instant ) {
if ( !$blockTarget.length ) {
return;
Convert Special:BlockIP JS to jQuery/ResourceLoader. Change the order of the checkboxes on the block form so that options which appear/disappear when the type of user is changed are grouped together.
2011-03-03 23:54:39 +00:00
}
Moving IP-check to mw.util & some enhancements to and applying code conventions to mw.special.block.js * This commit addresses the @TODOs that were in mediawiki.legacy.block before it was migrated to /resources in r83183 ("@TODO: find some better JS file for [is IP functions]") * JSHint warning fixed: Using ==== when comparing to '' (safer and faster than ==) * Instead of checking the initial onload state by faking a onkeyup/onchange event, seperate the two functions and use those ** --> This fixes issue where it falsely triggers other bindings on-load that are globally bound to input elements via $('input').live() or $('[type="text"]').delegate() because of the .keyup()/.change() call ) * Caching selectors (var $wpBlockExpiry = $(..) etc.) instead of re-creating a dozen jQuery objects again and getting the document element by id – on *every* onkeyup/onchange ** --> Notable speed improvement in Safari 3 and IE6 with the caching, these had a little bit of a lag when typing fast, mw.legacy.block.js had the lag as well. Fixed now. * Adding instantToggle-argument to switch between fade or hiding/showing right away. When setting the initial state they're called with instant=true so that there's no fading, the page loads and stuff hides that shouldn't be visible. Any later interaction will still have the fade. ** Calling a function like foo(true) sucks, adding a local DO_INSTANT = true. * Making behaviour the same as the legacy.block was (if isEmpty, do bring the element back to view ( show() / fadeIn) instead of doing nothing)
2011-03-04 01:48:24 +00:00
var blocktarget = $.trim( $blockTarget.val() );
var isEmpty = ( blocktarget === '' );
var isIp = mw.util.isIPv4Address( blocktarget, true ) || mw.util.isIPv6Address( blocktarget, true );
var isIpRange = isIp && blocktarget.match( /\/\d+$/ );
if ( isIp && !isEmpty ) {
$enableAutoblockRow.goOut( instant );
$hideUser.goOut( instant );
Convert Special:BlockIP JS to jQuery/ResourceLoader. Change the order of the checkboxes on the block form so that options which appear/disappear when the type of user is changed are grouped together.
2011-03-03 23:54:39 +00:00
} else {
Moving IP-check to mw.util & some enhancements to and applying code conventions to mw.special.block.js * This commit addresses the @TODOs that were in mediawiki.legacy.block before it was migrated to /resources in r83183 ("@TODO: find some better JS file for [is IP functions]") * JSHint warning fixed: Using ==== when comparing to '' (safer and faster than ==) * Instead of checking the initial onload state by faking a onkeyup/onchange event, seperate the two functions and use those ** --> This fixes issue where it falsely triggers other bindings on-load that are globally bound to input elements via $('input').live() or $('[type="text"]').delegate() because of the .keyup()/.change() call ) * Caching selectors (var $wpBlockExpiry = $(..) etc.) instead of re-creating a dozen jQuery objects again and getting the document element by id – on *every* onkeyup/onchange ** --> Notable speed improvement in Safari 3 and IE6 with the caching, these had a little bit of a lag when typing fast, mw.legacy.block.js had the lag as well. Fixed now. * Adding instantToggle-argument to switch between fade or hiding/showing right away. When setting the initial state they're called with instant=true so that there's no fading, the page loads and stuff hides that shouldn't be visible. Any later interaction will still have the fade. ** Calling a function like foo(true) sucks, adding a local DO_INSTANT = true. * Making behaviour the same as the legacy.block was (if isEmpty, do bring the element back to view ( show() / fadeIn) instead of doing nothing)
2011-03-04 01:48:24 +00:00
$enableAutoblockRow.goIn( instant );
$hideUser.goIn( instant );
Convert Special:BlockIP JS to jQuery/ResourceLoader. Change the order of the checkboxes on the block form so that options which appear/disappear when the type of user is changed are grouped together.
2011-03-03 23:54:39 +00:00
}
Moving IP-check to mw.util & some enhancements to and applying code conventions to mw.special.block.js * This commit addresses the @TODOs that were in mediawiki.legacy.block before it was migrated to /resources in r83183 ("@TODO: find some better JS file for [is IP functions]") * JSHint warning fixed: Using ==== when comparing to '' (safer and faster than ==) * Instead of checking the initial onload state by faking a onkeyup/onchange event, seperate the two functions and use those ** --> This fixes issue where it falsely triggers other bindings on-load that are globally bound to input elements via $('input').live() or $('[type="text"]').delegate() because of the .keyup()/.change() call ) * Caching selectors (var $wpBlockExpiry = $(..) etc.) instead of re-creating a dozen jQuery objects again and getting the document element by id – on *every* onkeyup/onchange ** --> Notable speed improvement in Safari 3 and IE6 with the caching, these had a little bit of a lag when typing fast, mw.legacy.block.js had the lag as well. Fixed now. * Adding instantToggle-argument to switch between fade or hiding/showing right away. When setting the initial state they're called with instant=true so that there's no fading, the page loads and stuff hides that shouldn't be visible. Any later interaction will still have the fade. ** Calling a function like foo(true) sucks, adding a local DO_INSTANT = true. * Making behaviour the same as the legacy.block was (if isEmpty, do bring the element back to view ( show() / fadeIn) instead of doing nothing)
2011-03-04 01:48:24 +00:00
if ( !isIp && !isEmpty ) {
$anonOnlyRow.goOut( instant );
} else {
$anonOnlyRow.goIn( instant );
}
if ( isIpRange && !isEmpty ) {
$watchUser.goOut( instant );
} else {
$watchUser.goIn( instant );
}
};
// Bind functions so they're checked whenever stuff changes
$blockTarget.keyup( updateBlockOptions );
// Call them now to set initial state (ie. Special:Block/Foobar?wpBlockExpiry=2+hours)
updateBlockOptions( DO_INSTANT );
Fixed case of ID in selector
2011-10-01 06:16:08 +00:00
});
Reference in a new issue Copy permalink