2020-04-17 01:30:38 +00:00
|
|
|
<?php
|
|
|
|
|
|
|
|
|
|
/**
|
|
|
|
|
* This program is free software; you can redistribute it and/or modify
|
|
|
|
|
* it under the terms of the GNU General Public License as published by
|
|
|
|
|
* the Free Software Foundation; either version 2 of the License, or
|
|
|
|
|
* (at your option) any later version.
|
|
|
|
|
*
|
|
|
|
|
* This program is distributed in the hope that it will be useful,
|
|
|
|
|
* but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
|
|
|
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
|
|
|
* GNU General Public License for more details.
|
|
|
|
|
*
|
|
|
|
|
* You should have received a copy of the GNU General Public License along
|
|
|
|
|
* with this program; if not, write to the Free Software Foundation, Inc.,
|
|
|
|
|
* 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
|
|
|
|
|
* http://www.gnu.org/copyleft/gpl.html
|
|
|
|
|
*
|
|
|
|
|
* @file
|
2020-04-28 22:54:18 +00:00
|
|
|
* @author DannyS712
|
2020-04-17 01:30:38 +00:00
|
|
|
*/
|
|
|
|
|
|
|
|
|
|
namespace MediaWiki\Page;
|
|
|
|
|
|
2021-03-26 22:56:39 +00:00
|
|
|
use ActorMigration;
|
2021-08-20 19:56:10 +00:00
|
|
|
use BagOStuff;
|
|
|
|
|
use CommentStore;
|
2021-03-26 22:56:39 +00:00
|
|
|
use Config;
|
2020-05-30 19:10:58 +00:00
|
|
|
use ContentModelChange;
|
2021-08-20 19:56:10 +00:00
|
|
|
use JobQueueGroup;
|
2021-09-08 22:07:01 +00:00
|
|
|
use MediaWiki\Cache\BacklinkCacheFactory;
|
2021-08-24 19:12:39 +00:00
|
|
|
use MediaWiki\Collation\CollationFactory;
|
2020-04-17 01:30:38 +00:00
|
|
|
use MediaWiki\Config\ServiceOptions;
|
|
|
|
|
use MediaWiki\Content\IContentHandlerFactory;
|
2020-05-13 21:30:46 +00:00
|
|
|
use MediaWiki\EditPage\SpamChecker;
|
Hooks::run() call site migration
Migrate all callers of Hooks::run() to use the new
HookContainer/HookRunner system.
General principles:
* Use DI if it is already used. We're not changing the way state is
managed in this patch.
* HookContainer is always injected, not HookRunner. HookContainer
is a service, it's a more generic interface, it is the only
thing that provides isRegistered() which is needed in some cases,
and a HookRunner can be efficiently constructed from it
(confirmed by benchmark). Because HookContainer is needed
for object construction, it is also needed by all factories.
* "Ask your friendly local base class". Big hierarchies like
SpecialPage and ApiBase have getHookContainer() and getHookRunner()
methods in the base class, and classes that extend that base class
are not expected to know or care where the base class gets its
HookContainer from.
* ProtectedHookAccessorTrait provides protected getHookContainer() and
getHookRunner() methods, getting them from the global service
container. The point of this is to ease migration to DI by ensuring
that call sites ask their local friendly base class rather than
getting a HookRunner from the service container directly.
* Private $this->hookRunner. In some smaller classes where accessor
methods did not seem warranted, there is a private HookRunner property
which is accessed directly. Very rarely (two cases), there is a
protected property, for consistency with code that conventionally
assumes protected=private, but in cases where the class might actually
be overridden, a protected accessor is preferred over a protected
property.
* The last resort: Hooks::runner(). Mostly for static, file-scope and
global code. In a few cases it was used for objects with broken
construction schemes, out of horror or laziness.
Constructors with new required arguments:
* AuthManager
* BadFileLookup
* BlockManager
* ClassicInterwikiLookup
* ContentHandlerFactory
* ContentSecurityPolicy
* DefaultOptionsManager
* DerivedPageDataUpdater
* FullSearchResultWidget
* HtmlCacheUpdater
* LanguageFactory
* LanguageNameUtils
* LinkRenderer
* LinkRendererFactory
* LocalisationCache
* MagicWordFactory
* MessageCache
* NamespaceInfo
* PageEditStash
* PageHandlerFactory
* PageUpdater
* ParserFactory
* PermissionManager
* RevisionStore
* RevisionStoreFactory
* SearchEngineConfig
* SearchEngineFactory
* SearchFormWidget
* SearchNearMatcher
* SessionBackend
* SpecialPageFactory
* UserNameUtils
* UserOptionsManager
* WatchedItemQueryService
* WatchedItemStore
Constructors with new optional arguments:
* DefaultPreferencesFactory
* Language
* LinkHolderArray
* MovePage
* Parser
* ParserCache
* PasswordReset
* Router
setHookContainer() now required after construction:
* AuthenticationProvider
* ResourceLoaderModule
* SearchEngine
Change-Id: Id442b0dbe43aba84bd5cf801d86dedc768b082c7
2020-03-19 02:42:09 +00:00
|
|
|
use MediaWiki\HookContainer\HookContainer;
|
2021-03-02 21:29:46 +00:00
|
|
|
use MediaWiki\Permissions\Authority;
|
2020-04-17 01:30:38 +00:00
|
|
|
use MediaWiki\Revision\RevisionStore;
|
2021-10-06 22:07:55 +00:00
|
|
|
use MediaWiki\Storage\PageUpdaterFactory;
|
2021-04-19 00:57:23 +00:00
|
|
|
use MediaWiki\User\ActorNormalization;
|
2021-04-24 04:54:48 +00:00
|
|
|
use MediaWiki\User\UserEditTracker;
|
2021-03-02 01:28:23 +00:00
|
|
|
use MediaWiki\User\UserFactory;
|
2021-03-26 22:56:39 +00:00
|
|
|
use MediaWiki\User\UserIdentity;
|
2020-04-28 22:54:18 +00:00
|
|
|
use MergeHistory;
|
2020-04-17 01:30:38 +00:00
|
|
|
use MovePage;
|
|
|
|
|
use NamespaceInfo;
|
2021-08-30 20:55:05 +00:00
|
|
|
use Psr\Log\LoggerInterface;
|
2021-03-26 22:56:39 +00:00
|
|
|
use ReadOnlyMode;
|
2020-04-17 01:30:38 +00:00
|
|
|
use RepoGroup;
|
|
|
|
|
use Title;
|
2021-05-14 00:52:32 +00:00
|
|
|
use TitleFactory;
|
2021-03-26 22:56:39 +00:00
|
|
|
use TitleFormatter;
|
2020-04-17 01:30:38 +00:00
|
|
|
use WatchedItemStoreInterface;
|
DeletePage: add option to delete the associated talk page
Currently this is implemented internally as a second method call. In the
future, it might be possible to optimize the implementation, e.g. to
reduce the amount of DB queries/jobs etc. without changing anything for
callers.
Since the implementation of e.g. the result getters is generic, a future
commit may add an option to delete subpages with relatively low effort.
The revision limit for big deletions is now using the total number of
revisions (base page + talk page). This is because both deletions would
happen in the same main transaction, and we presumably want to optimize
the deletion as a whole, not as two separated steps. This would become
even more important if the aforementioned improvements are ever
implemented. Note, the whole concept of "big deletion" might have been
superseded by batched deletions in the author's opinion, but as long as
such a limit exists, it should serve its purpose.
The current interpretation of the associated talk option is that the
request is validated, and an exception is raised if we cannot delete the
associated talk, as opposed to silently ignoring the parameter if the
talk cannot be deleted. The only exception to this is that it will not
fail hard if the talk page turns out not to exist by the time the
deletion is attempted, as that's hard to foresee due to race conditions.
Note that the summary for the talk deletion is prefixed with the
delete-talk-summary-prefix message. The main reason behind this is that
the delete UI can sometimes offer an auto-generated summary like "the
only contributor was XXX" or "the content was YYY", and since this may
not apply to the talk page as well, the log entry might look confusing.
Bug: T263209
Bug: T27471
Change-Id: Ife1f4e8258a69528dd1ce8fef8ae809761aa6f1d
2021-09-01 12:56:43 +00:00
|
|
|
use Wikimedia\Message\ITextFormatter;
|
2021-08-20 19:56:10 +00:00
|
|
|
use Wikimedia\Rdbms\LBFactory;
|
2020-05-30 19:10:58 +00:00
|
|
|
use WikiPage;
|
2020-04-17 01:30:38 +00:00
|
|
|
|
|
|
|
|
/**
|
|
|
|
|
* Common factory to construct page handling classes.
|
|
|
|
|
*
|
|
|
|
|
* @since 1.35
|
|
|
|
|
*/
|
2021-03-26 22:56:39 +00:00
|
|
|
class PageCommandFactory implements
|
|
|
|
|
ContentModelChangeFactory,
|
2021-08-20 19:56:10 +00:00
|
|
|
DeletePageFactory,
|
2021-03-26 22:56:39 +00:00
|
|
|
MergeHistoryFactory,
|
|
|
|
|
MovePageFactory,
|
2021-08-30 20:55:05 +00:00
|
|
|
RollbackPageFactory,
|
|
|
|
|
UndeletePageFactory
|
2021-03-26 22:56:39 +00:00
|
|
|
{
|
|
|
|
|
|
|
|
|
|
/** @var Config */
|
|
|
|
|
private $config;
|
2020-04-17 01:30:38 +00:00
|
|
|
|
2021-08-20 19:56:10 +00:00
|
|
|
/** @var LBFactory */
|
|
|
|
|
private $lbFactory;
|
2020-04-17 01:30:38 +00:00
|
|
|
|
|
|
|
|
/** @var NamespaceInfo */
|
2020-05-30 19:10:58 +00:00
|
|
|
private $namespaceInfo;
|
2020-04-17 01:30:38 +00:00
|
|
|
|
|
|
|
|
/** @var WatchedItemStoreInterface */
|
2020-04-28 22:54:18 +00:00
|
|
|
private $watchedItemStore;
|
2020-04-17 01:30:38 +00:00
|
|
|
|
|
|
|
|
/** @var RepoGroup */
|
|
|
|
|
private $repoGroup;
|
|
|
|
|
|
2021-03-26 22:56:39 +00:00
|
|
|
/** @var ReadOnlyMode */
|
|
|
|
|
private $readOnlyMode;
|
|
|
|
|
|
2020-04-17 01:30:38 +00:00
|
|
|
/** @var IContentHandlerFactory */
|
|
|
|
|
private $contentHandlerFactory;
|
|
|
|
|
|
|
|
|
|
/** @var RevisionStore */
|
|
|
|
|
private $revisionStore;
|
|
|
|
|
|
2020-05-13 21:30:46 +00:00
|
|
|
/** @var SpamChecker */
|
|
|
|
|
private $spamChecker;
|
|
|
|
|
|
2021-03-26 22:56:39 +00:00
|
|
|
/** @var TitleFormatter */
|
|
|
|
|
private $titleFormatter;
|
|
|
|
|
|
Hooks::run() call site migration
Migrate all callers of Hooks::run() to use the new
HookContainer/HookRunner system.
General principles:
* Use DI if it is already used. We're not changing the way state is
managed in this patch.
* HookContainer is always injected, not HookRunner. HookContainer
is a service, it's a more generic interface, it is the only
thing that provides isRegistered() which is needed in some cases,
and a HookRunner can be efficiently constructed from it
(confirmed by benchmark). Because HookContainer is needed
for object construction, it is also needed by all factories.
* "Ask your friendly local base class". Big hierarchies like
SpecialPage and ApiBase have getHookContainer() and getHookRunner()
methods in the base class, and classes that extend that base class
are not expected to know or care where the base class gets its
HookContainer from.
* ProtectedHookAccessorTrait provides protected getHookContainer() and
getHookRunner() methods, getting them from the global service
container. The point of this is to ease migration to DI by ensuring
that call sites ask their local friendly base class rather than
getting a HookRunner from the service container directly.
* Private $this->hookRunner. In some smaller classes where accessor
methods did not seem warranted, there is a private HookRunner property
which is accessed directly. Very rarely (two cases), there is a
protected property, for consistency with code that conventionally
assumes protected=private, but in cases where the class might actually
be overridden, a protected accessor is preferred over a protected
property.
* The last resort: Hooks::runner(). Mostly for static, file-scope and
global code. In a few cases it was used for objects with broken
construction schemes, out of horror or laziness.
Constructors with new required arguments:
* AuthManager
* BadFileLookup
* BlockManager
* ClassicInterwikiLookup
* ContentHandlerFactory
* ContentSecurityPolicy
* DefaultOptionsManager
* DerivedPageDataUpdater
* FullSearchResultWidget
* HtmlCacheUpdater
* LanguageFactory
* LanguageNameUtils
* LinkRenderer
* LinkRendererFactory
* LocalisationCache
* MagicWordFactory
* MessageCache
* NamespaceInfo
* PageEditStash
* PageHandlerFactory
* PageUpdater
* ParserFactory
* PermissionManager
* RevisionStore
* RevisionStoreFactory
* SearchEngineConfig
* SearchEngineFactory
* SearchFormWidget
* SearchNearMatcher
* SessionBackend
* SpecialPageFactory
* UserNameUtils
* UserOptionsManager
* WatchedItemQueryService
* WatchedItemStore
Constructors with new optional arguments:
* DefaultPreferencesFactory
* Language
* LinkHolderArray
* MovePage
* Parser
* ParserCache
* PasswordReset
* Router
setHookContainer() now required after construction:
* AuthenticationProvider
* ResourceLoaderModule
* SearchEngine
Change-Id: Id442b0dbe43aba84bd5cf801d86dedc768b082c7
2020-03-19 02:42:09 +00:00
|
|
|
/** @var HookContainer */
|
|
|
|
|
private $hookContainer;
|
|
|
|
|
|
2020-11-11 21:10:47 +00:00
|
|
|
/** @var WikiPageFactory */
|
|
|
|
|
private $wikiPageFactory;
|
|
|
|
|
|
2021-03-02 01:28:23 +00:00
|
|
|
/** @var UserFactory */
|
|
|
|
|
private $userFactory;
|
|
|
|
|
|
2021-03-26 22:56:39 +00:00
|
|
|
/** @var ActorMigration */
|
|
|
|
|
private $actorMigration;
|
2020-04-17 01:30:38 +00:00
|
|
|
|
2021-04-19 00:57:23 +00:00
|
|
|
/** @var ActorNormalization */
|
|
|
|
|
private $actorNormalization;
|
|
|
|
|
|
2021-05-14 00:52:32 +00:00
|
|
|
/** @var TitleFactory */
|
|
|
|
|
private $titleFactory;
|
|
|
|
|
|
2021-04-24 04:54:48 +00:00
|
|
|
/** @var UserEditTracker */
|
|
|
|
|
private $userEditTracker;
|
|
|
|
|
|
2021-08-24 19:12:39 +00:00
|
|
|
/** @var CollationFactory */
|
|
|
|
|
private $collationFactory;
|
|
|
|
|
|
2021-08-20 19:56:10 +00:00
|
|
|
/** @var JobQueueGroup */
|
|
|
|
|
private $jobQueueGroup;
|
|
|
|
|
|
|
|
|
|
/** @var CommentStore */
|
|
|
|
|
private $commentStore;
|
|
|
|
|
|
|
|
|
|
/** @var BagOStuff */
|
2022-01-11 09:58:31 +00:00
|
|
|
private $mainStash;
|
2021-08-20 19:56:10 +00:00
|
|
|
|
|
|
|
|
/** @var string */
|
|
|
|
|
private $localWikiID;
|
|
|
|
|
|
|
|
|
|
/** @var string */
|
|
|
|
|
private $webRequestID;
|
|
|
|
|
|
2021-09-08 22:07:01 +00:00
|
|
|
/** @var BacklinkCacheFactory */
|
|
|
|
|
private $backlinkCacheFactory;
|
|
|
|
|
|
2021-08-30 20:55:05 +00:00
|
|
|
/** @var LoggerInterface */
|
|
|
|
|
private $undeletePageLogger;
|
|
|
|
|
|
2021-10-06 22:07:55 +00:00
|
|
|
/** @var PageUpdaterFactory */
|
|
|
|
|
private $pageUpdaterFactory;
|
|
|
|
|
|
DeletePage: add option to delete the associated talk page
Currently this is implemented internally as a second method call. In the
future, it might be possible to optimize the implementation, e.g. to
reduce the amount of DB queries/jobs etc. without changing anything for
callers.
Since the implementation of e.g. the result getters is generic, a future
commit may add an option to delete subpages with relatively low effort.
The revision limit for big deletions is now using the total number of
revisions (base page + talk page). This is because both deletions would
happen in the same main transaction, and we presumably want to optimize
the deletion as a whole, not as two separated steps. This would become
even more important if the aforementioned improvements are ever
implemented. Note, the whole concept of "big deletion" might have been
superseded by batched deletions in the author's opinion, but as long as
such a limit exists, it should serve its purpose.
The current interpretation of the associated talk option is that the
request is validated, and an exception is raised if we cannot delete the
associated talk, as opposed to silently ignoring the parameter if the
talk cannot be deleted. The only exception to this is that it will not
fail hard if the talk page turns out not to exist by the time the
deletion is attempted, as that's hard to foresee due to race conditions.
Note that the summary for the talk deletion is prefixed with the
delete-talk-summary-prefix message. The main reason behind this is that
the delete UI can sometimes offer an auto-generated summary like "the
only contributor was XXX" or "the content was YYY", and since this may
not apply to the talk page as well, the log entry might look confusing.
Bug: T263209
Bug: T27471
Change-Id: Ife1f4e8258a69528dd1ce8fef8ae809761aa6f1d
2021-09-01 12:56:43 +00:00
|
|
|
/** @var ITextFormatter */
|
|
|
|
|
private $contLangMsgTextFormatter;
|
|
|
|
|
|
2020-04-17 01:30:38 +00:00
|
|
|
public function __construct(
|
2021-03-26 22:56:39 +00:00
|
|
|
Config $config,
|
2021-08-20 19:56:10 +00:00
|
|
|
LBFactory $lbFactory,
|
2020-05-30 19:10:58 +00:00
|
|
|
NamespaceInfo $namespaceInfo,
|
2020-04-28 22:54:18 +00:00
|
|
|
WatchedItemStoreInterface $watchedItemStore,
|
2020-04-17 01:30:38 +00:00
|
|
|
RepoGroup $repoGroup,
|
2021-03-26 22:56:39 +00:00
|
|
|
ReadOnlyMode $readOnlyMode,
|
2020-04-17 01:30:38 +00:00
|
|
|
IContentHandlerFactory $contentHandlerFactory,
|
2020-05-13 21:30:46 +00:00
|
|
|
RevisionStore $revisionStore,
|
Hooks::run() call site migration
Migrate all callers of Hooks::run() to use the new
HookContainer/HookRunner system.
General principles:
* Use DI if it is already used. We're not changing the way state is
managed in this patch.
* HookContainer is always injected, not HookRunner. HookContainer
is a service, it's a more generic interface, it is the only
thing that provides isRegistered() which is needed in some cases,
and a HookRunner can be efficiently constructed from it
(confirmed by benchmark). Because HookContainer is needed
for object construction, it is also needed by all factories.
* "Ask your friendly local base class". Big hierarchies like
SpecialPage and ApiBase have getHookContainer() and getHookRunner()
methods in the base class, and classes that extend that base class
are not expected to know or care where the base class gets its
HookContainer from.
* ProtectedHookAccessorTrait provides protected getHookContainer() and
getHookRunner() methods, getting them from the global service
container. The point of this is to ease migration to DI by ensuring
that call sites ask their local friendly base class rather than
getting a HookRunner from the service container directly.
* Private $this->hookRunner. In some smaller classes where accessor
methods did not seem warranted, there is a private HookRunner property
which is accessed directly. Very rarely (two cases), there is a
protected property, for consistency with code that conventionally
assumes protected=private, but in cases where the class might actually
be overridden, a protected accessor is preferred over a protected
property.
* The last resort: Hooks::runner(). Mostly for static, file-scope and
global code. In a few cases it was used for objects with broken
construction schemes, out of horror or laziness.
Constructors with new required arguments:
* AuthManager
* BadFileLookup
* BlockManager
* ClassicInterwikiLookup
* ContentHandlerFactory
* ContentSecurityPolicy
* DefaultOptionsManager
* DerivedPageDataUpdater
* FullSearchResultWidget
* HtmlCacheUpdater
* LanguageFactory
* LanguageNameUtils
* LinkRenderer
* LinkRendererFactory
* LocalisationCache
* MagicWordFactory
* MessageCache
* NamespaceInfo
* PageEditStash
* PageHandlerFactory
* PageUpdater
* ParserFactory
* PermissionManager
* RevisionStore
* RevisionStoreFactory
* SearchEngineConfig
* SearchEngineFactory
* SearchFormWidget
* SearchNearMatcher
* SessionBackend
* SpecialPageFactory
* UserNameUtils
* UserOptionsManager
* WatchedItemQueryService
* WatchedItemStore
Constructors with new optional arguments:
* DefaultPreferencesFactory
* Language
* LinkHolderArray
* MovePage
* Parser
* ParserCache
* PasswordReset
* Router
setHookContainer() now required after construction:
* AuthenticationProvider
* ResourceLoaderModule
* SearchEngine
Change-Id: Id442b0dbe43aba84bd5cf801d86dedc768b082c7
2020-03-19 02:42:09 +00:00
|
|
|
SpamChecker $spamChecker,
|
2021-03-26 22:56:39 +00:00
|
|
|
TitleFormatter $titleFormatter,
|
2020-11-11 21:10:47 +00:00
|
|
|
HookContainer $hookContainer,
|
2021-03-02 01:28:23 +00:00
|
|
|
WikiPageFactory $wikiPageFactory,
|
2021-03-26 22:56:39 +00:00
|
|
|
UserFactory $userFactory,
|
2021-04-19 00:57:23 +00:00
|
|
|
ActorMigration $actorMigration,
|
2021-05-14 00:52:32 +00:00
|
|
|
ActorNormalization $actorNormalization,
|
2021-04-24 04:54:48 +00:00
|
|
|
TitleFactory $titleFactory,
|
2021-08-24 19:12:39 +00:00
|
|
|
UserEditTracker $userEditTracker,
|
2021-08-20 19:56:10 +00:00
|
|
|
CollationFactory $collationFactory,
|
|
|
|
|
JobQueueGroup $jobQueueGroup,
|
|
|
|
|
CommentStore $commentStore,
|
2022-01-11 09:58:31 +00:00
|
|
|
BagOStuff $mainStash,
|
2021-08-20 19:56:10 +00:00
|
|
|
string $localWikiID,
|
2021-09-08 22:07:01 +00:00
|
|
|
string $webRequestID,
|
2021-08-30 20:55:05 +00:00
|
|
|
BacklinkCacheFactory $backlinkCacheFactory,
|
2021-10-06 22:07:55 +00:00
|
|
|
LoggerInterface $undeletePageLogger,
|
DeletePage: add option to delete the associated talk page
Currently this is implemented internally as a second method call. In the
future, it might be possible to optimize the implementation, e.g. to
reduce the amount of DB queries/jobs etc. without changing anything for
callers.
Since the implementation of e.g. the result getters is generic, a future
commit may add an option to delete subpages with relatively low effort.
The revision limit for big deletions is now using the total number of
revisions (base page + talk page). This is because both deletions would
happen in the same main transaction, and we presumably want to optimize
the deletion as a whole, not as two separated steps. This would become
even more important if the aforementioned improvements are ever
implemented. Note, the whole concept of "big deletion" might have been
superseded by batched deletions in the author's opinion, but as long as
such a limit exists, it should serve its purpose.
The current interpretation of the associated talk option is that the
request is validated, and an exception is raised if we cannot delete the
associated talk, as opposed to silently ignoring the parameter if the
talk cannot be deleted. The only exception to this is that it will not
fail hard if the talk page turns out not to exist by the time the
deletion is attempted, as that's hard to foresee due to race conditions.
Note that the summary for the talk deletion is prefixed with the
delete-talk-summary-prefix message. The main reason behind this is that
the delete UI can sometimes offer an auto-generated summary like "the
only contributor was XXX" or "the content was YYY", and since this may
not apply to the talk page as well, the log entry might look confusing.
Bug: T263209
Bug: T27471
Change-Id: Ife1f4e8258a69528dd1ce8fef8ae809761aa6f1d
2021-09-01 12:56:43 +00:00
|
|
|
PageUpdaterFactory $pageUpdaterFactory,
|
|
|
|
|
ITextFormatter $contLangMsgTextFormatter
|
2020-04-17 01:30:38 +00:00
|
|
|
) {
|
2021-03-26 22:56:39 +00:00
|
|
|
$this->config = $config;
|
2021-08-20 19:56:10 +00:00
|
|
|
$this->lbFactory = $lbFactory;
|
2020-05-30 19:10:58 +00:00
|
|
|
$this->namespaceInfo = $namespaceInfo;
|
2020-04-28 22:54:18 +00:00
|
|
|
$this->watchedItemStore = $watchedItemStore;
|
2020-04-17 01:30:38 +00:00
|
|
|
$this->repoGroup = $repoGroup;
|
2021-03-26 22:56:39 +00:00
|
|
|
$this->readOnlyMode = $readOnlyMode;
|
2020-04-17 01:30:38 +00:00
|
|
|
$this->contentHandlerFactory = $contentHandlerFactory;
|
|
|
|
|
$this->revisionStore = $revisionStore;
|
2020-05-13 21:30:46 +00:00
|
|
|
$this->spamChecker = $spamChecker;
|
2021-03-26 22:56:39 +00:00
|
|
|
$this->titleFormatter = $titleFormatter;
|
Hooks::run() call site migration
Migrate all callers of Hooks::run() to use the new
HookContainer/HookRunner system.
General principles:
* Use DI if it is already used. We're not changing the way state is
managed in this patch.
* HookContainer is always injected, not HookRunner. HookContainer
is a service, it's a more generic interface, it is the only
thing that provides isRegistered() which is needed in some cases,
and a HookRunner can be efficiently constructed from it
(confirmed by benchmark). Because HookContainer is needed
for object construction, it is also needed by all factories.
* "Ask your friendly local base class". Big hierarchies like
SpecialPage and ApiBase have getHookContainer() and getHookRunner()
methods in the base class, and classes that extend that base class
are not expected to know or care where the base class gets its
HookContainer from.
* ProtectedHookAccessorTrait provides protected getHookContainer() and
getHookRunner() methods, getting them from the global service
container. The point of this is to ease migration to DI by ensuring
that call sites ask their local friendly base class rather than
getting a HookRunner from the service container directly.
* Private $this->hookRunner. In some smaller classes where accessor
methods did not seem warranted, there is a private HookRunner property
which is accessed directly. Very rarely (two cases), there is a
protected property, for consistency with code that conventionally
assumes protected=private, but in cases where the class might actually
be overridden, a protected accessor is preferred over a protected
property.
* The last resort: Hooks::runner(). Mostly for static, file-scope and
global code. In a few cases it was used for objects with broken
construction schemes, out of horror or laziness.
Constructors with new required arguments:
* AuthManager
* BadFileLookup
* BlockManager
* ClassicInterwikiLookup
* ContentHandlerFactory
* ContentSecurityPolicy
* DefaultOptionsManager
* DerivedPageDataUpdater
* FullSearchResultWidget
* HtmlCacheUpdater
* LanguageFactory
* LanguageNameUtils
* LinkRenderer
* LinkRendererFactory
* LocalisationCache
* MagicWordFactory
* MessageCache
* NamespaceInfo
* PageEditStash
* PageHandlerFactory
* PageUpdater
* ParserFactory
* PermissionManager
* RevisionStore
* RevisionStoreFactory
* SearchEngineConfig
* SearchEngineFactory
* SearchFormWidget
* SearchNearMatcher
* SessionBackend
* SpecialPageFactory
* UserNameUtils
* UserOptionsManager
* WatchedItemQueryService
* WatchedItemStore
Constructors with new optional arguments:
* DefaultPreferencesFactory
* Language
* LinkHolderArray
* MovePage
* Parser
* ParserCache
* PasswordReset
* Router
setHookContainer() now required after construction:
* AuthenticationProvider
* ResourceLoaderModule
* SearchEngine
Change-Id: Id442b0dbe43aba84bd5cf801d86dedc768b082c7
2020-03-19 02:42:09 +00:00
|
|
|
$this->hookContainer = $hookContainer;
|
2020-11-11 21:10:47 +00:00
|
|
|
$this->wikiPageFactory = $wikiPageFactory;
|
2021-03-02 01:28:23 +00:00
|
|
|
$this->userFactory = $userFactory;
|
2021-03-26 22:56:39 +00:00
|
|
|
$this->actorMigration = $actorMigration;
|
2021-04-19 00:57:23 +00:00
|
|
|
$this->actorNormalization = $actorNormalization;
|
2021-05-14 00:52:32 +00:00
|
|
|
$this->titleFactory = $titleFactory;
|
2021-04-24 04:54:48 +00:00
|
|
|
$this->userEditTracker = $userEditTracker;
|
2021-08-24 19:12:39 +00:00
|
|
|
$this->collationFactory = $collationFactory;
|
2021-08-20 19:56:10 +00:00
|
|
|
$this->jobQueueGroup = $jobQueueGroup;
|
|
|
|
|
$this->commentStore = $commentStore;
|
2022-01-11 09:58:31 +00:00
|
|
|
$this->mainStash = $mainStash;
|
2021-08-20 19:56:10 +00:00
|
|
|
$this->localWikiID = $localWikiID;
|
|
|
|
|
$this->webRequestID = $webRequestID;
|
2021-09-08 22:07:01 +00:00
|
|
|
$this->backlinkCacheFactory = $backlinkCacheFactory;
|
2021-08-30 20:55:05 +00:00
|
|
|
$this->undeletePageLogger = $undeletePageLogger;
|
2021-10-06 22:07:55 +00:00
|
|
|
$this->pageUpdaterFactory = $pageUpdaterFactory;
|
DeletePage: add option to delete the associated talk page
Currently this is implemented internally as a second method call. In the
future, it might be possible to optimize the implementation, e.g. to
reduce the amount of DB queries/jobs etc. without changing anything for
callers.
Since the implementation of e.g. the result getters is generic, a future
commit may add an option to delete subpages with relatively low effort.
The revision limit for big deletions is now using the total number of
revisions (base page + talk page). This is because both deletions would
happen in the same main transaction, and we presumably want to optimize
the deletion as a whole, not as two separated steps. This would become
even more important if the aforementioned improvements are ever
implemented. Note, the whole concept of "big deletion" might have been
superseded by batched deletions in the author's opinion, but as long as
such a limit exists, it should serve its purpose.
The current interpretation of the associated talk option is that the
request is validated, and an exception is raised if we cannot delete the
associated talk, as opposed to silently ignoring the parameter if the
talk cannot be deleted. The only exception to this is that it will not
fail hard if the talk page turns out not to exist by the time the
deletion is attempted, as that's hard to foresee due to race conditions.
Note that the summary for the talk deletion is prefixed with the
delete-talk-summary-prefix message. The main reason behind this is that
the delete UI can sometimes offer an auto-generated summary like "the
only contributor was XXX" or "the content was YYY", and since this may
not apply to the talk page as well, the log entry might look confusing.
Bug: T263209
Bug: T27471
Change-Id: Ife1f4e8258a69528dd1ce8fef8ae809761aa6f1d
2021-09-01 12:56:43 +00:00
|
|
|
$this->contLangMsgTextFormatter = $contLangMsgTextFormatter;
|
2020-04-17 01:30:38 +00:00
|
|
|
}
|
|
|
|
|
|
2020-05-30 19:10:58 +00:00
|
|
|
/**
|
2021-03-02 21:29:46 +00:00
|
|
|
* @param Authority $performer
|
2020-05-30 19:10:58 +00:00
|
|
|
* @param WikiPage $wikipage
|
|
|
|
|
* @param string $newContentModel
|
|
|
|
|
* @return ContentModelChange
|
|
|
|
|
*/
|
|
|
|
|
public function newContentModelChange(
|
2021-03-02 21:29:46 +00:00
|
|
|
Authority $performer,
|
2020-05-30 19:10:58 +00:00
|
|
|
WikiPage $wikipage,
|
|
|
|
|
string $newContentModel
|
2021-07-22 03:11:47 +00:00
|
|
|
): ContentModelChange {
|
2020-05-30 19:10:58 +00:00
|
|
|
return new ContentModelChange(
|
|
|
|
|
$this->contentHandlerFactory,
|
|
|
|
|
$this->hookContainer,
|
|
|
|
|
$this->revisionStore,
|
2021-03-02 21:29:46 +00:00
|
|
|
$this->userFactory,
|
|
|
|
|
$performer,
|
2020-05-30 19:10:58 +00:00
|
|
|
$wikipage,
|
|
|
|
|
$newContentModel
|
|
|
|
|
);
|
|
|
|
|
}
|
|
|
|
|
|
2021-08-20 19:56:10 +00:00
|
|
|
/**
|
|
|
|
|
* @inheritDoc
|
|
|
|
|
*/
|
|
|
|
|
public function newDeletePage( ProperPageIdentity $page, Authority $deleter ): DeletePage {
|
|
|
|
|
return new DeletePage(
|
|
|
|
|
$this->hookContainer,
|
|
|
|
|
$this->revisionStore,
|
|
|
|
|
$this->lbFactory,
|
|
|
|
|
$this->jobQueueGroup,
|
|
|
|
|
$this->commentStore,
|
|
|
|
|
new ServiceOptions( DeletePage::CONSTRUCTOR_OPTIONS, $this->config ),
|
2022-01-11 09:58:31 +00:00
|
|
|
$this->mainStash,
|
2021-08-20 19:56:10 +00:00
|
|
|
$this->localWikiID,
|
|
|
|
|
$this->webRequestID,
|
|
|
|
|
$this->wikiPageFactory,
|
|
|
|
|
$this->userFactory,
|
2021-11-25 16:02:49 +00:00
|
|
|
$this->backlinkCacheFactory,
|
DeletePage: add option to delete the associated talk page
Currently this is implemented internally as a second method call. In the
future, it might be possible to optimize the implementation, e.g. to
reduce the amount of DB queries/jobs etc. without changing anything for
callers.
Since the implementation of e.g. the result getters is generic, a future
commit may add an option to delete subpages with relatively low effort.
The revision limit for big deletions is now using the total number of
revisions (base page + talk page). This is because both deletions would
happen in the same main transaction, and we presumably want to optimize
the deletion as a whole, not as two separated steps. This would become
even more important if the aforementioned improvements are ever
implemented. Note, the whole concept of "big deletion" might have been
superseded by batched deletions in the author's opinion, but as long as
such a limit exists, it should serve its purpose.
The current interpretation of the associated talk option is that the
request is validated, and an exception is raised if we cannot delete the
associated talk, as opposed to silently ignoring the parameter if the
talk cannot be deleted. The only exception to this is that it will not
fail hard if the talk page turns out not to exist by the time the
deletion is attempted, as that's hard to foresee due to race conditions.
Note that the summary for the talk deletion is prefixed with the
delete-talk-summary-prefix message. The main reason behind this is that
the delete UI can sometimes offer an auto-generated summary like "the
only contributor was XXX" or "the content was YYY", and since this may
not apply to the talk page as well, the log entry might look confusing.
Bug: T263209
Bug: T27471
Change-Id: Ife1f4e8258a69528dd1ce8fef8ae809761aa6f1d
2021-09-01 12:56:43 +00:00
|
|
|
$this->namespaceInfo,
|
|
|
|
|
$this->contLangMsgTextFormatter,
|
2021-08-20 19:56:10 +00:00
|
|
|
$page,
|
2021-11-25 16:02:49 +00:00
|
|
|
$deleter
|
2021-08-20 19:56:10 +00:00
|
|
|
);
|
|
|
|
|
}
|
|
|
|
|
|
2020-04-28 22:54:18 +00:00
|
|
|
/**
|
2021-05-14 00:52:32 +00:00
|
|
|
* @param PageIdentity $source
|
|
|
|
|
* @param PageIdentity $destination
|
2020-04-28 22:54:18 +00:00
|
|
|
* @param string|null $timestamp
|
|
|
|
|
* @return MergeHistory
|
|
|
|
|
*/
|
|
|
|
|
public function newMergeHistory(
|
2021-05-14 00:52:32 +00:00
|
|
|
PageIdentity $source,
|
|
|
|
|
PageIdentity $destination,
|
2020-04-28 22:54:18 +00:00
|
|
|
string $timestamp = null
|
2021-07-22 03:11:47 +00:00
|
|
|
): MergeHistory {
|
2020-04-28 22:54:18 +00:00
|
|
|
return new MergeHistory(
|
|
|
|
|
$source,
|
|
|
|
|
$destination,
|
|
|
|
|
$timestamp,
|
2021-08-20 19:56:10 +00:00
|
|
|
$this->lbFactory->getMainLB(),
|
2020-04-28 22:54:18 +00:00
|
|
|
$this->contentHandlerFactory,
|
|
|
|
|
$this->revisionStore,
|
2020-05-13 21:30:46 +00:00
|
|
|
$this->watchedItemStore,
|
2020-08-25 20:09:46 +00:00
|
|
|
$this->spamChecker,
|
2020-11-11 21:10:47 +00:00
|
|
|
$this->hookContainer,
|
2021-05-14 00:52:32 +00:00
|
|
|
$this->wikiPageFactory,
|
|
|
|
|
$this->titleFormatter,
|
|
|
|
|
$this->titleFactory
|
2020-04-28 22:54:18 +00:00
|
|
|
);
|
|
|
|
|
}
|
|
|
|
|
|
2020-04-17 01:30:38 +00:00
|
|
|
/**
|
|
|
|
|
* @param Title $from
|
|
|
|
|
* @param Title $to
|
|
|
|
|
* @return MovePage
|
|
|
|
|
*/
|
2021-07-22 03:11:47 +00:00
|
|
|
public function newMovePage( Title $from, Title $to ): MovePage {
|
2020-04-28 22:54:18 +00:00
|
|
|
return new MovePage(
|
|
|
|
|
$from,
|
|
|
|
|
$to,
|
2021-03-26 22:56:39 +00:00
|
|
|
new ServiceOptions( MovePage::CONSTRUCTOR_OPTIONS, $this->config ),
|
2021-08-20 19:56:10 +00:00
|
|
|
$this->lbFactory->getMainLB(),
|
2020-05-30 19:10:58 +00:00
|
|
|
$this->namespaceInfo,
|
2020-04-28 22:54:18 +00:00
|
|
|
$this->watchedItemStore,
|
2020-04-17 01:30:38 +00:00
|
|
|
$this->repoGroup,
|
|
|
|
|
$this->contentHandlerFactory,
|
2020-05-13 21:30:46 +00:00
|
|
|
$this->revisionStore,
|
Hooks::run() call site migration
Migrate all callers of Hooks::run() to use the new
HookContainer/HookRunner system.
General principles:
* Use DI if it is already used. We're not changing the way state is
managed in this patch.
* HookContainer is always injected, not HookRunner. HookContainer
is a service, it's a more generic interface, it is the only
thing that provides isRegistered() which is needed in some cases,
and a HookRunner can be efficiently constructed from it
(confirmed by benchmark). Because HookContainer is needed
for object construction, it is also needed by all factories.
* "Ask your friendly local base class". Big hierarchies like
SpecialPage and ApiBase have getHookContainer() and getHookRunner()
methods in the base class, and classes that extend that base class
are not expected to know or care where the base class gets its
HookContainer from.
* ProtectedHookAccessorTrait provides protected getHookContainer() and
getHookRunner() methods, getting them from the global service
container. The point of this is to ease migration to DI by ensuring
that call sites ask their local friendly base class rather than
getting a HookRunner from the service container directly.
* Private $this->hookRunner. In some smaller classes where accessor
methods did not seem warranted, there is a private HookRunner property
which is accessed directly. Very rarely (two cases), there is a
protected property, for consistency with code that conventionally
assumes protected=private, but in cases where the class might actually
be overridden, a protected accessor is preferred over a protected
property.
* The last resort: Hooks::runner(). Mostly for static, file-scope and
global code. In a few cases it was used for objects with broken
construction schemes, out of horror or laziness.
Constructors with new required arguments:
* AuthManager
* BadFileLookup
* BlockManager
* ClassicInterwikiLookup
* ContentHandlerFactory
* ContentSecurityPolicy
* DefaultOptionsManager
* DerivedPageDataUpdater
* FullSearchResultWidget
* HtmlCacheUpdater
* LanguageFactory
* LanguageNameUtils
* LinkRenderer
* LinkRendererFactory
* LocalisationCache
* MagicWordFactory
* MessageCache
* NamespaceInfo
* PageEditStash
* PageHandlerFactory
* PageUpdater
* ParserFactory
* PermissionManager
* RevisionStore
* RevisionStoreFactory
* SearchEngineConfig
* SearchEngineFactory
* SearchFormWidget
* SearchNearMatcher
* SessionBackend
* SpecialPageFactory
* UserNameUtils
* UserOptionsManager
* WatchedItemQueryService
* WatchedItemStore
Constructors with new optional arguments:
* DefaultPreferencesFactory
* Language
* LinkHolderArray
* MovePage
* Parser
* ParserCache
* PasswordReset
* Router
setHookContainer() now required after construction:
* AuthenticationProvider
* ResourceLoaderModule
* SearchEngine
Change-Id: Id442b0dbe43aba84bd5cf801d86dedc768b082c7
2020-03-19 02:42:09 +00:00
|
|
|
$this->spamChecker,
|
2020-11-11 21:10:47 +00:00
|
|
|
$this->hookContainer,
|
2021-03-02 01:28:23 +00:00
|
|
|
$this->wikiPageFactory,
|
2021-04-24 04:54:48 +00:00
|
|
|
$this->userFactory,
|
2021-08-03 18:35:18 +00:00
|
|
|
$this->userEditTracker,
|
2021-08-24 19:12:39 +00:00
|
|
|
$this,
|
2021-10-06 22:07:55 +00:00
|
|
|
$this->collationFactory,
|
|
|
|
|
$this->pageUpdaterFactory
|
2020-04-17 01:30:38 +00:00
|
|
|
);
|
|
|
|
|
}
|
2021-03-26 22:56:39 +00:00
|
|
|
|
|
|
|
|
/**
|
|
|
|
|
* Create a new command instance for page rollback.
|
|
|
|
|
*
|
|
|
|
|
* @param PageIdentity $page
|
|
|
|
|
* @param Authority $performer
|
|
|
|
|
* @param UserIdentity $byUser
|
|
|
|
|
* @return RollbackPage
|
|
|
|
|
*/
|
|
|
|
|
public function newRollbackPage(
|
|
|
|
|
PageIdentity $page,
|
|
|
|
|
Authority $performer,
|
|
|
|
|
UserIdentity $byUser
|
2021-07-22 03:11:47 +00:00
|
|
|
): RollbackPage {
|
2021-03-26 22:56:39 +00:00
|
|
|
return new RollbackPage(
|
|
|
|
|
new ServiceOptions( RollbackPage::CONSTRUCTOR_OPTIONS, $this->config ),
|
2021-08-20 19:56:10 +00:00
|
|
|
$this->lbFactory->getMainLB(),
|
2021-03-26 22:56:39 +00:00
|
|
|
$this->userFactory,
|
|
|
|
|
$this->readOnlyMode,
|
|
|
|
|
$this->revisionStore,
|
|
|
|
|
$this->titleFormatter,
|
|
|
|
|
$this->hookContainer,
|
|
|
|
|
$this->wikiPageFactory,
|
|
|
|
|
$this->actorMigration,
|
2021-04-19 00:57:23 +00:00
|
|
|
$this->actorNormalization,
|
2021-03-26 22:56:39 +00:00
|
|
|
$page,
|
|
|
|
|
$performer,
|
|
|
|
|
$byUser
|
|
|
|
|
);
|
|
|
|
|
}
|
2021-08-30 20:55:05 +00:00
|
|
|
|
|
|
|
|
/**
|
|
|
|
|
* @inheritDoc
|
|
|
|
|
*/
|
|
|
|
|
public function newUndeletePage( ProperPageIdentity $page, Authority $authority ): UndeletePage {
|
|
|
|
|
return new UndeletePage(
|
|
|
|
|
$this->hookContainer,
|
|
|
|
|
$this->jobQueueGroup,
|
|
|
|
|
$this->lbFactory->getMainLB(),
|
|
|
|
|
$this->readOnlyMode,
|
|
|
|
|
$this->repoGroup,
|
|
|
|
|
$this->undeletePageLogger,
|
|
|
|
|
$this->revisionStore,
|
|
|
|
|
$this->wikiPageFactory,
|
2021-10-22 12:48:23 +00:00
|
|
|
$this->pageUpdaterFactory,
|
2021-12-14 12:25:56 +00:00
|
|
|
$this->contentHandlerFactory,
|
|
|
|
|
$page,
|
|
|
|
|
$authority
|
2021-08-30 20:55:05 +00:00
|
|
|
);
|
|
|
|
|
}
|
2020-04-17 01:30:38 +00:00
|
|
|
}
|