Thijs/wiki.techinc.nl
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions
wiki.techinc.nl/tests/phpunit/data/css/expected.css

12 lines
409 B
CSS
Raw Normal View History

Add a test for mixed /*@noflip*/ and /*@embed*/ CSS annotations Given that we have entirely separate code for handling one and the other, and given the nature of code comments stuffed inside other structures, this isn't really obvious that they work. And indeed, "/*@noflip*/ /*@embed*/" doesn't work (filed bug 69698). Amazingly, all other combinations do. Change-Id: Ie30bab251eb4abee122c783d057de4102e53d1fc
2014-08-18 12:56:18 +00:00
/* All of the combinations should result in the same output in LTR and RTL mode. */
.selector { /*@embed*/ background-image: url(simple-ltr.gif); }
.selector { /*@embed*/ background-image: url(simple-ltr.gif); }
Make "/*@noflip*/ /*@embed*/" annotation work To do it, just remove /*@noflip*/ annotations in CSSJanus after we're done processing. They are not needed anymore and some obscure interactions with CSSMin logic for preserving comments caused `/*@noflip*/ /*@embed*/ background-image: url(…)` not to work correctly (it would not be embedded). This also requires us to always do CSSJanus processing, even when we don't need flipping, to consistently handle the annotations. I'm not entirely sure if this is worth it, but I still greatly prefer doing it to documenting this stupid limitation. :) Bug: 69698 Change-Id: I311b12b08b2dff9d45efb584db08cf4a11318f59
2014-08-18 15:32:22 +00:00
.selector { /*@embed*/ background-image: url(simple-ltr.gif); }
Add a test for mixed /*@noflip*/ and /*@embed*/ CSS annotations Given that we have entirely separate code for handling one and the other, and given the nature of code comments stuffed inside other structures, this isn't really obvious that they work. And indeed, "/*@noflip*/ /*@embed*/" doesn't work (filed bug 69698). Amazingly, all other combinations do. Change-Id: Ie30bab251eb4abee122c783d057de4102e53d1fc
2014-08-18 12:56:18 +00:00
.selector { /*@embed*/ background-image: url(simple-ltr.gif); }
.selector { /*@embed*/ background-image: url(simple-ltr.gif); }
Reference in a new issue Copy permalink