wiki.techinc.nl/tests/phpunit/includes/ResourceLoader/WikiModuleTest.php

483 lines
13 KiB
PHP
Raw Normal View History

<?php
namespace MediaWiki\Tests\ResourceLoader;
use Config;
use Content;
use CssContent;
use EmptyResourceLoader;
use FauxRequest;
use HashConfig;
use JavaScriptContent;
use JavaScriptContentHandler;
use LinkCacheTestTrait;
use MediaWiki\Page\PageIdentity;
use MediaWiki\Page\PageIdentityValue;
use MediaWiki\Page\PageRecord;
use MediaWiki\Page\PageStore;
use MediaWiki\ResourceLoader\Context;
use MediaWiki\ResourceLoader\DerivativeContext;
use MediaWiki\ResourceLoader\WikiModule;
use ReflectionMethod;
use ResourceLoaderTestCase;
use Title;
use TitleValue;
use WikiMap;
use Wikimedia\Rdbms\IDatabase;
use Wikimedia\TestingAccessWrapper;
use WikitextContent;
/**
* @covers \MediaWiki\ResourceLoader\WikiModule
*/
class WikiModuleTest extends ResourceLoaderTestCase {
use LinkCacheTestTrait;
/**
* @dataProvider provideConstructor
*/
public function testConstructor( $params ) {
$module = new WikiModule( $params );
$this->assertInstanceOf( WikiModule::class, $module );
}
public static function provideConstructor() {
yield 'null' => [ null ];
yield 'empty' => [ [] ];
yield 'unknown settings' => [ [ 'foo' => 'baz' ] ];
yield 'real settings' => [ [ 'MediaWiki:Common.js' ] ];
}
private function prepareTitleInfo( array $mockInfo ) {
$module = TestingAccessWrapper::newFromClass( WikiModule::class );
$info = [];
foreach ( $mockInfo as $key => $val ) {
$info[ $module->makeTitleKey( Title::newFromText( $key ) ) ] = $val;
}
return $info;
}
/**
* @dataProvider provideGetPages
*/
public function testGetPages( $params, Config $config, $expected ) {
$module = new WikiModule( $params );
$module->setConfig( $config );
resourceloader: Replace timestamp system with version hashing Modules now track their version via getVersionHash() instead of getModifiedTime(). == Background == While some resources have observeable timestamps (e.g. files stored on disk), many other resources do not. E.g. config variables, and module definitions. For static file modules, one can e.g. revert one of more files in a module to a previous version and not affect the max timestamp. Wiki modules include pages only if they exist. The user module supports common.js and skin.js. By default neither exists. If a user has both, and then the less-recently modified one is deleted, the max-timestamp remains unchanged. For client-side caching, batch requests use "Math.max" on the relevant timestamps. Again, if a module changes but another module is more recent (e.g. out-of-order deployment, or out-of-order discovery), the change would not result in a cache miss. More scenarios can be found in the associated Phabricator tasks. == Version hash == Previously we virtually mapped these variables to a timestamp by storing the current time alongside a hash of the value in ObjectCache. Considering the number of possible request contexts (wikis * modules * users * skins * languages) this doesn't work well. It results in needless cache invalidation when the first time observation is purged due to LRU algorithms. It also has other minor bugs leading to fewer cache hits. All modules automatically get the benefits of version hashing with this change. The old getDefinitionMtime() and getHashMtime() have been replaced with dummies that return 1. These functions are often called from getModifiedTime() in subclasses. For backward-compatibility, their respective values (definition summary and hash) are now included in getVersionHash directly. As examples, the following modules have been updated to use getVersionHash directly. Other modules still work fine and can be updated later. * ResourceLoaderFileModule * ResourceLoaderEditToolbarModule * ResourceLoaderStartUpModule * ResourceLoaderWikiModule The presence of hashes in place of timestamps increases the startup module size on a default MediaWiki install from 4.4k to 5.8k (after gzip and minification). == ETag == Since timestamps are no longer tracked, we need a different way to implement caching for cache proxies (e.g. Varnish) and web browsers. Previously we used the Last-Modified header (in combination with Cache-Control and Expires). Instead of Last-Modified (and If-Modified-Since), we use ETag (and If-None-Match). Entity tags (new in HTTP/1.1) are much stricter than Last-Modified by default. They instruct browsers to allow usage of partial Range requests. Since our responses are dynamically generated, we need to use the Weak version of ETag. While this sounds bad, it's no different than Last-Modified. As reassured by RFC 2616 <http://www.w3.org/Protocols/rfc2616/rfc2616-sec13.html#sec13.3.3> the specified behaviour behind Last-Modified follows the same "Weak" caching logic as Entity tags. It's just that entity tags are capable of a stricter mode (whereas Last-Modified is inherently weak). == File cache == If $wgUseFileCache is enabled, ResourceLoader uses ResourceFileCache to cache load.php responses. While the blind TTL handling (during the allowed expiry period) is still maxage/timestamp based, tryRespondNotModified() now requires the caller to know the expected ETag. For this to work, the FileCache handling had to be moved from the top of ResoureLoader::respond() to after the expected ETag is computed. This also allows us to remove the duplicate tryRespondNotModified() handling since that's is already handled by ResourceLoader::respond() meanwhile. == Misc == * Remove redundant modifiedTime cache in ResourceLoaderFileModule. * Change bugzilla references to Phabricator. * Centralised inclusion of wgCacheEpoch using getDefinitionSummary. Previously this logic was duplicated in each place the modified timestamp was used. * It's easy to forget calling the parent class in getDefinitionSummary(). Previously this method only tracked 'class' by default. As such, various extensions hardcoded that one value instead of calling the parent and extending the array. To better prevent this in the future, getVersionHash() now asserts that the '_cacheEpoch' property made it through. * tests: Don't use getDefinitionSummary() as an API. Fix ResourceLoaderWikiModuleTest to call getPages properly. * In tests, the default timestamp used to be 1388534400000 (which is the unix time of 20140101000000; the unit tests' CacheEpoch). The new version hash of these modules is "XyCC+PSK", which is the base64 encoded prefix of the SHA1 digest of: '{"_class":"ResourceLoaderTestModule","_cacheEpoch":"20140101000000"}' * Add sha1.js library for client-side hash generation. Compared various different implementations for code size (after minfication/gzip), and speed (when used for short hexidecimal strings). https://jsperf.com/sha1-implementations - CryptoJS <https://code.google.com/p/crypto-js/#SHA-1> (min+gzip: 2.5k) http://crypto-js.googlecode.com/svn/tags/3.1.2/build/rollups/sha1.js Chrome: 45k, Firefox: 89k, Safari: 92k - jsSHA <https://github.com/Caligatio/jsSHA> https://github.com/Caligatio/jsSHA/blob/3c1d4f2e/src/sha1.js (min+gzip: 1.8k) Chrome: 65k, Firefox: 53k, Safari: 69k - phpjs-sha1 <https://github.com/kvz/phpjs> (RL min+gzip: 0.8k) https://github.com/kvz/phpjs/blob/1eaab15d/functions/strings/sha1.js Chrome: 200k, Firefox: 280k, Safari: 78k Modern browsers implement the HTML5 Crypto API. However, this API is asynchronous, only enabled when on HTTPS in Chromium, and is quite low-level. It requires boilerplate code to actually use with TextEncoder, ArrayBuffer and Uint32Array. Due this being needed in the module loader, we'd have to load the fallback regardless. Considering this is not used in a critical path for performance, it's not worth shipping two implementations for this optimisation. May also resolve: * T44094 * T90411 * T94810 Bug: T94074 Change-Id: Ibb292d2416839327d1807a66c78fd96dac0637d0
2015-04-29 22:53:24 +00:00
// Because getPages is protected..
$getPages = new ReflectionMethod( $module, 'getPages' );
$getPages->setAccessible( true );
$out = $getPages->invoke( $module, Context::newDummyContext() );
$this->assertSame( $expected, $out );
}
public static function provideGetPages() {
$settings = self::getSettings() + [
'UseSiteJs' => true,
'UseSiteCss' => true,
];
$params = [
'styles' => [ 'MediaWiki:Common.css' ],
'scripts' => [ 'MediaWiki:Common.js' ],
];
return [
[ [], new HashConfig( $settings ), [] ],
[ $params, new HashConfig( $settings ), [
'MediaWiki:Common.js' => [ 'type' => 'script' ],
'MediaWiki:Common.css' => [ 'type' => 'style' ]
] ],
[ $params, new HashConfig( [ 'UseSiteCss' => false ] + $settings ), [
'MediaWiki:Common.js' => [ 'type' => 'script' ],
] ],
[ $params, new HashConfig( [ 'UseSiteJs' => false ] + $settings ), [
'MediaWiki:Common.css' => [ 'type' => 'style' ],
] ],
[ $params,
new HashConfig(
[ 'UseSiteJs' => false, 'UseSiteCss' => false ]
),
[]
],
];
}
/**
* @dataProvider provideGetGroup
*/
public function testGetGroup( $params, $expected ) {
$module = new WikiModule( $params );
$this->assertSame( $expected, $module->getGroup() );
}
public static function provideGetGroup() {
yield 'no group' => [ [], null ];
yield 'some group' => [ [ 'group' => 'foobar' ], 'foobar' ];
}
/**
* @dataProvider provideGetType
*/
public function testGetType( $params, $expected ) {
$module = new WikiModule( $params );
$this->assertSame( $expected, $module->getType() );
}
public static function provideGetType() {
yield 'empty' => [
[],
WikiModule::LOAD_GENERAL,
];
yield 'scripts' => [
[ 'scripts' => [ 'Example.js' ] ],
WikiModule::LOAD_GENERAL,
];
yield 'styles' => [
[ 'styles' => [ 'Example.css' ] ],
WikiModule::LOAD_STYLES,
];
yield 'styles and scripts' => [
[ 'styles' => [ 'Example.css' ], 'scripts' => [ 'Example.js' ] ],
WikiModule::LOAD_GENERAL,
];
}
/**
* @dataProvider provideIsKnownEmpty
*/
public function testIsKnownEmpty( $titleInfo, $group, $dependencies, $expected ) {
$module = $this->getMockBuilder( WikiModule::class )
->disableOriginalConstructor()
->onlyMethods( [ 'getTitleInfo', 'getGroup', 'getDependencies' ] )
->getMock();
$module->method( 'getTitleInfo' )
->willReturn( $this->prepareTitleInfo( $titleInfo ) );
$module->method( 'getGroup' )
->willReturn( $group );
$module->method( 'getDependencies' )
->willReturn( $dependencies );
$context = $this->createMock( Context::class );
$this->assertSame( $expected, $module->isKnownEmpty( $context ) );
}
public static function provideIsKnownEmpty() {
yield 'nothing' => [
[],
null,
[],
// No pages exist, considered empty.
true,
];
yield 'an empty page exists (no group)' => [
[ 'Project:Example/foo.js' => [ 'page_len' => 0 ] ],
null,
[],
// There is an existing page, so we should let the module be queued.
// Its emptiness might be temporary, hence considered non-empty (T70488).
false,
];
yield 'an empty page exists (site group)' => [
[ 'MediaWiki:Foo.js' => [ 'page_len' => 0 ] ],
'site',
[],
// There is an existing page, hence considered non-empty.
false,
];
yield 'an empty page exists (user group)' => [
[ 'User:Example/foo.js' => [ 'page_len' => 0 ] ],
'user',
[],
// There is an existing page, but it is empty.
// For user-specific modules, don't bother loading a known-empty module.
// Given user-specific HTML output, this will vary and re-appear if/when
// the page becomes non-empty again.
true,
];
yield 'no pages but having dependencies (no group)' => [
[],
null,
[ 'another-module' ],
false,
];
yield 'no pages but having dependencies (site group)' => [
[],
'site',
[ 'another-module' ],
false,
];
yield 'no pages but having dependencies (user group)' => [
[],
'user',
[ 'another-module' ],
false,
];
yield 'a non-empty page exists (user group)' => [
[ 'User:Example/foo.js' => [ 'page_len' => 25 ] ],
'user',
[],
false,
];
yield 'a non-empty page exists (site group)' => [
[ 'MediaWiki:Foo.js' => [ 'page_len' => 25 ] ],
'site',
[],
false,
];
}
public function testGetTitleInfo() {
$pages = [
'MediaWiki:Common.css' => [ 'type' => 'styles' ],
'mediawiki: fallback.css' => [ 'type' => 'styles' ],
];
$titleInfo = $this->prepareTitleInfo( [
'MediaWiki:Common.css' => [ 'page_len' => 1234 ],
'MediaWiki:Fallback.css' => [ 'page_len' => 0 ],
] );
$expected = $titleInfo;
$module = $this->getMockBuilder( WikiModule::class )
->onlyMethods( [ 'getPages', 'getTitleInfo' ] )
->getMock();
$module->method( 'getPages' )->willReturn( $pages );
$module->method( 'getTitleInfo' )->willReturn( $titleInfo );
$context = $this->createMock( Context::class );
$module = TestingAccessWrapper::newFromObject( $module );
$this->assertSame( $expected, $module->getTitleInfo( $context ), 'Title info' );
}
public function testGetPreloadedTitleInfo() {
$pages = [
'MediaWiki:Common.css' => [ 'type' => 'styles' ],
// Regression against T145673. It's impossible to statically declare page names in
// a canonical way since the canonical prefix is localised. As such, the preload
// cache computed the right cache key, but failed to find the results when
// doing an intersect on the canonical result, producing an empty array.
'mediawiki: fallback.css' => [ 'type' => 'styles' ],
];
$titleInfo = $this->prepareTitleInfo( [
'MediaWiki:Common.css' => [ 'page_len' => 1234 ],
'MediaWiki:Fallback.css' => [ 'page_len' => 0 ],
] );
$expected = $titleInfo;
$module = $this->getMockBuilder( TestResourceLoaderWikiModule::class )
->onlyMethods( [ 'getPages' ] )
->getMock();
$module->method( 'getPages' )->willReturn( $pages );
// Can't mock static methods
$module::$returnFetchTitleInfo = $titleInfo;
$rl = new EmptyResourceLoader();
$context = new Context( $rl, new FauxRequest() );
TestResourceLoaderWikiModule::invalidateModuleCache(
new PageIdentityValue( 17, NS_MEDIAWIKI, 'Common.css', PageIdentity::LOCAL ),
null,
null,
WikiMap::getCurrentWikiId()
);
TestResourceLoaderWikiModule::preloadTitleInfo(
$context,
$this->createMock( IDatabase::class ),
[ 'testmodule' ]
);
$module = TestingAccessWrapper::newFromObject( $module );
$this->assertSame( $expected, $module->getTitleInfo( $context ), 'Title info' );
}
public function testGetPreloadedBadTitle() {
// Set up
TestResourceLoaderWikiModule::$returnFetchTitleInfo = [];
$rl = new EmptyResourceLoader();
$rl->getConfig()->set( 'UseSiteJs', true );
$rl->getConfig()->set( 'UseSiteCss', true );
$rl->register( 'testmodule', [
'class' => TestResourceLoaderWikiModule::class,
// Covers preloadTitleInfo branch for invalid page name
'styles' => [ '[x]' ],
] );
$context = new Context( $rl, new FauxRequest() );
// Act
TestResourceLoaderWikiModule::preloadTitleInfo(
$context,
$this->createMock( IDatabase::class ),
[ 'testmodule' ]
);
// Assert
$module = TestingAccessWrapper::newFromObject( $rl->getModule( 'testmodule' ) );
$this->assertSame( [], $module->getTitleInfo( $context ), 'Title info' );
}
public function testGetPreloadedTitleInfoEmpty() {
$context = new Context( new EmptyResourceLoader(), new FauxRequest() );
// This covers the early return case
$this->assertSame(
null,
WikiModule::preloadTitleInfo(
$context,
$this->createMock( IDatabase::class ),
[]
)
);
}
public static function provideGetContent() {
yield 'Bad title' => [ null, '[x]' ];
yield 'No JS content found' => [ null, [
'text' => 'MediaWiki:Foo.js',
'ns' => NS_MEDIAWIKI,
'title' => 'Foo.js',
] ];
yield 'JS content' => [ 'code;', [
'text' => 'MediaWiki:Foo.js',
'ns' => NS_MEDIAWIKI,
'title' => 'Foo.js',
], new JavaScriptContent( 'code;' ) ];
yield 'CSS content' => [ 'code {}', [
'text' => 'MediaWiki:Foo.css',
'ns' => NS_MEDIAWIKI,
'title' => 'Foo.css',
], new CssContent( 'code {}' ) ];
yield 'Wikitext content' => [ null, [
'text' => 'MediaWiki:Foo',
'ns' => NS_MEDIAWIKI,
'title' => 'Foo',
], new WikitextContent( 'code;' ) ];
}
/**
* @dataProvider provideGetContent
*/
public function testGetContent( $expected, $title, Content $contentObj = null ) {
$context = $this->getResourceLoaderContext( [], new EmptyResourceLoader );
$module = $this->getMockBuilder( WikiModule::class )
->onlyMethods( [ 'getContentObj' ] )->getMock();
$module->method( 'getContentObj' )
->willReturn( $contentObj );
if ( is_array( $title ) ) {
$title += [ 'ns' => NS_MAIN, 'id' => 1, 'len' => 1, 'redirect' => 0 ];
$titleText = $title['text'];
// Mock page table access via PageStore
$pageStore = $this->createNoOpMock( PageStore::class, [ 'getPageByText' ] );
$pageStore->method( 'getPageByText' )->willReturn(
new PageIdentityValue(
$title['id'], $title['ns'], $title['text'], PageRecord::LOCAL
)
);
} else {
$titleText = $title;
}
$module = TestingAccessWrapper::newFromObject( $module );
$this->assertSame(
$expected,
$module->getContent( $titleText, $context )
);
}
public function testContentOverrides() {
$pages = [
'MediaWiki:Common.css' => [ 'type' => 'style' ],
];
$rl = new EmptyResourceLoader();
$module = $this->getMockBuilder( WikiModule::class )
->onlyMethods( [ 'getPages' ] )
->getMock();
$module->method( 'getPages' )->willReturn( $pages );
$module->setConfig( $rl->getConfig() );
$context = new DerivativeContext(
new Context( $rl, new FauxRequest() )
);
$context->setContentOverrideCallback( static function ( PageIdentity $t ) {
if ( $t->getDBkey() === 'Common.css' ) {
return new CssContent( '.override{}' );
}
return null;
} );
$this->assertTrue( $module->shouldEmbedModule( $context ) );
$this->assertSame( [
'all' => [
"/*\nMediaWiki:Common.css\n*/\n.override{}"
]
], $module->getStyles( $context ) );
$context->setContentOverrideCallback( static function ( PageIdentity $t ) {
if ( $t->getDBkey() === 'Skin.css' ) {
return new CssContent( '.override{}' );
}
return null;
} );
$this->assertFalse( $module->shouldEmbedModule( $context ) );
}
public function testGetContentForRedirects() {
// Set up context and module object
$context = new DerivativeContext(
$this->getResourceLoaderContext( [], new EmptyResourceLoader )
);
$module = $this->getMockBuilder( WikiModule::class )
->onlyMethods( [ 'getPages' ] )
->getMock();
$module->method( 'getPages' )
->willReturn( [
'MediaWiki:Redirect.js' => [ 'type' => 'script' ]
] );
$module->setConfig( $context->getResourceLoader()->getConfig() );
$context->setContentOverrideCallback( static function ( PageIdentity $title ) {
if ( $title->getDBkey() === 'Redirect.js' ) {
$handler = new JavaScriptContentHandler();
return $handler->makeRedirectContent(
Title::makeTitle( NS_MEDIAWIKI, 'Target.js' )
);
} elseif ( $title->getDBkey() === 'Target.js' ) {
return new JavaScriptContent( 'target;' );
} else {
return null;
}
} );
// Mock away Title's db queries with LinkCache
$this->addGoodLinkObject( 1, new TitleValue( NS_MEDIAWIKI, 'Redirect.js' ), 1, 1 );
$this->assertSame(
"/*\nMediaWiki:Redirect.js\n*/\ntarget;\n",
$module->getScript( $context ),
'Redirect resolved by getContent'
);
}
protected function tearDown(): void {
Title::clearCaches();
parent::tearDown();
}
}
class TestResourceLoaderWikiModule extends WikiModule {
public static $returnFetchTitleInfo = null;
protected static function fetchTitleInfo( IDatabase $db, array $pages, $fname = null ) {
$ret = self::$returnFetchTitleInfo;
self::$returnFetchTitleInfo = null;
return $ret;
}
}