wiki.techinc.nl/maintenance/update.php

318 lines
10 KiB
PHP
Raw Normal View History

#!/usr/bin/env php
<?php
/**
* Run all updaters.
*
* This is used when the database schema is modified and we need to apply patches.
*
* This program is free software; you can redistribute it and/or modify
* it under the terms of the GNU General Public License as published by
* the Free Software Foundation; either version 2 of the License, or
* (at your option) any later version.
*
* This program is distributed in the hope that it will be useful,
* but WITHOUT ANY WARRANTY; without even the implied warranty of
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
* GNU General Public License for more details.
*
* You should have received a copy of the GNU General Public License along
* with this program; if not, write to the Free Software Foundation, Inc.,
* 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
* http://www.gnu.org/copyleft/gpl.html
*
* @file
* @todo document
* @ingroup Maintenance
*/
Safer autoloading with respect to file-scope code Many files were in the autoloader despite having potentially harmful file-scope code. * Exclude all CommandLineInc maintenance scripts from the autoloader. * Introduce "NO_AUTOLOAD" tag which excludes the file containing it from the autoloader. Use it on CommandLineInc.php and a few suspicious-looking files without classes in case they are refactored to add classes in the future. * Add a test which parses all non-PSR4 class files and confirms that they do not contain dangerous file-scope code. It's slow (15s) but its results were enlightening. * Several maintenance scripts define constants in the file scope, intending to modify the behaviour of MediaWiki. Either move the define() to a later setup function, or protect with NO_AUTOLOAD. * Use require_once consistently with Maintenance.php and doMaintenance.php, per the original convention which is supposed to allow one maintenance script to use the class of another maintenance script. Using require breaks autoloading of these maintenance class files. * When Maintenance.php is included, check if MediaWiki has already started, and if so, return early. Revert the fix for T250003 which is incompatible with this safety measure. Hopefully it was superseded by splitting out the class file. * In runScript.php add a redundant PHP_SAPI check since it does some things in file-scope code before any other check will be run. * Change the if(false) class_alias(...) to something more hackish and more compatible with the new test. * Some site-related scripts found Maintenance.php in a non-standard way. Use the standard way. * fileOpPerfTest.php called error_reporting(). Probably debugging code left in; removed. * Moved mediawiki.compress.7z registration from the class file to the caller. Change-Id: I1b1be90343a5ab678df6f1b1bdd03319dcf6537f
2021-01-08 02:16:02 +00:00
// NO_AUTOLOAD -- due to hashbang above
require_once __DIR__ . '/Maintenance.php';
use MediaWiki\MediaWikiServices;
use MediaWiki\Settings\SettingsBuilder;
use MediaWiki\WikiMap\WikiMap;
use Wikimedia\Rdbms\DatabaseSqlite;
/**
* Maintenance script to run database schema updates.
*
* @ingroup Maintenance
*/
class UpdateMediaWiki extends Maintenance {
public function __construct() {
parent::__construct();
$this->addDescription( 'MediaWiki database updater' );
$this->addOption( 'skip-compat-checks', 'Skips compatibility checks, mostly for developers' );
$this->addOption( 'quick', 'Skip 5 second countdown before starting' );
$this->addOption( 'doshared', 'Also update shared tables' );
$this->addOption( 'noschema', 'Only do the updates that are not done during schema updates' );
$this->addOption(
'schema',
'Output SQL to do the schema updates instead of doing them. Works '
. 'even when $wgAllowSchemaUpdates is false',
false,
true
);
$this->addOption( 'force', 'Override when $wgAllowSchemaUpdates disables this script' );
$this->addOption(
'skip-external-dependencies',
'Skips checking whether external dependencies are up to date, mostly for developers'
);
$this->addOption(
'skip-config-validation',
'Skips checking whether the existing configuration is valid'
);
}
public function getDbType() {
return Maintenance::DB_ADMIN;
}
private function compatChecks() {
$minimumPcreVersion = Installer::MINIMUM_PCRE_VERSION;
$pcreVersion = explode( ' ', PCRE_VERSION, 2 )[0];
if ( version_compare( $pcreVersion, $minimumPcreVersion, '<' ) ) {
$this->fatalError(
"PCRE $minimumPcreVersion or later is required.\n" .
"Your PHP binary is linked with PCRE $pcreVersion.\n\n" .
"More information:\n" .
"https://www.mediawiki.org/wiki/Manual:Errors_and_symptoms/PCRE\n\n" .
"ABORTING.\n" );
}
}
public function execute() {
global $wgLang, $wgAllowSchemaUpdates, $wgMessagesDirs;
if ( !$wgAllowSchemaUpdates
&& !( $this->hasOption( 'force' )
|| $this->hasOption( 'schema' )
|| $this->hasOption( 'noschema' ) )
) {
$this->fatalError( "Do not run update.php on this wiki. If you're seeing this you should\n"
. "probably ask for some help in performing your schema updates or use\n"
. "the --noschema and --schema options to get an SQL file for someone\n"
. "else to inspect and run.\n\n"
. "If you know what you are doing, you can continue with --force\n" );
}
$this->fileHandle = null;
if ( substr( $this->getOption( 'schema', '' ), 0, 2 ) === "--" ) {
$this->fatalError( "The --schema option requires a file as an argument.\n" );
} elseif ( $this->hasOption( 'schema' ) ) {
$file = $this->getOption( 'schema' );
$this->fileHandle = fopen( $file, "w" );
if ( $this->fileHandle === false ) {
$err = error_get_last();
$this->fatalError( "Problem opening the schema file for writing: $file\n\t{$err['message']}" );
}
}
// Check for warnings about settings, and abort if there are any.
if ( !$this->hasOption( 'skip-config-validation' ) ) {
$this->validateSettings();
}
// T206765: We need to load the installer i18n files as some of errors come installer/updater code
$wgMessagesDirs['MediawikiInstaller'] = dirname( __DIR__ ) . '/includes/installer/i18n';
$lang = MediaWikiServices::getInstance()->getLanguageFactory()->getLanguage( 'en' );
// Set global language to ensure localised errors are in English (T22633)
RequestContext::getMain()->setLanguage( $lang );
// BackCompat
$wgLang = $lang;
define( 'MW_UPDATER', true );
$this->output( 'MediaWiki ' . MW_VERSION . " Updater\n\n" );
MediaWikiServices::getInstance()->getDBLoadBalancerFactory()->waitForReplication();
if ( !$this->hasOption( 'skip-compat-checks' ) ) {
$this->compatChecks();
} else {
$this->output( "Skipping compatibility checks, proceed at your own risk (Ctrl+C to abort)\n" );
$this->countDown( 5 );
}
// Check external dependencies are up to date
if ( !$this->hasOption( 'skip-external-dependencies' ) ) {
$composerLockUpToDate = $this->runChild( CheckComposerLockUpToDate::class );
$composerLockUpToDate->execute();
} else {
$this->output(
"Skipping checking whether external dependencies are up to date, proceed at your own risk\n"
);
}
# Attempt to connect to the database as a privileged user
# This will vomit up an error if there are permissions problems
$db = $this->getDB( DB_PRIMARY );
# Check to see whether the database server meets the minimum requirements
/** @var DatabaseInstaller $dbInstallerClass */
$dbInstallerClass = Installer::getDBInstallerClass( $db->getType() );
$status = $dbInstallerClass::meetsMinimumRequirement( $db->getServerVersion() );
if ( !$status->isOK() ) {
// This might output some wikitext like <strong> but it should be comprehensible
$text = $status->getWikiText();
$this->fatalError( $text );
}
$dbDomain = WikiMap::getCurrentWikiDbDomain()->getId();
$this->output( "Going to run database updates for $dbDomain\n" );
if ( $db->getType() === 'sqlite' ) {
/** @var DatabaseSqlite $db */
'@phan-var DatabaseSqlite $db';
$this->output( "Using SQLite file: '{$db->getDbFilePath()}'\n" );
}
$this->output( "Depending on the size of your database this may take a while!\n" );
if ( !$this->hasOption( 'quick' ) ) {
$this->output( "Abort with control-c in the next five seconds "
. "(skip this countdown with --quick) ..." );
$this->countDown( 5 );
}
$time1 = microtime( true );
$shared = $this->hasOption( 'doshared' );
$updates = [ 'core', 'extensions' ];
if ( !$this->hasOption( 'schema' ) ) {
if ( $this->hasOption( 'noschema' ) ) {
$updates[] = 'noschema';
}
$updates[] = 'stats';
}
$updater = DatabaseUpdater::newForDB( $db, $shared, $this );
// Avoid upgrading from versions older than 1.35
// Using an implicit marker (ar_user was dropped in 1.34)
// TODO: Use an explicit marker
// See T259771
if ( $updater->fieldExists( 'archive', 'ar_user' ) ) {
$this->fatalError(
"Can not upgrade from versions older than 1.35, please upgrade to that version or later first."
);
}
$updater->doUpdates( $updates );
foreach ( $updater->getPostDatabaseUpdateMaintenance() as $maint ) {
$child = $this->runChild( $maint );
// LoggedUpdateMaintenance is checking the updatelog itself
$isLoggedUpdate = $child instanceof LoggedUpdateMaintenance;
if ( !$isLoggedUpdate && $updater->updateRowExists( $maint ) ) {
continue;
}
$child->execute();
if ( !$isLoggedUpdate ) {
$updater->insertUpdateRow( $maint );
}
}
$updater->setFileAccess();
$updater->purgeCache();
$time2 = microtime( true );
$timeDiff = $lang->formatTimePeriod( $time2 - $time1 );
$this->output( "\nDone in $timeDiff.\n" );
}
protected function afterFinalSetup() {
global $wgLocalisationCacheConf;
# Don't try to access the database
# This needs to be disabled early since extensions will try to use the l10n
# cache from $wgExtensionFunctions (T22471)
$wgLocalisationCacheConf = [
'class' => LocalisationCache::class,
'storeClass' => LCStoreNull::class,
'storeDirectory' => false,
'manualRecache' => false,
];
}
/**
* @suppress PhanPluginDuplicateConditionalNullCoalescing
*/
public function validateParamsAndArgs() {
// Allow extensions to add additional params.
$params = [];
Hooks::run() call site migration Migrate all callers of Hooks::run() to use the new HookContainer/HookRunner system. General principles: * Use DI if it is already used. We're not changing the way state is managed in this patch. * HookContainer is always injected, not HookRunner. HookContainer is a service, it's a more generic interface, it is the only thing that provides isRegistered() which is needed in some cases, and a HookRunner can be efficiently constructed from it (confirmed by benchmark). Because HookContainer is needed for object construction, it is also needed by all factories. * "Ask your friendly local base class". Big hierarchies like SpecialPage and ApiBase have getHookContainer() and getHookRunner() methods in the base class, and classes that extend that base class are not expected to know or care where the base class gets its HookContainer from. * ProtectedHookAccessorTrait provides protected getHookContainer() and getHookRunner() methods, getting them from the global service container. The point of this is to ease migration to DI by ensuring that call sites ask their local friendly base class rather than getting a HookRunner from the service container directly. * Private $this->hookRunner. In some smaller classes where accessor methods did not seem warranted, there is a private HookRunner property which is accessed directly. Very rarely (two cases), there is a protected property, for consistency with code that conventionally assumes protected=private, but in cases where the class might actually be overridden, a protected accessor is preferred over a protected property. * The last resort: Hooks::runner(). Mostly for static, file-scope and global code. In a few cases it was used for objects with broken construction schemes, out of horror or laziness. Constructors with new required arguments: * AuthManager * BadFileLookup * BlockManager * ClassicInterwikiLookup * ContentHandlerFactory * ContentSecurityPolicy * DefaultOptionsManager * DerivedPageDataUpdater * FullSearchResultWidget * HtmlCacheUpdater * LanguageFactory * LanguageNameUtils * LinkRenderer * LinkRendererFactory * LocalisationCache * MagicWordFactory * MessageCache * NamespaceInfo * PageEditStash * PageHandlerFactory * PageUpdater * ParserFactory * PermissionManager * RevisionStore * RevisionStoreFactory * SearchEngineConfig * SearchEngineFactory * SearchFormWidget * SearchNearMatcher * SessionBackend * SpecialPageFactory * UserNameUtils * UserOptionsManager * WatchedItemQueryService * WatchedItemStore Constructors with new optional arguments: * DefaultPreferencesFactory * Language * LinkHolderArray * MovePage * Parser * ParserCache * PasswordReset * Router setHookContainer() now required after construction: * AuthenticationProvider * ResourceLoaderModule * SearchEngine Change-Id: Id442b0dbe43aba84bd5cf801d86dedc768b082c7
2020-03-19 02:42:09 +00:00
$this->getHookRunner()->onMaintenanceUpdateAddParams( $params );
// This executes before the PHP version check, so don't use null coalesce (??).
// Keeping this compatible with older PHP versions lets us reach the code that
// displays a more helpful error.
foreach ( $params as $name => $param ) {
$this->addOption(
$name,
$param['desc'],
isset( $param['require'] ) ? $param['require'] : false,
isset( $param['withArg'] ) ? $param['withArg'] : false,
isset( $param['shortName'] ) ? $param['shortName'] : false,
isset( $param['multiOccurrence'] ) ? $param['multiOccurrence'] : false
);
}
parent::validateParamsAndArgs();
}
private function formatWarnings( array $warnings ) {
$text = '';
foreach ( $warnings as $warning ) {
$warning = wordwrap( $warning, 75, "\n " );
$text .= "* $warning\n";
}
return $text;
}
private function validateSettings() {
$settings = SettingsBuilder::getInstance();
$warnings = [];
if ( $settings->getWarnings() ) {
$warnings = $settings->getWarnings();
}
$status = $settings->validate();
if ( !$status->isOK() ) {
foreach ( $status->getErrorsByType( 'error' ) as $msg ) {
$msg = wfMessage( $msg['message'], ...$msg['params'] );
$warnings[] = $msg->text();
}
}
$deprecations = $settings->detectDeprecatedConfig();
foreach ( $deprecations as $key => $msg ) {
$warnings[] = "$key is deprecated: $msg";
}
$obsolete = $settings->detectObsoleteConfig();
foreach ( $obsolete as $key => $msg ) {
$warnings[] = "$key is obsolete: $msg";
}
if ( $warnings ) {
$this->fatalError( "Some of your configuration settings caused a warning:\n\n"
. $this->formatWarnings( $warnings ) . "\n"
. "Please correct the issue before running update.php again.\n"
. "If you know what you are doing, you can bypass this check\n"
. "using --skip-config-validation.\n" );
}
}
}
$maintClass = UpdateMediaWiki::class;
require_once RUN_MAINTENANCE_IF_MAIN;