Add LinkRenderer (rewrite of Linker::link())
This is a rewrite of Linker::link() to a non-static, LinkTarget-based
interface. Users of plain Linker::link() with no options can use the
LinkRenderer instance provided by MediaWikiServices. Others that
have specific options should create and configure their own instance,
which can be used to create as many links as necessary.
The main entrypoints for making links are:
* ->makeLink( $target, $text, $attribs, $query );
* ->makeKnownLink( $target, $text, $attribs, $query );
* ->makeBrokenLink( $target, $text, $attribs, $query );
The order of the parameters are the same as Linker::link(), except
$options are now part of the LinkRenderer instance, and
known/broken status requires calling the function explicitly.
Additionally, instead of passing in raw $html for the link text, the
$text parameter will automatically be escaped unless it is specially
marked as safe HTML using the MediaWiki\Linker\HtmlArmor class.
The LinkBegin and LinkEnd hooks are now deprecated, but still function
for backwards-compatability. Clients should migrate to the nearly-
equivalent LinkRendererBegin and LinkRendererEnd hooks.
The main differences between the hooks are:
* Passing HtmlPageLinkRenderer object instead of deprecated DummyLinker
* Using LinkTarget instead of Title
* Begin hook can no longer change known/broken status of link. Use the
TitleIsAlwaysKnown hook for that.
* $options are no longer passed, they can be read (but shouldn't be
modified!) from the LinkRenderer object.
Bug: T469
Change-Id: I057cc86ae6404a080aa3c8e0e956ecbb10a897d5
2016-04-21 20:13:21 +00:00
|
|
|
<?php
|
|
|
|
|
|
|
|
|
|
use MediaWiki\Linker\LinkRenderer;
|
2016-05-27 16:11:58 +00:00
|
|
|
use MediaWiki\Linker\LinkRendererFactory;
|
Add LinkRenderer (rewrite of Linker::link())
This is a rewrite of Linker::link() to a non-static, LinkTarget-based
interface. Users of plain Linker::link() with no options can use the
LinkRenderer instance provided by MediaWikiServices. Others that
have specific options should create and configure their own instance,
which can be used to create as many links as necessary.
The main entrypoints for making links are:
* ->makeLink( $target, $text, $attribs, $query );
* ->makeKnownLink( $target, $text, $attribs, $query );
* ->makeBrokenLink( $target, $text, $attribs, $query );
The order of the parameters are the same as Linker::link(), except
$options are now part of the LinkRenderer instance, and
known/broken status requires calling the function explicitly.
Additionally, instead of passing in raw $html for the link text, the
$text parameter will automatically be escaped unless it is specially
marked as safe HTML using the MediaWiki\Linker\HtmlArmor class.
The LinkBegin and LinkEnd hooks are now deprecated, but still function
for backwards-compatability. Clients should migrate to the nearly-
equivalent LinkRendererBegin and LinkRendererEnd hooks.
The main differences between the hooks are:
* Passing HtmlPageLinkRenderer object instead of deprecated DummyLinker
* Using LinkTarget instead of Title
* Begin hook can no longer change known/broken status of link. Use the
TitleIsAlwaysKnown hook for that.
* $options are no longer passed, they can be read (but shouldn't be
modified!) from the LinkRenderer object.
Bug: T469
Change-Id: I057cc86ae6404a080aa3c8e0e956ecbb10a897d5
2016-04-21 20:13:21 +00:00
|
|
|
use MediaWiki\MediaWikiServices;
|
2021-03-25 11:45:56 +00:00
|
|
|
use MediaWiki\Page\PageReference;
|
|
|
|
|
use MediaWiki\Page\PageReferenceValue;
|
Add LinkRenderer (rewrite of Linker::link())
This is a rewrite of Linker::link() to a non-static, LinkTarget-based
interface. Users of plain Linker::link() with no options can use the
LinkRenderer instance provided by MediaWikiServices. Others that
have specific options should create and configure their own instance,
which can be used to create as many links as necessary.
The main entrypoints for making links are:
* ->makeLink( $target, $text, $attribs, $query );
* ->makeKnownLink( $target, $text, $attribs, $query );
* ->makeBrokenLink( $target, $text, $attribs, $query );
The order of the parameters are the same as Linker::link(), except
$options are now part of the LinkRenderer instance, and
known/broken status requires calling the function explicitly.
Additionally, instead of passing in raw $html for the link text, the
$text parameter will automatically be escaped unless it is specially
marked as safe HTML using the MediaWiki\Linker\HtmlArmor class.
The LinkBegin and LinkEnd hooks are now deprecated, but still function
for backwards-compatability. Clients should migrate to the nearly-
equivalent LinkRendererBegin and LinkRendererEnd hooks.
The main differences between the hooks are:
* Passing HtmlPageLinkRenderer object instead of deprecated DummyLinker
* Using LinkTarget instead of Title
* Begin hook can no longer change known/broken status of link. Use the
TitleIsAlwaysKnown hook for that.
* $options are no longer passed, they can be read (but shouldn't be
modified!) from the LinkRenderer object.
Bug: T469
Change-Id: I057cc86ae6404a080aa3c8e0e956ecbb10a897d5
2016-04-21 20:13:21 +00:00
|
|
|
|
|
|
|
|
/**
|
2016-05-27 18:53:04 +00:00
|
|
|
* @covers MediaWiki\Linker\LinkRenderer
|
Add LinkRenderer (rewrite of Linker::link())
This is a rewrite of Linker::link() to a non-static, LinkTarget-based
interface. Users of plain Linker::link() with no options can use the
LinkRenderer instance provided by MediaWikiServices. Others that
have specific options should create and configure their own instance,
which can be used to create as many links as necessary.
The main entrypoints for making links are:
* ->makeLink( $target, $text, $attribs, $query );
* ->makeKnownLink( $target, $text, $attribs, $query );
* ->makeBrokenLink( $target, $text, $attribs, $query );
The order of the parameters are the same as Linker::link(), except
$options are now part of the LinkRenderer instance, and
known/broken status requires calling the function explicitly.
Additionally, instead of passing in raw $html for the link text, the
$text parameter will automatically be escaped unless it is specially
marked as safe HTML using the MediaWiki\Linker\HtmlArmor class.
The LinkBegin and LinkEnd hooks are now deprecated, but still function
for backwards-compatability. Clients should migrate to the nearly-
equivalent LinkRendererBegin and LinkRendererEnd hooks.
The main differences between the hooks are:
* Passing HtmlPageLinkRenderer object instead of deprecated DummyLinker
* Using LinkTarget instead of Title
* Begin hook can no longer change known/broken status of link. Use the
TitleIsAlwaysKnown hook for that.
* $options are no longer passed, they can be read (but shouldn't be
modified!) from the LinkRenderer object.
Bug: T469
Change-Id: I057cc86ae6404a080aa3c8e0e956ecbb10a897d5
2016-04-21 20:13:21 +00:00
|
|
|
*/
|
|
|
|
|
class LinkRendererTest extends MediaWikiLangTestCase {
|
|
|
|
|
|
|
|
|
|
/**
|
2016-05-27 16:11:58 +00:00
|
|
|
* @var LinkRendererFactory
|
Add LinkRenderer (rewrite of Linker::link())
This is a rewrite of Linker::link() to a non-static, LinkTarget-based
interface. Users of plain Linker::link() with no options can use the
LinkRenderer instance provided by MediaWikiServices. Others that
have specific options should create and configure their own instance,
which can be used to create as many links as necessary.
The main entrypoints for making links are:
* ->makeLink( $target, $text, $attribs, $query );
* ->makeKnownLink( $target, $text, $attribs, $query );
* ->makeBrokenLink( $target, $text, $attribs, $query );
The order of the parameters are the same as Linker::link(), except
$options are now part of the LinkRenderer instance, and
known/broken status requires calling the function explicitly.
Additionally, instead of passing in raw $html for the link text, the
$text parameter will automatically be escaped unless it is specially
marked as safe HTML using the MediaWiki\Linker\HtmlArmor class.
The LinkBegin and LinkEnd hooks are now deprecated, but still function
for backwards-compatability. Clients should migrate to the nearly-
equivalent LinkRendererBegin and LinkRendererEnd hooks.
The main differences between the hooks are:
* Passing HtmlPageLinkRenderer object instead of deprecated DummyLinker
* Using LinkTarget instead of Title
* Begin hook can no longer change known/broken status of link. Use the
TitleIsAlwaysKnown hook for that.
* $options are no longer passed, they can be read (but shouldn't be
modified!) from the LinkRenderer object.
Bug: T469
Change-Id: I057cc86ae6404a080aa3c8e0e956ecbb10a897d5
2016-04-21 20:13:21 +00:00
|
|
|
*/
|
2016-05-27 16:11:58 +00:00
|
|
|
private $factory;
|
Add LinkRenderer (rewrite of Linker::link())
This is a rewrite of Linker::link() to a non-static, LinkTarget-based
interface. Users of plain Linker::link() with no options can use the
LinkRenderer instance provided by MediaWikiServices. Others that
have specific options should create and configure their own instance,
which can be used to create as many links as necessary.
The main entrypoints for making links are:
* ->makeLink( $target, $text, $attribs, $query );
* ->makeKnownLink( $target, $text, $attribs, $query );
* ->makeBrokenLink( $target, $text, $attribs, $query );
The order of the parameters are the same as Linker::link(), except
$options are now part of the LinkRenderer instance, and
known/broken status requires calling the function explicitly.
Additionally, instead of passing in raw $html for the link text, the
$text parameter will automatically be escaped unless it is specially
marked as safe HTML using the MediaWiki\Linker\HtmlArmor class.
The LinkBegin and LinkEnd hooks are now deprecated, but still function
for backwards-compatability. Clients should migrate to the nearly-
equivalent LinkRendererBegin and LinkRendererEnd hooks.
The main differences between the hooks are:
* Passing HtmlPageLinkRenderer object instead of deprecated DummyLinker
* Using LinkTarget instead of Title
* Begin hook can no longer change known/broken status of link. Use the
TitleIsAlwaysKnown hook for that.
* $options are no longer passed, they can be read (but shouldn't be
modified!) from the LinkRenderer object.
Bug: T469
Change-Id: I057cc86ae6404a080aa3c8e0e956ecbb10a897d5
2016-04-21 20:13:21 +00:00
|
|
|
|
2020-06-14 10:51:39 +00:00
|
|
|
protected function setUp() : void {
|
Add LinkRenderer (rewrite of Linker::link())
This is a rewrite of Linker::link() to a non-static, LinkTarget-based
interface. Users of plain Linker::link() with no options can use the
LinkRenderer instance provided by MediaWikiServices. Others that
have specific options should create and configure their own instance,
which can be used to create as many links as necessary.
The main entrypoints for making links are:
* ->makeLink( $target, $text, $attribs, $query );
* ->makeKnownLink( $target, $text, $attribs, $query );
* ->makeBrokenLink( $target, $text, $attribs, $query );
The order of the parameters are the same as Linker::link(), except
$options are now part of the LinkRenderer instance, and
known/broken status requires calling the function explicitly.
Additionally, instead of passing in raw $html for the link text, the
$text parameter will automatically be escaped unless it is specially
marked as safe HTML using the MediaWiki\Linker\HtmlArmor class.
The LinkBegin and LinkEnd hooks are now deprecated, but still function
for backwards-compatability. Clients should migrate to the nearly-
equivalent LinkRendererBegin and LinkRendererEnd hooks.
The main differences between the hooks are:
* Passing HtmlPageLinkRenderer object instead of deprecated DummyLinker
* Using LinkTarget instead of Title
* Begin hook can no longer change known/broken status of link. Use the
TitleIsAlwaysKnown hook for that.
* $options are no longer passed, they can be read (but shouldn't be
modified!) from the LinkRenderer object.
Bug: T469
Change-Id: I057cc86ae6404a080aa3c8e0e956ecbb10a897d5
2016-04-21 20:13:21 +00:00
|
|
|
parent::setUp();
|
|
|
|
|
$this->setMwGlobals( [
|
|
|
|
|
'wgArticlePath' => '/wiki/$1',
|
|
|
|
|
'wgServer' => '//example.org',
|
|
|
|
|
'wgCanonicalServer' => 'http://example.org',
|
|
|
|
|
'wgScriptPath' => '/w',
|
|
|
|
|
'wgScript' => '/w/index.php',
|
|
|
|
|
] );
|
2016-05-27 16:11:58 +00:00
|
|
|
$this->factory = MediaWikiServices::getInstance()->getLinkRendererFactory();
|
Add LinkRenderer (rewrite of Linker::link())
This is a rewrite of Linker::link() to a non-static, LinkTarget-based
interface. Users of plain Linker::link() with no options can use the
LinkRenderer instance provided by MediaWikiServices. Others that
have specific options should create and configure their own instance,
which can be used to create as many links as necessary.
The main entrypoints for making links are:
* ->makeLink( $target, $text, $attribs, $query );
* ->makeKnownLink( $target, $text, $attribs, $query );
* ->makeBrokenLink( $target, $text, $attribs, $query );
The order of the parameters are the same as Linker::link(), except
$options are now part of the LinkRenderer instance, and
known/broken status requires calling the function explicitly.
Additionally, instead of passing in raw $html for the link text, the
$text parameter will automatically be escaped unless it is specially
marked as safe HTML using the MediaWiki\Linker\HtmlArmor class.
The LinkBegin and LinkEnd hooks are now deprecated, but still function
for backwards-compatability. Clients should migrate to the nearly-
equivalent LinkRendererBegin and LinkRendererEnd hooks.
The main differences between the hooks are:
* Passing HtmlPageLinkRenderer object instead of deprecated DummyLinker
* Using LinkTarget instead of Title
* Begin hook can no longer change known/broken status of link. Use the
TitleIsAlwaysKnown hook for that.
* $options are no longer passed, they can be read (but shouldn't be
modified!) from the LinkRenderer object.
Bug: T469
Change-Id: I057cc86ae6404a080aa3c8e0e956ecbb10a897d5
2016-04-21 20:13:21 +00:00
|
|
|
}
|
|
|
|
|
|
2021-03-25 11:45:56 +00:00
|
|
|
public function provideMergeAttribs() {
|
|
|
|
|
yield [ new TitleValue( NS_SPECIAL, 'BlankPage' ) ];
|
|
|
|
|
yield [ new PageReferenceValue( NS_SPECIAL, 'BlankPage', PageReference::LOCAL ) ];
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
/**
|
|
|
|
|
* @dataProvider provideMergeAttribs
|
|
|
|
|
* @covers \MediaWiki\Linker\LinkRenderer::makeBrokenLink
|
|
|
|
|
*/
|
|
|
|
|
public function testMergeAttribs( $target ) {
|
2016-05-27 16:11:58 +00:00
|
|
|
$linkRenderer = $this->factory->create();
|
Add LinkRenderer (rewrite of Linker::link())
This is a rewrite of Linker::link() to a non-static, LinkTarget-based
interface. Users of plain Linker::link() with no options can use the
LinkRenderer instance provided by MediaWikiServices. Others that
have specific options should create and configure their own instance,
which can be used to create as many links as necessary.
The main entrypoints for making links are:
* ->makeLink( $target, $text, $attribs, $query );
* ->makeKnownLink( $target, $text, $attribs, $query );
* ->makeBrokenLink( $target, $text, $attribs, $query );
The order of the parameters are the same as Linker::link(), except
$options are now part of the LinkRenderer instance, and
known/broken status requires calling the function explicitly.
Additionally, instead of passing in raw $html for the link text, the
$text parameter will automatically be escaped unless it is specially
marked as safe HTML using the MediaWiki\Linker\HtmlArmor class.
The LinkBegin and LinkEnd hooks are now deprecated, but still function
for backwards-compatability. Clients should migrate to the nearly-
equivalent LinkRendererBegin and LinkRendererEnd hooks.
The main differences between the hooks are:
* Passing HtmlPageLinkRenderer object instead of deprecated DummyLinker
* Using LinkTarget instead of Title
* Begin hook can no longer change known/broken status of link. Use the
TitleIsAlwaysKnown hook for that.
* $options are no longer passed, they can be read (but shouldn't be
modified!) from the LinkRenderer object.
Bug: T469
Change-Id: I057cc86ae6404a080aa3c8e0e956ecbb10a897d5
2016-04-21 20:13:21 +00:00
|
|
|
$link = $linkRenderer->makeBrokenLink( $target, null, [
|
|
|
|
|
// Appended to class
|
|
|
|
|
'class' => 'foobar',
|
|
|
|
|
// Suppresses href attribute
|
|
|
|
|
'href' => false,
|
|
|
|
|
// Extra attribute
|
|
|
|
|
'bar' => 'baz'
|
|
|
|
|
] );
|
|
|
|
|
$this->assertEquals(
|
|
|
|
|
'<a href="/wiki/Special:BlankPage" class="new foobar" '
|
|
|
|
|
. 'title="Special:BlankPage (page does not exist)" bar="baz">'
|
|
|
|
|
. 'Special:BlankPage</a>',
|
|
|
|
|
$link
|
|
|
|
|
);
|
|
|
|
|
}
|
|
|
|
|
|
2021-03-25 11:45:56 +00:00
|
|
|
public function provideMakeKnownLink() {
|
|
|
|
|
yield [ new TitleValue( NS_MAIN, 'Foobar' ) ];
|
|
|
|
|
yield [ new PageReferenceValue( NS_MAIN, 'Foobar', PageReference::LOCAL ) ];
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
/**
|
|
|
|
|
* @dataProvider provideMakeKnownLink
|
|
|
|
|
* @covers \MediaWiki\Linker\LinkRenderer::makeKnownLink
|
|
|
|
|
*/
|
|
|
|
|
public function testMakeKnownLink( $target ) {
|
2016-05-27 16:11:58 +00:00
|
|
|
$linkRenderer = $this->factory->create();
|
Add LinkRenderer (rewrite of Linker::link())
This is a rewrite of Linker::link() to a non-static, LinkTarget-based
interface. Users of plain Linker::link() with no options can use the
LinkRenderer instance provided by MediaWikiServices. Others that
have specific options should create and configure their own instance,
which can be used to create as many links as necessary.
The main entrypoints for making links are:
* ->makeLink( $target, $text, $attribs, $query );
* ->makeKnownLink( $target, $text, $attribs, $query );
* ->makeBrokenLink( $target, $text, $attribs, $query );
The order of the parameters are the same as Linker::link(), except
$options are now part of the LinkRenderer instance, and
known/broken status requires calling the function explicitly.
Additionally, instead of passing in raw $html for the link text, the
$text parameter will automatically be escaped unless it is specially
marked as safe HTML using the MediaWiki\Linker\HtmlArmor class.
The LinkBegin and LinkEnd hooks are now deprecated, but still function
for backwards-compatability. Clients should migrate to the nearly-
equivalent LinkRendererBegin and LinkRendererEnd hooks.
The main differences between the hooks are:
* Passing HtmlPageLinkRenderer object instead of deprecated DummyLinker
* Using LinkTarget instead of Title
* Begin hook can no longer change known/broken status of link. Use the
TitleIsAlwaysKnown hook for that.
* $options are no longer passed, they can be read (but shouldn't be
modified!) from the LinkRenderer object.
Bug: T469
Change-Id: I057cc86ae6404a080aa3c8e0e956ecbb10a897d5
2016-04-21 20:13:21 +00:00
|
|
|
|
|
|
|
|
// Query added
|
|
|
|
|
$this->assertEquals(
|
2019-03-01 21:15:22 +00:00
|
|
|
'<a href="/w/index.php?title=Foobar&foo=bar" title="Foobar">Foobar</a>',
|
Add LinkRenderer (rewrite of Linker::link())
This is a rewrite of Linker::link() to a non-static, LinkTarget-based
interface. Users of plain Linker::link() with no options can use the
LinkRenderer instance provided by MediaWikiServices. Others that
have specific options should create and configure their own instance,
which can be used to create as many links as necessary.
The main entrypoints for making links are:
* ->makeLink( $target, $text, $attribs, $query );
* ->makeKnownLink( $target, $text, $attribs, $query );
* ->makeBrokenLink( $target, $text, $attribs, $query );
The order of the parameters are the same as Linker::link(), except
$options are now part of the LinkRenderer instance, and
known/broken status requires calling the function explicitly.
Additionally, instead of passing in raw $html for the link text, the
$text parameter will automatically be escaped unless it is specially
marked as safe HTML using the MediaWiki\Linker\HtmlArmor class.
The LinkBegin and LinkEnd hooks are now deprecated, but still function
for backwards-compatability. Clients should migrate to the nearly-
equivalent LinkRendererBegin and LinkRendererEnd hooks.
The main differences between the hooks are:
* Passing HtmlPageLinkRenderer object instead of deprecated DummyLinker
* Using LinkTarget instead of Title
* Begin hook can no longer change known/broken status of link. Use the
TitleIsAlwaysKnown hook for that.
* $options are no longer passed, they can be read (but shouldn't be
modified!) from the LinkRenderer object.
Bug: T469
Change-Id: I057cc86ae6404a080aa3c8e0e956ecbb10a897d5
2016-04-21 20:13:21 +00:00
|
|
|
$linkRenderer->makeKnownLink( $target, null, [], [ 'foo' => 'bar' ] )
|
|
|
|
|
);
|
|
|
|
|
|
|
|
|
|
$linkRenderer->setForceArticlePath( true );
|
|
|
|
|
$this->assertEquals(
|
|
|
|
|
'<a href="/wiki/Foobar?foo=bar" title="Foobar">Foobar</a>',
|
|
|
|
|
$linkRenderer->makeKnownLink( $target, null, [], [ 'foo' => 'bar' ] )
|
|
|
|
|
);
|
|
|
|
|
|
|
|
|
|
// expand = HTTPS
|
|
|
|
|
$linkRenderer->setForceArticlePath( false );
|
|
|
|
|
$linkRenderer->setExpandURLs( PROTO_HTTPS );
|
|
|
|
|
$this->assertEquals(
|
|
|
|
|
'<a href="https://example.org/wiki/Foobar" title="Foobar">Foobar</a>',
|
|
|
|
|
$linkRenderer->makeKnownLink( $target )
|
|
|
|
|
);
|
|
|
|
|
}
|
|
|
|
|
|
2021-03-25 11:45:56 +00:00
|
|
|
public function provideMakeBrokenLink() {
|
|
|
|
|
yield [
|
|
|
|
|
new TitleValue( NS_MAIN, 'Foobar' ),
|
|
|
|
|
new TitleValue( NS_SPECIAL, 'Foobar' )
|
|
|
|
|
];
|
|
|
|
|
yield [
|
|
|
|
|
new PageReferenceValue( NS_MAIN, 'Foobar', PageReference::LOCAL ),
|
|
|
|
|
new PageReferenceValue( NS_SPECIAL, 'Foobar', PageReference::LOCAL )
|
|
|
|
|
];
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
/**
|
|
|
|
|
* @dataProvider provideMakeBrokenLink
|
|
|
|
|
* @covers \MediaWiki\Linker\LinkRenderer::makeBrokenLink
|
|
|
|
|
*/
|
|
|
|
|
public function testMakeBrokenLink( $target, $special ) {
|
2016-05-27 16:11:58 +00:00
|
|
|
$linkRenderer = $this->factory->create();
|
Add LinkRenderer (rewrite of Linker::link())
This is a rewrite of Linker::link() to a non-static, LinkTarget-based
interface. Users of plain Linker::link() with no options can use the
LinkRenderer instance provided by MediaWikiServices. Others that
have specific options should create and configure their own instance,
which can be used to create as many links as necessary.
The main entrypoints for making links are:
* ->makeLink( $target, $text, $attribs, $query );
* ->makeKnownLink( $target, $text, $attribs, $query );
* ->makeBrokenLink( $target, $text, $attribs, $query );
The order of the parameters are the same as Linker::link(), except
$options are now part of the LinkRenderer instance, and
known/broken status requires calling the function explicitly.
Additionally, instead of passing in raw $html for the link text, the
$text parameter will automatically be escaped unless it is specially
marked as safe HTML using the MediaWiki\Linker\HtmlArmor class.
The LinkBegin and LinkEnd hooks are now deprecated, but still function
for backwards-compatability. Clients should migrate to the nearly-
equivalent LinkRendererBegin and LinkRendererEnd hooks.
The main differences between the hooks are:
* Passing HtmlPageLinkRenderer object instead of deprecated DummyLinker
* Using LinkTarget instead of Title
* Begin hook can no longer change known/broken status of link. Use the
TitleIsAlwaysKnown hook for that.
* $options are no longer passed, they can be read (but shouldn't be
modified!) from the LinkRenderer object.
Bug: T469
Change-Id: I057cc86ae6404a080aa3c8e0e956ecbb10a897d5
2016-04-21 20:13:21 +00:00
|
|
|
|
|
|
|
|
// action=edit&redlink=1 added
|
|
|
|
|
$this->assertEquals(
|
|
|
|
|
'<a href="/w/index.php?title=Foobar&action=edit&redlink=1" '
|
|
|
|
|
. 'class="new" title="Foobar (page does not exist)">Foobar</a>',
|
|
|
|
|
$linkRenderer->makeBrokenLink( $target )
|
|
|
|
|
);
|
|
|
|
|
|
|
|
|
|
// action=edit&redlink=1 not added due to action query parameter
|
|
|
|
|
$this->assertEquals(
|
|
|
|
|
'<a href="/w/index.php?title=Foobar&action=foobar" class="new" '
|
|
|
|
|
. 'title="Foobar (page does not exist)">Foobar</a>',
|
|
|
|
|
$linkRenderer->makeBrokenLink( $target, null, [], [ 'action' => 'foobar' ] )
|
|
|
|
|
);
|
|
|
|
|
|
|
|
|
|
// action=edit&redlink=1 not added due to NS_SPECIAL
|
|
|
|
|
$this->assertEquals(
|
|
|
|
|
'<a href="/wiki/Special:Foobar" class="new" title="Special:Foobar '
|
|
|
|
|
. '(page does not exist)">Special:Foobar</a>',
|
|
|
|
|
$linkRenderer->makeBrokenLink( $special )
|
|
|
|
|
);
|
|
|
|
|
|
|
|
|
|
// fragment stripped
|
2021-03-25 11:45:56 +00:00
|
|
|
if ( $target instanceof LinkTarget ) {
|
|
|
|
|
$this->assertEquals(
|
|
|
|
|
'<a href="/w/index.php?title=Foobar&action=foobar" class="new" '
|
|
|
|
|
. 'title="Foobar (page does not exist)">Foobar</a>',
|
|
|
|
|
$linkRenderer->makeBrokenLink( $target->createFragmentTarget( 'foobar' ) )
|
|
|
|
|
);
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
public function provideMakeLink() {
|
|
|
|
|
yield [
|
|
|
|
|
new TitleValue( NS_SPECIAL, 'Foobar' ),
|
|
|
|
|
new TitleValue( NS_SPECIAL, 'BlankPage' )
|
|
|
|
|
];
|
|
|
|
|
yield [
|
|
|
|
|
new PageReferenceValue( NS_SPECIAL, 'Foobar', PageReference::LOCAL ),
|
|
|
|
|
new PageReferenceValue( NS_SPECIAL, 'BlankPage', PageReference::LOCAL )
|
|
|
|
|
];
|
Add LinkRenderer (rewrite of Linker::link())
This is a rewrite of Linker::link() to a non-static, LinkTarget-based
interface. Users of plain Linker::link() with no options can use the
LinkRenderer instance provided by MediaWikiServices. Others that
have specific options should create and configure their own instance,
which can be used to create as many links as necessary.
The main entrypoints for making links are:
* ->makeLink( $target, $text, $attribs, $query );
* ->makeKnownLink( $target, $text, $attribs, $query );
* ->makeBrokenLink( $target, $text, $attribs, $query );
The order of the parameters are the same as Linker::link(), except
$options are now part of the LinkRenderer instance, and
known/broken status requires calling the function explicitly.
Additionally, instead of passing in raw $html for the link text, the
$text parameter will automatically be escaped unless it is specially
marked as safe HTML using the MediaWiki\Linker\HtmlArmor class.
The LinkBegin and LinkEnd hooks are now deprecated, but still function
for backwards-compatability. Clients should migrate to the nearly-
equivalent LinkRendererBegin and LinkRendererEnd hooks.
The main differences between the hooks are:
* Passing HtmlPageLinkRenderer object instead of deprecated DummyLinker
* Using LinkTarget instead of Title
* Begin hook can no longer change known/broken status of link. Use the
TitleIsAlwaysKnown hook for that.
* $options are no longer passed, they can be read (but shouldn't be
modified!) from the LinkRenderer object.
Bug: T469
Change-Id: I057cc86ae6404a080aa3c8e0e956ecbb10a897d5
2016-04-21 20:13:21 +00:00
|
|
|
}
|
|
|
|
|
|
2021-03-25 11:45:56 +00:00
|
|
|
/**
|
|
|
|
|
* @dataProvider provideMakeLink
|
|
|
|
|
* @covers \MediaWiki\Linker\LinkRenderer::makeLink
|
|
|
|
|
*/
|
|
|
|
|
public function testMakeLink( $foobar, $blankpage ) {
|
2016-05-27 16:11:58 +00:00
|
|
|
$linkRenderer = $this->factory->create();
|
Add LinkRenderer (rewrite of Linker::link())
This is a rewrite of Linker::link() to a non-static, LinkTarget-based
interface. Users of plain Linker::link() with no options can use the
LinkRenderer instance provided by MediaWikiServices. Others that
have specific options should create and configure their own instance,
which can be used to create as many links as necessary.
The main entrypoints for making links are:
* ->makeLink( $target, $text, $attribs, $query );
* ->makeKnownLink( $target, $text, $attribs, $query );
* ->makeBrokenLink( $target, $text, $attribs, $query );
The order of the parameters are the same as Linker::link(), except
$options are now part of the LinkRenderer instance, and
known/broken status requires calling the function explicitly.
Additionally, instead of passing in raw $html for the link text, the
$text parameter will automatically be escaped unless it is specially
marked as safe HTML using the MediaWiki\Linker\HtmlArmor class.
The LinkBegin and LinkEnd hooks are now deprecated, but still function
for backwards-compatability. Clients should migrate to the nearly-
equivalent LinkRendererBegin and LinkRendererEnd hooks.
The main differences between the hooks are:
* Passing HtmlPageLinkRenderer object instead of deprecated DummyLinker
* Using LinkTarget instead of Title
* Begin hook can no longer change known/broken status of link. Use the
TitleIsAlwaysKnown hook for that.
* $options are no longer passed, they can be read (but shouldn't be
modified!) from the LinkRenderer object.
Bug: T469
Change-Id: I057cc86ae6404a080aa3c8e0e956ecbb10a897d5
2016-04-21 20:13:21 +00:00
|
|
|
$this->assertEquals(
|
|
|
|
|
'<a href="/wiki/Special:Foobar" class="new" title="Special:Foobar '
|
|
|
|
|
. '(page does not exist)">foo</a>',
|
|
|
|
|
$linkRenderer->makeLink( $foobar, 'foo' )
|
|
|
|
|
);
|
|
|
|
|
|
|
|
|
|
$this->assertEquals(
|
|
|
|
|
'<a href="/wiki/Special:BlankPage" title="Special:BlankPage">blank</a>',
|
|
|
|
|
$linkRenderer->makeLink( $blankpage, 'blank' )
|
|
|
|
|
);
|
|
|
|
|
|
|
|
|
|
$this->assertEquals(
|
|
|
|
|
'<a href="/wiki/Special:Foobar" class="new" title="Special:Foobar '
|
|
|
|
|
. '(page does not exist)"><script>evil()</script></a>',
|
|
|
|
|
$linkRenderer->makeLink( $foobar, '<script>evil()</script>' )
|
|
|
|
|
);
|
|
|
|
|
|
|
|
|
|
$this->assertEquals(
|
|
|
|
|
'<a href="/wiki/Special:Foobar" class="new" title="Special:Foobar '
|
|
|
|
|
. '(page does not exist)"><script>evil()</script></a>',
|
|
|
|
|
$linkRenderer->makeLink( $foobar, new HtmlArmor( '<script>evil()</script>' ) )
|
|
|
|
|
);
|
2018-06-10 19:12:52 +00:00
|
|
|
|
|
|
|
|
$this->assertEquals(
|
|
|
|
|
'<a href="#fragment">fragment</a>',
|
|
|
|
|
$linkRenderer->makeLink( Title::newFromText( '#fragment' ) )
|
|
|
|
|
);
|
Add LinkRenderer (rewrite of Linker::link())
This is a rewrite of Linker::link() to a non-static, LinkTarget-based
interface. Users of plain Linker::link() with no options can use the
LinkRenderer instance provided by MediaWikiServices. Others that
have specific options should create and configure their own instance,
which can be used to create as many links as necessary.
The main entrypoints for making links are:
* ->makeLink( $target, $text, $attribs, $query );
* ->makeKnownLink( $target, $text, $attribs, $query );
* ->makeBrokenLink( $target, $text, $attribs, $query );
The order of the parameters are the same as Linker::link(), except
$options are now part of the LinkRenderer instance, and
known/broken status requires calling the function explicitly.
Additionally, instead of passing in raw $html for the link text, the
$text parameter will automatically be escaped unless it is specially
marked as safe HTML using the MediaWiki\Linker\HtmlArmor class.
The LinkBegin and LinkEnd hooks are now deprecated, but still function
for backwards-compatability. Clients should migrate to the nearly-
equivalent LinkRendererBegin and LinkRendererEnd hooks.
The main differences between the hooks are:
* Passing HtmlPageLinkRenderer object instead of deprecated DummyLinker
* Using LinkTarget instead of Title
* Begin hook can no longer change known/broken status of link. Use the
TitleIsAlwaysKnown hook for that.
* $options are no longer passed, they can be read (but shouldn't be
modified!) from the LinkRenderer object.
Bug: T469
Change-Id: I057cc86ae6404a080aa3c8e0e956ecbb10a897d5
2016-04-21 20:13:21 +00:00
|
|
|
}
|
2016-05-27 16:11:58 +00:00
|
|
|
|
2021-03-25 11:45:56 +00:00
|
|
|
public function provideGetLinkClasses() {
|
|
|
|
|
yield [
|
|
|
|
|
new TitleValue( NS_MAIN, 'FooBar' ),
|
|
|
|
|
new TitleValue( NS_MAIN, 'Redirect' ),
|
|
|
|
|
new TitleValue( NS_USER, 'Someuser' )
|
|
|
|
|
];
|
|
|
|
|
yield [
|
|
|
|
|
new PageReferenceValue( NS_MAIN, 'FooBar', PageReference::LOCAL ),
|
|
|
|
|
new PageReferenceValue( NS_MAIN, 'Redirect', PageReference::LOCAL ),
|
|
|
|
|
new PageReferenceValue( NS_USER, 'Someuser', PageReference::LOCAL )
|
|
|
|
|
];
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
/**
|
|
|
|
|
* @dataProvider provideGetLinkClasses
|
|
|
|
|
* @covers \MediaWiki\Linker\LinkRenderer::getLinkClasses
|
|
|
|
|
*/
|
|
|
|
|
public function testGetLinkClasses( $foobarTitle, $redirectTitle, $userTitle ) {
|
2019-07-03 12:17:16 +00:00
|
|
|
$services = MediaWikiServices::getInstance();
|
|
|
|
|
$wanCache = $services->getMainWANObjectCache();
|
|
|
|
|
$titleFormatter = $services->getTitleFormatter();
|
|
|
|
|
$nsInfo = $services->getNamespaceInfo();
|
2020-05-22 18:33:06 +00:00
|
|
|
$specialPageFactory = $services->getSpecialPageFactory();
|
Hooks::run() call site migration
Migrate all callers of Hooks::run() to use the new
HookContainer/HookRunner system.
General principles:
* Use DI if it is already used. We're not changing the way state is
managed in this patch.
* HookContainer is always injected, not HookRunner. HookContainer
is a service, it's a more generic interface, it is the only
thing that provides isRegistered() which is needed in some cases,
and a HookRunner can be efficiently constructed from it
(confirmed by benchmark). Because HookContainer is needed
for object construction, it is also needed by all factories.
* "Ask your friendly local base class". Big hierarchies like
SpecialPage and ApiBase have getHookContainer() and getHookRunner()
methods in the base class, and classes that extend that base class
are not expected to know or care where the base class gets its
HookContainer from.
* ProtectedHookAccessorTrait provides protected getHookContainer() and
getHookRunner() methods, getting them from the global service
container. The point of this is to ease migration to DI by ensuring
that call sites ask their local friendly base class rather than
getting a HookRunner from the service container directly.
* Private $this->hookRunner. In some smaller classes where accessor
methods did not seem warranted, there is a private HookRunner property
which is accessed directly. Very rarely (two cases), there is a
protected property, for consistency with code that conventionally
assumes protected=private, but in cases where the class might actually
be overridden, a protected accessor is preferred over a protected
property.
* The last resort: Hooks::runner(). Mostly for static, file-scope and
global code. In a few cases it was used for objects with broken
construction schemes, out of horror or laziness.
Constructors with new required arguments:
* AuthManager
* BadFileLookup
* BlockManager
* ClassicInterwikiLookup
* ContentHandlerFactory
* ContentSecurityPolicy
* DefaultOptionsManager
* DerivedPageDataUpdater
* FullSearchResultWidget
* HtmlCacheUpdater
* LanguageFactory
* LanguageNameUtils
* LinkRenderer
* LinkRendererFactory
* LocalisationCache
* MagicWordFactory
* MessageCache
* NamespaceInfo
* PageEditStash
* PageHandlerFactory
* PageUpdater
* ParserFactory
* PermissionManager
* RevisionStore
* RevisionStoreFactory
* SearchEngineConfig
* SearchEngineFactory
* SearchFormWidget
* SearchNearMatcher
* SessionBackend
* SpecialPageFactory
* UserNameUtils
* UserOptionsManager
* WatchedItemQueryService
* WatchedItemStore
Constructors with new optional arguments:
* DefaultPreferencesFactory
* Language
* LinkHolderArray
* MovePage
* Parser
* ParserCache
* PasswordReset
* Router
setHookContainer() now required after construction:
* AuthenticationProvider
* ResourceLoaderModule
* SearchEngine
Change-Id: Id442b0dbe43aba84bd5cf801d86dedc768b082c7
2020-03-19 02:42:09 +00:00
|
|
|
$hookContainer = $services->getHookContainer();
|
2020-08-13 20:10:35 +00:00
|
|
|
$loadBalancer = $services->getDBLoadBalancer();
|
|
|
|
|
$linkCache = new LinkCache( $titleFormatter, $wanCache, $nsInfo, $loadBalancer );
|
2021-03-25 11:45:56 +00:00
|
|
|
if ( $foobarTitle instanceof PageReference ) {
|
|
|
|
|
$cacheTitle = Title::castFromPageReference( $foobarTitle );
|
|
|
|
|
} else {
|
|
|
|
|
$cacheTitle = $foobarTitle;
|
|
|
|
|
}
|
2016-05-27 16:11:58 +00:00
|
|
|
$linkCache->addGoodLinkObj(
|
|
|
|
|
1, // id
|
2021-03-25 11:45:56 +00:00
|
|
|
$cacheTitle,
|
2016-05-27 16:11:58 +00:00
|
|
|
10, // len
|
|
|
|
|
0 // redir
|
|
|
|
|
);
|
2021-03-25 11:45:56 +00:00
|
|
|
if ( $redirectTitle instanceof PageReference ) {
|
|
|
|
|
$cacheTitle = Title::castFromPageReference( $redirectTitle );
|
|
|
|
|
} else {
|
|
|
|
|
$cacheTitle = $redirectTitle;
|
|
|
|
|
}
|
2016-05-27 16:11:58 +00:00
|
|
|
$linkCache->addGoodLinkObj(
|
|
|
|
|
2, // id
|
2021-03-25 11:45:56 +00:00
|
|
|
$cacheTitle,
|
2016-05-27 16:11:58 +00:00
|
|
|
10, // len
|
|
|
|
|
1 // redir
|
|
|
|
|
);
|
|
|
|
|
|
2021-03-25 11:45:56 +00:00
|
|
|
if ( $userTitle instanceof PageReference ) {
|
|
|
|
|
$cacheTitle = Title::castFromPageReference( $userTitle );
|
|
|
|
|
} else {
|
|
|
|
|
$cacheTitle = $userTitle;
|
|
|
|
|
}
|
2016-05-27 16:11:58 +00:00
|
|
|
$linkCache->addGoodLinkObj(
|
|
|
|
|
3, // id
|
2021-03-25 11:45:56 +00:00
|
|
|
$cacheTitle,
|
2016-05-27 16:11:58 +00:00
|
|
|
10, // len
|
|
|
|
|
0 // redir
|
|
|
|
|
);
|
|
|
|
|
|
Hooks::run() call site migration
Migrate all callers of Hooks::run() to use the new
HookContainer/HookRunner system.
General principles:
* Use DI if it is already used. We're not changing the way state is
managed in this patch.
* HookContainer is always injected, not HookRunner. HookContainer
is a service, it's a more generic interface, it is the only
thing that provides isRegistered() which is needed in some cases,
and a HookRunner can be efficiently constructed from it
(confirmed by benchmark). Because HookContainer is needed
for object construction, it is also needed by all factories.
* "Ask your friendly local base class". Big hierarchies like
SpecialPage and ApiBase have getHookContainer() and getHookRunner()
methods in the base class, and classes that extend that base class
are not expected to know or care where the base class gets its
HookContainer from.
* ProtectedHookAccessorTrait provides protected getHookContainer() and
getHookRunner() methods, getting them from the global service
container. The point of this is to ease migration to DI by ensuring
that call sites ask their local friendly base class rather than
getting a HookRunner from the service container directly.
* Private $this->hookRunner. In some smaller classes where accessor
methods did not seem warranted, there is a private HookRunner property
which is accessed directly. Very rarely (two cases), there is a
protected property, for consistency with code that conventionally
assumes protected=private, but in cases where the class might actually
be overridden, a protected accessor is preferred over a protected
property.
* The last resort: Hooks::runner(). Mostly for static, file-scope and
global code. In a few cases it was used for objects with broken
construction schemes, out of horror or laziness.
Constructors with new required arguments:
* AuthManager
* BadFileLookup
* BlockManager
* ClassicInterwikiLookup
* ContentHandlerFactory
* ContentSecurityPolicy
* DefaultOptionsManager
* DerivedPageDataUpdater
* FullSearchResultWidget
* HtmlCacheUpdater
* LanguageFactory
* LanguageNameUtils
* LinkRenderer
* LinkRendererFactory
* LocalisationCache
* MagicWordFactory
* MessageCache
* NamespaceInfo
* PageEditStash
* PageHandlerFactory
* PageUpdater
* ParserFactory
* PermissionManager
* RevisionStore
* RevisionStoreFactory
* SearchEngineConfig
* SearchEngineFactory
* SearchFormWidget
* SearchNearMatcher
* SessionBackend
* SpecialPageFactory
* UserNameUtils
* UserOptionsManager
* WatchedItemQueryService
* WatchedItemStore
Constructors with new optional arguments:
* DefaultPreferencesFactory
* Language
* LinkHolderArray
* MovePage
* Parser
* ParserCache
* PasswordReset
* Router
setHookContainer() now required after construction:
* AuthenticationProvider
* ResourceLoaderModule
* SearchEngine
Change-Id: Id442b0dbe43aba84bd5cf801d86dedc768b082c7
2020-03-19 02:42:09 +00:00
|
|
|
$linkRenderer = new LinkRenderer( $titleFormatter, $linkCache,
|
|
|
|
|
$nsInfo, $specialPageFactory, $hookContainer );
|
2016-05-27 16:11:58 +00:00
|
|
|
$linkRenderer->setStubThreshold( 0 );
|
2019-09-17 14:28:35 +00:00
|
|
|
$this->assertSame(
|
2016-05-27 16:11:58 +00:00
|
|
|
'',
|
|
|
|
|
$linkRenderer->getLinkClasses( $foobarTitle )
|
|
|
|
|
);
|
|
|
|
|
|
|
|
|
|
$linkRenderer->setStubThreshold( 20 );
|
|
|
|
|
$this->assertEquals(
|
|
|
|
|
'stub',
|
|
|
|
|
$linkRenderer->getLinkClasses( $foobarTitle )
|
|
|
|
|
);
|
|
|
|
|
|
|
|
|
|
$linkRenderer->setStubThreshold( 0 );
|
|
|
|
|
$this->assertEquals(
|
|
|
|
|
'mw-redirect',
|
|
|
|
|
$linkRenderer->getLinkClasses( $redirectTitle )
|
|
|
|
|
);
|
|
|
|
|
|
|
|
|
|
$linkRenderer->setStubThreshold( 20 );
|
2019-09-17 14:28:35 +00:00
|
|
|
$this->assertSame(
|
2016-05-27 16:11:58 +00:00
|
|
|
'',
|
|
|
|
|
$linkRenderer->getLinkClasses( $userTitle )
|
|
|
|
|
);
|
|
|
|
|
}
|
|
|
|
|
|
2020-06-14 10:51:39 +00:00
|
|
|
protected function tearDown() : void {
|
2018-10-25 04:31:58 +00:00
|
|
|
Title::clearCaches();
|
|
|
|
|
parent::tearDown();
|
|
|
|
|
}
|
Add LinkRenderer (rewrite of Linker::link())
This is a rewrite of Linker::link() to a non-static, LinkTarget-based
interface. Users of plain Linker::link() with no options can use the
LinkRenderer instance provided by MediaWikiServices. Others that
have specific options should create and configure their own instance,
which can be used to create as many links as necessary.
The main entrypoints for making links are:
* ->makeLink( $target, $text, $attribs, $query );
* ->makeKnownLink( $target, $text, $attribs, $query );
* ->makeBrokenLink( $target, $text, $attribs, $query );
The order of the parameters are the same as Linker::link(), except
$options are now part of the LinkRenderer instance, and
known/broken status requires calling the function explicitly.
Additionally, instead of passing in raw $html for the link text, the
$text parameter will automatically be escaped unless it is specially
marked as safe HTML using the MediaWiki\Linker\HtmlArmor class.
The LinkBegin and LinkEnd hooks are now deprecated, but still function
for backwards-compatability. Clients should migrate to the nearly-
equivalent LinkRendererBegin and LinkRendererEnd hooks.
The main differences between the hooks are:
* Passing HtmlPageLinkRenderer object instead of deprecated DummyLinker
* Using LinkTarget instead of Title
* Begin hook can no longer change known/broken status of link. Use the
TitleIsAlwaysKnown hook for that.
* $options are no longer passed, they can be read (but shouldn't be
modified!) from the LinkRenderer object.
Bug: T469
Change-Id: I057cc86ae6404a080aa3c8e0e956ecbb10a897d5
2016-04-21 20:13:21 +00:00
|
|
|
}
|