2017-07-08 03:34:56 +00:00
|
|
|
<?php
|
|
|
|
|
|
2018-08-20 23:58:41 +00:00
|
|
|
use Wikimedia\TestingAccessWrapper;
|
|
|
|
|
|
2017-07-08 03:34:56 +00:00
|
|
|
/**
|
|
|
|
|
* @group ResourceLoader
|
|
|
|
|
*/
|
2018-08-20 23:58:41 +00:00
|
|
|
class ResourceLoaderSkinModuleTest extends MediaWikiTestCase {
|
2017-07-08 03:34:56 +00:00
|
|
|
|
2020-01-07 19:18:51 +00:00
|
|
|
public static function provideGetAvailableLogos() {
|
|
|
|
|
return [
|
|
|
|
|
[
|
|
|
|
|
[
|
|
|
|
|
'Logos' => [],
|
|
|
|
|
'Logo' => '/logo.png',
|
|
|
|
|
],
|
|
|
|
|
[
|
|
|
|
|
'1x' => '/logo.png',
|
|
|
|
|
]
|
|
|
|
|
],
|
|
|
|
|
[
|
|
|
|
|
[
|
|
|
|
|
'Logos' => [
|
|
|
|
|
'svg' => '/logo.svg',
|
|
|
|
|
'2x' => 'logo-2x.png'
|
|
|
|
|
],
|
|
|
|
|
'Logo' => '/logo.png',
|
|
|
|
|
],
|
|
|
|
|
[
|
|
|
|
|
'svg' => '/logo.svg',
|
|
|
|
|
'2x' => 'logo-2x.png',
|
|
|
|
|
'1x' => '/logo.png',
|
|
|
|
|
]
|
|
|
|
|
],
|
|
|
|
|
[
|
|
|
|
|
[
|
|
|
|
|
'Logos' => [
|
|
|
|
|
'wordmark' => '/logo-wordmark.png',
|
|
|
|
|
'1x' => '/logo.png',
|
|
|
|
|
'svg' => '/logo.svg',
|
|
|
|
|
'2x' => 'logo-2x.png'
|
|
|
|
|
],
|
|
|
|
|
],
|
|
|
|
|
[
|
|
|
|
|
'wordmark' => '/logo-wordmark.png',
|
|
|
|
|
'1x' => '/logo.png',
|
|
|
|
|
'svg' => '/logo.svg',
|
|
|
|
|
'2x' => 'logo-2x.png',
|
|
|
|
|
]
|
|
|
|
|
]
|
|
|
|
|
];
|
|
|
|
|
}
|
|
|
|
|
|
2017-07-08 03:34:56 +00:00
|
|
|
public static function provideGetStyles() {
|
2018-01-01 13:10:16 +00:00
|
|
|
// phpcs:disable Generic.Files.LineLength
|
2017-07-08 03:34:56 +00:00
|
|
|
return [
|
|
|
|
|
[
|
|
|
|
|
'parent' => [],
|
2017-05-22 18:12:26 +00:00
|
|
|
'logo' => '/logo.png',
|
2017-07-08 03:34:56 +00:00
|
|
|
'expected' => [
|
|
|
|
|
'all' => [ '.mw-wiki-logo { background-image: url(/logo.png); }' ],
|
|
|
|
|
],
|
|
|
|
|
],
|
|
|
|
|
[
|
|
|
|
|
'parent' => [
|
|
|
|
|
'screen' => '.example {}',
|
|
|
|
|
],
|
2017-05-22 18:12:26 +00:00
|
|
|
'logo' => '/logo.png',
|
2017-07-08 03:34:56 +00:00
|
|
|
'expected' => [
|
|
|
|
|
'screen' => [ '.example {}' ],
|
|
|
|
|
'all' => [ '.mw-wiki-logo { background-image: url(/logo.png); }' ],
|
|
|
|
|
],
|
|
|
|
|
],
|
2017-05-22 18:12:26 +00:00
|
|
|
[
|
|
|
|
|
'parent' => [],
|
|
|
|
|
'logo' => [
|
|
|
|
|
'1x' => '/logo.png',
|
|
|
|
|
'1.5x' => '/logo@1.5x.png',
|
|
|
|
|
'2x' => '/logo@2x.png',
|
|
|
|
|
],
|
|
|
|
|
'expected' => [
|
|
|
|
|
'all' => [ <<<CSS
|
|
|
|
|
.mw-wiki-logo { background-image: url(/logo.png); }
|
|
|
|
|
CSS
|
|
|
|
|
],
|
|
|
|
|
'(-webkit-min-device-pixel-ratio: 1.5), (min--moz-device-pixel-ratio: 1.5), (min-resolution: 1.5dppx), (min-resolution: 144dpi)' => [ <<<CSS
|
|
|
|
|
.mw-wiki-logo { background-image: url(/logo@1.5x.png);background-size: 135px auto; }
|
|
|
|
|
CSS
|
|
|
|
|
],
|
|
|
|
|
'(-webkit-min-device-pixel-ratio: 2), (min--moz-device-pixel-ratio: 2), (min-resolution: 2dppx), (min-resolution: 192dpi)' => [ <<<CSS
|
|
|
|
|
.mw-wiki-logo { background-image: url(/logo@2x.png);background-size: 135px auto; }
|
|
|
|
|
CSS
|
|
|
|
|
],
|
|
|
|
|
],
|
|
|
|
|
],
|
|
|
|
|
[
|
|
|
|
|
'parent' => [],
|
|
|
|
|
'logo' => [
|
|
|
|
|
'1x' => '/logo.png',
|
|
|
|
|
'svg' => '/logo.svg',
|
|
|
|
|
],
|
|
|
|
|
'expected' => [
|
|
|
|
|
'all' => [ <<<CSS
|
|
|
|
|
.mw-wiki-logo { background-image: url(/logo.png); }
|
|
|
|
|
CSS
|
|
|
|
|
, <<<CSS
|
|
|
|
|
.mw-wiki-logo { background-image: -webkit-linear-gradient(transparent, transparent), url(/logo.svg); background-image: linear-gradient(transparent, transparent), url(/logo.svg);background-size: 135px auto; }
|
|
|
|
|
CSS
|
|
|
|
|
],
|
|
|
|
|
],
|
|
|
|
|
],
|
2017-07-08 03:34:56 +00:00
|
|
|
];
|
2018-01-01 13:10:16 +00:00
|
|
|
// phpcs:enable
|
2017-07-08 03:34:56 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
|
|
/**
|
|
|
|
|
* @dataProvider provideGetStyles
|
2018-05-04 16:30:33 +00:00
|
|
|
* @covers ResourceLoaderSkinModule
|
2017-07-08 03:34:56 +00:00
|
|
|
*/
|
2017-05-22 18:12:26 +00:00
|
|
|
public function testGetStyles( $parent, $logo, $expected ) {
|
2017-07-08 03:34:56 +00:00
|
|
|
$module = $this->getMockBuilder( ResourceLoaderSkinModule::class )
|
2017-05-22 18:12:26 +00:00
|
|
|
->setMethods( [ 'readStyleFiles', 'getConfig', 'getLogoData' ] )
|
2017-07-08 03:34:56 +00:00
|
|
|
->getMock();
|
|
|
|
|
$module->expects( $this->once() )->method( 'readStyleFiles' )
|
|
|
|
|
->willReturn( $parent );
|
2017-05-22 18:12:26 +00:00
|
|
|
$module->expects( $this->once() )->method( 'getConfig' )
|
|
|
|
|
->willReturn( new HashConfig() );
|
|
|
|
|
$module->expects( $this->once() )->method( 'getLogoData' )
|
|
|
|
|
->willReturn( $logo );
|
2017-07-08 03:34:56 +00:00
|
|
|
|
|
|
|
|
$ctx = $this->getMockBuilder( ResourceLoaderContext::class )
|
|
|
|
|
->disableOriginalConstructor()->getMock();
|
|
|
|
|
|
|
|
|
|
$this->assertEquals(
|
2017-05-22 18:12:26 +00:00
|
|
|
$expected,
|
|
|
|
|
$module->getStyles( $ctx )
|
2017-07-08 03:34:56 +00:00
|
|
|
);
|
|
|
|
|
}
|
|
|
|
|
|
2020-01-07 19:18:51 +00:00
|
|
|
/**
|
|
|
|
|
* @dataProvider provideGetAvailableLogos
|
|
|
|
|
* @covers ResourceLoaderSkinModule::getAvailableLogos
|
|
|
|
|
*/
|
|
|
|
|
public function testGetAvailableLogos( $config, $expected ) {
|
|
|
|
|
$logos = ResourceLoaderSkinModule::getAvailableLogos( new HashConfig( $config ) );
|
|
|
|
|
$this->assertSame( $logos, $expected );
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
/**
|
|
|
|
|
* @covers ResourceLoaderSkinModule::getAvailableLogos
|
|
|
|
|
*/
|
|
|
|
|
public function testGetAvailableLogosRuntimeException() {
|
|
|
|
|
$this->expectException( \RuntimeException::class );
|
|
|
|
|
ResourceLoaderSkinModule::getAvailableLogos( new HashConfig( [
|
|
|
|
|
'Logo' => false,
|
|
|
|
|
'Logos' => false,
|
|
|
|
|
'LogoHD' => false,
|
|
|
|
|
] ) );
|
|
|
|
|
}
|
|
|
|
|
|
2017-07-08 03:34:56 +00:00
|
|
|
/**
|
|
|
|
|
* @covers ResourceLoaderSkinModule::isKnownEmpty
|
|
|
|
|
*/
|
|
|
|
|
public function testIsKnownEmpty() {
|
|
|
|
|
$module = $this->getMockBuilder( ResourceLoaderSkinModule::class )
|
|
|
|
|
->disableOriginalConstructor()->setMethods( null )->getMock();
|
|
|
|
|
$ctx = $this->getMockBuilder( ResourceLoaderContext::class )
|
|
|
|
|
->disableOriginalConstructor()->getMock();
|
|
|
|
|
|
|
|
|
|
$this->assertFalse( $module->isKnownEmpty( $ctx ) );
|
|
|
|
|
}
|
2017-05-22 18:12:26 +00:00
|
|
|
|
|
|
|
|
/**
|
2018-08-20 23:58:41 +00:00
|
|
|
* @dataProvider provideGetLogoData
|
|
|
|
|
* @covers ResourceLoaderSkinModule::getLogoData
|
2017-05-22 18:12:26 +00:00
|
|
|
*/
|
2018-08-20 23:58:41 +00:00
|
|
|
public function testGetLogoData( $config, $expected, $baseDir = null ) {
|
2017-05-22 18:12:26 +00:00
|
|
|
if ( $baseDir ) {
|
2018-08-20 23:58:41 +00:00
|
|
|
$this->setMwGlobals( 'IP', $baseDir );
|
2017-05-22 18:12:26 +00:00
|
|
|
}
|
2018-08-20 23:58:41 +00:00
|
|
|
// Allow testing of protected method
|
|
|
|
|
$module = TestingAccessWrapper::newFromObject( new ResourceLoaderSkinModule() );
|
2017-05-22 18:12:26 +00:00
|
|
|
|
|
|
|
|
$this->assertEquals(
|
|
|
|
|
$expected,
|
2018-08-20 23:58:41 +00:00
|
|
|
$module->getLogoData( new HashConfig( $config ) )
|
2017-05-22 18:12:26 +00:00
|
|
|
);
|
|
|
|
|
}
|
|
|
|
|
|
2018-08-20 23:58:41 +00:00
|
|
|
public function provideGetLogoData() {
|
2017-05-22 18:12:26 +00:00
|
|
|
return [
|
2020-02-05 21:12:02 +00:00
|
|
|
'wordmark' => [
|
|
|
|
|
'config' => [
|
|
|
|
|
'ResourceBasePath' => '/w',
|
|
|
|
|
'Logos' => [
|
|
|
|
|
'1x' => '/img/default.png',
|
|
|
|
|
'wordmark' => '/img/wordmark.png',
|
|
|
|
|
],
|
|
|
|
|
],
|
|
|
|
|
'expected' => '/img/default.png',
|
|
|
|
|
],
|
2017-05-22 18:12:26 +00:00
|
|
|
'simple' => [
|
|
|
|
|
'config' => [
|
|
|
|
|
'ResourceBasePath' => '/w',
|
2020-01-07 19:18:51 +00:00
|
|
|
'Logos' => [
|
|
|
|
|
'1x' => '/img/default.png',
|
|
|
|
|
],
|
2017-05-22 18:12:26 +00:00
|
|
|
],
|
|
|
|
|
'expected' => '/img/default.png',
|
|
|
|
|
],
|
|
|
|
|
'default and 2x' => [
|
|
|
|
|
'config' => [
|
|
|
|
|
'ResourceBasePath' => '/w',
|
2020-01-07 19:18:51 +00:00
|
|
|
'Logos' => [
|
|
|
|
|
'1x' => '/img/default.png',
|
2017-05-22 18:12:26 +00:00
|
|
|
'2x' => '/img/two-x.png',
|
|
|
|
|
],
|
|
|
|
|
],
|
|
|
|
|
'expected' => [
|
|
|
|
|
'1x' => '/img/default.png',
|
|
|
|
|
'2x' => '/img/two-x.png',
|
|
|
|
|
],
|
|
|
|
|
],
|
|
|
|
|
'default and all HiDPIs' => [
|
|
|
|
|
'config' => [
|
|
|
|
|
'ResourceBasePath' => '/w',
|
2020-01-07 19:18:51 +00:00
|
|
|
'Logos' => [
|
|
|
|
|
'1x' => '/img/default.png',
|
2017-05-22 18:12:26 +00:00
|
|
|
'1.5x' => '/img/one-point-five.png',
|
|
|
|
|
'2x' => '/img/two-x.png',
|
|
|
|
|
],
|
|
|
|
|
],
|
|
|
|
|
'expected' => [
|
|
|
|
|
'1x' => '/img/default.png',
|
|
|
|
|
'1.5x' => '/img/one-point-five.png',
|
|
|
|
|
'2x' => '/img/two-x.png',
|
|
|
|
|
],
|
|
|
|
|
],
|
|
|
|
|
'default and SVG' => [
|
|
|
|
|
'config' => [
|
|
|
|
|
'ResourceBasePath' => '/w',
|
2020-01-07 19:18:51 +00:00
|
|
|
'Logos' => [
|
|
|
|
|
'1x' => '/img/default.png',
|
2017-05-22 18:12:26 +00:00
|
|
|
'svg' => '/img/vector.svg',
|
|
|
|
|
],
|
|
|
|
|
],
|
|
|
|
|
'expected' => [
|
|
|
|
|
'1x' => '/img/default.png',
|
|
|
|
|
'svg' => '/img/vector.svg',
|
|
|
|
|
],
|
|
|
|
|
],
|
|
|
|
|
'everything' => [
|
|
|
|
|
'config' => [
|
|
|
|
|
'ResourceBasePath' => '/w',
|
2020-01-07 19:18:51 +00:00
|
|
|
'Logos' => [
|
|
|
|
|
'1x' => '/img/default.png',
|
2017-05-22 18:12:26 +00:00
|
|
|
'1.5x' => '/img/one-point-five.png',
|
|
|
|
|
'2x' => '/img/two-x.png',
|
|
|
|
|
'svg' => '/img/vector.svg',
|
|
|
|
|
],
|
|
|
|
|
],
|
|
|
|
|
'expected' => [
|
|
|
|
|
'1x' => '/img/default.png',
|
|
|
|
|
'svg' => '/img/vector.svg',
|
|
|
|
|
],
|
|
|
|
|
],
|
|
|
|
|
'versioned url' => [
|
|
|
|
|
'config' => [
|
|
|
|
|
'ResourceBasePath' => '/w',
|
|
|
|
|
'UploadPath' => '/w/images',
|
2020-01-07 19:18:51 +00:00
|
|
|
'Logos' => [
|
|
|
|
|
'1x' => '/w/test.jpg',
|
|
|
|
|
],
|
2017-05-22 18:12:26 +00:00
|
|
|
],
|
|
|
|
|
'expected' => '/w/test.jpg?edcf2',
|
|
|
|
|
'baseDir' => dirname( dirname( __DIR__ ) ) . '/data/media',
|
|
|
|
|
],
|
|
|
|
|
];
|
|
|
|
|
}
|
2018-08-20 23:58:41 +00:00
|
|
|
|
|
|
|
|
/**
|
|
|
|
|
* @dataProvider providePreloadLinks
|
|
|
|
|
* @covers ResourceLoaderSkinModule::getPreloadLinks
|
|
|
|
|
* @covers ResourceLoaderSkinModule::getLogoPreloadlinks
|
|
|
|
|
* @covers ResourceLoaderSkinModule::getLogoData
|
|
|
|
|
*/
|
|
|
|
|
public function testPreloadLinkHeaders( $config, $result ) {
|
|
|
|
|
$this->setMwGlobals( $config );
|
|
|
|
|
$ctx = $this->getMockBuilder( ResourceLoaderContext::class )
|
|
|
|
|
->disableOriginalConstructor()->getMock();
|
|
|
|
|
$module = new ResourceLoaderSkinModule();
|
|
|
|
|
|
|
|
|
|
$this->assertEquals( [ $result ], $module->getHeaders( $ctx ) );
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
public function providePreloadLinks() {
|
|
|
|
|
return [
|
|
|
|
|
[
|
|
|
|
|
[
|
|
|
|
|
'wgResourceBasePath' => '/w',
|
2020-01-07 19:18:51 +00:00
|
|
|
'wgLogo' => false,
|
|
|
|
|
'wgLogoHD' => false,
|
|
|
|
|
'wgLogos' => [
|
|
|
|
|
'1x' => '/img/default.png',
|
2018-08-20 23:58:41 +00:00
|
|
|
'1.5x' => '/img/one-point-five.png',
|
|
|
|
|
'2x' => '/img/two-x.png',
|
|
|
|
|
],
|
|
|
|
|
],
|
|
|
|
|
'Link: </img/default.png>;rel=preload;as=image;media=' .
|
|
|
|
|
'not all and (min-resolution: 1.5dppx),' .
|
|
|
|
|
'</img/one-point-five.png>;rel=preload;as=image;media=' .
|
|
|
|
|
'(min-resolution: 1.5dppx) and (max-resolution: 1.999999dppx),' .
|
|
|
|
|
'</img/two-x.png>;rel=preload;as=image;media=(min-resolution: 2dppx)'
|
|
|
|
|
],
|
|
|
|
|
[
|
|
|
|
|
[
|
|
|
|
|
'wgResourceBasePath' => '/w',
|
2020-01-07 19:18:51 +00:00
|
|
|
'wgLogo' => false,
|
2018-08-20 23:58:41 +00:00
|
|
|
'wgLogoHD' => false,
|
2020-01-07 19:18:51 +00:00
|
|
|
'wgLogos' => [
|
|
|
|
|
'1x' => '/img/default.png',
|
|
|
|
|
],
|
2018-08-20 23:58:41 +00:00
|
|
|
],
|
|
|
|
|
'Link: </img/default.png>;rel=preload;as=image'
|
|
|
|
|
],
|
|
|
|
|
[
|
|
|
|
|
[
|
|
|
|
|
'wgResourceBasePath' => '/w',
|
2020-01-07 19:18:51 +00:00
|
|
|
'wgLogo' => false,
|
|
|
|
|
'wgLogoHD' => false,
|
|
|
|
|
'wgLogos' => [
|
|
|
|
|
'1x' => '/img/default.png',
|
2018-08-20 23:58:41 +00:00
|
|
|
'2x' => '/img/two-x.png',
|
|
|
|
|
],
|
|
|
|
|
],
|
|
|
|
|
'Link: </img/default.png>;rel=preload;as=image;media=' .
|
|
|
|
|
'not all and (min-resolution: 2dppx),' .
|
|
|
|
|
'</img/two-x.png>;rel=preload;as=image;media=(min-resolution: 2dppx)'
|
|
|
|
|
],
|
|
|
|
|
[
|
|
|
|
|
[
|
|
|
|
|
'wgResourceBasePath' => '/w',
|
2020-01-07 19:18:51 +00:00
|
|
|
'wgLogo' => false,
|
|
|
|
|
'wgLogoHD' => false,
|
|
|
|
|
'wgLogos' => [
|
|
|
|
|
'1x' => '/img/default.png',
|
2018-08-20 23:58:41 +00:00
|
|
|
'svg' => '/img/vector.svg',
|
|
|
|
|
],
|
|
|
|
|
],
|
|
|
|
|
'Link: </img/vector.svg>;rel=preload;as=image'
|
|
|
|
|
|
|
|
|
|
],
|
|
|
|
|
[
|
|
|
|
|
[
|
|
|
|
|
'wgResourceBasePath' => '/w',
|
2020-01-07 19:18:51 +00:00
|
|
|
'wgLogo' => false,
|
2018-08-20 23:58:41 +00:00
|
|
|
'wgLogoHD' => false,
|
2020-01-07 19:18:51 +00:00
|
|
|
'wgLogos' => [
|
|
|
|
|
'1x' => '/w/test.jpg',
|
|
|
|
|
],
|
2018-08-20 23:58:41 +00:00
|
|
|
'wgUploadPath' => '/w/images',
|
|
|
|
|
'IP' => dirname( dirname( __DIR__ ) ) . '/data/media',
|
|
|
|
|
],
|
|
|
|
|
'Link: </w/test.jpg?edcf2>;rel=preload;as=image',
|
|
|
|
|
],
|
|
|
|
|
];
|
|
|
|
|
}
|
2020-06-10 14:09:09 +00:00
|
|
|
|
|
|
|
|
/**
|
|
|
|
|
* Covers ResourceLoaderSkinModule::FEATURE_FILES, but not annotatable.
|
|
|
|
|
*
|
|
|
|
|
* @dataProvider provideFeatureFiles
|
|
|
|
|
* @coversNothing
|
|
|
|
|
*
|
|
|
|
|
* @param string $file
|
|
|
|
|
*/
|
|
|
|
|
public function testFeatureFilesExist( string $file ) : void {
|
|
|
|
|
$this->assertFileExists( $file );
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
public function provideFeatureFiles() : Generator {
|
|
|
|
|
global $IP;
|
|
|
|
|
|
|
|
|
|
$featureFiles = ( new ReflectionClass( ResourceLoaderSkinModule::class ) )
|
|
|
|
|
->getConstant( 'FEATURE_FILES' );
|
|
|
|
|
|
|
|
|
|
foreach ( $featureFiles as $feature => $files ) {
|
|
|
|
|
foreach ( $files as $media => $stylesheets ) {
|
|
|
|
|
foreach ( $stylesheets as $stylesheet ) {
|
|
|
|
|
yield "$feature: $media: $stylesheet" => [ "$IP/$stylesheet" ];
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
}
|
2017-07-08 03:34:56 +00:00
|
|
|
}
|