2016-02-01 20:44:03 +00:00
|
|
|
<?php
|
|
|
|
|
|
|
|
|
|
namespace MediaWiki\Session;
|
|
|
|
|
|
2019-08-26 12:24:37 +00:00
|
|
|
use MediaWiki\MediaWikiServices;
|
2021-04-29 20:44:45 +00:00
|
|
|
use MediaWiki\User\UserNameUtils;
|
2020-06-30 15:09:24 +00:00
|
|
|
use MediaWikiIntegrationTestCase;
|
2021-04-29 20:44:45 +00:00
|
|
|
use TestLogger;
|
2017-04-19 19:37:35 +00:00
|
|
|
use Wikimedia\TestingAccessWrapper;
|
2016-02-01 20:44:03 +00:00
|
|
|
|
|
|
|
|
/**
|
|
|
|
|
* @group Session
|
|
|
|
|
* @group Database
|
|
|
|
|
* @covers MediaWiki\Session\SessionProvider
|
|
|
|
|
*/
|
2020-06-30 15:09:24 +00:00
|
|
|
class SessionProviderTest extends MediaWikiIntegrationTestCase {
|
2021-05-26 15:50:28 +00:00
|
|
|
use SessionProviderTestTrait;
|
2016-02-01 20:44:03 +00:00
|
|
|
|
|
|
|
|
public function testBasics() {
|
2021-05-07 19:56:38 +00:00
|
|
|
$this->hideDeprecated( 'MediaWiki\Session\SessionProvider::setConfig' );
|
|
|
|
|
$this->hideDeprecated( 'MediaWiki\Session\SessionProvider::setLogger' );
|
|
|
|
|
$this->hideDeprecated( 'MediaWiki\Session\SessionProvider::setManager' );
|
|
|
|
|
$this->hideDeprecated( 'MediaWiki\Session\SessionProvider::setHookContainer' );
|
|
|
|
|
|
2016-02-01 20:44:03 +00:00
|
|
|
$manager = new SessionManager();
|
2021-04-29 20:44:45 +00:00
|
|
|
$logger = new TestLogger();
|
2016-02-01 20:44:03 +00:00
|
|
|
$config = new \HashConfig();
|
Hooks::run() call site migration
Migrate all callers of Hooks::run() to use the new
HookContainer/HookRunner system.
General principles:
* Use DI if it is already used. We're not changing the way state is
managed in this patch.
* HookContainer is always injected, not HookRunner. HookContainer
is a service, it's a more generic interface, it is the only
thing that provides isRegistered() which is needed in some cases,
and a HookRunner can be efficiently constructed from it
(confirmed by benchmark). Because HookContainer is needed
for object construction, it is also needed by all factories.
* "Ask your friendly local base class". Big hierarchies like
SpecialPage and ApiBase have getHookContainer() and getHookRunner()
methods in the base class, and classes that extend that base class
are not expected to know or care where the base class gets its
HookContainer from.
* ProtectedHookAccessorTrait provides protected getHookContainer() and
getHookRunner() methods, getting them from the global service
container. The point of this is to ease migration to DI by ensuring
that call sites ask their local friendly base class rather than
getting a HookRunner from the service container directly.
* Private $this->hookRunner. In some smaller classes where accessor
methods did not seem warranted, there is a private HookRunner property
which is accessed directly. Very rarely (two cases), there is a
protected property, for consistency with code that conventionally
assumes protected=private, but in cases where the class might actually
be overridden, a protected accessor is preferred over a protected
property.
* The last resort: Hooks::runner(). Mostly for static, file-scope and
global code. In a few cases it was used for objects with broken
construction schemes, out of horror or laziness.
Constructors with new required arguments:
* AuthManager
* BadFileLookup
* BlockManager
* ClassicInterwikiLookup
* ContentHandlerFactory
* ContentSecurityPolicy
* DefaultOptionsManager
* DerivedPageDataUpdater
* FullSearchResultWidget
* HtmlCacheUpdater
* LanguageFactory
* LanguageNameUtils
* LinkRenderer
* LinkRendererFactory
* LocalisationCache
* MagicWordFactory
* MessageCache
* NamespaceInfo
* PageEditStash
* PageHandlerFactory
* PageUpdater
* ParserFactory
* PermissionManager
* RevisionStore
* RevisionStoreFactory
* SearchEngineConfig
* SearchEngineFactory
* SearchFormWidget
* SearchNearMatcher
* SessionBackend
* SpecialPageFactory
* UserNameUtils
* UserOptionsManager
* WatchedItemQueryService
* WatchedItemStore
Constructors with new optional arguments:
* DefaultPreferencesFactory
* Language
* LinkHolderArray
* MovePage
* Parser
* ParserCache
* PasswordReset
* Router
setHookContainer() now required after construction:
* AuthenticationProvider
* ResourceLoaderModule
* SearchEngine
Change-Id: Id442b0dbe43aba84bd5cf801d86dedc768b082c7
2020-03-19 02:42:09 +00:00
|
|
|
$hookContainer = $this->createHookContainer();
|
2021-04-29 20:44:45 +00:00
|
|
|
$userNameUtils = $this->createNoOpMock( UserNameUtils::class );
|
2016-02-01 20:44:03 +00:00
|
|
|
|
2016-03-28 18:53:04 +00:00
|
|
|
$provider = $this->getMockForAbstractClass( SessionProvider::class );
|
2017-04-19 19:37:35 +00:00
|
|
|
$priv = TestingAccessWrapper::newFromObject( $provider );
|
2016-02-01 20:44:03 +00:00
|
|
|
|
2021-05-28 13:38:53 +00:00
|
|
|
$this->initProvider( $provider, $logger, $config, $manager, $hookContainer, $userNameUtils );
|
2021-04-29 20:44:45 +00:00
|
|
|
$this->assertSame( $logger, $priv->logger );
|
|
|
|
|
$this->assertSame( $config, $priv->getConfig() );
|
|
|
|
|
$this->assertSame( $manager, $priv->manager );
|
|
|
|
|
$this->assertSame( $manager, $provider->getManager() );
|
|
|
|
|
$this->assertSame( $hookContainer, $priv->getHookContainer() );
|
|
|
|
|
$this->assertSame( $userNameUtils, $priv->userNameUtils );
|
2016-02-01 20:44:03 +00:00
|
|
|
$provider->setConfig( $config );
|
2021-04-29 20:44:45 +00:00
|
|
|
$this->assertSame( $config, $priv->getConfig() );
|
2016-02-01 20:44:03 +00:00
|
|
|
$provider->setLogger( $logger );
|
|
|
|
|
$this->assertSame( $logger, $priv->logger );
|
|
|
|
|
$provider->setManager( $manager );
|
|
|
|
|
$this->assertSame( $manager, $priv->manager );
|
|
|
|
|
$this->assertSame( $manager, $provider->getManager() );
|
Hooks::run() call site migration
Migrate all callers of Hooks::run() to use the new
HookContainer/HookRunner system.
General principles:
* Use DI if it is already used. We're not changing the way state is
managed in this patch.
* HookContainer is always injected, not HookRunner. HookContainer
is a service, it's a more generic interface, it is the only
thing that provides isRegistered() which is needed in some cases,
and a HookRunner can be efficiently constructed from it
(confirmed by benchmark). Because HookContainer is needed
for object construction, it is also needed by all factories.
* "Ask your friendly local base class". Big hierarchies like
SpecialPage and ApiBase have getHookContainer() and getHookRunner()
methods in the base class, and classes that extend that base class
are not expected to know or care where the base class gets its
HookContainer from.
* ProtectedHookAccessorTrait provides protected getHookContainer() and
getHookRunner() methods, getting them from the global service
container. The point of this is to ease migration to DI by ensuring
that call sites ask their local friendly base class rather than
getting a HookRunner from the service container directly.
* Private $this->hookRunner. In some smaller classes where accessor
methods did not seem warranted, there is a private HookRunner property
which is accessed directly. Very rarely (two cases), there is a
protected property, for consistency with code that conventionally
assumes protected=private, but in cases where the class might actually
be overridden, a protected accessor is preferred over a protected
property.
* The last resort: Hooks::runner(). Mostly for static, file-scope and
global code. In a few cases it was used for objects with broken
construction schemes, out of horror or laziness.
Constructors with new required arguments:
* AuthManager
* BadFileLookup
* BlockManager
* ClassicInterwikiLookup
* ContentHandlerFactory
* ContentSecurityPolicy
* DefaultOptionsManager
* DerivedPageDataUpdater
* FullSearchResultWidget
* HtmlCacheUpdater
* LanguageFactory
* LanguageNameUtils
* LinkRenderer
* LinkRendererFactory
* LocalisationCache
* MagicWordFactory
* MessageCache
* NamespaceInfo
* PageEditStash
* PageHandlerFactory
* PageUpdater
* ParserFactory
* PermissionManager
* RevisionStore
* RevisionStoreFactory
* SearchEngineConfig
* SearchEngineFactory
* SearchFormWidget
* SearchNearMatcher
* SessionBackend
* SpecialPageFactory
* UserNameUtils
* UserOptionsManager
* WatchedItemQueryService
* WatchedItemStore
Constructors with new optional arguments:
* DefaultPreferencesFactory
* Language
* LinkHolderArray
* MovePage
* Parser
* ParserCache
* PasswordReset
* Router
setHookContainer() now required after construction:
* AuthenticationProvider
* ResourceLoaderModule
* SearchEngine
Change-Id: Id442b0dbe43aba84bd5cf801d86dedc768b082c7
2020-03-19 02:42:09 +00:00
|
|
|
$provider->setHookContainer( $hookContainer );
|
|
|
|
|
$this->assertSame( $hookContainer, $priv->getHookContainer() );
|
2016-02-01 20:44:03 +00:00
|
|
|
|
2016-05-10 20:40:46 +00:00
|
|
|
$provider->invalidateSessionsForUser( new \User );
|
|
|
|
|
|
2016-02-17 09:09:32 +00:00
|
|
|
$this->assertSame( [], $provider->getVaryHeaders() );
|
|
|
|
|
$this->assertSame( [], $provider->getVaryCookies() );
|
2016-02-01 20:44:03 +00:00
|
|
|
$this->assertSame( null, $provider->suggestLoginUsername( new \FauxRequest ) );
|
|
|
|
|
|
|
|
|
|
$this->assertSame( get_class( $provider ), (string)$provider );
|
|
|
|
|
|
2016-05-13 00:03:20 +00:00
|
|
|
$this->assertNull( $provider->getRememberUserDuration() );
|
|
|
|
|
|
2016-02-01 20:44:03 +00:00
|
|
|
$this->assertNull( $provider->whyNoSession() );
|
2020-03-11 02:10:07 +00:00
|
|
|
$this->assertFalse( $provider->safeAgainstCsrf() );
|
2016-02-01 20:44:03 +00:00
|
|
|
|
2016-02-17 09:09:32 +00:00
|
|
|
$info = new SessionInfo( SessionInfo::MIN_PRIORITY, [
|
2016-02-01 20:44:03 +00:00
|
|
|
'id' => 'aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa',
|
|
|
|
|
'provider' => $provider,
|
2016-02-17 09:09:32 +00:00
|
|
|
] );
|
|
|
|
|
$metadata = [ 'foo' ];
|
2016-02-01 20:44:03 +00:00
|
|
|
$this->assertTrue( $provider->refreshSessionInfo( $info, new \FauxRequest, $metadata ) );
|
2016-02-17 09:09:32 +00:00
|
|
|
$this->assertSame( [ 'foo' ], $metadata );
|
2016-02-01 20:44:03 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
|
|
/**
|
|
|
|
|
* @dataProvider provideNewSessionInfo
|
|
|
|
|
* @param bool $persistId Return value for ->persistsSessionId()
|
|
|
|
|
* @param bool $persistUser Return value for ->persistsSessionUser()
|
|
|
|
|
* @param bool $ok Whether a SessionInfo is provided
|
|
|
|
|
*/
|
|
|
|
|
public function testNewSessionInfo( $persistId, $persistUser, $ok ) {
|
|
|
|
|
$manager = new SessionManager();
|
|
|
|
|
|
2016-03-28 18:53:04 +00:00
|
|
|
$provider = $this->getMockBuilder( SessionProvider::class )
|
2021-03-20 15:18:58 +00:00
|
|
|
->onlyMethods( [ 'canChangeUser', 'persistsSessionId' ] )
|
2016-02-01 20:44:03 +00:00
|
|
|
->getMockForAbstractClass();
|
2021-04-22 08:28:11 +00:00
|
|
|
$provider->method( 'persistsSessionId' )
|
|
|
|
|
->willReturn( $persistId );
|
|
|
|
|
$provider->method( 'canChangeUser' )
|
|
|
|
|
->willReturn( $persistUser );
|
2021-05-26 15:50:28 +00:00
|
|
|
$this->initProvider( $provider, null, null, $manager );
|
2016-02-01 20:44:03 +00:00
|
|
|
|
|
|
|
|
if ( $ok ) {
|
|
|
|
|
$info = $provider->newSessionInfo();
|
|
|
|
|
$this->assertNotNull( $info );
|
|
|
|
|
$this->assertFalse( $info->wasPersisted() );
|
|
|
|
|
$this->assertTrue( $info->isIdSafe() );
|
|
|
|
|
|
|
|
|
|
$id = 'aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa';
|
|
|
|
|
$info = $provider->newSessionInfo( $id );
|
|
|
|
|
$this->assertNotNull( $info );
|
|
|
|
|
$this->assertSame( $id, $info->getId() );
|
|
|
|
|
$this->assertFalse( $info->wasPersisted() );
|
|
|
|
|
$this->assertTrue( $info->isIdSafe() );
|
|
|
|
|
} else {
|
|
|
|
|
$this->assertNull( $provider->newSessionInfo() );
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
public function testMergeMetadata() {
|
2016-03-28 18:53:04 +00:00
|
|
|
$provider = $this->getMockBuilder( SessionProvider::class )
|
2016-02-01 20:44:03 +00:00
|
|
|
->getMockForAbstractClass();
|
|
|
|
|
|
|
|
|
|
try {
|
|
|
|
|
$provider->mergeMetadata(
|
2016-02-17 09:09:32 +00:00
|
|
|
[ 'foo' => 1, 'baz' => 3 ],
|
|
|
|
|
[ 'bar' => 2, 'baz' => '3' ]
|
2016-02-01 20:44:03 +00:00
|
|
|
);
|
|
|
|
|
$this->fail( 'Expected exception not thrown' );
|
2016-02-11 16:55:37 +00:00
|
|
|
} catch ( MetadataMergeException $ex ) {
|
2016-02-01 20:44:03 +00:00
|
|
|
$this->assertSame( 'Key "baz" changed', $ex->getMessage() );
|
2016-02-11 16:55:37 +00:00
|
|
|
$this->assertSame(
|
|
|
|
|
[ 'old_value' => 3, 'new_value' => '3' ], $ex->getContext() );
|
2016-02-01 20:44:03 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
|
|
$res = $provider->mergeMetadata(
|
2016-02-17 09:09:32 +00:00
|
|
|
[ 'foo' => 1, 'baz' => 3 ],
|
|
|
|
|
[ 'bar' => 2, 'baz' => 3 ]
|
2016-02-01 20:44:03 +00:00
|
|
|
);
|
2016-02-17 09:09:32 +00:00
|
|
|
$this->assertSame( [ 'bar' => 2, 'baz' => 3 ], $res );
|
2016-02-01 20:44:03 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
|
|
public static function provideNewSessionInfo() {
|
2016-02-17 09:09:32 +00:00
|
|
|
return [
|
|
|
|
|
[ false, false, false ],
|
|
|
|
|
[ true, false, false ],
|
|
|
|
|
[ false, true, false ],
|
|
|
|
|
[ true, true, true ],
|
|
|
|
|
];
|
2016-02-01 20:44:03 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
|
|
public function testImmutableSessions() {
|
2016-03-28 18:53:04 +00:00
|
|
|
$provider = $this->getMockBuilder( SessionProvider::class )
|
2021-03-20 15:18:58 +00:00
|
|
|
->onlyMethods( [ 'canChangeUser', 'persistsSessionId' ] )
|
2016-02-01 20:44:03 +00:00
|
|
|
->getMockForAbstractClass();
|
2021-04-22 08:28:11 +00:00
|
|
|
$provider->method( 'canChangeUser' )
|
|
|
|
|
->willReturn( true );
|
2016-02-01 20:44:03 +00:00
|
|
|
$provider->preventSessionsForUser( 'Foo' );
|
|
|
|
|
|
2016-03-28 18:53:04 +00:00
|
|
|
$provider = $this->getMockBuilder( SessionProvider::class )
|
2021-03-20 15:18:58 +00:00
|
|
|
->onlyMethods( [ 'canChangeUser', 'persistsSessionId' ] )
|
2016-02-01 20:44:03 +00:00
|
|
|
->getMockForAbstractClass();
|
2021-04-22 08:28:11 +00:00
|
|
|
$provider->method( 'canChangeUser' )
|
|
|
|
|
->willReturn( false );
|
2016-02-01 20:44:03 +00:00
|
|
|
try {
|
|
|
|
|
$provider->preventSessionsForUser( 'Foo' );
|
|
|
|
|
$this->fail( 'Expected exception not thrown' );
|
|
|
|
|
} catch ( \BadMethodCallException $ex ) {
|
2016-02-26 20:02:56 +00:00
|
|
|
$this->assertSame(
|
2019-03-21 15:10:02 +00:00
|
|
|
'MediaWiki\\Session\\SessionProvider::preventSessionsForUser must be implemented ' .
|
2016-02-26 20:02:56 +00:00
|
|
|
'when canChangeUser() is false',
|
|
|
|
|
$ex->getMessage()
|
|
|
|
|
);
|
2016-02-01 20:44:03 +00:00
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
public function testHashToSessionId() {
|
2016-02-17 09:09:32 +00:00
|
|
|
$config = new \HashConfig( [
|
2016-02-01 20:44:03 +00:00
|
|
|
'SecretKey' => 'Shhh!',
|
2016-02-17 09:09:32 +00:00
|
|
|
] );
|
2016-02-01 20:44:03 +00:00
|
|
|
|
2016-03-28 18:53:04 +00:00
|
|
|
$provider = $this->getMockForAbstractClass( SessionProvider::class,
|
2016-02-17 09:09:32 +00:00
|
|
|
[], 'MockSessionProvider' );
|
2021-05-26 15:50:28 +00:00
|
|
|
$this->initProvider( $provider, null, $config );
|
2017-04-19 19:37:35 +00:00
|
|
|
$priv = TestingAccessWrapper::newFromObject( $provider );
|
2016-02-01 20:44:03 +00:00
|
|
|
|
|
|
|
|
$this->assertSame( 'eoq8cb1mg7j30ui5qolafps4hg29k5bb', $priv->hashToSessionId( 'foobar' ) );
|
|
|
|
|
$this->assertSame( '4do8j7tfld1g8tte9jqp3csfgmulaun9',
|
|
|
|
|
$priv->hashToSessionId( 'foobar', 'secret' ) );
|
|
|
|
|
|
|
|
|
|
try {
|
2016-02-17 09:09:32 +00:00
|
|
|
$priv->hashToSessionId( [] );
|
2016-02-01 20:44:03 +00:00
|
|
|
$this->fail( 'Expected exception not thrown' );
|
|
|
|
|
} catch ( \InvalidArgumentException $ex ) {
|
|
|
|
|
$this->assertSame(
|
|
|
|
|
'$data must be a string, array was passed',
|
|
|
|
|
$ex->getMessage()
|
|
|
|
|
);
|
|
|
|
|
}
|
|
|
|
|
try {
|
|
|
|
|
$priv->hashToSessionId( '', false );
|
|
|
|
|
$this->fail( 'Expected exception not thrown' );
|
|
|
|
|
} catch ( \InvalidArgumentException $ex ) {
|
|
|
|
|
$this->assertSame(
|
|
|
|
|
'$key must be a string or null, boolean was passed',
|
|
|
|
|
$ex->getMessage()
|
|
|
|
|
);
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
public function testDescribe() {
|
2016-03-28 18:53:04 +00:00
|
|
|
$provider = $this->getMockForAbstractClass( SessionProvider::class,
|
2016-02-17 09:09:32 +00:00
|
|
|
[], 'MockSessionProvider' );
|
2016-02-01 20:44:03 +00:00
|
|
|
|
|
|
|
|
$this->assertSame(
|
|
|
|
|
'MockSessionProvider sessions',
|
2019-08-26 12:24:37 +00:00
|
|
|
$provider->describe(
|
|
|
|
|
MediaWikiServices::getInstance()->getLanguageFactory()->getLanguage( 'en' ) )
|
2016-02-01 20:44:03 +00:00
|
|
|
);
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
public function testGetAllowedUserRights() {
|
2016-03-28 18:53:04 +00:00
|
|
|
$provider = $this->getMockForAbstractClass( SessionProvider::class );
|
2016-02-01 20:44:03 +00:00
|
|
|
$backend = TestUtils::getDummySessionBackend();
|
|
|
|
|
|
|
|
|
|
try {
|
|
|
|
|
$provider->getAllowedUserRights( $backend );
|
|
|
|
|
$this->fail( 'Expected exception not thrown' );
|
|
|
|
|
} catch ( \InvalidArgumentException $ex ) {
|
|
|
|
|
$this->assertSame(
|
|
|
|
|
'Backend\'s provider isn\'t $this',
|
|
|
|
|
$ex->getMessage()
|
|
|
|
|
);
|
|
|
|
|
}
|
|
|
|
|
|
2017-04-19 19:37:35 +00:00
|
|
|
TestingAccessWrapper::newFromObject( $backend )->provider = $provider;
|
2016-02-01 20:44:03 +00:00
|
|
|
$this->assertNull( $provider->getAllowedUserRights( $backend ) );
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
}
|