2016-02-01 20:44:03 +00:00
|
|
|
<?php
|
|
|
|
|
|
|
|
|
|
namespace MediaWiki\Session;
|
|
|
|
|
|
2016-02-10 16:43:23 +00:00
|
|
|
use Psr\Log\LogLevel;
|
2016-02-01 20:44:03 +00:00
|
|
|
use MediaWikiTestCase;
|
|
|
|
|
use User;
|
|
|
|
|
|
|
|
|
|
/**
|
|
|
|
|
* @group Session
|
|
|
|
|
* @covers MediaWiki\Session\Session
|
|
|
|
|
*/
|
|
|
|
|
class SessionTest extends MediaWikiTestCase {
|
|
|
|
|
|
|
|
|
|
public function testConstructor() {
|
|
|
|
|
$backend = TestUtils::getDummySessionBackend();
|
2016-02-17 09:09:32 +00:00
|
|
|
\TestingAccessWrapper::newFromObject( $backend )->requests = [ -1 => 'dummy' ];
|
2016-02-01 20:44:03 +00:00
|
|
|
\TestingAccessWrapper::newFromObject( $backend )->id = new SessionId( 'abc' );
|
|
|
|
|
|
2016-02-10 16:43:23 +00:00
|
|
|
$session = new Session( $backend, 42, new \TestLogger );
|
2016-02-01 20:44:03 +00:00
|
|
|
$priv = \TestingAccessWrapper::newFromObject( $session );
|
|
|
|
|
$this->assertSame( $backend, $priv->backend );
|
|
|
|
|
$this->assertSame( 42, $priv->index );
|
|
|
|
|
|
|
|
|
|
$request = new \FauxRequest();
|
|
|
|
|
$priv2 = \TestingAccessWrapper::newFromObject( $session->sessionWithRequest( $request ) );
|
|
|
|
|
$this->assertSame( $backend, $priv2->backend );
|
|
|
|
|
$this->assertNotSame( $priv->index, $priv2->index );
|
|
|
|
|
$this->assertSame( $request, $priv2->getRequest() );
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
/**
|
|
|
|
|
* @dataProvider provideMethods
|
|
|
|
|
* @param string $m Method to test
|
|
|
|
|
* @param array $args Arguments to pass to the method
|
|
|
|
|
* @param bool $index Whether the backend method gets passed the index
|
|
|
|
|
* @param bool $ret Whether the method returns a value
|
|
|
|
|
*/
|
|
|
|
|
public function testMethods( $m, $args, $index, $ret ) {
|
2016-03-28 18:53:04 +00:00
|
|
|
$mock = $this->getMock( DummySessionBackend::class,
|
2016-02-17 09:09:32 +00:00
|
|
|
[ $m, 'deregisterSession' ] );
|
2016-02-01 20:44:03 +00:00
|
|
|
$mock->expects( $this->once() )->method( 'deregisterSession' )
|
|
|
|
|
->with( $this->identicalTo( 42 ) );
|
|
|
|
|
|
|
|
|
|
$tmp = $mock->expects( $this->once() )->method( $m );
|
2016-02-17 09:09:32 +00:00
|
|
|
$expectArgs = [];
|
2016-02-01 20:44:03 +00:00
|
|
|
if ( $index ) {
|
|
|
|
|
$expectArgs[] = $this->identicalTo( 42 );
|
|
|
|
|
}
|
|
|
|
|
foreach ( $args as $arg ) {
|
|
|
|
|
$expectArgs[] = $this->identicalTo( $arg );
|
|
|
|
|
}
|
2016-02-17 09:09:32 +00:00
|
|
|
$tmp = call_user_func_array( [ $tmp, 'with' ], $expectArgs );
|
2016-02-01 20:44:03 +00:00
|
|
|
|
|
|
|
|
$retval = new \stdClass;
|
|
|
|
|
$tmp->will( $this->returnValue( $retval ) );
|
|
|
|
|
|
|
|
|
|
$session = TestUtils::getDummySession( $mock, 42 );
|
|
|
|
|
|
|
|
|
|
if ( $ret ) {
|
2016-02-17 09:09:32 +00:00
|
|
|
$this->assertSame( $retval, call_user_func_array( [ $session, $m ], $args ) );
|
2016-02-01 20:44:03 +00:00
|
|
|
} else {
|
2016-02-17 09:09:32 +00:00
|
|
|
$this->assertNull( call_user_func_array( [ $session, $m ], $args ) );
|
2016-02-01 20:44:03 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
|
|
// Trigger Session destructor
|
|
|
|
|
$session = null;
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
public static function provideMethods() {
|
2016-02-17 09:09:32 +00:00
|
|
|
return [
|
|
|
|
|
[ 'getId', [], false, true ],
|
|
|
|
|
[ 'getSessionId', [], false, true ],
|
|
|
|
|
[ 'resetId', [], false, true ],
|
|
|
|
|
[ 'getProvider', [], false, true ],
|
|
|
|
|
[ 'isPersistent', [], false, true ],
|
|
|
|
|
[ 'persist', [], false, false ],
|
2016-02-26 21:17:37 +00:00
|
|
|
[ 'unpersist', [], false, false ],
|
2016-02-17 09:09:32 +00:00
|
|
|
[ 'shouldRememberUser', [], false, true ],
|
|
|
|
|
[ 'setRememberUser', [ true ], false, false ],
|
|
|
|
|
[ 'getRequest', [], true, true ],
|
|
|
|
|
[ 'getUser', [], false, true ],
|
|
|
|
|
[ 'getAllowedUserRights', [], false, true ],
|
|
|
|
|
[ 'canSetUser', [], false, true ],
|
|
|
|
|
[ 'setUser', [ new \stdClass ], false, false ],
|
|
|
|
|
[ 'suggestLoginUsername', [], true, true ],
|
|
|
|
|
[ 'shouldForceHTTPS', [], false, true ],
|
|
|
|
|
[ 'setForceHTTPS', [ true ], false, false ],
|
|
|
|
|
[ 'getLoggedOutTimestamp', [], false, true ],
|
|
|
|
|
[ 'setLoggedOutTimestamp', [ 123 ], false, false ],
|
|
|
|
|
[ 'getProviderMetadata', [], false, true ],
|
|
|
|
|
[ 'save', [], false, false ],
|
|
|
|
|
[ 'delaySave', [], false, true ],
|
|
|
|
|
[ 'renew', [], false, false ],
|
|
|
|
|
];
|
2016-02-01 20:44:03 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
|
|
public function testDataAccess() {
|
|
|
|
|
$session = TestUtils::getDummySession();
|
|
|
|
|
$backend = \TestingAccessWrapper::newFromObject( $session )->backend;
|
|
|
|
|
|
|
|
|
|
$this->assertEquals( 1, $session->get( 'foo' ) );
|
|
|
|
|
$this->assertEquals( 'zero', $session->get( 0 ) );
|
|
|
|
|
$this->assertFalse( $backend->dirty );
|
|
|
|
|
|
|
|
|
|
$this->assertEquals( null, $session->get( 'null' ) );
|
|
|
|
|
$this->assertEquals( 'default', $session->get( 'null', 'default' ) );
|
|
|
|
|
$this->assertFalse( $backend->dirty );
|
|
|
|
|
|
|
|
|
|
$session->set( 'foo', 55 );
|
|
|
|
|
$this->assertEquals( 55, $backend->data['foo'] );
|
|
|
|
|
$this->assertTrue( $backend->dirty );
|
|
|
|
|
$backend->dirty = false;
|
|
|
|
|
|
|
|
|
|
$session->set( 1, 'one' );
|
|
|
|
|
$this->assertEquals( 'one', $backend->data[1] );
|
|
|
|
|
$this->assertTrue( $backend->dirty );
|
|
|
|
|
$backend->dirty = false;
|
|
|
|
|
|
|
|
|
|
$session->set( 1, 'one' );
|
|
|
|
|
$this->assertFalse( $backend->dirty );
|
|
|
|
|
|
|
|
|
|
$this->assertTrue( $session->exists( 'foo' ) );
|
|
|
|
|
$this->assertTrue( $session->exists( 1 ) );
|
|
|
|
|
$this->assertFalse( $session->exists( 'null' ) );
|
|
|
|
|
$this->assertFalse( $session->exists( 100 ) );
|
|
|
|
|
$this->assertFalse( $backend->dirty );
|
|
|
|
|
|
|
|
|
|
$session->remove( 'foo' );
|
|
|
|
|
$this->assertArrayNotHasKey( 'foo', $backend->data );
|
|
|
|
|
$this->assertTrue( $backend->dirty );
|
|
|
|
|
$backend->dirty = false;
|
|
|
|
|
$session->remove( 1 );
|
|
|
|
|
$this->assertArrayNotHasKey( 1, $backend->data );
|
|
|
|
|
$this->assertTrue( $backend->dirty );
|
|
|
|
|
$backend->dirty = false;
|
|
|
|
|
|
|
|
|
|
$session->remove( 101 );
|
|
|
|
|
$this->assertFalse( $backend->dirty );
|
|
|
|
|
|
2016-02-17 09:09:32 +00:00
|
|
|
$backend->data = [ 'a', 'b', '?' => 'c' ];
|
2016-02-01 20:44:03 +00:00
|
|
|
$this->assertSame( 3, $session->count() );
|
|
|
|
|
$this->assertSame( 3, count( $session ) );
|
|
|
|
|
$this->assertFalse( $backend->dirty );
|
|
|
|
|
|
2016-02-17 09:09:32 +00:00
|
|
|
$data = [];
|
2016-02-01 20:44:03 +00:00
|
|
|
foreach ( $session as $key => $value ) {
|
|
|
|
|
$data[$key] = $value;
|
|
|
|
|
}
|
|
|
|
|
$this->assertEquals( $backend->data, $data );
|
|
|
|
|
$this->assertFalse( $backend->dirty );
|
|
|
|
|
|
|
|
|
|
$this->assertEquals( $backend->data, iterator_to_array( $session ) );
|
|
|
|
|
$this->assertFalse( $backend->dirty );
|
|
|
|
|
}
|
|
|
|
|
|
2016-02-10 16:43:23 +00:00
|
|
|
public function testArrayAccess() {
|
|
|
|
|
$logger = new \TestLogger;
|
|
|
|
|
$session = TestUtils::getDummySession( null, -1, $logger );
|
|
|
|
|
$backend = \TestingAccessWrapper::newFromObject( $session )->backend;
|
|
|
|
|
|
|
|
|
|
$this->assertEquals( 1, $session['foo'] );
|
|
|
|
|
$this->assertEquals( 'zero', $session[0] );
|
|
|
|
|
$this->assertFalse( $backend->dirty );
|
|
|
|
|
|
|
|
|
|
$logger->setCollect( true );
|
|
|
|
|
$this->assertEquals( null, $session['null'] );
|
|
|
|
|
$logger->setCollect( false );
|
|
|
|
|
$this->assertFalse( $backend->dirty );
|
2016-02-17 09:09:32 +00:00
|
|
|
$this->assertSame( [
|
|
|
|
|
[ LogLevel::DEBUG, 'Undefined index (auto-adds to session with a null value): null' ]
|
|
|
|
|
], $logger->getBuffer() );
|
2016-02-10 16:43:23 +00:00
|
|
|
$logger->clearBuffer();
|
|
|
|
|
|
|
|
|
|
$session['foo'] = 55;
|
|
|
|
|
$this->assertEquals( 55, $backend->data['foo'] );
|
|
|
|
|
$this->assertTrue( $backend->dirty );
|
|
|
|
|
$backend->dirty = false;
|
|
|
|
|
|
|
|
|
|
$session[1] = 'one';
|
|
|
|
|
$this->assertEquals( 'one', $backend->data[1] );
|
|
|
|
|
$this->assertTrue( $backend->dirty );
|
|
|
|
|
$backend->dirty = false;
|
|
|
|
|
|
|
|
|
|
$session[1] = 'one';
|
|
|
|
|
$this->assertFalse( $backend->dirty );
|
|
|
|
|
|
2016-02-17 09:09:32 +00:00
|
|
|
$session['bar'] = [ 'baz' => [] ];
|
2016-02-10 16:43:23 +00:00
|
|
|
$session['bar']['baz']['quux'] = 2;
|
2016-02-17 09:09:32 +00:00
|
|
|
$this->assertEquals( [ 'baz' => [ 'quux' => 2 ] ], $backend->data['bar'] );
|
2016-02-10 16:43:23 +00:00
|
|
|
|
|
|
|
|
$logger->setCollect( true );
|
|
|
|
|
$session['bar2']['baz']['quux'] = 3;
|
|
|
|
|
$logger->setCollect( false );
|
2016-02-17 09:09:32 +00:00
|
|
|
$this->assertEquals( [ 'baz' => [ 'quux' => 3 ] ], $backend->data['bar2'] );
|
|
|
|
|
$this->assertSame( [
|
|
|
|
|
[ LogLevel::DEBUG, 'Undefined index (auto-adds to session with a null value): bar2' ]
|
|
|
|
|
], $logger->getBuffer() );
|
2016-02-10 16:43:23 +00:00
|
|
|
$logger->clearBuffer();
|
|
|
|
|
|
|
|
|
|
$backend->dirty = false;
|
|
|
|
|
$this->assertTrue( isset( $session['foo'] ) );
|
|
|
|
|
$this->assertTrue( isset( $session[1] ) );
|
|
|
|
|
$this->assertFalse( isset( $session['null'] ) );
|
|
|
|
|
$this->assertFalse( isset( $session['missing'] ) );
|
|
|
|
|
$this->assertFalse( isset( $session[100] ) );
|
|
|
|
|
$this->assertFalse( $backend->dirty );
|
|
|
|
|
|
|
|
|
|
unset( $session['foo'] );
|
|
|
|
|
$this->assertArrayNotHasKey( 'foo', $backend->data );
|
|
|
|
|
$this->assertTrue( $backend->dirty );
|
|
|
|
|
$backend->dirty = false;
|
|
|
|
|
unset( $session[1] );
|
|
|
|
|
$this->assertArrayNotHasKey( 1, $backend->data );
|
|
|
|
|
$this->assertTrue( $backend->dirty );
|
|
|
|
|
$backend->dirty = false;
|
|
|
|
|
|
|
|
|
|
unset( $session[101] );
|
|
|
|
|
$this->assertFalse( $backend->dirty );
|
|
|
|
|
}
|
|
|
|
|
|
2016-02-01 20:44:03 +00:00
|
|
|
public function testClear() {
|
|
|
|
|
$session = TestUtils::getDummySession();
|
|
|
|
|
$priv = \TestingAccessWrapper::newFromObject( $session );
|
|
|
|
|
|
|
|
|
|
$backend = $this->getMock(
|
2016-03-28 18:53:04 +00:00
|
|
|
DummySessionBackend::class, [ 'canSetUser', 'setUser', 'save' ]
|
2016-02-01 20:44:03 +00:00
|
|
|
);
|
|
|
|
|
$backend->expects( $this->once() )->method( 'canSetUser' )
|
|
|
|
|
->will( $this->returnValue( true ) );
|
|
|
|
|
$backend->expects( $this->once() )->method( 'setUser' )
|
|
|
|
|
->with( $this->callback( function ( $user ) {
|
|
|
|
|
return $user instanceof User && $user->isAnon();
|
|
|
|
|
} ) );
|
|
|
|
|
$backend->expects( $this->once() )->method( 'save' );
|
|
|
|
|
$priv->backend = $backend;
|
|
|
|
|
$session->clear();
|
2016-02-17 09:09:32 +00:00
|
|
|
$this->assertSame( [], $backend->data );
|
2016-02-01 20:44:03 +00:00
|
|
|
$this->assertTrue( $backend->dirty );
|
|
|
|
|
|
|
|
|
|
$backend = $this->getMock(
|
2016-03-28 18:53:04 +00:00
|
|
|
DummySessionBackend::class, [ 'canSetUser', 'setUser', 'save' ]
|
2016-02-01 20:44:03 +00:00
|
|
|
);
|
2016-02-17 09:09:32 +00:00
|
|
|
$backend->data = [];
|
2016-02-01 20:44:03 +00:00
|
|
|
$backend->expects( $this->once() )->method( 'canSetUser' )
|
|
|
|
|
->will( $this->returnValue( true ) );
|
|
|
|
|
$backend->expects( $this->once() )->method( 'setUser' )
|
|
|
|
|
->with( $this->callback( function ( $user ) {
|
|
|
|
|
return $user instanceof User && $user->isAnon();
|
|
|
|
|
} ) );
|
|
|
|
|
$backend->expects( $this->once() )->method( 'save' );
|
|
|
|
|
$priv->backend = $backend;
|
|
|
|
|
$session->clear();
|
|
|
|
|
$this->assertFalse( $backend->dirty );
|
|
|
|
|
|
|
|
|
|
$backend = $this->getMock(
|
2016-03-28 18:53:04 +00:00
|
|
|
DummySessionBackend::class, [ 'canSetUser', 'setUser', 'save' ]
|
2016-02-01 20:44:03 +00:00
|
|
|
);
|
|
|
|
|
$backend->expects( $this->once() )->method( 'canSetUser' )
|
|
|
|
|
->will( $this->returnValue( false ) );
|
|
|
|
|
$backend->expects( $this->never() )->method( 'setUser' );
|
|
|
|
|
$backend->expects( $this->once() )->method( 'save' );
|
|
|
|
|
$priv->backend = $backend;
|
|
|
|
|
$session->clear();
|
2016-02-17 09:09:32 +00:00
|
|
|
$this->assertSame( [], $backend->data );
|
2016-02-01 20:44:03 +00:00
|
|
|
$this->assertTrue( $backend->dirty );
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
public function testTokens() {
|
2016-03-28 18:53:04 +00:00
|
|
|
$rc = new \ReflectionClass( Session::class );
|
2016-02-01 20:44:03 +00:00
|
|
|
if ( !method_exists( $rc, 'newInstanceWithoutConstructor' ) ) {
|
|
|
|
|
$this->markTestSkipped(
|
|
|
|
|
'ReflectionClass::newInstanceWithoutConstructor isn\'t available'
|
|
|
|
|
);
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
// Instead of actually constructing the Session, we use reflection to
|
|
|
|
|
// bypass the constructor and plug a mock SessionBackend into the
|
|
|
|
|
// private fields to avoid having to actually create a SessionBackend.
|
|
|
|
|
$backend = new DummySessionBackend;
|
|
|
|
|
$session = $rc->newInstanceWithoutConstructor();
|
|
|
|
|
$priv = \TestingAccessWrapper::newFromObject( $session );
|
|
|
|
|
$priv->backend = $backend;
|
|
|
|
|
$priv->index = 42;
|
|
|
|
|
|
|
|
|
|
$token = \TestingAccessWrapper::newFromObject( $session->getToken() );
|
|
|
|
|
$this->assertArrayHasKey( 'wsTokenSecrets', $backend->data );
|
|
|
|
|
$this->assertArrayHasKey( 'default', $backend->data['wsTokenSecrets'] );
|
|
|
|
|
$secret = $backend->data['wsTokenSecrets']['default'];
|
|
|
|
|
$this->assertSame( $secret, $token->secret );
|
|
|
|
|
$this->assertSame( '', $token->salt );
|
|
|
|
|
$this->assertTrue( $token->wasNew() );
|
|
|
|
|
|
|
|
|
|
$token = \TestingAccessWrapper::newFromObject( $session->getToken( 'foo' ) );
|
|
|
|
|
$this->assertSame( $secret, $token->secret );
|
|
|
|
|
$this->assertSame( 'foo', $token->salt );
|
|
|
|
|
$this->assertFalse( $token->wasNew() );
|
|
|
|
|
|
|
|
|
|
$backend->data['wsTokenSecrets']['secret'] = 'sekret';
|
|
|
|
|
$token = \TestingAccessWrapper::newFromObject(
|
2016-02-17 09:09:32 +00:00
|
|
|
$session->getToken( [ 'bar', 'baz' ], 'secret' )
|
2016-02-01 20:44:03 +00:00
|
|
|
);
|
|
|
|
|
$this->assertSame( 'sekret', $token->secret );
|
|
|
|
|
$this->assertSame( 'bar|baz', $token->salt );
|
|
|
|
|
$this->assertFalse( $token->wasNew() );
|
|
|
|
|
|
|
|
|
|
$session->resetToken( 'secret' );
|
|
|
|
|
$this->assertArrayHasKey( 'wsTokenSecrets', $backend->data );
|
|
|
|
|
$this->assertArrayHasKey( 'default', $backend->data['wsTokenSecrets'] );
|
|
|
|
|
$this->assertArrayNotHasKey( 'secret', $backend->data['wsTokenSecrets'] );
|
|
|
|
|
|
|
|
|
|
$session->resetAllTokens();
|
|
|
|
|
$this->assertArrayNotHasKey( 'wsTokenSecrets', $backend->data );
|
|
|
|
|
|
|
|
|
|
}
|
|
|
|
|
}
|