Thijs/wiki.techinc.nl
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions
wiki.techinc.nl/tests/phpunit/includes/logging/ProtectLogFormatterTest.php

423 lines
10 KiB
PHP
Raw Normal View History

Migrate move protect log to new log system Migrate the move protect log as first sub type of the protection log, because it does not have complex log parameter, which needs some way of handling/migration. It also keeps the gerrit change smaller and hopefully makes review easier. The other sub types of the protection log will be migrated in a later patch set. This allows use of gender on Special:Log. Old message is kept for use in IRC. A test was added to ensure an unchanged IRC message. Bug: T47988 Change-Id: I57b3bd8a7dc823acdbb56520d2364f5542283373
2015-07-07 20:36:41 +00:00
<?php
class ProtectLogFormatterTest extends LogFormatterTestCase {
Migrate protect log to new log system This localize the protect type, level and expiry on Special:Log/protect. To allow i18n there are some details stored in the log params of new log items, these details also shown on API output. The details cannot get from the old existing data, because there are containing L10n strings therefore i18n works only for new items. In the api and for IRC the old description text is still stored in the log params for backward compatibility. This allows use of gender on Special:Log. Old messages are kept for use in IRC. Tests already exists to ensure an unchanged IRC message. Bug: T47988 Change-Id: I3bb85c61b857972e66c99c499d7d785c88cafb25
2015-08-22 18:29:00 +00:00
/**
* Provide different rows from the logging table to test
* for backward compatibility.
* Do not change the existing data, just add a new database row
*/
public static function provideProtectLogDatabaseRows() {
return array(
// Current format
array(
array(
'type' => 'protect',
'action' => 'protect',
'comment' => 'protect comment',
'namespace' => NS_MAIN,
'title' => 'ProtectPage',
'params' => array(
'4::description' => '[edit=sysop] (indefinite)[move=sysop] (indefinite)',
'5:bool:cascade' => false,
'details' => array(
array(
'type' => 'edit',
'level' => 'sysop',
'expiry' => 'infinity',
'cascade' => false,
),
array(
'type' => 'move',
'level' => 'sysop',
'expiry' => 'infinity',
'cascade' => false,
),
),
),
),
array(
'text' => 'User protected ProtectPage [Edit=Allow only administrators] (indefinite) [Move=Allow only administrators] (indefinite)',
'api' => array(
'description' => '[edit=sysop] (indefinite)[move=sysop] (indefinite)',
'cascade' => false,
'details' => array(
array(
'type' => 'edit',
'level' => 'sysop',
'expiry' => 'infinite',
'cascade' => false,
),
array(
'type' => 'move',
'level' => 'sysop',
'expiry' => 'infinite',
'cascade' => false,
),
),
),
),
),
// Current format with cascade
array(
array(
'type' => 'protect',
'action' => 'protect',
'comment' => 'protect comment',
'namespace' => NS_MAIN,
'title' => 'ProtectPage',
'params' => array(
'4::description' => '[edit=sysop] (indefinite)[move=sysop] (indefinite)',
'5:bool:cascade' => true,
'details' => array(
array(
'type' => 'edit',
'level' => 'sysop',
'expiry' => 'infinity',
'cascade' => true,
),
array(
'type' => 'move',
'level' => 'sysop',
'expiry' => 'infinity',
'cascade' => false,
),
),
),
),
array(
'text' => 'User protected ProtectPage [Edit=Allow only administrators] (indefinite) [Move=Allow only administrators] (indefinite) [cascading]',
'api' => array(
'description' => '[edit=sysop] (indefinite)[move=sysop] (indefinite)',
'cascade' => true,
'details' => array(
array(
'type' => 'edit',
'level' => 'sysop',
'expiry' => 'infinite',
'cascade' => true,
),
array(
'type' => 'move',
'level' => 'sysop',
'expiry' => 'infinite',
'cascade' => false,
),
),
),
),
),
// Legacy format
array(
array(
'type' => 'protect',
'action' => 'protect',
'comment' => 'protect comment',
'namespace' => NS_MAIN,
'title' => 'ProtectPage',
'params' => array(
'[edit=sysop] (indefinite)[move=sysop] (indefinite)',
'',
),
),
array(
'legacy' => true,
'text' => 'User protected ProtectPage [edit=sysop] (indefinite)[move=sysop] (indefinite)',
'api' => array(
'description' => '[edit=sysop] (indefinite)[move=sysop] (indefinite)',
'cascade' => false,
),
),
),
// Legacy format with cascade
array(
array(
'type' => 'protect',
'action' => 'protect',
'comment' => 'protect comment',
'namespace' => NS_MAIN,
'title' => 'ProtectPage',
'params' => array(
'[edit=sysop] (indefinite)[move=sysop] (indefinite)',
'cascade',
),
),
array(
'legacy' => true,
'text' => 'User protected ProtectPage [edit=sysop] (indefinite)[move=sysop] (indefinite) [cascading]',
'api' => array(
'description' => '[edit=sysop] (indefinite)[move=sysop] (indefinite)',
'cascade' => true,
),
),
),
);
}
/**
* @dataProvider provideProtectLogDatabaseRows
*/
public function testProtectLogDatabaseRows( $row, $extra ) {
$this->doTestLogFormatter( $row, $extra );
}
/**
* Provide different rows from the logging table to test
* for backward compatibility.
* Do not change the existing data, just add a new database row
*/
public static function provideModifyLogDatabaseRows() {
return array(
// Current format
array(
array(
'type' => 'protect',
'action' => 'modify',
'comment' => 'protect comment',
'namespace' => NS_MAIN,
'title' => 'ProtectPage',
'params' => array(
'4::description' => '[edit=sysop] (indefinite)[move=sysop] (indefinite)',
'5:bool:cascade' => false,
'details' => array(
array(
'type' => 'edit',
'level' => 'sysop',
'expiry' => 'infinity',
'cascade' => false,
),
array(
'type' => 'move',
'level' => 'sysop',
'expiry' => 'infinity',
'cascade' => false,
),
),
),
),
array(
'text' => 'User changed protection level for ProtectPage [Edit=Allow only administrators] (indefinite) [Move=Allow only administrators] (indefinite)',
'api' => array(
'description' => '[edit=sysop] (indefinite)[move=sysop] (indefinite)',
'cascade' => false,
'details' => array(
array(
'type' => 'edit',
'level' => 'sysop',
'expiry' => 'infinite',
'cascade' => false,
),
array(
'type' => 'move',
'level' => 'sysop',
'expiry' => 'infinite',
'cascade' => false,
),
),
),
),
),
// Current format with cascade
array(
array(
'type' => 'protect',
'action' => 'modify',
'comment' => 'protect comment',
'namespace' => NS_MAIN,
'title' => 'ProtectPage',
'params' => array(
'4::description' => '[edit=sysop] (indefinite)[move=sysop] (indefinite)',
'5:bool:cascade' => true,
'details' => array(
array(
'type' => 'edit',
'level' => 'sysop',
'expiry' => 'infinity',
'cascade' => true,
),
array(
'type' => 'move',
'level' => 'sysop',
'expiry' => 'infinity',
'cascade' => false,
),
),
),
),
array(
'text' => 'User changed protection level for ProtectPage [Edit=Allow only administrators] (indefinite) [Move=Allow only administrators] (indefinite) [cascading]',
'api' => array(
'description' => '[edit=sysop] (indefinite)[move=sysop] (indefinite)',
'cascade' => true,
'details' => array(
array(
'type' => 'edit',
'level' => 'sysop',
'expiry' => 'infinite',
'cascade' => true,
),
array(
'type' => 'move',
'level' => 'sysop',
'expiry' => 'infinite',
'cascade' => false,
),
),
),
),
),
// Legacy format
array(
array(
'type' => 'protect',
'action' => 'modify',
'comment' => 'protect comment',
'namespace' => NS_MAIN,
'title' => 'ProtectPage',
'params' => array(
'[edit=sysop] (indefinite)[move=sysop] (indefinite)',
'',
),
),
array(
'legacy' => true,
'text' => 'User changed protection level for ProtectPage [edit=sysop] (indefinite)[move=sysop] (indefinite)',
'api' => array(
'description' => '[edit=sysop] (indefinite)[move=sysop] (indefinite)',
'cascade' => false,
),
),
),
// Legacy format with cascade
array(
array(
'type' => 'protect',
'action' => 'modify',
'comment' => 'protect comment',
'namespace' => NS_MAIN,
'title' => 'ProtectPage',
'params' => array(
'[edit=sysop] (indefinite)[move=sysop] (indefinite)',
'cascade',
),
),
array(
'legacy' => true,
'text' => 'User changed protection level for ProtectPage [edit=sysop] (indefinite)[move=sysop] (indefinite) [cascading]',
'api' => array(
'description' => '[edit=sysop] (indefinite)[move=sysop] (indefinite)',
'cascade' => true,
),
),
),
);
}
/**
* @dataProvider provideModifyLogDatabaseRows
*/
public function testModifyLogDatabaseRows( $row, $extra ) {
$this->doTestLogFormatter( $row, $extra );
}
/**
* Provide different rows from the logging table to test
* for backward compatibility.
* Do not change the existing data, just add a new database row
*/
public static function provideUnprotectLogDatabaseRows() {
return array(
// Current format
array(
array(
'type' => 'protect',
'action' => 'unprotect',
'comment' => 'unprotect comment',
'namespace' => NS_MAIN,
'title' => 'ProtectPage',
'params' => array(),
),
array(
'text' => 'User removed protection from ProtectPage',
'api' => array(),
),
),
);
}
/**
* @dataProvider provideUnprotectLogDatabaseRows
*/
public function testUnprotectLogDatabaseRows( $row, $extra ) {
$this->doTestLogFormatter( $row, $extra );
}
Migrate move protect log to new log system Migrate the move protect log as first sub type of the protection log, because it does not have complex log parameter, which needs some way of handling/migration. It also keeps the gerrit change smaller and hopefully makes review easier. The other sub types of the protection log will be migrated in a later patch set. This allows use of gender on Special:Log. Old message is kept for use in IRC. A test was added to ensure an unchanged IRC message. Bug: T47988 Change-Id: I57b3bd8a7dc823acdbb56520d2364f5542283373
2015-07-07 20:36:41 +00:00
/**
* Provide different rows from the logging table to test
* for backward compatibility.
* Do not change the existing data, just add a new database row
*/
public static function provideMoveProtLogDatabaseRows() {
return array(
// Current format
array(
array(
'type' => 'protect',
'action' => 'move_prot',
'comment' => 'Move comment',
'namespace' => NS_MAIN,
'title' => 'NewPage',
'params' => array(
'4::oldtitle' => 'OldPage',
),
),
array(
'text' => 'User moved protection settings from OldPage to NewPage',
'api' => array(
'oldtitle_ns' => 0,
'oldtitle_title' => 'OldPage',
),
),
),
// Legacy format
array(
array(
'type' => 'protect',
'action' => 'move_prot',
'comment' => 'Move comment',
'namespace' => NS_MAIN,
'title' => 'NewPage',
'params' => array(
'OldPage',
),
),
array(
'legacy' => true,
'text' => 'User moved protection settings from OldPage to NewPage',
'api' => array(
'oldtitle_ns' => 0,
'oldtitle_title' => 'OldPage',
),
),
),
);
}
/**
* @dataProvider provideMoveProtLogDatabaseRows
*/
public function testMoveProtLogDatabaseRows( $row, $extra ) {
$this->doTestLogFormatter( $row, $extra );
}
}
Reference in a new issue Copy permalink