wiki.techinc.nl/includes/user/UserEditTracker.php

228 lines
5.5 KiB
PHP
Raw Normal View History

<?php
namespace MediaWiki\User;
use ActorMigration;
use DeferredUpdates;
use InvalidArgumentException;
use JobQueueGroup;
UserEditTracker: Minor code clean up and follow-ups * Remove ILoadBalancer from UserEditCountInitJob constructor, since it is not a parameter and not a Job property. It is not needed during Job construction. * Use ConvertibleTimestamp instead of MWTimestamp since no MW-specific methods or behaviours are needed here. * I don't know if UserEditCountInitJob is always safe to de-duplicate, but this should be decided in the Job class, and is not the responsibility of calling code that creates/queues a job. I don't know for sure why this is publicly part of JobSpecification, but I guess it is there for internal use when serialising jobs, not for external use in the way it was used here. I'm assuming for now that its use means it is safe and I moved it to the UserEditCountInitJob class. If this is not the case and de-dupability is actually dependent on the parameters, then that logic should reside in the UserEditCountInitJob constructor. * Document for which internal use clearUserEditCache() is public. This way during refactoring the method can be easily found and made private if that caller is no longer needed. * Remove needless Job::factory() indirection in the UserEditCountInitJob test suite. This added overhead that is not part of the test's purpose, and also risks making the test break because Job::factory() allows types to be mapped to different implementations. But, this test suite is meant to cover the UserEditCountInitJob class implementation specifically. Change-Id: I6fef4d297b1c0169f95906822e30b4addab7eaf4
2020-08-12 01:35:55 +00:00
use UserEditCountInitJob;
use UserEditCountUpdate;
use Wikimedia\Rdbms\ILoadBalancer;
UserEditTracker: Minor code clean up and follow-ups * Remove ILoadBalancer from UserEditCountInitJob constructor, since it is not a parameter and not a Job property. It is not needed during Job construction. * Use ConvertibleTimestamp instead of MWTimestamp since no MW-specific methods or behaviours are needed here. * I don't know if UserEditCountInitJob is always safe to de-duplicate, but this should be decided in the Job class, and is not the responsibility of calling code that creates/queues a job. I don't know for sure why this is publicly part of JobSpecification, but I guess it is there for internal use when serialising jobs, not for external use in the way it was used here. I'm assuming for now that its use means it is safe and I moved it to the UserEditCountInitJob class. If this is not the case and de-dupability is actually dependent on the parameters, then that logic should reside in the UserEditCountInitJob constructor. * Document for which internal use clearUserEditCache() is public. This way during refactoring the method can be easily found and made private if that caller is no longer needed. * Remove needless Job::factory() indirection in the UserEditCountInitJob test suite. This added overhead that is not part of the test's purpose, and also risks making the test break because Job::factory() allows types to be mapped to different implementations. But, this test suite is meant to cover the UserEditCountInitJob class implementation specifically. Change-Id: I6fef4d297b1c0169f95906822e30b4addab7eaf4
2020-08-12 01:35:55 +00:00
use Wikimedia\Timestamp\ConvertibleTimestamp;
/**
* Track info about user edit counts and timings
*
* @since 1.35
*
* @author DannyS712
*/
class UserEditTracker {
private const FIRST_EDIT = 1;
private const LATEST_EDIT = 2;
/** @var ActorMigration */
private $actorMigration;
/** @var ILoadBalancer */
private $loadBalancer;
/** @var JobQueueGroup */
private $jobQueueGroup;
/**
* @var array
*
* Mapping of user id to edit count for caching
* To avoid using non-sequential numerical keys, keys are in the form: `u⧼user id⧽`
*/
private $userEditCountCache = [];
/**
* @param ActorMigration $actorMigration
* @param ILoadBalancer $loadBalancer
* @param JobQueueGroup $jobQueueGroup
*/
public function __construct(
ActorMigration $actorMigration,
ILoadBalancer $loadBalancer,
JobQueueGroup $jobQueueGroup
) {
$this->actorMigration = $actorMigration;
$this->loadBalancer = $loadBalancer;
$this->jobQueueGroup = $jobQueueGroup;
}
/**
* Get a user's edit count from the user_editcount field, falling back to initialize
*
* @param UserIdentity $user
* @return int|null Null for anonymous users
*/
public function getUserEditCount( UserIdentity $user ): ?int {
if ( !$user->isRegistered() ) {
return null;
}
$userId = $user->getId();
$cacheKey = 'u' . (string)$userId;
if ( isset( $this->userEditCountCache[ $cacheKey ] ) ) {
return $this->userEditCountCache[ $cacheKey ];
}
$dbr = $this->loadBalancer->getConnectionRef( DB_REPLICA );
$count = $dbr->selectField(
'user',
'user_editcount',
[ 'user_id' => $userId ],
__METHOD__
);
if ( $count === null ) {
// it has not been initialized. do so.
$count = $this->initializeUserEditCount( $user );
}
$this->userEditCountCache[ $cacheKey ] = $count;
return $count;
}
/**
UserEditTracker: Minor code clean up and follow-ups * Remove ILoadBalancer from UserEditCountInitJob constructor, since it is not a parameter and not a Job property. It is not needed during Job construction. * Use ConvertibleTimestamp instead of MWTimestamp since no MW-specific methods or behaviours are needed here. * I don't know if UserEditCountInitJob is always safe to de-duplicate, but this should be decided in the Job class, and is not the responsibility of calling code that creates/queues a job. I don't know for sure why this is publicly part of JobSpecification, but I guess it is there for internal use when serialising jobs, not for external use in the way it was used here. I'm assuming for now that its use means it is safe and I moved it to the UserEditCountInitJob class. If this is not the case and de-dupability is actually dependent on the parameters, then that logic should reside in the UserEditCountInitJob constructor. * Document for which internal use clearUserEditCache() is public. This way during refactoring the method can be easily found and made private if that caller is no longer needed. * Remove needless Job::factory() indirection in the UserEditCountInitJob test suite. This added overhead that is not part of the test's purpose, and also risks making the test break because Job::factory() allows types to be mapped to different implementations. But, this test suite is meant to cover the UserEditCountInitJob class implementation specifically. Change-Id: I6fef4d297b1c0169f95906822e30b4addab7eaf4
2020-08-12 01:35:55 +00:00
* @internal For use in UserEditCountUpdate class
* @param UserIdentity $user
* @return int
*/
public function initializeUserEditCount( UserIdentity $user ): int {
$dbr = $this->loadBalancer->getConnectionRef( DB_REPLICA );
$actorWhere = $this->actorMigration->getWhere( $dbr, 'rev_user', $user );
$count = (int)$dbr->selectField(
[ 'revision' ] + $actorWhere['tables'],
'COUNT(*)',
[ $actorWhere['conds'] ],
__METHOD__,
[],
$actorWhere['joins']
);
UserEditTracker: Minor code clean up and follow-ups * Remove ILoadBalancer from UserEditCountInitJob constructor, since it is not a parameter and not a Job property. It is not needed during Job construction. * Use ConvertibleTimestamp instead of MWTimestamp since no MW-specific methods or behaviours are needed here. * I don't know if UserEditCountInitJob is always safe to de-duplicate, but this should be decided in the Job class, and is not the responsibility of calling code that creates/queues a job. I don't know for sure why this is publicly part of JobSpecification, but I guess it is there for internal use when serialising jobs, not for external use in the way it was used here. I'm assuming for now that its use means it is safe and I moved it to the UserEditCountInitJob class. If this is not the case and de-dupability is actually dependent on the parameters, then that logic should reside in the UserEditCountInitJob constructor. * Document for which internal use clearUserEditCache() is public. This way during refactoring the method can be easily found and made private if that caller is no longer needed. * Remove needless Job::factory() indirection in the UserEditCountInitJob test suite. This added overhead that is not part of the test's purpose, and also risks making the test break because Job::factory() allows types to be mapped to different implementations. But, this test suite is meant to cover the UserEditCountInitJob class implementation specifically. Change-Id: I6fef4d297b1c0169f95906822e30b4addab7eaf4
2020-08-12 01:35:55 +00:00
// Defer updating the edit count via a job (T259719)
$this->jobQueueGroup->push( new UserEditCountInitJob( [
'userId' => $user->getId(),
'editCount' => $count,
] ) );
return $count;
}
/**
* Schedule a job to increase a user's edit count
*
* @since 1.37
* @param UserIdentity $user
*/
public function incrementUserEditCount( UserIdentity $user ) {
if ( !$user->isRegistered() ) {
// Anonymous users don't have edit counts
return;
}
DeferredUpdates::addUpdate(
new UserEditCountUpdate( $user, 1 ),
DeferredUpdates::POSTSEND
);
}
/**
* Get the user's first edit timestamp
*
* @param UserIdentity $user
* @return string|false Timestamp of first edit, or false for non-existent/anonymous user
* accounts.
*/
public function getFirstEditTimestamp( UserIdentity $user ) {
return $this->getUserEditTimestamp( $user, self::FIRST_EDIT );
}
/**
* Get the user's latest edit timestamp
*
* @param UserIdentity $user
* @return string|false Timestamp of latest edit, or false for non-existent/anonymous user
* accounts.
*/
public function getLatestEditTimestamp( UserIdentity $user ) {
return $this->getUserEditTimestamp( $user, self::LATEST_EDIT );
}
/**
* Get the timestamp of a user's edit, either their first or latest
*
* @param UserIdentity $user
* @param int $type either self::FIRST_EDIT or ::LATEST_EDIT
* @return string|false Timestamp of edit, or false for non-existent/anonymous user accounts.
*/
private function getUserEditTimestamp( UserIdentity $user, int $type ) {
if ( $user->getId() === 0 ) {
return false; // anonymous user
}
$dbr = $this->loadBalancer->getConnectionRef( DB_REPLICA );
$actorWhere = $this->actorMigration->getWhere( $dbr, 'rev_user', $user );
$tsField = isset( $actorWhere['tables']['temp_rev_user'] ) // SCHEMA_COMPAT_READ_TEMP
? 'revactor_timestamp' : 'rev_timestamp';
$sortOrder = ( $type === self::FIRST_EDIT ) ? 'ASC' : 'DESC';
$time = $dbr->selectField(
[ 'revision' ] + $actorWhere['tables'],
$tsField,
[ $actorWhere['conds'] ],
__METHOD__,
[ 'ORDER BY' => "$tsField $sortOrder" ],
$actorWhere['joins']
);
if ( !$time ) {
return false; // no edits
}
UserEditTracker: Minor code clean up and follow-ups * Remove ILoadBalancer from UserEditCountInitJob constructor, since it is not a parameter and not a Job property. It is not needed during Job construction. * Use ConvertibleTimestamp instead of MWTimestamp since no MW-specific methods or behaviours are needed here. * I don't know if UserEditCountInitJob is always safe to de-duplicate, but this should be decided in the Job class, and is not the responsibility of calling code that creates/queues a job. I don't know for sure why this is publicly part of JobSpecification, but I guess it is there for internal use when serialising jobs, not for external use in the way it was used here. I'm assuming for now that its use means it is safe and I moved it to the UserEditCountInitJob class. If this is not the case and de-dupability is actually dependent on the parameters, then that logic should reside in the UserEditCountInitJob constructor. * Document for which internal use clearUserEditCache() is public. This way during refactoring the method can be easily found and made private if that caller is no longer needed. * Remove needless Job::factory() indirection in the UserEditCountInitJob test suite. This added overhead that is not part of the test's purpose, and also risks making the test break because Job::factory() allows types to be mapped to different implementations. But, this test suite is meant to cover the UserEditCountInitJob class implementation specifically. Change-Id: I6fef4d297b1c0169f95906822e30b4addab7eaf4
2020-08-12 01:35:55 +00:00
return ConvertibleTimestamp::convert( TS_MW, $time );
}
/**
* @internal For use by User::clearInstanceCache()
* @param UserIdentity $user
*/
public function clearUserEditCache( UserIdentity $user ) {
if ( !$user->isRegistered() ) {
return;
}
$userId = $user->getId();
$cacheKey = 'u' . (string)$userId;
unset( $this->userEditCountCache[ $cacheKey ] );
}
/**
* @internal For use by User::loadFromRow() and tests
* @param UserIdentity $user
* @param int $editCount
* @throws InvalidArgumentException If the user is not registered
*/
public function setCachedUserEditCount( UserIdentity $user, int $editCount ) {
if ( !$user->isRegistered() ) {
throw new InvalidArgumentException( __METHOD__ . ' with an anonymous user' );
}
$userId = $user->getId();
$cacheKey = 'u' . (string)$userId;
$this->userEditCountCache[ $cacheKey ] = $editCount;
}
}