Hard deprecate ContribsPager::tryToCreateValidRevision

Bug: T250431
Change-Id: Icffe4c407f46e068fb27b0632d93fcaac2b6cfa9

RELEASE-NOTES-1.35

@@ -728,7 +728,7 @@ because of Phabricator reports.
   outside of mediawiki core.
 * AuthManager::singleton() has been deprecated. Use
   MediaWikiServices::getInstance()->getAuthManager() instead.
-* ContribsPager::tryToCreateValidRevision is soft deprecated. Instead, use
+* ContribsPager::tryToCreateValidRevision is hard deprecated. Instead, use
   ContribsPager::tryCreatingRevisionRecord.
 * The following functions all accept an optional user parameter. Not passing a
   user is hard deprecated, and support for calling them without passing a user

includes/specials/pagers/ContribsPager.php

@@ -541,6 +541,7 @@ class ContribsPager extends RangeChronologicalPager {
 	 * @return Revision|null
 	 */
 	public function tryToCreateValidRevision( $row, $title = null ) {
+		wfDeprecated( __METHOD__, '1.35' );
 		$potentialRevRecord = $this->tryCreatingRevisionRecord( $row, $title );
 		return $potentialRevRecord ? new Revision( $potentialRevRecord ) : null;
 	}

tests/phpunit/includes/specials/ContribsPagerTest.php

@@ -175,6 +175,8 @@ class ContribsPagerTest extends MediaWikiTestCase {
 	 * @covers \ContribsPager::tryCreatingRevisionRecord
 	 */
 	public function testCreateRevision() {
+		$this->hideDeprecated( 'ContribsPager::tryToCreateValidRevision' );
+
 		$pager = new ContribsPager( new RequestContext(), [
 			'target' => '116.17.184.5/32',
 			'start' => '',