Thijs/wiki.techinc.nl
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Remove double check of $oldRevision

Browse source 
The

 if ( $oldRevision )

above already do the same check.

Change-Id: Ibbd5b6209d67f195b6b7431bccc31c4401f0a799
This commit is contained in:
Fomafix 2019-02-08 14:05:13 +01:00
parent d90508d3c2
commit 04370ccb08
1 changed files with 2 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
includes/diff/DifferenceEngine.php
View file

@ -1642,8 +1642,8 @@ class DifferenceEngine extends ContextSource {
$this->mOldPage = Title::newFromLinkTarget( $oldRevision->getPageAsLinkTarget() );
// This method is meant for edit diffs and such so there is no reason to provide a
// revision that's not readable to the user, but check it just in case.
$this->mOldContent = $oldRevision ? $oldRevision->getContent( SlotRecord::MAIN,
RevisionRecord::FOR_THIS_USER, $this->getUser() ) : null;
$this->mOldContent = $oldRevision->getContent( SlotRecord::MAIN,
RevisionRecord::FOR_THIS_USER, $this->getUser() );
} else {
$this->mOldPage = null;
$this->mOldRev = $this->mOldid = false;