Thijs/wiki.techinc.nl
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Make TitleValue fields private

Browse source 
Class is extended only in JsonConfig extension, but
these fields are not accessed.

The @deprecated annotation was put in there to prevent
external access, since the fields were protected we can't
use DeprecationHelper to hard deprecate. The class is
not @stable to extend, so for all intents and purposes
protected is equivalent to private.

Change-Id: I30089cf1f1361bf8f8c544316e422581ac7aea64
This commit is contained in:
Petr Pchelko 2021-09-13 07:28:57 -07:00
parent a4b5426e4c
commit 045d04ca2b
1 changed files with 8 additions and 20 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

28
includes/title/TitleValue.php
View file

@ -39,29 +39,17 @@ use Wikimedia\Assert\ParameterTypeException;
*/
class TitleValue implements LinkTarget {
/**
* @deprecated in 1.31. This class is immutable. Use the getter for access.
* @var int
*/
protected $namespace;
/** @var int */
private $namespace;
/**
* @deprecated in 1.31. This class is immutable. Use the getter for access.
* @var string
*/
protected $dbkey;
/** @var string */
private $dbkey;
/**
* @deprecated in 1.31. This class is immutable. Use the getter for access.
* @var string
*/
protected $fragment;
/** @var string */
private $fragment;
/**
* @deprecated in 1.31. This class is immutable. Use the getter for access.
* @var string
*/
protected $interwiki;
/** @var string */
private $interwiki;
/**
* Text form including namespace/interwiki, initialised on demand