Thijs/wiki.techinc.nl
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Hard deprecate Article::updateRevisionOn and ::updateIfNewerOn

Browse source 
Accept Revision parameters, calls WikiPage::updateRevisionOn and
::updateIfNewerOn respectively
Unused in deployed code

Bug: T249561
Bug: T239975
Change-Id: I34cfa04e2785b3e1d811f21fee77c51a12601330
This commit is contained in:
DannyS712 2020-04-15 06:01:39 +00:00
parent 792cdc3bdb
commit 059846ad36
2 changed files with 6 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
RELEASE-NOTES-1.35
View file

@ -705,6 +705,8 @@ because of Phabricator reports.
WikiPage::doDeleteArticleReal.
* Article::getComment is deprecated. Instead, use WikiPage::getComment.
* Article::getCreator is deprecated. Instead, use WikiPage::getCreator.
* Article::updateRevisionOn and Article::updateIfNewerOn are deprecated.
Instead, use WikiPage::updateRevisionOn.
* Article::getUser is deprecated. Instead, use WikiPage::getUser.
* Article::getUserText is deprecated. Instead, use WikiPage::getUserText.
* Article::doDeleteUpdates is deprecated. Instead, use

4
includes/page/Article.php
View file

@ -2939,12 +2939,14 @@ class Article implements Page {
/**
* Call to WikiPage function for backwards compatibility.
* @deprecated since 1.35
* @see WikiPage::updateIfNewerOn
* @param IDatabase $dbw
* @param Revision $revision
* @return bool
*/
public function updateIfNewerOn( $dbw, $revision ) {
wfDeprecated( __METHOD__, '1.35' );
return $this->mPage->updateIfNewerOn( $dbw, $revision );
}
@ -2962,6 +2964,7 @@ class Article implements Page {
/**
* Call to WikiPage function for backwards compatibility.
* @deprecated since 1.35
* @see WikiPage::updateRevisionOn
* @param IDatabase $dbw
* @param Revision $revision
@ -2972,6 +2975,7 @@ class Article implements Page {
public function updateRevisionOn( $dbw, $revision, $lastRevision = null,
$lastRevIsRedirect = null
) {
wfDeprecated( __METHOD__, '1.35' );
return $this->mPage->updateRevisionOn( $dbw, $revision, $lastRevision,
$lastRevIsRedirect
);