From 72010ca8186b8b8cac26bbf1ae29b5cdba1d2306 Mon Sep 17 00:00:00 2001
From: DannyS712 <DannyS712.enwiki@gmail.com>
Date: Wed, 24 Jun 2020 22:05:35 +0000
Subject: [PATCH] DifferenceEngine: Call DiffTools hook with correct parameter
 order

mNewRevisionRecord is meant to be the first parameter, and
mOldRevisionRecord the third, not the other way around

Bug: T256298
Change-Id: I030a9834635a85ad464e5826926c26b41a9c31b0
---
 includes/diff/DifferenceEngine.php | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/includes/diff/DifferenceEngine.php b/includes/diff/DifferenceEngine.php
index 0e7019f2e88..3c5ed653864 100644
--- a/includes/diff/DifferenceEngine.php
+++ b/includes/diff/DifferenceEngine.php
@@ -776,9 +776,9 @@ class DifferenceEngine extends ContextSource {
 
 		# Allow extensions to define their own revision tools
 		$this->hookRunner->onDiffTools(
-			$this->mOldRevisionRecord,
-			$revisionTools,
 			$this->mNewRevisionRecord,
+			$revisionTools,
+			$this->mOldRevisionRecord,
 			$user
 		);