Thijs/wiki.techinc.nl
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Use WikiPage::getRevision() instead of another Revision object if the oldid parameter corresponds to the page's latest revision

Browse source
This commit is contained in:
Alexandre Emsenhuber 2012-03-09 14:50:39 +00:00
parent 1a15440e43
commit 08efa9be88
1 changed files with 10 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

16
includes/Article.php
View file

@ -248,12 +248,16 @@ class Article extends Page {
if ( $oldid !== 0 ) {
# Load the given revision and check whether the page is another one.
# In that case, update this instance to reflect the change.
$this->mRevision = Revision::newFromId( $oldid );
if ( $this->mRevision !== null ) {
// Revision title doesn't match the page title given?
if ( $this->mPage->getID() != $this->mRevision->getPage() ) {
$function = array( get_class( $this->mPage ), 'newFromID' );
$this->mPage = call_user_func( $function, $this->mRevision->getPage() );
if ( $oldid === $this->mPage->getLatest() ) {
$this->mRevision = $this->mPage->getRevision();
} else {
$this->mRevision = Revision::newFromId( $oldid );
if ( $this->mRevision !== null ) {
// Revision title doesn't match the page title given?
if ( $this->mPage->getID() != $this->mRevision->getPage() ) {
$function = array( get_class( $this->mPage ), 'newFromID' );
$this->mPage = call_user_func( $function, $this->mRevision->getPage() );
}
}
}
}