Thijs/wiki.techinc.nl
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Prettier wfLogProfilingData() log message

Browse source 
Make the profiler logging output introduced in Iae11e1e a little nicer.
Stop adding the Profiler::getRawData() information and add the URL and
textual report to the default log message. When testing with a Monolog
logger and Logstash the getRawData output from the Xhprof profiler was
found to be too big to be usable. The default message output was found
to be less informative than desirable when a PSR-3 logger other than
MWLoggerLegacyLogger was used. MWLoggerLegacyLogger implements special
backwards compatible formatting for the profileoutput channel that will
not be effected by this change.

Change-Id: Id326aed4f72a3489fac30661c101ac3bb3af2530
This commit is contained in:
Bryan Davis 2014-11-17 10:32:45 -07:00
parent 478272b6e5
commit 0b91f622a3
1 changed files with 1 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
includes/GlobalFunctions.php
View file

@ -1226,10 +1226,9 @@ function wfLogProfilingData() {
}
$ctx['output'] = $profiler->getOutput();
$ctx['profile'] = $profiler->getRawData();
$log = MWLogger::getInstance( 'profileoutput' );
$log->info( 'Elapsed: {elapsed}', $ctx );
$log->info( "Elapsed: {elapsed}; URL: <{url}>\n{output}", $ctx );
}
/**