From 0cf2ec25859a5b400385ef7f781523d469e7514e Mon Sep 17 00:00:00 2001
From: Umherirrender <umherirrender_de.wp@web.de>
Date: Sat, 5 Mar 2022 19:45:57 +0100
Subject: [PATCH] Pass rcid as integer to
 DifferenceEngine::createDifferenceEngine

Found by phan strict checks

Change-Id: I3c0454c1df66f6a04c3392acaf8368040d03eb77
---
 includes/actions/RollbackAction.php       | 2 +-
 includes/page/Article.php                 | 2 +-
 includes/specials/SpecialComparePages.php | 2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/includes/actions/RollbackAction.php b/includes/actions/RollbackAction.php
index 521ed0d3cf3..ae6fe04963e 100644
--- a/includes/actions/RollbackAction.php
+++ b/includes/actions/RollbackAction.php
@@ -256,7 +256,7 @@ class RollbackAction extends FormAction {
 				$this->getContext(),
 				$current->getId(),
 				$newId,
-				false,
+				0,
 				true
 			);
 			$de->showDiff( '', '' );
diff --git a/includes/page/Article.php b/includes/page/Article.php
index 0229ab3bcd9..466ddc2e0a6 100644
--- a/includes/page/Article.php
+++ b/includes/page/Article.php
@@ -845,7 +845,7 @@ class Article implements Page {
 		$request = $this->getContext()->getRequest();
 		$user = $this->getContext()->getUser();
 		$diff = $request->getVal( 'diff' );
-		$rcid = $request->getVal( 'rcid' );
+		$rcid = $request->getInt( 'rcid' );
 		$diffOnly = $request->getBool( 'diffonly', $user->getOption( 'diffonly' ) );
 		$purge = $request->getRawVal( 'action' ) === 'purge';
 		$unhide = $request->getInt( 'unhide' ) == 1;
diff --git a/includes/specials/SpecialComparePages.php b/includes/specials/SpecialComparePages.php
index c50057932c7..91631251f78 100644
--- a/includes/specials/SpecialComparePages.php
+++ b/includes/specials/SpecialComparePages.php
@@ -144,7 +144,7 @@ class SpecialComparePages extends SpecialPage {
 				$de = $contentHandler->createDifferenceEngine( $form->getContext(),
 					$rev1,
 					$rev2,
-					null, // rcid
+					0, // rcid
 					( $data['Action'] == 'purge' ),
 					( $data['Unhide'] == '1' )
 				);