Thijs/wiki.techinc.nl
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

LanguageConverter: Only set mTablesLoaded once they're really loaded

Browse source 
If something inside the callback above throws an exception (e.g.
`parseCachedTable()` when the database is down), and it is caught,
`$this->mTablesLoaded` and `$this->mTables` will be left in an
inconsistent state for the rest of the request, causing confusing
errors elsewhere.

Bug: T388807
Change-Id: I79704d6d5c03d5e028c0c762a37fd55b953a4a6a
(cherry picked from commit 6d4f287059521fd4e7fe094ccb00aca54906b31f)
This commit is contained in:
Bartosz Dziewoński 2025-03-18 01:27:46 +01:00 committed by Winston Sung
parent b1d2516673
commit 0d5d80b7e1
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
includes/language/LanguageConverter.php
View file

@ -1027,7 +1027,6 @@ abstract class LanguageConverter implements ILanguageConverter {
return;
}
$this->mTablesLoaded = true;
$cache = $services->getObjectCacheFactory()->getInstance( $languageConverterCacheType );
$cacheKey = $cache->makeKey(
'conversiontables', $this->getMainCode(),
@ -1048,6 +1047,7 @@ abstract class LanguageConverter implements ILanguageConverter {
$this->postLoadTables( $tables );
return $tables;
} );
$this->mTablesLoaded = true;
}
/**