Thijs/wiki.techinc.nl
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Make DeferredUpdates enqueue updates that failed to run when possible

Browse source 
Bug: T206288
Bug: T206283
Change-Id: I6025bcc7d68cf214d291191d4044a66cdeff108b
This commit is contained in:
Aaron Schulz 2018-10-12 13:49:25 -07:00 committed by Krinkle
parent 500cbe99b6
commit 0ef02cd018
1 changed files with 10 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

10
includes/deferred/DeferredUpdates.php
View file

@ -280,6 +280,16 @@ class DeferredUpdates {
} }
MWExceptionHandler::rollbackMasterChangesAndLog( $e ); MWExceptionHandler::rollbackMasterChangesAndLog( $e );
// Try to push the update as a job so it can run later perhaps
if ( $mode !== 'enqueue' && $update instanceof EnqueueableDataUpdate ) {
try {
$spec = $update->getAsJobSpecification();
JobQueueGroup::singleton( $spec['wiki'] )->push( $spec['job'] );
} catch ( Exception $e ) {
MWExceptionHandler::rollbackMasterChangesAndLog( $e );
}
}
// VW-style hack to work around T190178, so we can make sure // VW-style hack to work around T190178, so we can make sure
// PageMetaDataUpdater doesn't throw exceptions. // PageMetaDataUpdater doesn't throw exceptions.
if ( defined( 'MW_PHPUNIT_TEST' ) ) { if ( defined( 'MW_PHPUNIT_TEST' ) ) {