Thijs/wiki.techinc.nl
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

ChangesList separates content elements from presentation

Browse source 
Special:RecentChanges and Special:Watchlist benefit from this change

Bug: T205581
Change-Id: If46d9ed904fdc6f01decbfde12ade0c47e282171
This commit is contained in:
jdlrobson 2018-11-21 14:55:48 -08:00 committed by Jdlrobson
parent e81eed3675
commit 103581ec75
2 changed files with 9 additions and 9 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

16
includes/changes/ChangesList.php
View file

@ -454,11 +454,9 @@ class ChangesList extends ContextSource {
); );
} }
if ( $rc->mAttribs['rc_type'] == RC_CATEGORIZE ) { if ( $rc->mAttribs['rc_type'] == RC_CATEGORIZE ) {
$diffhist = $diffLink . $this->message['pipe-separator'] . $this->message['hist']; $histLink = $this->message['hist'];
} else { } else {
$diffhist = $diffLink . $this->message['pipe-separator']; $histLink = $this->linkRenderer->makeKnownLink(
# History link
$diffhist .= $this->linkRenderer->makeKnownLink(
$rc->getTitle(), $rc->getTitle(),
new HtmlArmor( $this->message['hist'] ), new HtmlArmor( $this->message['hist'] ),
[ 'class' => 'mw-changeslist-history' ], [ 'class' => 'mw-changeslist-history' ],
@ -469,9 +467,11 @@ class ChangesList extends ContextSource {
); );
} }
// @todo FIXME: Hard coded ". .". Is there a message for this? Should there be? $s .= Html::rawElement( 'div', [ 'class' => 'mw-changeslist-links' ],
$s .= $this->msg( 'parentheses' )->rawParams( $diffhist )->escaped() . Html::rawElement( 'span', [], $diffLink ) .
' <span class="mw-changeslist-separator">. .</span> '; Html::rawElement( 'span', [], $histLink )
) .
' <span class="mw-changeslist-separator"></span> ';
} }
/** /**
@ -535,7 +535,7 @@ class ChangesList extends ContextSource {
htmlspecialchars( $this->getLanguage()->userTime( htmlspecialchars( $this->getLanguage()->userTime(
$rc->mAttribs['rc_timestamp'], $rc->mAttribs['rc_timestamp'],
$this->getUser() $this->getUser()
) ) . '</span> <span class="mw-changeslist-separator">. .</span> '; ) ) . '</span> <span class="mw-changeslist-separator"></span> ';
} }
/** /**

2
includes/changes/OldChangesList.php
View file

@ -121,7 +121,7 @@ class OldChangesList extends ChangesList {
if ( $this->getConfig()->get( 'RCShowChangedSize' ) ) { if ( $this->getConfig()->get( 'RCShowChangedSize' ) ) {
$cd = $this->formatCharacterDifference( $rc ); $cd = $this->formatCharacterDifference( $rc );
if ( $cd !== '' ) { if ( $cd !== '' ) {
$html .= $cd . ' <span class="mw-changeslist-separator">. .</span> '; $html .= $cd . ' <span class="mw-changeslist-separator"></span> ';
} }
} }