Thijs/wiki.techinc.nl
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Follow-up r67324: removed check for empty text since the length is checked explicitly

Browse source
This commit is contained in:
Alexandre Emsenhuber 2010-12-04 19:30:26 +00:00
parent 2287d50007
commit 1098d92d42
1 changed files with 4 additions and 9 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

13
maintenance/dumpTextPass.php
View file

@ -214,18 +214,13 @@ class TextPassDumper extends BackupDumper {
$this->fetchCount++;
if ( isset( $this->prefetch ) ) {
$text = $this->prefetch->prefetch( $this->thisPage, $this->thisRev );
if ( $text === null ) {
// Entry missing from prefetch dump
} elseif ( $text === "" ) {
// Blank entries may indicate that the prior dump was broken.
// To be safe, reload it.
} else {
if ( $text !== null ) { // Entry missing from prefetch dump
$dbr = wfGetDB( DB_SLAVE );
$revID = intval($this->thisRev);
$revLength = $dbr->selectField( 'revision', 'rev_len', array('rev_id' => $revID ) );
$revID = intval( $this->thisRev );
$revLength = $dbr->selectField( 'revision', 'rev_len', array( 'rev_id' => $revID ) );
// if length of rev text in file doesn't match length in db, we reload
// this avoids carrying forward broken data from previous xml dumps
if( strlen($text) == $revLength ) {
if( strlen( $text ) == $revLength ) {
$this->prefetchCount++;
return $text;
}