Ensure MWHttpRequest::method gets set with strtoupper() since code

examining MWHttpRequest::method always expects its value to be
fully uppercased.

Yes, this should not be a problem if MWHttpRequest is accessed
via HTTP class, but that will not always be guaranteed.

Resolves bug 36137.

Change-Id: Ic20e1b99dcb56b8a11cea50293ba44022e564de9
This commit is contained in:
awjrichards 2012-04-20 15:17:55 -07:00
parent 242659a4a7
commit 1122ca5f87

View file

@ -216,6 +216,11 @@ class MWHttpRequest {
foreach ( $members as $o ) {
if ( isset( $options[$o] ) ) {
// ensure that MWHttpRequest::method is always
// uppercased. Bug 36137
if ( $o == 'method' ) {
$options[$o] = strtoupper( $options[$o] );
}
$this->$o = $options[$o];
}
}