From 120ecc6d1babfaabf1fd6b8cabdf4b9e79314835 Mon Sep 17 00:00:00 2001
From: jdlrobson <jdlrobson@gmail.com>
Date: Tue, 13 Jul 2021 08:32:28 -0700
Subject: [PATCH] links is flat array

Pass a valid key to makeLink rather than an integer (index)
which may result in an exception.

Bug: T286040
Change-Id: Ic69ec102caec982e65e264f5812ac15df5168008
---
 includes/skins/Skin.php | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/includes/skins/Skin.php b/includes/skins/Skin.php
index 183dd956cad..8b41c6fcdec 100644
--- a/includes/skins/Skin.php
+++ b/includes/skins/Skin.php
@@ -2481,8 +2481,9 @@ abstract class Skin extends ContextSource {
 
 		if ( isset( $item['links'] ) ) {
 			$links = [];
-			foreach ( $item['links'] as $linkKey => $link ) {
-				$links[] = $this->makeLink( $linkKey, $link, $options );
+			foreach ( $item['links'] as $link ) {
+				// Note: links will have identical label unless 'msg' is set on $link
+				$links[] = $this->makeLink( $key, $link, $options );
 			}
 			$html = implode( ' ', $links );
 		} else {