Thijs/wiki.techinc.nl
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Revert "Deprecate no longer used Skin::getCommonStylePath."

Browse source 
This reverts commit 79dcf7686d.

getCommonStylePath and getSkinStylePath are a pair of methods for use in 3rd party skins (NOT core).
They cut down on the boilerplate for including skin urls into skins for things like <img> tags.
Without these methods skin authors will be forced to revert to unintuitive boilerplate to add style paths and style versions into their code.
Most won't even bother to include the style version.
And ResourceLoader is a tangent to the whole topic because no matter what the advantages to CSS are developers writing custom skins for a single site from scratch will not care and they will choose CSS or <img> based on situations on hand in their own markup that make one or the other harder to handle.
This addition was part of the effort to fix the longstanding issue that our our skin system does not properly account for 3rd party skin developers.

Change-Id: I98f4fd83c93aba7681306d0a1edb58f798057543
This commit is contained in:
Daniel Friesen 2012-06-14 18:08:29 -07:00
parent c31cb08184
commit 127befb178
2 changed files with 0 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
RELEASE-NOTES-1.20
View file

@ -161,7 +161,6 @@ changes to languages because of Bugzilla reports.
* Removed ./tests/qunit/index.html from core. It wasn't actively maintained and
has been made obsolete when [[Special:JavaScriptTest/qunit]] was introduced,
which actually uses ResourceLoader, LocalSettings and the Skin.
* Skin::getCommonStylePath has been deprecated. Its use is obsolete.
== Compatibility ==

5
includes/Skin.php
View file

@ -1033,16 +1033,11 @@ abstract class Skin extends ContextSource {
* Return a fully resolved style path url to images or styles stored in the common folder.
* This method returns a url resolved using the configured skin style path
* and includes the style version inside of the url.
* @deprecated since 1.20: obsolete
*
* @param $name String: The name or path of a skin resource file
* @return String The fully resolved style path url including styleversion
*/
function getCommonStylePath( $name ) {
global $wgStylePath, $wgStyleVersion;
wfDeprecated( __METHOD__, '1.20' );
return "$wgStylePath/common/$name?$wgStyleVersion";
}