From 12a3c76c9ea3b72df719da481d29c1b10b4c9358 Mon Sep 17 00:00:00 2001 From: RhinosF1 Date: Sun, 22 May 2022 10:49:47 +0000 Subject: [PATCH] notifications: prevent log spam when invalid user object listed. Bug: T308967 Change-Id: I20bfb3c5b725405aaeb48f17d300a06428084cfe --- includes/mail/EmailNotification.php | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/includes/mail/EmailNotification.php b/includes/mail/EmailNotification.php index cc6d342f4c6..16bb6f9ab17 100644 --- a/includes/mail/EmailNotification.php +++ b/includes/mail/EmailNotification.php @@ -301,9 +301,10 @@ class EmailNotification { continue; } $user = User::newFromName( $name ); - $this->compose( $user, self::ALL_CHANGES, $messageCache ); + if ( $user instanceof User ) { + $this->compose( $user, self::ALL_CHANGES, $messageCache ); + } } - $this->sendMails(); }