diff --git a/includes/changes/ChangesList.php b/includes/changes/ChangesList.php index cf97afbb1e6..b938ff0b35a 100644 --- a/includes/changes/ChangesList.php +++ b/includes/changes/ChangesList.php @@ -366,7 +366,7 @@ class ChangesList extends ContextSource { $diffLink = Linker::linkKnown( $rc->getTitle(), $this->message['diff'], - [ 'tabindex' => $rc->counter ], + [], $query ); } diff --git a/includes/changes/RCCacheEntryFactory.php b/includes/changes/RCCacheEntryFactory.php index 4c003d32dce..549bc3730eb 100644 --- a/includes/changes/RCCacheEntryFactory.php +++ b/includes/changes/RCCacheEntryFactory.php @@ -174,7 +174,7 @@ class RCCacheEntryFactory { $curLink = $curMessage; } else { $curUrl = htmlspecialchars( $cacheEntry->getTitle()->getLinkURL( $queryParams ) ); - $curLink = "$curMessage"; + $curLink = "$curMessage"; } return $curLink; @@ -217,10 +217,10 @@ class RCCacheEntryFactory { return $diffMessage; } $diffUrl = htmlspecialchars( $pageTitle->getLinkURL( $queryParams ) ); - $diffLink = "$diffMessage"; + $diffLink = "$diffMessage"; } else { $diffUrl = htmlspecialchars( $cacheEntry->getTitle()->getLinkURL( $queryParams ) ); - $diffLink = "$diffMessage"; + $diffLink = "$diffMessage"; } return $diffLink; diff --git a/tests/phpunit/includes/changes/OldChangesListTest.php b/tests/phpunit/includes/changes/OldChangesListTest.php index 5746a61dc4b..bc70a133e12 100644 --- a/tests/phpunit/includes/changes/OldChangesListTest.php +++ b/tests/phpunit/includes/changes/OldChangesListTest.php @@ -93,7 +93,6 @@ class OldChangesListTest extends MediaWikiLangTestCase { 'assert diff link' ); - $this->assertRegExp( '/tabindex="0"/', $line, 'assert tab index' ); $this->assertRegExp( '/title=Cat&curid=20131103212153&action=history"/', $line,