Thijs/wiki.techinc.nl
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

The pass-by-reference on the string on fastCompose() really slows things down sometimes in PHP4. Taking it out speeds up processing of Japanese text significantly.

Browse source
This commit is contained in:
Brion Vibber 2004-10-30 12:35:37 +00:00
parent ca8ef41fbb
commit 1897c54f2a
1 changed files with 6 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

11
includes/normal/UtfNormal.php
View file

@ -417,11 +417,11 @@ class UtfNormal {
* (depending on which decomposition map is passed to us).
* Input is assumed to be *valid* UTF-8. Invalid code will break.
* @access private
* @param string &$string Valid UTF-8 string
* @param array &$map hash of expanded decomposition map
* @param string $string Valid UTF-8 string
* @param array $map hash of expanded decomposition map
* @return string a UTF-8 string decomposed, not yet normalized (needs sorting)
*/
function fastDecompose( &$string, &$map ) {
function fastDecompose( $string, &$map ) {
UtfNormal::loadData();
$len = strlen( $string );
$out = '';
@ -445,6 +445,7 @@ class UtfNormal {
}
if( isset( $map[$c] ) ) {
$out .= $map[$c];
continue;
} else {
if( $c >= UTF8_HANGUL_FIRST && $c <= UTF8_HANGUL_LAST ) {
# Decompose a hangul syllable into jamo;
@ -465,10 +466,10 @@ class UtfNormal {
} elseif( $t ) {
$out .= "\xe1\x86" . chr( 0xa7 + $t );
}
} else {
$out .= $c;
continue;
}
}
$out .= $c;
}
return $out;
}