Remove reference parameters on make*LinkObj() methods. They're unnecessary and PHP5 is pickier about what it lets you pass that way. (Besides they're passed as normal references on PHP5 anyway.)
This commit is contained in:
parent
7a982f1a8a
commit
197e4592fb
1 changed files with 4 additions and 4 deletions
|
|
@ -264,7 +264,7 @@ class Linker {
|
||||||
/**
|
/**
|
||||||
* Pass a title object, not a title string
|
* Pass a title object, not a title string
|
||||||
*/
|
*/
|
||||||
function makeKnownLinkObj( &$nt, $text = '', $query = '', $trail = '', $prefix = '' , $aprops = '' ) {
|
function makeKnownLinkObj( $nt, $text = '', $query = '', $trail = '', $prefix = '' , $aprops = '' ) {
|
||||||
global $wgOut, $wgTitle, $wgInputEncoding;
|
global $wgOut, $wgTitle, $wgInputEncoding;
|
||||||
|
|
||||||
$fname = 'Skin::makeKnownLinkObj';
|
$fname = 'Skin::makeKnownLinkObj';
|
||||||
|
|
@ -310,7 +310,7 @@ class Linker {
|
||||||
/**
|
/**
|
||||||
* Pass a title object, not a title string
|
* Pass a title object, not a title string
|
||||||
*/
|
*/
|
||||||
function makeBrokenLinkObj( &$nt, $text = '', $query = '', $trail = '', $prefix = '' ) {
|
function makeBrokenLinkObj( $nt, $text = '', $query = '', $trail = '', $prefix = '' ) {
|
||||||
# Fail gracefully
|
# Fail gracefully
|
||||||
if ( ! isset($nt) ) {
|
if ( ! isset($nt) ) {
|
||||||
# wfDebugDieBacktrace();
|
# wfDebugDieBacktrace();
|
||||||
|
|
@ -348,7 +348,7 @@ class Linker {
|
||||||
/**
|
/**
|
||||||
* Pass a title object, not a title string
|
* Pass a title object, not a title string
|
||||||
*/
|
*/
|
||||||
function makeStubLinkObj( &$nt, $text = '', $query = '', $trail = '', $prefix = '' ) {
|
function makeStubLinkObj( $nt, $text = '', $query = '', $trail = '', $prefix = '' ) {
|
||||||
$link = $nt->getPrefixedURL();
|
$link = $nt->getPrefixedURL();
|
||||||
|
|
||||||
$u = $nt->escapeLocalURL( $query );
|
$u = $nt->escapeLocalURL( $query );
|
||||||
|
|
@ -370,7 +370,7 @@ class Linker {
|
||||||
}
|
}
|
||||||
|
|
||||||
/** @todo document */
|
/** @todo document */
|
||||||
function makeSelfLinkObj( &$nt, $text = '', $query = '', $trail = '', $prefix = '' ) {
|
function makeSelfLinkObj( $nt, $text = '', $query = '', $trail = '', $prefix = '' ) {
|
||||||
$u = $nt->escapeLocalURL( $query );
|
$u = $nt->escapeLocalURL( $query );
|
||||||
if ( '' == $text ) {
|
if ( '' == $text ) {
|
||||||
$text = htmlspecialchars( $nt->getPrefixedText() );
|
$text = htmlspecialchars( $nt->getPrefixedText() );
|
||||||
|
|
|
||||||
Loading…
Reference in a new issue