Thijs/wiki.techinc.nl
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

TextFormatter: Remove a pointless type check

Browse source 
The function signature guarantees that this parameter can't be
of any other type.

Change-Id: I08f80e3ae7515f21f88b7f1f4f395ddbbb7b70ab
This commit is contained in:
Max Semenik 2019-10-06 17:02:38 -07:00 committed by Jforrester
parent bcf2d4a7ac
commit 1a3a67d296
1 changed files with 13 additions and 17 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

30
includes/Message/TextFormatter.php
View file

@ -52,24 +52,20 @@ class TextFormatter implements ITextFormatter {
$convertedElements[] = $this->convertParam( $element );
}
return Message::listParam( $convertedElements, $param->getListType() );
} elseif ( $param instanceof MessageParam ) {
$value = $param->getValue();
if ( $value instanceof MessageValue ) {
$mv = $value;
$value = $this->createMessage( $mv->getKey() );
foreach ( $mv->getParams() as $mvParam ) {
$value->params( $this->convertParam( $mvParam ) );
}
}
if ( $param->getType() === ParamType::TEXT ) {
return $value;
} else {
return [ $param->getType() => $value ];
}
} else {
throw new \InvalidArgumentException( 'Invalid message parameter type' );
}
$value = $param->getValue();
if ( $value instanceof MessageValue ) {
$mv = $value;
$value = $this->createMessage( $mv->getKey() );
foreach ( $mv->getParams() as $mvParam ) {
$value->params( $this->convertParam( $mvParam ) );
}
}
if ( $param->getType() === ParamType::TEXT ) {
return $value;
}
return [ $param->getType() => $value ];
}
public function format( MessageValue $mv ) {