Thijs/wiki.techinc.nl
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Merge "Suppress php 7.4 phan false positive"

Browse source
This commit is contained in:
jenkins-bot 2022-09-19 15:12:24 +00:00 committed by Gerrit Code Review
commit 1a808ae744
5 changed files with 29 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

12
.phan/config.php
View file

@ -104,6 +104,18 @@ $cfg['exclude_analysis_directory_list'] = [
'includes/PHPVersionCheck.php',
];
if ( version_compare( PHP_VERSION, '7.4.0', '<' ) ) {
$cfg['exclude_analysis_directory_list'] = array_merge(
$cfg['exclude_analysis_directory_list'],
[
'includes/libs/rdbms/dbal/MWMySQLPlatform.php',
'includes/libs/rdbms/dbal/MWMySQLPlatformCompat.php',
'includes/libs/rdbms/dbal/MWPostgreSqlPlatform.php',
'includes/libs/rdbms/dbal/MWPostgreSqlPlatformCompat.php',
]
);
}
// Do not use aliases in core.
// Use the correct name, because we don't need backward compatibility
$cfg['enable_class_alias_support'] = false;

4
includes/libs/rdbms/dbal/MWMySQLPlatform.php
View file

@ -2,6 +2,10 @@
namespace Wikimedia\Rdbms;
/**
* @phan-file-suppress PhanCommentAbstractOnInheritedMethod T298571
*/
/**
* @suppress PhanRedefinedExtendedClass
*/

5
includes/libs/rdbms/dbal/MWMySQLPlatformCompat.php
View file

@ -1,5 +1,10 @@
<?php
// phpcs:ignoreFile -- This is a very temporary file
/**
* @phan-file-suppress PhanCommentAbstractOnInheritedMethod T298571
*/
namespace Wikimedia\Rdbms;
// T270740 - HACK: In doctrine/dbal 3.0.0, they renamed MySql -> MySQL

4
includes/libs/rdbms/dbal/MWPostgreSqlPlatform.php
View file

@ -1,5 +1,9 @@
<?php
/**
* @phan-file-suppress PhanCommentAbstractOnInheritedMethod T298571
*/
namespace Wikimedia\Rdbms;
use Wikimedia\Timestamp\ConvertibleTimestamp;

4
includes/libs/rdbms/dbal/MWPostgreSqlPlatformCompat.php
View file

@ -1,5 +1,9 @@
<?php
/**
* @phan-file-suppress PhanCommentAbstractOnInheritedMethod T298571
*/
namespace Wikimedia\Rdbms;
// T270740 - HACK