Made FileOp::allowStaleReads take a boolean argument (more versatile) and killed a few lines of code.

This commit is contained in:
Aaron Schulz 2012-03-09 19:36:19 +00:00
parent eee30c7fd0
commit 1b4dc593f1

View file

@ -63,12 +63,13 @@ abstract class FileOp {
}
/**
* Allow stale data for file reads and existence checks
* Whether to allow stale data for file reads and stat checks
*
* @param $allowStale bool
* @return void
*/
final protected function allowStaleReads() {
$this->useLatest = false;
final protected function allowStaleReads( $allowStale ) {
$this->useLatest = !$allowStale;
}
/**
@ -105,9 +106,7 @@ abstract class FileOp {
$predicates = FileOp::newPredicates(); // account for previous op in prechecks
// Do pre-checks for each operation; abort on failure...
foreach ( $performOps as $index => $fileOp ) {
if ( $allowStale ) {
$fileOp->allowStaleReads(); // allow potentially stale reads
}
$fileOp->allowStaleReads( $allowStale );
$subStatus = $fileOp->precheck( $predicates );
$status->merge( $subStatus );
if ( !$subStatus->isOK() ) { // operation failed?