Thijs/wiki.techinc.nl
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Skin: Restore use of Authority in place of PermissionManager

Browse source 
This was done originally in Ie530051, but it seems was partially
reverted when I177cd83 was merged.

Change-Id: Ib699f3519a12b442adcd31938a1394918f3a74f7
This commit is contained in:
Ammarpad 2021-03-15 07:52:22 +01:00
parent 7f907d657d
commit 1c8cda3e87
1 changed files with 1 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
includes/skins/Skin.php
View file

@ -450,14 +450,13 @@ abstract class Skin extends ContextSource {
}
}
$pm = MediaWikiServices::getInstance()->getPermissionManager();
// The relevant user should only be set if it exists. However, if it exists but is hidden,
// and the viewer cannot see hidden users, this exposes the fact that the user exists;
// pretend like the user does not exist in such cases, by setting it to null. T120883
if ( $this->mRelevantUser
&& $this->mRelevantUser->isRegistered()
&& $this->mRelevantUser->isHidden()
&& !$pm->userHasRight( $this->getUser(), 'hideuser' )
&& !$this->getAuthority()->isAllowed( 'hideuser' )
) {
return null;
}