Remove unneeded continue/return statements

Change-Id: I26f9845b09ecc15de8b6e0213ab369b386194c9d
This commit is contained in:
Umherirrender 2021-08-17 22:53:53 +02:00
parent 4d8c21e2fb
commit 1d178e177b
5 changed files with 0 additions and 10 deletions

View file

@ -373,7 +373,6 @@ class SqlBlobStore implements IDBAccessObject, BlobStore {
$errors[$blobAddress] = "Unknown blob address schema: $schema."
. ' Use findBadBlobs.php to remedy.';
$result[$blobAddress] = false;
continue;
}
}

View file

@ -861,8 +861,6 @@ END;
$fi = $this->db->fieldInfo( $table, $field );
if ( $fi === null ) {
$this->output( "...$table table does not contain $field field.\n" );
return;
} else {
$this->output( "Dropping column '$table.$field'\n" );
$table = $this->db->addIdentifierQuotes( $table );
@ -874,8 +872,6 @@ END;
$fi = $this->db->fieldInfo( $table, $field );
if ( $fi !== null ) {
$this->output( "...column '$table.$field' already exists\n" );
return;
} else {
$this->output( "Adding column '$table.$field'\n" );
$table = $this->db->addIdentifierQuotes( $table );

View file

@ -238,7 +238,6 @@ class GIFMetadataExtractor {
// unrecognized extension block
fseek( $fh, -( $blockLength + 1 ), SEEK_CUR );
self::skipBlock( $fh );
continue;
}
} else {
self::skipBlock( $fh );

View file

@ -1816,8 +1816,6 @@ abstract class Skin extends ContextSource {
'id' => Sanitizer::escapeIdForAttribute( 'n-' . strtr( $line[1], ' ', '-' ) ),
'active' => false,
], $extraAttribs );
} else {
continue;
}
}
}

View file

@ -87,11 +87,9 @@ class FixTimestamps extends Maintenance {
// Monotonic change
$lastNormal = $timestamp;
++$numGoodRevs;
continue;
} elseif ( abs( $delta ) <= $grace ) {
// Non-monotonic change within grace interval
++$numGoodRevs;
continue;
} else {
// Non-monotonic change larger than grace interval
$badRevs[] = $row->rev_id;