Thijs/wiki.techinc.nl
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

resourceloader: Don't register raw modules client-side

Browse source 
Prevents modules from depending on raw modules, like 'mediawiki' & 'jquery'.

To do that, those modules (as designated by raw=>true), aren't
registered in the module registry.

Change-Id: Iac37a236964dc40d6259988a0baaaa6331b54ec6
This commit is contained in:
Kunal Mehta 2014-08-28 13:16:03 -07:00 committed by Krinkle
parent 823e8c97e7
commit 1e063f6078
1 changed files with 7 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
includes/resourceloader/ResourceLoaderStartUpModule.php
View file

@ -207,6 +207,13 @@ class ResourceLoaderStartUpModule extends ResourceLoaderModule {
continue;
}
if ( $module->isRaw() ) {
// Don't register "raw" modules (like 'jquery' and 'mediawiki') client-side because
// depending on them is illegal anyway and would only lead to them being reloaded
// causing any state to be lost (like jQuery plugins, mw.config etc.)
continue;
}
// getModifiedTime() is supposed to return a UNIX timestamp, but it doesn't always
// seem to do that, and custom implementations might forget. Coerce it to TS_UNIX
$moduleMtime = wfTimestamp( TS_UNIX, $module->getModifiedTime( $context ) );