Thijs/wiki.techinc.nl
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Revert "Work around HHVM bug with stdin/stdout in proc_open()"

Browse source 
This was fixed in HHVM (https://github.com/facebook/hhvm/issues/1247).

This reverts commit 52e546640c.

bug: 56597
Change-Id: I9c97ba5645d794ff562347979e3f2027eb8b4534
This commit is contained in:
Aaron Schulz 2014-04-11 11:39:10 -07:00 committed by Ori.livneh
parent e88f4497bc
commit 1f19a345bc
1 changed files with 0 additions and 9 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

9
includes/GlobalFunctions.php
View file

@ -2881,15 +2881,6 @@ function wfShellExec( $cmd, &$retval = null, $environ = array(),
if ( $useLogPipe ) {
$desc[3] = array( 'pipe', 'w' );
}
# TODO/FIXME: This is a bad hack to workaround an HHVM bug that prevents
# proc_open() from opening stdin/stdout, so use /dev/null *for now*
# See bug 56597 / https://github.com/facebook/hhvm/issues/1247 for more info
if ( wfIsHHVM() ) {
$desc[0] = array( 'file', '/dev/null', 'r' );
$desc[2] = array( 'file', '/dev/null', 'w' );
}
$pipes = null;
$proc = proc_open( $cmd, $desc, $pipes );
if ( !$proc ) {