From 1f2bf063d79d90d6fd35c01d08c29a6865725dbe Mon Sep 17 00:00:00 2001
From: "Derick N. Alangi" <alangiderick@gmail.com>
Date: Fri, 17 Jan 2020 16:24:42 +0100
Subject: [PATCH] tests, preferences: Use `$this->` instead of `self::` when
 creating TD

In core, Test Doubles (TDs) are almost always created like that (using $this->),
lets stick to a unified way of things.

Change-Id: Ic8e62ccec19f136bc4cc6b27deefb43fd789ef07
---
 tests/phpunit/unit/includes/preferences/FiltersTest.php | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tests/phpunit/unit/includes/preferences/FiltersTest.php b/tests/phpunit/unit/includes/preferences/FiltersTest.php
index d2b5d05bb36..61ebb294586 100644
--- a/tests/phpunit/unit/includes/preferences/FiltersTest.php
+++ b/tests/phpunit/unit/includes/preferences/FiltersTest.php
@@ -114,7 +114,7 @@ class FiltersTest extends \MediaWikiUnitTestCase {
 			'Baz' => 3,
 		];
 		$flipped = array_flip( $userMapping );
-		$idLookup = self::getMockBuilder( CentralIdLookup::class )
+		$idLookup = $this->getMockBuilder( CentralIdLookup::class )
 			->disableOriginalConstructor()
 			->setMethods( [ 'centralIdsFromNames', 'namesFromCentralIds' ] )
 			->getMockForAbstractClass();