Thijs/wiki.techinc.nl
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Merge "Minor code clean up in SpecialBooksources"

Browse source
This commit is contained in:
jenkins-bot 2016-02-18 21:04:06 +00:00 committed by Gerrit Code Review
commit 1fe596cbe6
1 changed files with 7 additions and 8 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

15
includes/specials/SpecialBooksources.php
View file

@ -34,9 +34,6 @@ class SpecialBookSources extends SpecialPage {
*/
private $isbn = '';
/**
* Constructor
*/
public function __construct() {
parent::__construct( 'Booksources' );
}
@ -49,9 +46,9 @@ class SpecialBookSources extends SpecialPage {
public function execute( $isbn ) {
$this->setHeaders();
$this->outputHeader();
$this->isbn = self::cleanIsbn( $isbn ? $isbn : $this->getRequest()->getText( 'isbn' ) );
$this->isbn = self::cleanIsbn( $isbn ?: $this->getRequest()->getText( 'isbn' ) );
$this->getOutput()->addHTML( $this->makeForm() );
if ( strlen( $this->isbn ) > 0 ) {
if ( $this->isbn !== '' ) {
if ( !self::isValidISBN( $this->isbn ) ) {
$this->getOutput()->wrapWikiMsg(
"<div class=\"error\">\n$1\n</div>",
@ -63,7 +60,8 @@ class SpecialBookSources extends SpecialPage {
}
/**
* Returns whether a given ISBN (10 or 13) is valid. True indicates validity.
* Return whether a given ISBN (10 or 13) is valid.
*
* @param string $isbn ISBN passed for check
* @return bool
*/
@ -154,7 +152,7 @@ class SpecialBookSources extends SpecialPage {
* format and output them
*
* @throws MWException
* @return string
* @return bool
*/
private function showList() {
global $wgContLang;
@ -205,7 +203,8 @@ class SpecialBookSources extends SpecialPage {
$url = str_replace( '$1', $this->isbn, $url );
return Html::rawElement( 'li', [],
Html::element( 'a', [ 'href' => $url, 'class' => 'external' ], $label ) );
Html::element( 'a', [ 'href' => $url, 'class' => 'external' ], $label )
);
}
protected function getGroupName() {